Commit Graph

121 Commits

Author SHA1 Message Date
Nihanth Subramanya
2164478f1e Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh
Differential Revision: https://phabricator.services.mozilla.com/D47427

--HG--
extra : moz-landing-system : lando
2019-11-01 23:24:25 +00:00
Dorel Luca
b9074d53a1 Backed out 4 changesets (bug 1584479) for Browser-chrome failures in toolkit/components/antitracking/test/browser/browser_socialtracking.js
Backed out changeset b0d9877bd8b0 (bug 1584479)
Backed out changeset d2c56bd61b08 (bug 1584479)
Backed out changeset 0edb22786545 (bug 1584479)
Backed out changeset 7e03b392edb3 (bug 1584479)
2019-11-02 01:18:42 +02:00
Nihanth Subramanya
e7620d9a8c Bug 1584479 - Part 1: Add flag for blocked social cookies in the content blocking log. r=Ehsan,droeh
Differential Revision: https://phabricator.services.mozilla.com/D47427

--HG--
extra : moz-landing-system : lando
2019-11-01 21:02:09 +00:00
Jean-Yves Avenard
e6d0e7dfda Bug 1588899 - P1. Move classification flags related method to nsIClassifiedChannel. r=Ehsan,baku
This is where it should have been in the first place. Those attributes belong there.

Differential Revision: https://phabricator.services.mozilla.com/D49577

--HG--
extra : moz-landing-system : lando
2019-10-19 04:30:24 +00:00
Ehsan Akhgari
7239f850ee Bug 1583211 - Use the URL file path when performing cookie path matching instead of the url path query ref; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D46809

--HG--
extra : moz-landing-system : lando
2019-09-24 14:33:59 +00:00
Thomas Nguyen
32ab8293ff Bug 1528697 - Expose ReferrerPolicy.webidl and use referrerpolicy enum r=smaug
ReferrerPolicy gets tossed back and forth as a uint32_t and
ReferrerPolicy enum in header file. Expose ReferrerPolicyValues from
webidl file and use consistently in native code.

Differential Revision: https://phabricator.services.mozilla.com/D41954

--HG--
extra : moz-landing-system : lando
2019-08-21 13:24:45 +00:00
Tom Schuster
d2d9c3ff60 Bug 1558915 - Use infallible nsIURI::SchemeIs in netwerk/. r=baku
Sorry I had some problems figuring out who can review netwerk/. Most people seem to be on PTO.

Differential Revision: https://phabricator.services.mozilla.com/D41175

--HG--
extra : moz-landing-system : lando
2019-08-08 13:02:36 +00:00
Nicholas Nethercote
18fae65f38 Bug 1563139 - Remove StaticPrefs.h. r=glandium
This requires replacing inclusions of it with inclusions of more specific prefs
files.

The exception is that StaticPrefsAll.h, which is equivalent to StaticPrefs.h,
and is used in `Codegen.py` because doing something smarter is tricky and
suitable for a follow-up. As a result, any change to StaticPrefList.yaml will
still trigger recompilation of all the generated DOM bindings files, but that's
still a big improvement over trigger recompilation of every file that uses
static prefs.

Most of the changes in this commit are very boring. The only changes that are
not boring are modules/libpref/*, Codegen.py, and ServoBindings.toml.

Differential Revision: https://phabricator.services.mozilla.com/D39138

--HG--
extra : moz-landing-system : lando
2019-07-26 01:10:23 +00:00
Andrea Marchesini
382a3aa030 Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan,robwu
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-06-05 12:19:54 +00:00
Andrea Marchesini
aa84d3c812 Bug 1436674 - nsICookieService.idl should use ACString XPIDL type in place of the string type, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32662

--HG--
extra : moz-landing-system : lando
2019-05-31 09:36:44 +00:00
Andrea Marchesini
b1b122fb20 Bug 1554464 - Merge nsICookie2 and nsICookie in 1 single interface, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33031

--HG--
extra : moz-landing-system : lando
2019-05-31 09:36:44 +00:00
Andrea Marchesini
68fbe6f8ca Bug 1554377 - Cleanup nsCookie implementation - Removed mIPCOpen, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32616

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:51 +00:00
Andrea Marchesini
fd927a96aa Bug 1554377 - Cleanup nsCookie implementation - network_cookie_thirdparty_nonsecureSessionOnly to StaticPrefs, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32615

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:33 +00:00
Andrea Marchesini
1040f3de6a Bug 1554377 - Cleanup nsCookie implementation - network.cookie.thirdparty.sessionOnly to StaticPrefs, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32614

--HG--
extra : moz-landing-system : lando
2019-05-31 09:32:13 +00:00
Andrea Marchesini
8bcf905e12 Bug 1554377 - Cleanup nsCookie implementation - Get rid of nsCookieAttributes, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32561

--HG--
extra : moz-landing-system : lando
2019-05-31 09:31:30 +00:00
Csoregi Natalia
a51ae3670f Backed out 5 changesets (bug 1551798) for failures on test_rawSameSite.js. CLOSED TREE
Backed out changeset 11ddc433b632 (bug 1551798)
Backed out changeset f2ac8efb023d (bug 1551798)
Backed out changeset 0f6e797b434f (bug 1551798)
Backed out changeset eae7f88660c8 (bug 1551798)
Backed out changeset 2ba747afb3d0 (bug 1551798)
2019-05-30 10:17:01 +03:00
Andrea Marchesini
84e139e50b Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-05-29 16:34:33 +00:00
arthur.iakab
944263f18a Backed out 5 changesets (bug 1551798) for multiple build bustages on StaticPrefList.h CLOSED TREE
Backed out changeset c89daff34d97 (bug 1551798)
Backed out changeset bbc3f88b8c03 (bug 1551798)
Backed out changeset b87996b8a411 (bug 1551798)
Backed out changeset d88b0002d736 (bug 1551798)
Backed out changeset 0fe740c90e2b (bug 1551798)
2019-05-29 18:07:26 +03:00
Andrea Marchesini
d5fdfc9e8c Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-05-27 05:11:54 +00:00
Ehsan Akhgari
a5fe850945 Bug 1547813 - Part 9: Ensure the cookie service does third-party checks when the cookie policy is set to nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30118

--HG--
extra : moz-landing-system : lando
2019-05-25 01:25:46 +00:00
Ehsan Akhgari
ab20502fb9 Bug 1547813 - Part 7: Introduce a storage partitioning API; r=baku
This API abstracts away the details of the decision on what context should be
partitioned away from the consumers and centralizes the decision making into
the same location in the code base.

Differential Revision: https://phabricator.services.mozilla.com/D29742

--HG--
extra : moz-landing-system : lando
2019-05-25 01:25:41 +00:00
Andrea Marchesini
289365e128 Bug 1551821 - Get rid of pref network.cookie.same-site.enabled, r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D31217

--HG--
extra : moz-landing-system : lando
2019-05-15 13:33:45 +00:00
Noemi Erli
6430d23336 Backed out 12 changesets (bug 1547813) for failures in browser_partitionedIndexedDB.js CLOSED TREE
Backed out changeset 98989127264b (bug 1547813)
Backed out changeset f9d790139a26 (bug 1547813)
Backed out changeset a29f58cef022 (bug 1547813)
Backed out changeset c1288949de1c (bug 1547813)
Backed out changeset 8cad4fd197b1 (bug 1547813)
Backed out changeset 807ce59e7e6e (bug 1547813)
Backed out changeset 06943593738c (bug 1547813)
Backed out changeset 4ced8d49ddc3 (bug 1547813)
Backed out changeset 77a040f527e9 (bug 1547813)
Backed out changeset b4651cfaff30 (bug 1547813)
Backed out changeset 279c140a4d71 (bug 1547813)
Backed out changeset 0e0241f3d366 (bug 1547813)
2019-05-09 20:04:16 +03:00
Ehsan Akhgari
b9c7626390 Bug 1547813 - Part 9: Ensure the cookie service does third-party checks when the cookie policy is set to nsICookieService::BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30118

--HG--
extra : moz-landing-system : lando
2019-05-08 19:38:08 +00:00
Ehsan Akhgari
f33f21e80b Bug 1547813 - Part 7: Introduce a storage partitioning API; r=baku
This API abstracts away the details of the decision on what context should be
partitioned away from the consumers and centralizes the decision making into
the same location in the code base.

Differential Revision: https://phabricator.services.mozilla.com/D29742

--HG--
extra : moz-landing-system : lando
2019-05-08 20:15:13 +00:00
Sylvestre Ledru
e226046cb8 Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956

--HG--
extra : moz-landing-system : lando
2019-05-01 08:47:10 +00:00
Andrea Marchesini
a2db742a8c Bug 1536411 - StoragePrincipal - part 6 - Cookies, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D24864

--HG--
extra : moz-landing-system : lando
2019-04-12 05:30:43 +00:00
Cosmin Sabou
af07021e88 Backed out 10 changesets (bug 1536411) for causing leaks in CondVar, MessagePortService, MessagePortServiceData.
Backed out changeset eda5854cd7e8 (bug 1536411)
Backed out changeset f94dfbf2476c (bug 1536411)
Backed out changeset c68dc3152faa (bug 1536411)
Backed out changeset f67d157e8baf (bug 1536411)
Backed out changeset 1107a9767f38 (bug 1536411)
Backed out changeset ccbe1af00fb9 (bug 1536411)
Backed out changeset 552c4b588524 (bug 1536411)
Backed out changeset 2eb20578159b (bug 1536411)
Backed out changeset 45708d22bb6d (bug 1536411)
Backed out changeset 87601ef1d4d4 (bug 1536411)
2019-04-11 22:48:49 +03:00
Andrea Marchesini
0830861f7e Bug 1536411 - StoragePrincipal - part 6 - Cookies, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D24864

--HG--
extra : moz-landing-system : lando
2019-04-11 16:28:51 +00:00
Andrea Marchesini
7f2e25b635 Bug 1534340 - Fix a nullptr check in CookieServiceChild::RequireThirdPartyCheck, r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D23873

--HG--
extra : moz-landing-system : lando
2019-03-19 13:23:28 +00:00
Andrea Marchesini
5bb6c49ba8 Bug 1535799 - nsIHttpChannel.isTrackingResource should be a method, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D23765

--HG--
extra : moz-landing-system : lando
2019-03-17 06:55:50 +00:00
Andrea Marchesini
a78d942c6b Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 13 - Cookies, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21696

--HG--
extra : moz-landing-system : lando
2019-03-08 09:04:34 +00:00
Ciure Andrei
712dd2bb8c Backed out 16 changesets (bug 1525245) for perma failing test_document_cookie.html CLOSED TREE
Backed out changeset 3fd27215698f (bug 1525245)
Backed out changeset d9a9e8e77873 (bug 1525245)
Backed out changeset 0e6f7be92e3f (bug 1525245)
Backed out changeset 6790802e2fa5 (bug 1525245)
Backed out changeset a5a9e01116ed (bug 1525245)
Backed out changeset 66e19a0c38dd (bug 1525245)
Backed out changeset fb90d51ba853 (bug 1525245)
Backed out changeset 4772db3625b3 (bug 1525245)
Backed out changeset 9affaf0cb998 (bug 1525245)
Backed out changeset a91b7ebe8bdd (bug 1525245)
Backed out changeset c2a13a7480e1 (bug 1525245)
Backed out changeset abe4482fa137 (bug 1525245)
Backed out changeset b3920c0bcf84 (bug 1525245)
Backed out changeset 0821b81f2724 (bug 1525245)
Backed out changeset 70bed2ad7899 (bug 1525245)
Backed out changeset 5f72ba232cc8 (bug 1525245)
2019-03-07 17:54:18 +02:00
Andrea Marchesini
54a53b2d9e Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 13 - Cookies, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21696

--HG--
extra : moz-landing-system : lando
2019-03-07 10:21:50 +00:00
Dorel Luca
ac34e1d973 Backed out 16 changesets (bug 1525245) for Android failures. CLOSED TREE
Backed out changeset 9f8a1b410320 (bug 1525245)
Backed out changeset 0ef284a9a1d5 (bug 1525245)
Backed out changeset 835e5f642a03 (bug 1525245)
Backed out changeset 362f5a8d033c (bug 1525245)
Backed out changeset 9da3ab33cf67 (bug 1525245)
Backed out changeset 6aacd2d6e835 (bug 1525245)
Backed out changeset 8ff9e8f45e02 (bug 1525245)
Backed out changeset 2020227181cc (bug 1525245)
Backed out changeset fc3c64c330b9 (bug 1525245)
Backed out changeset 2762bf88e050 (bug 1525245)
Backed out changeset ffc10fdc50a6 (bug 1525245)
Backed out changeset bb6ade1207d7 (bug 1525245)
Backed out changeset 1875eb5085e4 (bug 1525245)
Backed out changeset 7e4f67a6d6f1 (bug 1525245)
Backed out changeset e671fc9581eb (bug 1525245)
Backed out changeset b89f5def8d0d (bug 1525245)
2019-03-06 21:07:49 +02:00
Andrea Marchesini
89b7c3883a Bug 1525245 - Stabilize cookiePolicy/cookiePermission for live documents - part 13 - Cookies, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D21696

--HG--
extra : moz-landing-system : lando
2019-03-06 17:04:29 +00:00
Alex Gaynor
e5279ff3f7 Bug 1532727 - replace OptionalURIParams with URIParams? in IPDL; r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D22138

--HG--
extra : moz-landing-system : lando
2019-03-06 14:05:50 +00:00
Andrea Marchesini
9e8594dfcb Bug 1526214 - Get rid of network.cookie.leave-secure-alone, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D19125

--HG--
extra : moz-landing-system : lando
2019-02-20 09:42:22 +00:00
Christoph Kerschbaumer
54df1cb98c Bug 1528677: Remove nullchecks for loadinfo since we have loadinfo on all channels. r=baku 2019-02-20 13:27:25 +01:00
Ehsan Akhgari
57a8f5ed79 Bug 1517389 - Ensure that we emit content blocking events when setting cookie headers and reading cookies from the cookies database; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D17203

--HG--
extra : moz-landing-system : lando
2019-01-22 19:46:10 +00:00
Sylvestre Ledru
265e672179 Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
# ignore-this-changeset

--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Nicholas Hurley
c5f9b83562 Bug 1440462 - Send httponly cookie names to content processes. r=jdm
Previously, if script tried to set a cookie that matched a cookie we had
received via Set-Cookie that was labeled httponly, script would think
that cookie was properly set (even though it wasn't). This ensures that
script knows just enough about httponly cookies to prevent this
inconsistent view while avoiding leakages of the potentially-sensitive
cookie values.

Differential Revision: https://phabricator.services.mozilla.com/D5700

--HG--
extra : moz-landing-system : lando
2018-09-26 15:39:33 +00:00
Diego Pino Garcia
0f11b0a3d3 Bug 1483986 - Remove sync versions of document.cookie getter/setter; r=ehsan,froydnj 2018-09-21 23:01:32 -04:00
Andrea Marchesini
125aa75f3b Bug 1492769 - Fix a cookie policy range check in CookieServiceChild, r=ehsan 2018-09-21 07:31:41 +02:00
Kershaw Chang
cca49915e3 Bug 1487085 - Allow to set cookie with a null channel in child process, r=valentin
In the current implmentation of CookieServiceChild::SetCookieString, pass a null channel will crash the child process. This is because we call aChannel->GetURI() without checking if aChannel is null.
However, set cookie with a null channel is possible in non-e10s mode. To make sure the behavior to be consistent in both non-e10s and e10s mode, we have to pass an empty URIParams in child process.

Differential Revision: https://phabricator.services.mozilla.com/D5432

--HG--
extra : moz-landing-system : lando
2018-09-12 15:14:32 +00:00
Ehsan Akhgari
bff765cf05 Bug 1488784 - Part 2: Remove the XPCOM component registration for nsCookiePermission; r=jdm
Differential Revision: https://phabricator.services.mozilla.com/D5038
2018-09-05 11:56:17 -04:00
Andrea Marchesini
40a8c122d3 Bug 1487331 - STATE_BLOCKED_TRACKING_COOKIES must tell why cookies are blocked, r=ehsan
Introduce these new blocking state values:

const unsigned long STATE_COOKIES_BLOCKED_BY_PERMISSION = 0x10000000;
const unsigned long STATE_COOKIES_BLOCKED_TRACKER       = 0x20000000;
const unsigned long STATE_COOKIES_BLOCKED_ALL           = 0x40000000;
const unsigned long STATE_COOKIES_BLOCKED_FOREIGN       = 0x80000000;
2018-08-31 11:02:33 +02:00
Ehsan Akhgari
d4ab894392 Bug 1486926 - Part 1: Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior; r=baku 2018-08-29 14:26:22 -04:00
Tiberius Oros
0354172fa8 Backed out 5 changesets (bug 1486944, bug 1486926)for multiple failures on a CLOSED TREE
Backed out changeset b536e2deff08 (bug 1486944)
Backed out changeset 5fc45a7e2b35 (bug 1486944)
Backed out changeset fef913dda33d (bug 1486926)
Backed out changeset f6533c40954f (bug 1486926)
Backed out changeset 20f625526901 (bug 1486926)
2018-08-29 16:50:15 +03:00
Ehsan Akhgari
1743f7b993 Bug 1486926 - Part 1: Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior; r=baku 2018-08-29 08:27:15 -04:00