The issue was that the getHighlighter request for the about:printpreview
target never settled. It appears that the document always stays in an
unitialized readyState, which was causing trouble.
Instead of relying only on readyState, we now call isDocumentReady, which
also checks if the document is loading.
Differential Revision: https://phabricator.services.mozilla.com/D87756
Reduces explicit "elem.style.x = 'y' assignments by consolidating them
into associated Objects, and using `Object.assign` to make the style
modifications to the respective elements."
Depends on D86866
Differential Revision: https://phabricator.services.mozilla.com/D86867
I had to put it in toolbox.css as it wasn't working from EvaluationContextSelector.css.
I imagine that's because the context DOM element are actually in toolbox document rather than the console one.
Also, React must be re-creating all DOM elements anytime there is an update
as you can see the list scroll up, everytime there is an update.
We should probably have a look at that as well.
Differential Revision: https://phabricator.services.mozilla.com/D87620
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.
Depends on D66463
Differential Revision: https://phabricator.services.mozilla.com/D68645
The issue was that the getHighlighter request for the about:printpreview
target never settled. It appears that the document always stays in an
unitialized readyState, which was causing trouble.
Instead of relying only on readyState, we now call isDocumentReady, which
also checks if the document is loading.
Differential Revision: https://phabricator.services.mozilla.com/D87756
Currently the `jest/no-standalone-expect` rule needs to be disabled for `jest-in-case` cases blocks as it is not compatible.
Differential Revision: https://phabricator.services.mozilla.com/D87184
Wraps the header container and the preferences list in a grid layout
that is meant to be a "single source of truth" for nested grids via
subgrid.
Differential Revision: https://phabricator.services.mozilla.com/D86866
Some tests made some assumptions about the number of returned entries
by performance.getEntries, and these assumptions are not valid
anymore once we added new entries.
Depends on D66463
Differential Revision: https://phabricator.services.mozilla.com/D68645
It has some properties which make it footgunny, especially in the face of
Fission. Callers should use WindowGlobalChild.innerWindowId instead.
Differential Revision: https://phabricator.services.mozilla.com/D82801
In `getMappedExpression`, we check if the expression contains `await `, and in
such case, transform the input to handle top-level await expressions.
The catch is that we first check the existence of this.parserService, and the
getter for parserService will start the parser worker if it wasn't the case yet.
That means we were always spawning the parser worker, even if it wasn't going
to be used, consuming unnecessary resources.
This patch removes the conditions in the if, as `parserService` will always be truthy.
Differential Revision: https://phabricator.services.mozilla.com/D86826
Sometimes, it might happen that the user triggered the popup
opening (by typing a letter) and hit Enter before the popup
was already shown, which would result in a blank popup being opened.
This patch addresses that by storing the popup opening promise
and if it exists in the code that handle the Enter key, wait until
the promise resolves and hide the popup.
It would be tricky to write a consistent test as this race is depending
on the server response time and the time it take for the popup to be
shown; but manual tests seemed to indicate this fixes the issue.
Differential Revision: https://phabricator.services.mozilla.com/D86548
We already had a function that was returning a resourceType dictionnary for
a given watcher or target actor, on which we were then checking the targetType
to return the appropriate dictionnary.
It feels appropriate to have a dedicated function to get the dictionnary from
the targetType only, so we can call it from other places instead of repeating
the same instructions.
Differential Revision: https://phabricator.services.mozilla.com/D86979
