Commit Graph

653844 Commits

Author SHA1 Message Date
Johann Hofmann
de6eaee5b4 Bug 1554167 - Remove pending shutdown sanitization immediately after shutdown sanitization finishes. r=mak,baku
In https://hg.mozilla.org/mozilla-central/rev/25397a6f8c4f#l1.35 we added an early return to
the SanitizeOnShutdown function to avoid cleaning principals by permission if the user had
set their preferences to clear all storage on shutdown anyway. This unfortunately ended
the function execution before it would call `removePendingSanitization("shutdown");` later on
and thus remove the pending shutdown sanitization (which, in fact, had completed successfully earlier).

The result is that the shutdown sanitization would be left dangling and run again on next startup,
where, for reasons I don't fully understand, it would race and conflict with loading the home page,
if that home page was from web content.

The solution is to remove the pending shutdown sanitization immediately after the sanitization is done.

As far as I can see there was never really a point in having it happen after session principal
cleanup finished, since in case of a crash it would not run the principal cleanup again next startup,
just the shutdown cleanup.

For good measure I also moved the new tab container sanitization to happen earlier in this function,
to prevent it from dangling as well.

Differential Revision: https://phabricator.services.mozilla.com/D33087

--HG--
extra : moz-landing-system : lando
2019-05-30 15:39:39 +00:00
Ehsan Akhgari
98809ae136 Bug 1555564 - Part 3: Make sure local storage manager caches the partitioned origins separately from each other; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33118

--HG--
extra : moz-landing-system : lando
2019-05-30 12:09:42 +00:00
Ehsan Akhgari
11bd289c14 Bug 1555564 - Part 2: When initiating a local storage preload from early navigation in the parent process, use the storage principal; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33117

--HG--
extra : moz-landing-system : lando
2019-05-30 12:09:42 +00:00
Ehsan Akhgari
bd4f22baf9 Bug 1555564 - Part 1: Support the privacy.restrict3rdpartystorage.partitionedHosts pref for both dynamic FPI and storage principal; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D33116

--HG--
extra : moz-landing-system : lando
2019-05-30 12:09:42 +00:00
prathiksha
01e4a0825b Bug 1549561 - Migrate strings from pipnss.properties to aboutCertError.ftl. r=flod CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com//D32513

--HG--
extra : amend_source : 38c0b2409ef80860cd389b141db4458e7b50a0c3
2019-05-30 09:43:23 +03:00
Mihai Alexandru Michis
d50fcf5b84 Bug 1424433 - Disable browser_contextmenu_touch.js on Windows 10 due to high failure rate. r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D33142

--HG--
extra : moz-landing-system : lando
2019-05-30 13:12:00 +00:00
ffxbld
669d19df08 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D33154

--HG--
extra : moz-landing-system : lando
2019-05-30 13:07:37 +00:00
Arnold Iakab
3a496ddefa Bug 1554681 Re-record youtube.com to reflect Polymer update Desktop r=perftest-reviewers,Bebe
Differential Revision: https://phabricator.services.mozilla.com/D32998

--HG--
extra : moz-landing-system : lando
2019-05-30 13:06:00 +00:00
Mike Conley
a4897dec85 Bug 1548364 - Let the Process Priority Manager ride out to the release channel on Windows. r=gsvelto
Differential Revision: https://phabricator.services.mozilla.com/D33067

--HG--
extra : moz-landing-system : lando
2019-05-30 12:19:07 +00:00
Gijs Kruitbosch
e561d233e9 Bug 1552993 - r=valentin,dragana
Differential Revision: https://phabricator.services.mozilla.com/D32066

--HG--
extra : moz-landing-system : lando
2019-05-27 09:14:33 +00:00
Andrew McCreight
f8a94637c7 Bug 1555516 - Whitelist another CSP leak frame. r=jgraham
The stack isn't always deep enough to get to LoadInfo, so add another
fairly distinct frame that is closer to the top of the stack. I also
noticed an instance of this failure in the service-worker directory,
so I added the whitelisting there, too.

Differential Revision: https://phabricator.services.mozilla.com/D33091

--HG--
extra : moz-landing-system : lando
2019-05-30 10:07:10 +00:00
Masayuki Nakano
a3d946e313 Bug 1555640 - Check if aPointAfterInsertedString is nullptr when WSRunObject::InsertText() sets its value r=m_kato
`aPointAfterInsertedString` of `WSRunObject::InsertText()` is optional (i.e.,
may be nullptr).  However, the fix for bug 1534394 makes it always set to
original insertion point when `InsertTextWithTransaction()` is failed.

This patch just make it check if `aPointAfterInsertedString` is nullptr before
setting its value.

Differential Revision: https://phabricator.services.mozilla.com/D33144

--HG--
extra : moz-landing-system : lando
2019-05-30 10:32:44 +00:00
Jan Horak
89fcedf92d Bug 1555653 Fix asserts in WindowBackBufferShm; r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D33147

--HG--
extra : moz-landing-system : lando
2019-05-30 11:33:29 +00:00
Dan Minor
3edf01f700 Bug 1554174 - Remove media.eme.vp9-in-mp4.enabled pref; r=jya
Differential Revision: https://phabricator.services.mozilla.com/D32808

--HG--
extra : moz-landing-system : lando
2019-05-30 07:17:38 +00:00
Jonathan Kew
91826a2e60 Bug 1554193 - Move support for the AAT 'trak' table from platform-specific MacFontEntry/gfxMacFont into the generic gfxFontEntry/gfxFont classes. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D33068

--HG--
extra : moz-landing-system : lando
2019-05-30 10:28:44 +00:00
yulia
fd9524f7ff Bug 1042642 - Do not pass the threadClient to EnvironmentClient during instantiation in tests; r=jdescottes
r=jdescottes

turns out we were incorrectly passing the threadClient to the environmentClient while
instantiating in one of the tests. It worked before because the threadClient exposed the API surface
of the debugger-client.

Differential Revision: https://phabricator.services.mozilla.com/D32685

--HG--
extra : moz-landing-system : lando
2019-05-30 09:02:03 +00:00
yulia
ae4a4c8517 Bug 1042642 - Stop using the DebuggerClient instance to listen for ThreadClient events in tests; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D29375

--HG--
extra : moz-landing-system : lando
2019-05-30 08:38:51 +00:00
yulia
a9f8c70111 Bug 1042642 - Use EventEmitter instead of EventSource for the threadClient; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D29373

--HG--
extra : moz-landing-system : lando
2019-05-30 08:37:55 +00:00
yulia
29a61755bc Bug 1042642 - use EventEmitter instead of eventSource on the DebuggerClient; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D29371

--HG--
extra : moz-landing-system : lando
2019-05-29 15:51:28 +00:00
yulia
41a557e3b1 Bug 1042642 - do not use DebuggerClient for functions that should only take ThreadClient; r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D29370

--HG--
extra : moz-landing-system : lando
2019-05-29 15:46:02 +00:00
Mihai Alexandru Michis
2454605299 Merge mozilla-central to autoland. CLOSED TREE 2019-05-30 12:49:36 +03:00
Mihai Alexandru Michis
f02325c271 Merge inbound to mozilla-central. a=merge 2019-05-30 12:45:32 +03:00
Csoregi Natalia
19709739ea Backed out changeset 46cfc6e018ba (bug 1553855) for assertion failures on LazyIdleThread.cpp. 2019-05-30 09:30:43 +03:00
Nick Thomas
b52fce9a8f Bug 1543932 - partner repacks bustage in 68.0, r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D33124

--HG--
extra : moz-landing-system : lando
2019-05-30 05:30:39 +00:00
Dão Gottwald
b50e9a3cd7 Bug 1554038 - Make UrlbarInput::pickResult and UrlbarController::recordSelectedResult take a UrlbarResult instead of an index and remove UrlbarView::getResult. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D32708

--HG--
extra : moz-landing-system : lando
2019-05-30 01:13:59 +00:00
Tom Prince
592bb93848 Bug 1549889: Add support for displaying WNP conditionally on build-id; r=nthomas
Differential Revision: https://phabricator.services.mozilla.com/D33039

--HG--
extra : moz-landing-system : lando
2019-05-29 23:47:07 +00:00
sotaro
5e274cc3e6 Bug 1554952 - Remove function pointers from WrExternalImageHandler r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D32813

--HG--
extra : moz-landing-system : lando
2019-05-29 20:50:13 +00:00
prathiksha
325e222d30 Bug 1549561 - Move _setTechDetails from NetErrorChild.jsm to aboutNetError.js. r=johannh,flod
Differential Revision: https://phabricator.services.mozilla.com/D30852

--HG--
extra : moz-landing-system : lando
2019-05-30 06:43:14 +00:00
prathiksha
5752203326 Bug 1549561 - Expose attributes from nsITransportSecurityInfo to content for about certerror use. r=baku
Differential Revision: https://phabricator.services.mozilla.com/D30851

--HG--
extra : moz-landing-system : lando
2019-05-30 06:42:56 +00:00
Connor Brewster
bb54c17ce3 Bug 1555476 - Implement flood filter in WebRender r=gw
Differential Revision: https://phabricator.services.mozilla.com/D33109

--HG--
extra : moz-landing-system : lando
2019-05-30 03:11:53 +00:00
Tom Tung
3f4b49387b Bug 1539219 - Get RefPtr for IDBOpenDBRequest before using it; r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D31440

--HG--
extra : moz-landing-system : lando
2019-05-30 02:53:07 +00:00
Csoregi Natalia
a51ae3670f Backed out 5 changesets (bug 1551798) for failures on test_rawSameSite.js. CLOSED TREE
Backed out changeset 11ddc433b632 (bug 1551798)
Backed out changeset f2ac8efb023d (bug 1551798)
Backed out changeset 0f6e797b434f (bug 1551798)
Backed out changeset eae7f88660c8 (bug 1551798)
Backed out changeset 2ba747afb3d0 (bug 1551798)
2019-05-30 10:17:01 +03:00
Chris Manchester
99eb67df5d Bug 1499147 - Produce archives of toolchains suitable for use with sccache-dist in automation. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D33101

--HG--
extra : moz-landing-system : lando
2019-05-30 06:38:00 +00:00
Matthew Noorenberghe
1c6438d64f Bug 1548857 - Save a generated login immediately if there are no saved logins for the site. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D32427

--HG--
extra : moz-landing-system : lando
2019-05-30 06:22:09 +00:00
Chris Manchester
494eff062e Bug 1555396 - Bump revision of sccache built in automation to current master. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D33102

--HG--
extra : moz-landing-system : lando
2019-05-30 06:32:54 +00:00
Andrew Swan
9bedc4a90f Bug 1555496 Fix bookmark toolbar drag handlers r=bgrins
Code here explicitly references lastElementChild inside a toolbarbutton
but it doesn't have any tests so it wasn't caught when bug 1519577 landed :(

Differential Revision: https://phabricator.services.mozilla.com/D33104

--HG--
extra : moz-landing-system : lando
2019-05-30 03:29:19 +00:00
Andrea Marchesini
ef73f6105f Bug 1551798 - Add comments about the next removing patches, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33037

--HG--
extra : moz-landing-system : lando
2019-05-29 16:34:27 +00:00
Andrea Marchesini
d513a67ed4 Bug 1551798 - Test for cookie migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32483

--HG--
extra : moz-landing-system : lando
2019-05-29 15:56:22 +00:00
Andrea Marchesini
84e139e50b Bug 1551798 - Store sameSite value as received from the wire in the database - migration 10, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D32482

--HG--
extra : moz-landing-system : lando
2019-05-29 16:34:33 +00:00
Andrea Marchesini
25006292a6 Bug 1551798 - SameSite=lax by default and SameSite=none only if secure - tests, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31216

--HG--
extra : moz-landing-system : lando
2019-05-29 15:55:39 +00:00
Andrea Marchesini
ae8ab513d8 Bug 1551798 - SameSite=lax by default and SameSite=none only if secure, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31215

--HG--
extra : moz-landing-system : lando
2019-05-30 00:48:41 +00:00
Mike Hommey
4c0ecc6982 Bug 1554063 - Move decimal to mozglue. r=jwalden
Differential Revision: https://phabricator.services.mozilla.com/D32435

--HG--
rename : mfbt/decimal/Decimal.cpp => mozglue/misc/decimal/Decimal.cpp
rename : mfbt/decimal/Decimal.h => mozglue/misc/decimal/Decimal.h
rename : mfbt/decimal/UPSTREAM-GIT-SHA => mozglue/misc/decimal/UPSTREAM-GIT-SHA
rename : mfbt/decimal/comparison-with-nan.patch => mozglue/misc/decimal/comparison-with-nan.patch
rename : mfbt/decimal/fix-wshadow-warnings.patch => mozglue/misc/decimal/fix-wshadow-warnings.patch
rename : mfbt/decimal/mfbt-abi-markers.patch => mozglue/misc/decimal/mfbt-abi-markers.patch
rename : mfbt/decimal/moz-decimal-utils.h => mozglue/misc/decimal/moz-decimal-utils.h
rename : mfbt/decimal/to-moz-dependencies.patch => mozglue/misc/decimal/to-moz-dependencies.patch
rename : mfbt/decimal/update.sh => mozglue/misc/decimal/update.sh
rename : mfbt/decimal/zero-serialization.patch => mozglue/misc/decimal/zero-serialization.patch
extra : moz-landing-system : lando
2019-05-29 06:57:28 +00:00
Dzmitry Malyshau
b431e7fe94 Bug 1554502 - Configurable lookback count r=gw
We've had a constant of 10 hard-coded there since early days.
Turning it into a configurable number allows us to easier tune it and
debug related issues.

Differential Revision: https://phabricator.services.mozilla.com/D32761

--HG--
extra : moz-landing-system : lando
2019-05-30 01:29:43 +00:00
Randell Jesup
8aeebca654 Bug 1553855: Make the Classifier Update thread a LazyIdle thread r=dimi
Differential Revision: https://phabricator.services.mozilla.com/D32529
Differential Revision: https://phabricator.services.mozilla.com/D32857

--HG--
extra : rebase_source : 52e2ef90c9585119a39c6569f6c791f104681392
2019-05-24 15:58:32 -04:00
shindli
b374b306cf Merge mozilla-central to inbound. a=merge CLOSED TREE 2019-05-30 06:50:22 +03:00
Jim Blandy
ea6f3617dc Bug 1551176: Rename js::DebugScript::stepMode to 'stepperCount'. r=jorendorff
This field of js::DebugScript is a count of the number of Debugger.Frames with
onPop handlers that apply to the given script, and its name should reflect that
more directly. All accessors and mutators renamed accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D32269

--HG--
extra : moz-landing-system : lando
2019-05-29 20:52:17 +00:00
Sam Foster
c2adf1ffc8 Bug 1554005 - Check login-saving is enabled before offering a generated password for a form. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D33080

--HG--
extra : moz-landing-system : lando
2019-05-30 00:28:06 +00:00
Jim Blandy
2206c1191d Bug 1551176: Clean up js::DebugScript and step mode count. r=jorendorff
The present JSScript::setNewStepMode method deals with both increments and
decrements. This provides a single site from which to call
BaselineScript::toggleDebugTraps. But it also checks whether it should free the
DebugScript, which is only needed when we're decrementing, and requires
incrementStepModeCount to furnish a FreeOp which is never needed.

On the balance, removing setNewStepMode altogether and letting
JSScript::incrementStepModeCount and decrementStepModeCount each specialize in
building things up or tearing things down seems cleaner, even if both need to
call toggleDebugTraps.

Differential Revision: https://phabricator.services.mozilla.com/D32268

--HG--
extra : moz-landing-system : lando
2019-05-29 20:52:02 +00:00
Emilio Cobos Álvarez
0bdeae4db0 Bug 1493420 - followup: Bump max allowed stack size of RuleNode. irc-r=heycam 2019-05-30 02:27:59 +02:00
Daosheng Mu
3db15dbbdb Bug 1523351 - Part 5: Add LightIndicatorColor dummy functions in other platforms. r=aklotz
Differential Revision: https://phabricator.services.mozilla.com/D31114

--HG--
extra : moz-landing-system : lando
2019-05-29 22:15:19 +00:00