Commit Graph

5055 Commits

Author SHA1 Message Date
Andrew Halberstadt
1190fb0269 Bug 1563797 - Use 'backports.shutil_which' instead of 'which' in the build system r=firefox-build-system-reviewers,chmanchester
Credit: Callek for figuring out an issue in 'make check' making the binary
absolute in mozbuild.base.

Differential Revision: https://phabricator.services.mozilla.com/D37319

--HG--
extra : moz-landing-system : lando
2019-07-11 14:04:39 +00:00
Andrew Halberstadt
3486ba642c Bug 1563797 - Use 'backports.shutil_which' instead of 'which' across the tree r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D37097

--HG--
extra : moz-landing-system : lando
2019-07-11 14:03:39 +00:00
Victor Porof
9350016346 Bug 1564824 - Format source fails with Prettier on patches with moved files where the original directory also does not exist, r=andi
Differential Revision: https://phabricator.services.mozilla.com/D37537

--HG--
extra : moz-landing-system : lando
2019-07-10 11:15:18 +00:00
Andreea Pavel
a35fc693c4 Backed out changeset fa94c9a03e3f (bug 1564314) for linting failures on a CLOSED TREE
--HG--
rename : python/gdbpp/gdbpp/__init__.py => third_party/python/gdbpp/gdbpp/__init__.py
rename : python/gdbpp/gdbpp/enumset.py => third_party/python/gdbpp/gdbpp/enumset.py
rename : python/gdbpp/gdbpp/linkedlist.py => third_party/python/gdbpp/gdbpp/linkedlist.py
rename : python/gdbpp/gdbpp/owningthread.py => third_party/python/gdbpp/gdbpp/owningthread.py
rename : python/gdbpp/gdbpp/smartptr.py => third_party/python/gdbpp/gdbpp/smartptr.py
rename : python/gdbpp/gdbpp/string.py => third_party/python/gdbpp/gdbpp/string.py
rename : python/gdbpp/gdbpp/tarray.py => third_party/python/gdbpp/gdbpp/tarray.py
rename : python/gdbpp/gdbpp/thashtable.py => third_party/python/gdbpp/gdbpp/thashtable.py
2019-07-10 10:12:34 +03:00
Mike Hommey
2f3833c4b3 Bug 1564314 - Move gdbpp back to python/. r=nalexander
Somehow bug 1346025 moved it to third_party/python but... it's not third
party code.

Differential Revision: https://phabricator.services.mozilla.com/D37364

--HG--
rename : third_party/python/gdbpp/gdbpp/__init__.py => python/gdbpp/gdbpp/__init__.py
rename : third_party/python/gdbpp/gdbpp/enumset.py => python/gdbpp/gdbpp/enumset.py
rename : third_party/python/gdbpp/gdbpp/linkedlist.py => python/gdbpp/gdbpp/linkedlist.py
rename : third_party/python/gdbpp/gdbpp/owningthread.py => python/gdbpp/gdbpp/owningthread.py
rename : third_party/python/gdbpp/gdbpp/smartptr.py => python/gdbpp/gdbpp/smartptr.py
rename : third_party/python/gdbpp/gdbpp/string.py => python/gdbpp/gdbpp/string.py
rename : third_party/python/gdbpp/gdbpp/tarray.py => python/gdbpp/gdbpp/tarray.py
rename : third_party/python/gdbpp/gdbpp/thashtable.py => python/gdbpp/gdbpp/thashtable.py
extra : moz-landing-system : lando
2019-07-09 16:09:14 +00:00
Mike Hommey
20ee1b2284 Bug 1563158 - Properly handle imply_option dependency loops when when is involved. r=chmanchester
This is an extension of the relaxation added in bug 1529799.

Differential Revision: https://phabricator.services.mozilla.com/D36716

--HG--
extra : moz-landing-system : lando
2019-07-09 22:04:01 +00:00
Makoto Kato
ecd47d34f4 Bug 1562389 - Better detect non-clang-cl native windows clang. r=glandium
When building Gecko/Android/aarch64 on Windows, `--target` parameter may not be incorrect value. Although `check_compiler`'s `info` is target compiler, clang on Windows is always detected as `clang-cl`, not `clang`.

```
c:/Users/mkato/.mozbuild/clang/bin/clang.exe -E  -dM - < /dev/null
...
#define _MSC_VER 1916
```

So even if using clang on Windows, not clang-cl, we should detect as 'clang' correctly

Differential Revision: https://phabricator.services.mozilla.com/D36422

--HG--
extra : moz-landing-system : lando
2019-07-08 10:35:40 +00:00
Justin Wood
4b233fe605 Bug 1559975 - Make python/mach lint with 'py2' and 'py3' r=catlee
Depends on D36096

Differential Revision: https://phabricator.services.mozilla.com/D36099

--HG--
extra : moz-landing-system : lando
2019-07-05 14:24:58 +00:00
Justin Wood
939e67a089 Bug 1559975 - Make python/mozbuild lint with 'py2' and 'py3' r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D36090

--HG--
extra : moz-landing-system : lando
2019-07-05 14:36:43 +00:00
Victor Porof
fc0105c226 Bug 1556393 - Pre 0 (m-c): Create a simple Prettier command for running format-source, r=andi
Differential Revision: https://phabricator.services.mozilla.com/D36720

--HG--
extra : source : c168aefc21dfec8a1935272201592f3781df07b0
extra : intermediate-source : 008847a148cfd171e6e23425be5d6876c6174ef0
2019-07-04 14:50:20 +02:00
Andi-Bogdan Postelnicu
d2e65163f9 Bug 1563326 - for code-analysis target do not globally import PackageFrontend. r=sylvestre
By globally importing PackageFrontend from the globe-analysis module we break the logger for
the PackageFrontend package.

Differential Revision: https://phabricator.services.mozilla.com/D36887

--HG--
extra : moz-landing-system : lando
2019-07-04 11:42:16 +00:00
Ed Lee
475d41e647 Bug 1563243 - Add optimistic images, string robustness and bug fixes to New Tab Page r=pdahiya,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D36764

--HG--
extra : moz-landing-system : lando
2019-07-03 23:49:07 +00:00
Mike Hommey
7256ffeb9b Bug 1560044 - Always use a SDK path on macOS. r=nalexander
The SDK headers may not be installed in /usr/include. The usual response
has been to have people run e.g. `open
/Library/Developer/CommandLineTools/Packages/macOS_SDK_headers_for_macOS_10.14.pkg`
which is not really sustainable.

This makes builds that happen on a macOS host try to detect their SDK
and use that as a default for --with-macos-sdk, which has the side
effect of enabling the SDK version check in that configuration.

Differential Revision: https://phabricator.services.mozilla.com/D36558

--HG--
extra : moz-landing-system : lando
2019-07-03 22:11:05 +00:00
Francesco Lodolo (:flod)
e14e57c33f Bug 1563216 - Remove Fluent migration recipes for Firefox 68 r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D36754

--HG--
extra : moz-landing-system : lando
2019-07-03 13:36:06 +00:00
Andrew Halberstadt
1a58163ed7 Bug 1473498 - [mach] Enable test_logger with Python 3 r=firefox-build-system-reviewers,chmanchester
Depends on D36101

Differential Revision: https://phabricator.services.mozilla.com/D36102

--HG--
extra : moz-landing-system : lando
2019-07-02 20:59:46 +00:00
Andrew Halberstadt
3f6339271d Bug 1473498 - [mach] Enable test_config with Python 3 r=firefox-build-system-reviewers,chmanchester
Depends on D36100

Differential Revision: https://phabricator.services.mozilla.com/D36101

--HG--
extra : moz-landing-system : lando
2019-07-02 20:59:03 +00:00
Andrew Halberstadt
975f664521 Bug 1473498 - [mach] Enable test_entry_points with Python 3 r=firefox-build-system-reviewers,chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D36100

--HG--
extra : moz-landing-system : lando
2019-07-02 20:58:14 +00:00
Andrew Halberstadt
3824b084b6 Bug 1473498 - [mach] Enable test_dispatcher with python 3 r=firefox-build-system-reviewers,chmanchester
This test is working with minimal effort. Let's get it running to prevent
future regressions.

Differential Revision: https://phabricator.services.mozilla.com/D36098

--HG--
extra : moz-landing-system : lando
2019-07-02 21:27:35 +00:00
Andrew Halberstadt
6f363de429 Bug 1473498 - [mach] Pull tests out of make check r=firefox-build-system-reviewers,mshal
Differential Revision: https://phabricator.services.mozilla.com/D36097

--HG--
extra : moz-landing-system : lando
2019-07-02 20:40:39 +00:00
Mike Hommey
18f786a985 Bug 1528314 - Remove --with-java-bin-path mozconfig entry from bootstrap suggestions. r=nalexander
Configure should just be able to find the right one. If it doesn't, that
should be fixed in configure rather than with suggestions in bootstrap.

Differential Revision: https://phabricator.services.mozilla.com/D36562

--HG--
extra : moz-landing-system : lando
2019-07-02 23:25:03 +00:00
Andreea Pavel
c92947ecc6 Backed out 5 changesets (bug 1528314, bug 1560044) for build bustages on a CLOSED TREE
Backed out changeset 4a544cd4b035 (bug 1528314)
Backed out changeset 91919cdf9159 (bug 1528314)
Backed out changeset 1271940e91e8 (bug 1560044)
Backed out changeset a5bbaa8c1001 (bug 1560044)
Backed out changeset 7ae0d606f1c6 (bug 1560044)
2019-07-03 02:20:15 +03:00
Mike Hommey
0c7ee5ce30 Bug 1528314 - Remove --with-java-bin-path mozconfig entry from bootstrap suggestions. r=nalexander
Configure should just be able to find the right one. If it doesn't, that
should be fixed in configure rather than with suggestions in bootstrap.

Differential Revision: https://phabricator.services.mozilla.com/D36562

--HG--
extra : moz-landing-system : lando
2019-07-02 17:25:38 +00:00
Ryan VanderMeulen
252c38a825 Bug 1563038 - Add more trees to the candidate tree list for artifact builds. r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D36676

--HG--
extra : moz-landing-system : lando
2019-07-02 21:58:21 +00:00
Jeane Carlos
fbe42f7796 Bug 1555788 - Migrate about preferences home content to use fluent r=fluent-reviewers,Mardak,pdahiya,flod
Differential Revision: https://phabricator.services.mozilla.com/D35278

--HG--
extra : moz-landing-system : lando
2019-07-02 17:25:55 +00:00
Andi-Bogdan Postelnicu
247d96a5f4 Bug 1559740 - add separate modules for build, static-analysis and artifacts. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D36479

--HG--
extra : moz-landing-system : lando
2019-07-01 14:02:20 +00:00
Sylvestre Ledru
da21266863 Bug 1559740 - Move the clang-{format,tidy} and infer declarations into a separate directory r=andi
Differential Revision: https://phabricator.services.mozilla.com/D35187

--HG--
extra : moz-landing-system : lando
2019-07-01 13:57:18 +00:00
Samuel Thibault
102e3a2ebb Bug 1543725 Add marionette support to thunderbird r=ato,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D27102

--HG--
extra : moz-landing-system : lando
2019-06-27 14:09:05 +00:00
Kartikaya Gupta
711c133f6d Bug 1558598 - Force WebRender on or off in the gtest harness. r=ahal
This covers the local and remote gtests, as well as the mach command.

Differential Revision: https://phabricator.services.mozilla.com/D35852

--HG--
extra : moz-landing-system : lando
2019-06-29 09:48:16 +00:00
Mike Hommey
b53fa7eb49 Bug 1561632 - Back out bug 1554987. r=ahal
Bug 1554987 made `mach try` use a transient remote, but that causes
problems with existing setups that happen to use the same remote name,
because of a combination of not-quite-as-documented-as-it-should
behavior of git.

- `git -c foo.bar=qux` doesn't override the value of `foo.bar` from the
  git configuration when `foo.bar` is an item that can take several
  values.
- `remote.$remote.url` and `remote.$remote.pushurl` take several values,
  allowing to give several URLs.

The combination of both means that if the git configuration already has
`remote.try.url` set, that value takes precedence (because git push
tries them one after the other, and takes the one from the command line
last)

One way we could increase the chances of things working out fine would
be to use `remote.try.pushurl`, which if already set, is more likely to
be right than an existing `remote.try.url`.

OTOH, it turns out, after more investigation, that bug 1554987 requires
a footgunny setup to happen in the first place. Namely, it requires
having run `git lfs install` from a git-cinnabar clone.

so we just go back to the previous status quo.

Differential Revision: https://phabricator.services.mozilla.com/D36149

--HG--
extra : moz-landing-system : lando
2019-06-28 15:58:36 +00:00
championshuttler
60ba27adf8 Bug 1536103 - Fix various Sphinx Warning in 'mach doc' (3). r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35314

--HG--
extra : moz-landing-system : lando
2019-06-26 20:00:31 +00:00
championshuttler
3303d92a29 Bug 1536103 - Fix Sphinx Warning - Unexpected indentation (1). r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35304

--HG--
extra : moz-landing-system : lando
2019-06-28 18:33:19 +00:00
Cosmin Sabou
20f7fd4c63 Backed out 3 changesets (bug 1559740) for linting errors and android bustages. CLOSED TREE
Backed out changeset 39db36060b8a (bug 1559740)
Backed out changeset df14ac0c2421 (bug 1559740)
Backed out changeset 089e04f53971 (bug 1559740)
2019-06-28 19:40:13 +03:00
Cosmin Sabou
6dce1fb935 Bug 1559740 - Ride along - add a missing import. r=Sylvestre 2019-06-28 18:15:31 +03:00
Sylvestre Ledru
edf07b0f4d Bug 1559740 - Ride along - flake8+black+codespell on python/mozbuild/mozbuild/code-analysis/mach_commands.py r=andi
Depends on D35187

Differential Revision: https://phabricator.services.mozilla.com/D35188

--HG--
extra : moz-landing-system : lando
2019-06-28 07:40:18 +00:00
Sylvestre Ledru
85ae7943fc Bug 1559740 - Move the clang-{format,tidy} and infer declarations into a separate directory r=andi
Differential Revision: https://phabricator.services.mozilla.com/D35187

--HG--
extra : moz-landing-system : lando
2019-06-28 07:39:48 +00:00
Ed Lee
10090c374d Bug 1561811 - Add fluent performance, 7-row pocket and bug fixes to Activity Stream r=k88hudson,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D36150

--HG--
extra : moz-landing-system : lando
2019-06-27 20:31:22 +00:00
Rok Garbas
d8e57f535e Bug 1561582 - tooltool.py now supports python 3 and 2 r=rail CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D36010

--HG--
extra : source : 7e05642566d001eb7b6900e80788212310243c3c
extra : histedit_source : 361d6b5974f9a4708f12f2c747645df6c7d706ee
2019-06-27 12:54:07 +00:00
Dorel Luca
66a6c7cb6f Backed out changeset 7e05642566d0 (bug 1561582) for Toolchain failures. CLOSED TREE 2019-06-27 19:36:32 +03:00
Rok Garbas
e09d6e060e Bug 1561582 - tooltool.py now supports python 3 and 2 r=rail
Differential Revision: https://phabricator.services.mozilla.com/D36010

--HG--
extra : moz-landing-system : lando
2019-06-27 12:54:07 +00:00
Mike Hommey
794ccc7940 Bug 1500436 - Redirect node.js's stderr to a pipe. r=froydnj
This works around https://github.com/nodejs/node/issues/14752, which
causes problems with make.

Differential Revision: https://phabricator.services.mozilla.com/D35986

--HG--
extra : moz-landing-system : lando
2019-06-26 21:44:00 +00:00
Mike Hommey
8ad5ae09a7 Bug 1561494 - Remove gconf from bootstrap. r=froydnj
Gconf support was removed in bug 1433685.

Differential Revision: https://phabricator.services.mozilla.com/D35982

--HG--
extra : moz-landing-system : lando
2019-06-26 12:54:30 +00:00
prathiksha
82a4475a6a Bug 1555438 - Remove getDetailedCertErrorInfo from NetErrorChild.jsm. r=johannh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D33065

--HG--
extra : moz-landing-system : lando
2019-06-26 20:24:05 +00:00
L. David Baron
f721ff614d Bug 1515105 - Adjust test for turning off git commit.gpgSign when making temporary commits for try pushes. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35876

--HG--
extra : moz-landing-system : lando
2019-06-26 15:04:01 +00:00
Nick Alexander
871427c9e4 Bug 1555255 - Don't require a network connection to produce Javadoc. r=geckoview-reviewers,agi
See https://stackoverflow.com/a/24026735.

Adding the `docs` package requirement is not ideal, but it's not worth
the effort to install it only in automation (or in the relevant task),
and it's not *that* large: 1.0G on my macOS installation.

Differential Revision: https://phabricator.services.mozilla.com/D35834

--HG--
extra : moz-landing-system : lando
2019-06-25 19:58:26 +00:00
Mike Hommey
2bd4c4799f Bug 1560826 - Make bootstrap upgrade mercurial when it is older than 4.8. r=nalexander
4.3.3 is the strict minimum required for v-c-t's config wizard, but it
is preferable people use more modern versions. We could go with 5.0, but
it feels like people still using 4.8 and 4.9 don't really need to be
bugged to update to a more recent version, they are kind of modern
enough. OTOH MozillaBuild comes with 4.5.x, and this will force an
upgrade for those.

Differential Revision: https://phabricator.services.mozilla.com/D35756

--HG--
extra : moz-landing-system : lando
2019-06-25 16:50:17 +00:00
Mike Hommey
c836cba1d4 Bug 1560826 - Only install mercurial versions that have wheels. r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D35755

--HG--
extra : moz-landing-system : lando
2019-06-25 16:50:50 +00:00
Mike Hommey
9101a37a23 Bug 1560826 - Backout changeset c9732a51552b (bug 1364511). r=nalexander
This makes the bootstrap behavior wrt. Mercurial consistent on all
platforms, making Windows bootstrap only upgrade Mercurial if the
version is older than MODERN_MERCURIAL_VERSION.

As a side effect, this avoids upgrading to version 5.0.1, which doesn't
come with wheels at the moment.

Differential Revision: https://phabricator.services.mozilla.com/D35754

--HG--
extra : moz-landing-system : lando
2019-06-25 16:49:30 +00:00
Mike Hommey
d01dbf277a Bug 1561201 - Expose the list of build resource data from mach resource-usage page. r=nalexander
The `mach resource-usage` page supports a list of build resource data,
but only ever displays the first one. Nothing actually creates a list
with multiple items automatically, but one might want to do that
manually to explore data from multiple builds more conveniently.

So if such a list exists, we expose a dropdown list of all the data
available, and switch the graph when a different item is chosen from the
list.

Differential Revision: https://phabricator.services.mozilla.com/D35757

--HG--
extra : moz-landing-system : lando
2019-06-25 16:48:19 +00:00
Mike Hommey
2424ebfd74 Bug 1561102 - Add license exception for the mach crate. r=chmanchester
Differential Revision: https://phabricator.services.mozilla.com/D35743

--HG--
extra : moz-landing-system : lando
2019-06-25 20:25:44 +00:00
L. David Baron
36f9d91fe8 Bug 1515105 - Turn off git commit.gpgSign when making temporary commits for try pushes. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D35726

--HG--
extra : moz-landing-system : lando
2019-06-25 17:21:47 +00:00