Commit Graph

26239 Commits

Author SHA1 Message Date
Jeff Muizelaar
fcce3abceb Bug 1633412 - Rollout WebRender to Intel Icelake r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D72660
2020-04-27 15:28:43 +00:00
Jeff Muizelaar
f9a64ef094 Bug 1633411 - Roll out WebRender to AMD Raven Ridge devices. r=aosmond
This is a modern AMD APU

Differential Revision: https://phabricator.services.mozilla.com/D72658
2020-04-27 15:05:21 +00:00
Jeff Muizelaar
2362f66489 Bug 1633290 - Enable WebRender on Skylake GT1. r=aosmond
Differential Revision: https://phabricator.services.mozilla.com/D72571
2020-04-27 00:52:57 +00:00
Sylvestre Ledru
34acbb653a Bug 1619165 - Reformat recent changes to the Google coding style r=andi
First reformat with clang-format 10

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D68802
2020-04-25 09:40:08 +00:00
Chun-Min Chang
530a6c8ee6 Bug 1631608 - P6: Log error message when PropertiesChanged signal fails being emitted r=alwu
- Log error messages when `PropertiesChanged` signal fails being emitted
- Add some missing `':'` in error messages

Differential Revision: https://phabricator.services.mozilla.com/D72195
2020-04-24 22:39:20 +00:00
Chun-Min Chang
ec57fa6d2a Bug 1631608 - P5: Define mpris:trackid r=alwu
The `"mpris:trackid"` [1] is an unique dbus path identifying the track.
It's better to use a more specific path for `"mpria:trackid"` instead of
using a `"/valid/path"` that can appear on any example code. The
rythembox [2,3] and vlc [4,5] also uses their own special path for their
`"mpris:trackid"` so Firefox should do the same.

On the other hand, Chrome doesn't use `"mpris:trackid"` at all. That
indeed works but the spec [1] explicitly states `"mpris:trackid"` must
be defined if there is a current track.

Thus, to make sure the implementation meets the spec [1], the
`"mpris:trackid"` must be defined in MPRIS's `"Metadata"` field by an
unique path value that belongs to Firefox only.

[1] https://specifications.freedesktop.org/mpris-spec/2.2/Player_Interface.html#Property:Metadata
[2] 7542759eda/plugins/mpris/rb-mpris-plugin.c (L547)
[3] 7542759eda/plugins/mpris/rb-mpris-plugin.c (L55)
[4] 9ddf27caa7/modules/control/dbus/dbus.c (L1300)
[5] 9ddf27caa7/modules/control/dbus/dbus_common.h (L90)

Differential Revision: https://phabricator.services.mozilla.com/D71869
2020-04-24 22:39:12 +00:00
Chun-Min Chang
c9eafeca3c Bug 1631608 - P4: Define "org.mpris.MediaPlayer2.Player" in macro r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D71868
2020-04-24 22:39:10 +00:00
Chun-Min Chang
e3b7390390 Bug 1631608 - P3: Use %d for int r=alwu
Align the policy to get the dbus name in `MPRISServiceHandler::Open`
with the one in `MPRISServiceHandler::Close()`

Differential Revision: https://phabricator.services.mozilla.com/D71865
2020-04-24 22:39:08 +00:00
Chun-Min Chang
cff082955d Bug 1631608 - P2: Emit DBus signal once MPRIS Metadata is set r=alwu
According to spec [1], when the `Metadata` is changed, a signal with the
new `Metadata` value should be emitted.

[1] https://specifications.freedesktop.org/mpris-spec/2.2/Player_Interface.html#Property:Metadata

Differential Revision: https://phabricator.services.mozilla.com/D71864
2020-04-24 22:39:00 +00:00
Chun-Min Chang
9236093c78 Bug 1631608 - P1: Log messages when getting or setting metadata r=alwu
By monitoring the added logs, any access to the metadata can be watched.

Differential Revision: https://phabricator.services.mozilla.com/D71863
2020-04-24 22:38:58 +00:00
Jeff Muizelaar
e11b7fe8c4 Bug 1632961 - Fix up kabylake ids. r=aosmond
Remove duplicates and add back 0x5912

Differential Revision: https://phabricator.services.mozilla.com/D72441
2020-04-24 19:34:12 +00:00
Martin Stransky
42d551312e Bug 1628583 [Wayland] Use mutex to access mozcontainer wayland internals, r=jhorak
Mozcontainer is accessed from various threads - Main/Compositor/Renderer - which causes races
when wayland surfaces are created/deleted/updated so we need to control it.

Differential Revision: https://phabricator.services.mozilla.com/D71737
2020-04-24 17:19:15 +00:00
Simon Giesecke
191a830575 Bug 1628715 - Part 7: Add MOZ_NONNULL_RETURN to infallible nsTArray::AppendElements. r=xpcom-reviewers,necko-reviewers,nika,valentin
Differential Revision: https://phabricator.services.mozilla.com/D70831
2020-04-24 13:31:14 +00:00
Timothy Nikkel
ae8f3fddd1 Bug 1632357. Add a pref to disable adding the WS_EX_LAYERED style to the compositor window. r=sotaro
On older machines it creates a blank window and we only need the pref to direct manipulation (which hasn't landed yet and will be preffed off by default when it lands).

Differential Revision: https://phabricator.services.mozilla.com/D72283
2020-04-24 08:58:16 +00:00
Cosmin Sabou
16f21e6dae Backed out 1 changesets (bug 1632357) for build bustages. CLOSED TREE
Backed out changeset 428d3ada2cb2 (bug 1632357)
2020-04-24 11:21:31 +03:00
Timothy Nikkel
ea404ff352 Bug 1632357. Add a pref to disable adding the WS_EX_LAYERED style to the compositor window. r=sotaro
On older machines it creates a blank window and we only need the pref to direct manipulation (which hasn't landed yet and will be preffed off by default when it lands).

Differential Revision: https://phabricator.services.mozilla.com/D72283
2020-04-24 07:38:09 +00:00
Tom Schuster
7abdca1793 Bug 1631196 - Implement MPRIS Raise event by focusing the window playing media. r=alwu
Implement MPRIS Raise event by focusing the window playing media.

Differential Revision: https://phabricator.services.mozilla.com/D71450
2020-04-23 19:32:34 +00:00
Brindusan Cristian
42e680a4ef Merge mozilla-central to autoland on a CLOSED TREE 2020-04-24 00:44:23 +03:00
Brindusan Cristian
295d851672 Merge autoland to mozilla-central. a=merge 2020-04-24 00:42:24 +03:00
Noemi Erli
71ad949346 Backed out changeset 779722364805 (bug 1628583) per request a=backout 2020-04-23 17:54:42 +03:00
Martin Stransky
59c99a1b8c Bug 1632059 [Wayland] Use wayland display directly for va-api, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D72122
2020-04-23 16:06:54 +00:00
Martin Stransky
7112c02038 Bug 1603839 [Linux] Explicitly set Wayland/X11 backend for GtkCompositorWidget, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D71888
2020-04-23 17:26:17 +00:00
Jeff Muizelaar
4cefa44bc5 Bug 1632239 - Reduce AMD DirectComposition blocking. r=aosmond
Haven't seen any problems so lets be less conservative.
This uses the arbitrary broken version as a new minimum.

Differential Revision: https://phabricator.services.mozilla.com/D72018
2020-04-22 19:02:27 +00:00
Jeff Muizelaar
a158aafa00 Bug 1632240 - Add some more Kabylake ids. r=aosmond
This adds support for kabylake gt1 and gt1.5

Differential Revision: https://phabricator.services.mozilla.com/D72019
2020-04-22 19:02:44 +00:00
Emilio Cobos Álvarez
3e3dc71cba Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl
This is used by platforms with overlay scrollbars, only in order to
reserve enough space for the chevron of the `<select>` element.

So our general min-widget-size, which is the same as for scrollbars
works.

Differential Revision: https://phabricator.services.mozilla.com/D71825
2020-04-22 17:45:39 +00:00
Kartikaya Gupta
763e05dece Bug 1627716 - Remove GeckoView API exposing the DynamicToolbarAnimator. r=geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D71776
2020-04-22 11:50:40 +00:00
Martin Stransky
bff4088157 Bug 1632100 [Wayland] Emulate window focus change by window hide/show when running in testsuite, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D71926
2020-04-22 15:54:06 +00:00
Martin Stransky
f5dbae2f0c Bug 1628583 [Wayland] Use mutex to access mozcontainer wayland internals, r=jhorak
Mozcontainer is accessed from various threads - Main/Compositor/Renderer - which causes races
when wayland surfaces are created/deleted/updated so we need to control it.

Differential Revision: https://phabricator.services.mozilla.com/D71737
2020-04-22 15:53:49 +00:00
Jeff Muizelaar
c0acfaa944 Bug 1632202. Enable WebRender on some Gen7 in Nightly. r=aosmond
Seems to work well enough.

Differential Revision: https://phabricator.services.mozilla.com/D71986
2020-04-22 15:28:14 +00:00
Makoto Kato
784bdca25f Bug 1626389 - Part 1. Use JNI to get password setting even if content process. r=geckoview-reviewers,snorp
Now we can use JNI on content process, so it is unnecessary to use sync IPC
to get password setting.

Differential Revision: https://phabricator.services.mozilla.com/D71707
2020-04-21 14:54:29 +00:00
Jeff Muizelaar
c575c3531c Bug 1632002. Re-enable WebRender on Gen7.5 in Nightly.
Scrolling on Youtube (Bug 1576637) has improved enough
that we can turn gen7 back on in Nightly

Differential Revision: https://phabricator.services.mozilla.com/D71859
2020-04-22 01:18:23 +00:00
Bogdan Tara
62d94d25d6 Backed out changeset c7623d3b49ec (bug 1631887) for foreignObject-img-form-theme.html CLOSED TREE 2020-04-22 02:14:37 +03:00
Haik Aftandilian
b6992791c8 Bug 1629313 - Part 1 - Set As Desktop Background fails on macOS r=spohl
Change the nsMacShellService::SetDesktopBackground() implementation (specifically code in the OnStateChange handler) to use the Apple setDesktopImageURL API instead of Apple Events to allow the "Set As Desktop Background..." context menu option to work again.

Alternatively, to allow the AppleEvent-base implementation to work again, Firefox could be signed with the com.apple.security.automation.apple-events entitlement but this would also require the user to grant Firefox permission to control Finder. setDesktopImageURL requires Mac OS 10.6 or newer and hence was not an option originally.

The implementation only changes the background of the focused screen in the current workspace (which matches the behavior of Safari).

Differential Revision: https://phabricator.services.mozilla.com/D71426
2020-04-21 19:57:29 +00:00
Emilio Cobos Álvarez
2368532cda Bug 1631887 - Claim to support NonDisappearingScrollbarWidth on the non-native theme. r=spohl
This is used by platforms with overlay scrollbars, only in order to
reserve enough space for the chevron of the `<select>` element.

So our general min-widget-size, which is the same as for scrollbars
works.

Differential Revision: https://phabricator.services.mozilla.com/D71825
2020-04-21 20:36:22 +00:00
Jan Horak
2cc879bea5 Bug 1623974 [wayland] Attach popups to anchor rects; r=stransky
If we want correct popup placement we need to use the right anchor rect
for gdk_window_move_to_rect under Wayland. Patch exports the anchor rect from the
nsMenuPopupFrame to be used in nsWindow.

This patch also fixes popup overflowing the screen by using the size returned from
gdk_window_move_to_rect for the nsMenuPopupFrame.

Differential Revision: https://phabricator.services.mozilla.com/D67810
2020-04-21 19:19:30 +00:00
Robert Mader
a000f064be Bug 1629140 - Enable frame callback based VsyncSource by default. r=stransky
Differential Revision: https://phabricator.services.mozilla.com/D70551
2020-04-21 11:34:14 +00:00
Chris Peterson
ce0c6b20bb Bug 1624786 - Replace "clang-format off" with semicolon workaround for clang-format bug 1629756. r=spohl
This semicolon workaround is tidier than the `// clang-format off/on` comments and avoids turning off all clang-format checks. The comment also links to clang-format bug 1629756 so future code readers can learn why this extra semicolon exists. And if we find a way to fix this in clang-format, then we can search for this bug number to find and remove these extra semicolons and comments.

Differential Revision: https://phabricator.services.mozilla.com/D71504
2020-04-20 12:18:48 +00:00
Ciure Andrei
33a2dc2141 Backed out changeset 339795d0a51e (bug 1574746) for causing browser_startup_syncIPC.js failures CLOSED TREE 2020-04-21 04:32:44 +03:00
sotaro
66fa9f31db Bug 1574746 - Remove AllowWebRenderForThisWindow() r=nical
nsBaseWidget::AllowWebRenderForThisWindow() limits WebRender usage to some  type of windows. It was added by Bug 1377321, because initialization of WebRender was heavy weight in the past. It is not necessary anymore.

Differential Revision: https://phabricator.services.mozilla.com/D71440
2020-04-20 14:15:08 +00:00
Arthur Iakab
d0d3827cd2 Backed out changeset 880f56e1656b (bug 1603839) for causing build bustages on GtkCompositorWidget.h
CLOSED TREE
2020-04-23 12:28:10 +03:00
Jan Horak
f9d7f39b74 Bug 1631458 Account font scale factor for the popup placement under wayland; r=stransky
The font scale factor needs to be accounted for the popup anchor rect under
Wayland.

Differential Revision: https://phabricator.services.mozilla.com/D72100
2020-04-23 08:43:52 +00:00
Martin Stransky
4d6599f102 Bug 1603839 [Linux] Explicitly set Wayland/X11 backend for GtkCompositorWidget, r=jhorak
Differential Revision: https://phabricator.services.mozilla.com/D71888
2020-04-23 08:19:07 +00:00
Mihai Alexandru Michis
25a1d0163b Backed out changeset 86630db403c1 (bug 1623974) for causing failures in browser_toolbox_zoom_popup.js and in wpt.
CLOSED TREE
2020-04-20 18:07:23 +03:00
Jan Horak
5664a8f139 Bug 1623974 [wayland] Attach popups to anchor rects; r=stransky
If we want correct popup placement we need to use the right anchor rect
for gdk_window_move_to_rect under Wayland. Patch exports the anchor rect from the
nsMenuPopupFrame to be used in nsWindow.

This patch also fixes popup overflowing the screen by using the size returned from
gdk_window_move_to_rect for the nsMenuPopupFrame.

Differential Revision: https://phabricator.services.mozilla.com/D67810
2020-04-20 12:50:25 +00:00
sotaro
c64e7f13d2 Bug 1611372 - Invalidate WebRender frame on nsWindow::OnExposeEvent() r=nical
Differential Revision: https://phabricator.services.mozilla.com/D71139
2020-04-17 17:27:37 +00:00
Kris Taeleman
0ec13882ab Bug 1607322 - Enable webrender for Pixel 2/3 on release r=jnicol
Preparing change to enable webrender on Fenix once the shader compilation changes are in.

Differential Revision: https://phabricator.services.mozilla.com/D70944
2020-04-17 16:34:10 +00:00
Jeff Muizelaar
264a9feb12 Bug 1629602 - Include reason for failure when describing features. r=aosmond
This should give us more information in telemetry.

Differential Revision: https://phabricator.services.mozilla.com/D70706
2020-04-15 22:11:19 +00:00
Makoto Kato
ac14cb654b Bug 1629759 - Remove unused dom.event.touch.coalescing.enabled preference. r=geckoview-reviewers,agi
No one seems to reference `dom.event.touch.coalescing.enabled` after landing Bug 1291373.
So remove it.

Differential Revision: https://phabricator.services.mozilla.com/D70794

--HG--
extra : moz-landing-system : lando
2020-04-15 21:20:11 +00:00
Martin Stransky
6cfd5ed10f Bug 1629526 [Wayland] Add gWaylandThreadLoopMutex to guard thread loop shutdown, r=jhorak
- Add gWaylandThreadLoopMutex to guard thread loop shutdown
- Rename gWaylandDisplaysMutex to gWaylandDisplayArrayMutex to clarify it's mutex for gWaylandDisplays array access
- Add gWaylandDisplayArrayMutex lock at ReleaseDisplaysAtExit()
- Rename DispatcherThreadLoop names to ThreadLoop

Differential Revision: https://phabricator.services.mozilla.com/D71106

--HG--
extra : moz-landing-system : lando
2020-04-16 06:07:06 +00:00
Makoto Kato
ff4dcdc969 Bug 1629730 - Remove unnecessary AKEYCODE defines from GeckoEditableSupport. r=geckoview-reviewers,agi
Old NDK requires AKEYCODE defines for newer API version, but it is unnecessary
to define it when using NDK r20.

Differential Revision: https://phabricator.services.mozilla.com/D70786

--HG--
extra : moz-landing-system : lando
2020-04-15 21:25:46 +00:00