This breaks out some of the parts on #10586, that should be easily mergeable (hopefully pretty much a no-brainer really). The idea would be to let you review & merge it first, and then I'll complete the other PR rebase off of this stuff.
@bholley - I did like you suggested and broke it out for `geckolib` as well. The tests should also be running without problems (tested `./mach test-unit` locally).
Source-Repo: https://github.com/servo/servo
Source-Revision: 0c51259e4064e76ac180210c724af61bf15f8640
To quote Lars Bergstrom:
> yeah, that's a giant footgun :-)
Source-Repo: https://github.com/servo/servo
Source-Revision: db4481b4509db4be83e0f77a66884feccd1878e0
Acquiring the stdout lock while printing the profile data prevents other
messages printed to stdout from being interleaved with prints from elsewhere.
Source-Repo: https://github.com/servo/servo
Source-Revision: d9ffefe5620eca8d377ccdca81041328bcd48065
Added the panic message to failures. This is a step towards #10334, since it gives us access to the panic error message when we fire a `mozbrowsererror` event. The remaining steps are also to record the backtrace, and to report the failure in the event.
Source-Repo: https://github.com/servo/servo
Source-Revision: 2b910678db8b461dc50919832044bd95cdecb53e
In rust-url 1.0 the `Url` struct is going to have private fields, and there is no way to to create an aribitrary one without going through the parser.
The plugin never had a clear demonstrated performance benefit, it was made mostly because it was possible and relatively easy at the time.
This commit was originally part of #9840, but it’s taking a while to land and I keep removing new uses of `url!` when rebasing.
r? @nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 3368565b3c6c76e5ce2d170d5c5cfb2f52a56956
The remaining test failure in `base_multiple.html` looks like there's a problem with the test itself (it does not have a `<base>` tag at all).
Source-Repo: https://github.com/servo/servo
Source-Revision: 3ad1b9134f17803f04ac94754e640e7f876799d8
I have added all properties that are marked with (exactly) PARSE_VALUES and H | K in [0] to properties.mako.rs, as part of #10408. A few questions and remarks:
* I created a SVG style struct. Should those properties be somewhere else instead?
* I did not know what to do with ime-mode (which lives in nsStyleUIReset), so I did not include it.
* Servo already has a -servo-overflow-clip-box property, while Gecko has overflow-clip-box. Should those be consolidated?
* There is a code comment (marked with XXX) about scroll-snap-type-y. Should I add a <%self:longhand> template tag for that, similar to the one in overflow-y?
I am getting error E0053 while trying to run "./mach build-geckolib -r" on master, and the bholley/stylo branch doesn't support the products keyword argument yet, so I haven't exactly checked this compiles properly. It doesn't add any new compilation errors before the E0053 one, though.
Let me know if some extra information (say, a table saying where each property went) would be useful in the review process. r? @bholley
[0] https://docs.google.com/spreadsheets/d/1pSw2SjNxXZAQ19SAuNKcs5u4S7Zkc1ebEOkSP4oITUQ/edit?pref=2&pli=1
Source-Repo: https://github.com/servo/servo
Source-Revision: 0e953618d1070f2019f452318deac4a6ea375600
These pave the way for implementing other parts of specifications more thoroughly.
Source-Repo: https://github.com/servo/servo
Source-Revision: 9b57d8d686d361c0dfba1056523cbea12abd148b
Without this `./mach run -b -- -M` would start fine but navigating to a site would fail with:
`thread 'ScriptThread PipelineId { namespace_id: PipelineNamespaceId(0), index: PipelineIndex(0) }' panicked at 'assertion failed: mozbrowser_enabled()', /Users/ulf/Documents/Code/servo/components/script/dom/htmliframeelement.rs:163`
Source-Repo: https://github.com/servo/servo
Source-Revision: e8e354d5d3e6757c16912e7f5e6234ec5eece493
Note that this only works for translation; a more general fix would
require major changes to how display lists work.
Closes#10431?
Source-Repo: https://github.com/servo/servo
Source-Revision: 7e63c1be63716e6f190416b512caa12afb4cda52
A `Root` cannot outlive the `RootCollection` it is recorded in.
The docs were saying otherwise.
r? @jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: bbcbd35095bdfcd9b8e7eb329209682e89408c72
code is unreachable after return, and identical to the upper block
Source-Repo: https://github.com/servo/servo
Source-Revision: 155e4052d150179ea8423a7ea626a84e25409718
More work as described in #10185.
I am getting _extremely_ weird compile-time errors with this one, when it's trying to expand the `lazy_static!` macro. I think I'll need help getting that part sorted out. The rest should be pretty OK.
Anyone has ideas on how to resolve it?
Source-Repo: https://github.com/servo/servo
Source-Revision: a4991f536cb60b70309358cbb4da46dfbe412b3d
Solving https://github.com/servo/servo/issues/10428
- Fix timing precision in old `update_with_current_time`
- Correct time unit in `navigation_start`
- Add `LoadEventStart` and `LoadEventEnd` timing properties
There are still many properties left unimplemented. I tend to leave the for future PRs.
Welcome comments!
Source-Repo: https://github.com/servo/servo
Source-Revision: 421dcc92f05532e5d8bda850c8d14c9375da2bd9
a pull request that solves #9769.
I fixed on review note, and couldn't reproduce the second one.
Fixes#10506.
Source-Repo: https://github.com/servo/servo
Source-Revision: ea97c8905580e67e96ae00572d1c4e7af3d58736
Improves YouTube.
Improves the Washington Post.
Closes#10526.
r? @glennw
Source-Repo: https://github.com/servo/servo
Source-Revision: 150338503dce8f2ba7f2a6850dca253733a636a1
Got `etc/ci/check_no_unwrap.sh` to pass, and re-enabled it.
Source-Repo: https://github.com/servo/servo
Source-Revision: a61fc5285fa00915d538a9672c04030804f7db2d
Core Text treats a font size of 0.0 as 12.0, which is obviously not what
we want.
Improves Twitter.
Improves Reddit /r/rust.
Closes#10492.
r? @mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: 65120756c06ee2d0357cca6357e30694a0ec6559
Add style property for `order` and implement reordering by this property
in flex flow. Based on previous work by @zentner-kyle.
Fixes: #9957
Source-Repo: https://github.com/servo/servo
Source-Revision: df21bb47d414a1ff068623b55e9da644d7239731
This adds in preferences for all the SM 39 available options (as
retrieved from Gecko), and uses the same defaults as Gecko. A few
properties are not supported yet, and incremental GC is still always
disabled regardless of the preference setting.
Source-Repo: https://github.com/servo/servo
Source-Revision: bc2237ea2ba3beac501ca4347b8118f3dccd9629
