Commit Graph

35039 Commits

Author SHA1 Message Date
Martin Stransky
5a403b0cdd Bug 1587008 - [Wayland] Set EGL window size at CompositorOGL::BeginFrame, r=sotaro
wl_egl_window size must exactly march GL rendering pipeline setting.

Compositor and widget can have different window sizes during window resize when widget
is resized faster than layout can render. Firefox window is rendered misplaced then
and it's "jumping" as layout size is behind toolkit size.

Differential Revision: https://phabricator.services.mozilla.com/D49136

--HG--
extra : moz-landing-system : lando
2019-10-15 19:25:28 +00:00
Kris Taeleman
8205a49853 Bug 1585801 - Fixing crash when folder is not writable and refactored logic. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48999

--HG--
extra : moz-landing-system : lando
2019-10-15 17:03:22 +00:00
Dorel Luca
518c1a81eb Backed out 2 changesets (bug 1587008) for build bustage on src/widget/gtk/GtkCompositorWidget.cpp. CLOSED TREE
Backed out changeset 9e610c4628e1 (bug 1587008)
Backed out changeset afc6499c8f1f (bug 1587008)

--HG--
extra : rebase_source : 3c3cc17ada4079f279809cae1ece2e226fde5acf
extra : histedit_source : c7f61dbede0eda8ea3b0a1dfa5c67f8650f4ca81
2019-10-15 19:10:32 +03:00
Martin Stransky
bfddf50156 Bug 1587008 - [Wayland] Set EGL window size at CompositorOGL::BeginFrame, r=sotaro
wl_egl_window size must exactly march GL rendering pipeline setting.

Compositor and widget can have different window sizes during window resize when widget
is resized faster than layout can render. Firefox window is rendered misplaced then
and it's "jumping" as layout size is behind toolkit size.

Differential Revision: https://phabricator.services.mozilla.com/D49136

--HG--
extra : moz-landing-system : lando
2019-10-15 13:12:13 +00:00
Emilio Cobos Álvarez
1aaa268725 Bug 1588743 - Remove old scroll-snap implementation, and scroll snapping prefs. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D49267

--HG--
extra : moz-landing-system : lando
2019-10-15 12:40:14 +00:00
Coroiu Cristina
291d475197 Backed out changeset 1a951477dca5 (bug 1588743) for xpcshell failures at devtools/shared/tests/unit/test_css-properties-db.js on a CLOSED TREE 2019-10-15 15:35:50 +03:00
Emilio Cobos Álvarez
8325c4b9a3 Bug 1588743 - Remove old scroll-snap implementation, and scroll snapping prefs. r=hiro
Differential Revision: https://phabricator.services.mozilla.com/D49267

--HG--
extra : moz-landing-system : lando
2019-10-15 11:39:30 +00:00
Emilio Cobos Álvarez
1de29ffe19 Bug 1586600 - Make nsPresContext's overflow propagation match the spec. r=hiro
From https://drafts.csswg.org/css-overflow/#overflow-propagation:

> UAs must apply the overflow-* values set on the root element to the viewport.
> However, when the root element is an [HTML] html element (including XML syntax
> for HTML) whose overflow value is visible (in both axes), and that element has
> a body element as a child, user agents must instead apply the overflow-*
> values of the first such child element to the viewport. The element from which
> the value is propagated must then have a used overflow value of visible.

This was out of sync with Document::IsScrollingElement, which implements the
right thing.

Differential Revision: https://phabricator.services.mozilla.com/D49196

--HG--
extra : moz-landing-system : lando
2019-10-15 10:33:14 +00:00
Markus Stange
d76e9ba35f Bug 1586627 - Work around a bug in AppleIntelHD3000GraphicsGLDriver in CompositorOGL. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D49050

--HG--
extra : moz-landing-system : lando
2019-10-15 02:14:50 +00:00
Cosmin Sabou
3c03c8f466 Backed out changeset 2947c5ae2f8b (bug 1586600) for mochitest failures on test_group_wheelevents.html. 2019-10-15 03:52:46 +03:00
Emilio Cobos Álvarez
a934a45ffd Bug 1586600 - Make nsPresContext's overflow propagation match the spec. r=hiro
From https://drafts.csswg.org/css-overflow/#overflow-propagation:

> UAs must apply the overflow-* values set on the root element to the viewport.
> However, when the root element is an [HTML] html element (including XML syntax
> for HTML) whose overflow value is visible (in both axes), and that element has
> a body element as a child, user agents must instead apply the overflow-*
> values of the first such child element to the viewport. The element from which
> the value is propagated must then have a used overflow value of visible.

This was out of sync with Document::IsScrollingElement, which implements the
right thing.

Differential Revision: https://phabricator.services.mozilla.com/D49196

--HG--
extra : moz-landing-system : lando
2019-10-14 22:29:17 +00:00
sotaro
61f09c1667 Bug 1588019 - Add option of enabling highlighting redraw regions of DCompositionVisual r=nical
Differential Revision: https://phabricator.services.mozilla.com/D48937

--HG--
extra : moz-landing-system : lando
2019-10-14 12:55:01 +00:00
Glenn Watson
1cca72e311 Bug 1587676 - Allocate picture caching tile surfaces later during the frame. r=nical,kvark
Instead of allocating a tile surface from the texture cache during
the tile post_update method, this is now deferred until the
take_context method of picture.

This will allow a simple CPU occlusion culling pass to run after
all the tile cache dependency updates (when the visible tiles and
rects are know), but before the surfaces are allocated. In this way,
we will be able to skip allocating, rasterizing and compositing
any tiles that are eliminated by the occlusion culling test.

Differential Revision: https://phabricator.services.mozilla.com/D48795

--HG--
extra : moz-landing-system : lando
2019-10-13 20:24:40 +00:00
Oana Pop Rus
8a7bc2ad4e Backed out changeset 77357e0aa88e (bug 1584859) for wpt and mochitest failures. on a CLOSED TREE 2019-10-13 14:06:44 +03:00
Emilio Cobos Álvarez
8657ceea27 Bug 1584859 - Make smooth scrolling conditional on reduced motion settings. r=dbaron
We could put this change itself behind a pref too, if we considered that worth
it. But probably not so.

Differential Revision: https://phabricator.services.mozilla.com/D48010

--HG--
extra : moz-landing-system : lando
2019-10-13 09:16:26 +00:00
Emilio Cobos Álvarez
536c1bc0bb Bug 1581467 - Fix checks for display: inline{,-block} which don't account for inline list items. r=mats
Differential Revision: https://phabricator.services.mozilla.com/D48346

--HG--
extra : moz-landing-system : lando
2019-10-12 21:05:16 +00:00
Jeff Muizelaar
b36a941d02 Bug 1588224. Blob: Remove unused members and some debugging code.
This also reduces the size of BlobItemData which will give us
some free performance on SVGs that have a lot of items by reducing
our working set size.

Differential Revision: https://phabricator.services.mozilla.com/D49023

--HG--
extra : moz-landing-system : lando
2019-10-11 21:59:59 +00:00
Jeff Muizelaar
8a440a3269 Bug 1587198. Wrench: Supported saving images with strides != width*bytes_per_pixel. r=kvark
Differential Revision: https://phabricator.services.mozilla.com/D48602

--HG--
extra : moz-landing-system : lando
2019-10-09 18:58:08 +00:00
Imanol Fernandez
2d92d3cf9a Bug 1587366 - Fix VRManagerParent::GetVRActiveStatus race condition: Notify VRActiveStatus after a the VREventObserver is created. r=rbarker,daoshengmu
Notify VRActiveStatus after a the VREventObserver is created to prevent the VRManagerParent::GetVRActiveStatus race condition.
Call VRManager::Shutdown() when the app goes to background instead of calling it in the foreground event due to the inactivity timer.

Differential Revision: https://phabricator.services.mozilla.com/D48678

--HG--
extra : moz-landing-system : lando
2019-10-11 15:58:39 +00:00
arthur.iakab
604018cb2e Backed out changeset 42d3ccf69629 (bug 1583879) for causing reftest failures on sort-startSame-1b.svg CLOSED TREE 2019-10-11 18:27:52 +03:00
Nicolas Silva
c1f7e63ce2 Bug 1583879 - Skip uploading and rendering empty blob tiles. r=jrmuizel
This patch adds a notion of "fully transparent" image in the resource cache.
These are not uploaded in the texture cache and image requests return the
necessary information to allow the frame building code to skip emitting
primitives accordingly.

Differential Revision: https://phabricator.services.mozilla.com/D47878

--HG--
extra : moz-landing-system : lando
2019-10-09 13:34:51 +00:00
Dzmitry Malyshau
1cc5f88f07 Bug 1558167 - Force 256 alignment for texture uploads on AMD on macOS r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48862

--HG--
extra : moz-landing-system : lando
2019-10-10 15:25:57 +00:00
sotaro
2df9cdb3b4 Bug 1587695 - Fix redundant SwapChain re-creation r=nical
Since Bug 1570879, SwapChain is created with alpha at first, then the SwapChain is typically re-created at first RenderCompositorANGLE::BeginFrame() calle, since non Glass window is common since Windows 10. The re-creation is redundant.

Differential Revision: https://phabricator.services.mozilla.com/D48800

--HG--
extra : moz-landing-system : lando
2019-10-10 08:58:00 +00:00
John Lin
aeb8b64dbe Bug 1509316 - p1: move composite listening out of VideoData/VideoSink. r=jya,mattwoodrow
On Android, decoded buffers need to be send back to MediaCodec in order to be
rendered and/or recycled. The current mechanism introduced in bug 1299068 only
works for playback(VideoData/VideoSink) but not WebRTC(VideoFrame/VideoOutput).
Move the callback to SurfaceTextureImage because VideoData and VideoFrame both
own that when using MediaCodec, and move the notification to VideoFrameContainer
for both VideoSink and VideoOutput pass frames there for compositing.

Differential Revision: https://phabricator.services.mozilla.com/D45771

--HG--
extra : moz-landing-system : lando
2019-10-09 23:08:12 +00:00
Emilio Cobos Álvarez
b320aa695c Bug 1587468 - Add syn/quote/etc to the list of allowed duplicated WR dependencies for now. r=bustage
MANUAL PUSH: bustage
2019-10-09 23:06:09 +02:00
Jeff Muizelaar
487b155e34 Bug 1586573. Don't use the visibleRect for non blob images. r=aosmond
This reverts to the previous behaviour for non-blob fallback images.

Differential Revision: https://phabricator.services.mozilla.com/D48631

--HG--
extra : moz-landing-system : lando
2019-10-09 16:54:34 +00:00
Emilio Cobos Álvarez
3a4be043a8 Bug 1587468 - Update syn / quote / synstructure in peek-poke-derive. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48732

--HG--
extra : moz-landing-system : lando
2019-10-09 17:10:12 +00:00
Jeff Muizelaar
88c6d9a1dc Bug 1587210. Always clear mInvalidRect. r=mstange
In the future mInvalidRect and some other state should move out of DIGroup
and into a non-persistant struct that's only used during Group building.
This will allow us to completely avoid errors like this.

Differential Revision: https://phabricator.services.mozilla.com/D48706

--HG--
extra : moz-landing-system : lando
2019-10-09 18:10:54 +00:00
Markus Stange
f2eaddfc8f Bug 1577566 - Enforce appropriate output channel clamping in D2D1 ColorMatrix filters. r=bas
Differential Revision: https://phabricator.services.mozilla.com/D45142

--HG--
extra : moz-landing-system : lando
2019-10-09 15:38:21 +00:00
Jamie Nicol
51410a091e Bug 1584109 - Rename WR_RENDER_TIME to WR_FRAMEBUILD_TIME. r=jrmuizel
It is actually measuring frame building time, not rendering.

Differential Revision: https://phabricator.services.mozilla.com/D48343

--HG--
extra : moz-landing-system : lando
2019-10-09 10:52:22 +00:00
sotaro
3546b3c622 Bug 1585278 - Add option of enabling performance debugging counters of DirectComposition r=nical,jrmuizel
IDCompositionDevice is replaced by IDCompositionDevice2. It is necessary for IDCompositionDeviceDebug usage. And for using IDCompositionDevice2, _WIN32_WINNT and NTDDI_VERSION is updated from Windows 8 to Windows 8.1.

Workaround MinGW build failure.

Differential Revision: https://phabricator.services.mozilla.com/D47742

--HG--
extra : moz-landing-system : lando
2019-10-07 20:09:17 +00:00
Glenn Watson
b4d8e0c7ca Bug 1587084 - Restore the picture caching enabled preference. r=nical
The previous patch fixed the bug in the non-picture caching code
path, so we can re-enable the preference now.

Differential Revision: https://phabricator.services.mozilla.com/D48639

--HG--
extra : moz-landing-system : lando
2019-10-09 08:07:36 +00:00
Brendan Dahl
237d762715 Bug 1510785 - Skip all XBL related tests when XBL is disabled. r=bzbarsky
XBL will be disabled on android, so these tests must be skipped. Where possible
tests are copied to create shadow DOM tests.

Depends on D45615

Differential Revision: https://phabricator.services.mozilla.com/D45616

--HG--
rename : layout/inspector/tests/test_bug522601.xhtml => layout/inspector/tests/test_bug522601-shadow.xhtml
rename : layout/inspector/tests/test_bug609549.xhtml => layout/inspector/tests/test_bug609549-shadow.xhtml
rename : layout/reftests/bugs/334829-1a.xhtml => layout/reftests/bugs/334829-1a-shadow.xhtml
rename : layout/reftests/bugs/334829-1b.xhtml => layout/reftests/bugs/334829-1b-shadow.xhtml
rename : layout/reftests/bugs/386310-1b.html => layout/reftests/bugs/386310-1b-shadow.html
rename : layout/reftests/bugs/386310-1c.html => layout/reftests/bugs/386310-1c-shadow.html
rename : layout/reftests/bugs/386310-1d.html => layout/reftests/bugs/386310-1d-shadow.html
rename : layout/reftests/bugs/482592-1a.xhtml => layout/reftests/bugs/482592-1a-shadow.xhtml
rename : layout/reftests/bugs/482592-1b.xhtml => layout/reftests/bugs/482592-1b-shadow.xhtml
rename : layout/reftests/css-selectors/sibling-combinators-on-anon-content-1.xhtml => layout/reftests/css-selectors/sibling-combinators-on-anon-content-1-shadow.xhtml
rename : layout/reftests/css-selectors/sibling-combinators-on-anon-content-2.xhtml => layout/reftests/css-selectors/sibling-combinators-on-anon-content-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendmultiple.xhtml => layout/reftests/dom/multipleinsertionpoints-appendmultiple-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendsingle-1.xhtml => layout/reftests/dom/multipleinsertionpoints-appendsingle-1-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-appendsingle-2.xhtml => layout/reftests/dom/multipleinsertionpoints-appendsingle-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertmultiple.xhtml => layout/reftests/dom/multipleinsertionpoints-insertmultiple-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertsingle-1.xhtml => layout/reftests/dom/multipleinsertionpoints-insertsingle-1-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-insertsingle-2.xhtml => layout/reftests/dom/multipleinsertionpoints-insertsingle-2-shadow.xhtml
rename : layout/reftests/dom/multipleinsertionpoints-ref2.xhtml => layout/reftests/dom/multipleinsertionpoints-ref2-shadow.xhtml
rename : layout/reftests/ib-split/insert-into-split-inline-5.html => layout/reftests/ib-split/insert-into-split-inline-5-shadow.html
extra : moz-landing-system : lando
2019-10-08 23:52:46 +00:00
Jamie Nicol
523db48f57 Bug 1587047 - Update wrench reftest expectations. r=gw
Depends on D48541

Differential Revision: https://phabricator.services.mozilla.com/D48542

--HG--
extra : moz-landing-system : lando
2019-10-08 20:18:50 +00:00
Jamie Nicol
fb307f9307 Bug 1587047 - Ensure PBO is at least height * stride size to avoid emulator error. r=gw
When uploading texture data with a PBO we currently ensure the PBO
is the size of `(height - 1) * stride + (width * bpp)`, ie the final row
only contains the width's worth of data, not the stride. This should
be okay, and works fine on other implementations, but the android
emulator thinks it is invalid and emits a GL_INVALID_OPERATION error
in the glTexSubImage* call. To avoid this, ensure that the PBO is the
full `height * stride` size.

Differential Revision: https://phabricator.services.mozilla.com/D48541

--HG--
extra : moz-landing-system : lando
2019-10-08 20:18:28 +00:00
Glenn Watson
59f6ac9ee1 Bug 1587084 - Fix non-picture-caching path on webrender. r=kvark
The framebuffer clear was accidentally removed due to a rebase
error. We need to clear the framebuffer (and z) here when the
non-picture caching path is active.

Differential Revision: https://phabricator.services.mozilla.com/D48600

--HG--
extra : moz-landing-system : lando
2019-10-08 20:44:56 +00:00
Jeff Muizelaar
c572d06005 Bug 1516286. WR Fallback: Do the empty check later. r=aosmond
What we actually care about here is whether itemRect is empty bceause that's
the what we'll use for the actual surface size.

Differential Revision: https://phabricator.services.mozilla.com/D48548

--HG--
extra : moz-landing-system : lando
2019-10-08 14:20:40 +00:00
Nicolas Silva
a68a1fa1cd Bug 1587084 - Prevent disabling picture caching temporarily. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48555

--HG--
extra : moz-landing-system : lando
2019-10-08 15:47:46 +00:00
Bob Owen
003b93beee Bug 1580511: Check size is allowed in DrawTargetRecording::CreateSourceSurfaceFromData. r=jrmuizel
Differential Revision: https://phabricator.services.mozilla.com/D48317

--HG--
extra : moz-landing-system : lando
2019-10-07 14:38:06 +00:00
sotaro
fb4696fe6d Bug 1570879 - Fix high contrast theme handling with DirectComposition and WebRender r=nical
When high contrast mode is enabled, title bar is drawn as transparent and on-client area rendering by DWM is shown. But when compositor window in GPU process is used, the on-client area rendering was not shown. To address the proboem, window needs to be cleard as transparent and SwapChain of compositor window needs to be DXGI_ALPHA_MODE_PREMULTIPLIED.

WinCompositorWidget::mTransparencyMode is changed to atomic, since it is accessed from compositor thread and render thread.

Differential Revision: https://phabricator.services.mozilla.com/D48302

--HG--
extra : moz-landing-system : lando
2019-10-08 10:07:47 +00:00
Bob Owen
b6cee86eff Bug 1583337: Return null in CanvasChild::WrapSurface if we don't have a recorder. r=jrmuizel
The CanvasChild must be in the process of being destroyed at this point anyway.

Differential Revision: https://phabricator.services.mozilla.com/D47443

--HG--
extra : moz-landing-system : lando
2019-10-07 14:37:13 +00:00
alwu
d832456285 Bug 1579127 - only count the frame dropping due to system overload. r=mattwoodrow
When user adjusts the video playback rate, which might cause we sending images in a speed that is faster than the speend we composite images.

In this situation, the frame dropping actually won't cause any visual defect and we also don't want to report this frame dropping to user, because it's not caused by system overloading, it's just our compositor doesn't support compositing images in such a high rate.

Therefore, we should check if the dropped images are caused by system overload or high update rate, and only report the former to user.

Differential Revision: https://phabricator.services.mozilla.com/D46236

--HG--
extra : moz-landing-system : lando
2019-10-08 08:06:13 +00:00
Botond Ballo
1e691d370f Bug 1552608 - Handle fixed layer margins in ReceiveInputEvent. r=tnikkel
Only touch events are handled at this time.

Differential Revision: https://phabricator.services.mozilla.com/D48385

--HG--
extra : moz-landing-system : lando
2019-10-07 22:22:08 +00:00
Botond Ballo
0e413c9b53 Bug 1552608 - Include the fixed-position sides in HitTestResult. r=tnikkel
Populating them is hooked up for non-WebRender, with a comment outlining
possible implementation strategies for WebRender.

Differential Revision: https://phabricator.services.mozilla.com/D48384

--HG--
extra : moz-landing-system : lando
2019-10-07 22:16:51 +00:00
Botond Ballo
ba2a3dd77a Bug 1552608 - Introduce a HitTestResult structure for grouping the results of APZ hit testing. r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48383

--HG--
extra : moz-landing-system : lando
2019-10-07 22:47:17 +00:00
Botond Ballo
429e12e60f Bug 1552608 - Allow HitTestingTreeNodeAutoLock to be moved. r=tnikkel
Also remove the MOZ_RAII annotation, as that inhibits moving.

Differential Revision: https://phabricator.services.mozilla.com/D48382

--HG--
extra : moz-landing-system : lando
2019-10-07 22:04:23 +00:00
Botond Ballo
f7a776d631 Bug 1552608 - Remove the unused function APZCTreeManager::HitTestAPZC(). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48381

--HG--
extra : moz-landing-system : lando
2019-10-07 22:01:52 +00:00
Botond Ballo
9649f2e747 Bug 1552608 - Remove the 'aNode' parameter of GetAPZCAtPoint(). r=tnikkel
This is a relic from earlier times when GetAPZCAtPoint() was recursive.

Differential Revision: https://phabricator.services.mozilla.com/D48380

--HG--
extra : moz-landing-system : lando
2019-10-07 22:00:59 +00:00
Botond Ballo
f8900bc22d Bug 1552608 - Handle fixed layer margins in ComputeTransformForNode(). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48379

--HG--
extra : moz-landing-system : lando
2019-10-07 22:00:31 +00:00
Botond Ballo
c747ab0102 Bug 1552608 - Add a helper APZCTreeManager::IsFixedToRootContent(node). r=tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D48378

--HG--
extra : moz-landing-system : lando
2019-10-07 21:56:36 +00:00