This adds the following tasks on central:
> test-linux1804-64-shippable-qr/opt-mochitest-webgl1-ext-fis-e10s
> test-windows10-64-shippable-qr/opt-mochitest-webgl1-ext-fis-e10s
Differential Revision: https://phabricator.services.mozilla.com/D112983
This starts using the same spacing as commonDialog for these dialogs
with proton enabled. It also updates the checkbox spacing, alignment
and colour (bug 1705882 will fix the correct colour choice here.)
The spacing is still not ideal in the second dialog (after you click
'Choose Application') but there isn't much we can do about that unless
we get rid of the confirmation text about where to change the preference,
or we start creating ways for the dialog to tell SubDialog to resize
it when items are added/removed, which is not straightforward, so I
decided not to tackle that here.
Differential Revision: https://phabricator.services.mozilla.com/D112788
Unlike the stdlib Popen class, ProcessHandler.kill implictly waits for
the process to end. To avoid hangs in the case where the process
doesn't end, allow passing through a timeout to this function (on
posix only).
This is somewhat unfortunate as it means that ProcessHandler isn't
interchangable with Popen. But the only other option here appears to
be not doing the implicit wait which presumably consumers are relying on.
Differential Revision: https://phabricator.services.mozilla.com/D112609
This is not obviously doing more than the stdlib code does these days,
and also doesn't support timeouts, so we're perhaps better just always
defering to the stdlib.
Differential Revision: https://phabricator.services.mozilla.com/D112608
This forces current_job to null as soon as it is known whether there are no more
bands available so that current_job is always null if job_count is zero.
Differential Revision: https://phabricator.services.mozilla.com/D112891
This patch doesn't change behavior. The "InProcess" version of this API (which
we're migrating to in this patch) is used to annotate GetCrossDocParentFrame()
callsites that have been vetted as being OK with the fact that this API returns
null at the boundary of a cross-origin iframe, if fission is enabled.
This particular callsite is in MacOS "source-list" rendering code, which seems
to be a XUL-only feature; and that means it should be parent-process-only and
shouldn't need to traverse process boundaries / origins. So, it's reasonable to
annotate. (And if it does somehow hit a process boundary, this function will
just return false and take the "not-in-a-source-list" rendering codepath
elsewhere in this file.)
Differential Revision: https://phabricator.services.mozilla.com/D112882
This test contains a section that checks arrow key navigation of context menus,
which doesn't work with macOS native context menus. This patch disables that
section of the test and uses a more declarative context menu API when the pref
is set, which is an indicator that the test is being run on macOS with native
context menus.
Differential Revision: https://phabricator.services.mozilla.com/D112119
When changing a dictionary property, we have to generate a new shape for the
object (last property shape) and we can then mutate the property in place.
This removes the extra shape allocation for the mutated property.
This reverts the change in bug 703157: the issue fixed there no longer applies.
`replaceWithNewEquivalentShape` is then only used for `generateOwnShape`, to generate
a new shape for the last property, so we can inline it into `generateOwnShape` and
simplify the code a bit.
Differential Revision: https://phabricator.services.mozilla.com/D112907
We have seen a lot of crashes with the new vsync input alignment code
because a possible case is
1. Input event runs when there's a pending vsync (state=HasPendingVsync)
2. Input event handler starts an event loop (state=HasPendingVsync)
3. Vsync runs (state=HasPendingVsync) and crashes.
It crashes because the `DidRunTask` method for the input event doesn't
get a chance to run, which supposes to set the state to RunVsync.
Differential Revision: https://phabricator.services.mozilla.com/D112799
Otherwise the menupopup retains the native "Menu" color, which inherits
to menuitems, and can cause contrast issues for HCM users.
It also makes more sense to specify color along with background anyways.
Differential Revision: https://phabricator.services.mozilla.com/D112909
We should just restore the state when seeing whitespace and an unknown
token like when we do when finding any other token a few lines below.
This is not an issue for most callers (it's only an issue for clamp())
because the other callers use either `parse_comma_separated()` (for
min/max), or `parse_nested_block()` (for parens / nested calc()).
Both of those functions restrict the input in such a way that
is_exhausted returns true (a few lines above) and thus we parse
successfully.
Differential Revision: https://phabricator.services.mozilla.com/D112681
This starts using the same spacing as commonDialog for these dialogs
with proton enabled. It also updates the checkbox spacing, alignment
and colour (bug 1705882 will fix the correct colour choice here.)
The spacing is still not ideal in the second dialog (after you click
'Choose Application') but there isn't much we can do about that unless
we get rid of the confirmation text about where to change the preference,
or we start creating ways for the dialog to tell SubDialog to resize
it when items are added/removed, which is not straightforward, so I
decided not to tackle that here.
Differential Revision: https://phabricator.services.mozilla.com/D112788
Shifts and rotates may require a variable RHS to be in a specific
register. We can express this generically by passing an rhs-popper
function to the emitter.
(64-bit rotates are additionally complicated by requiring a temp, and
are not translated in this patch.)
Differential Revision: https://phabricator.services.mozilla.com/D109610
Popcount may need a temp; whether it does depends on both the platform
and the CPU. A custom temp allocator function can be passed to the
emitter and used generically.
Differential Revision: https://phabricator.services.mozilla.com/D109609
