When opening a new tab, there is a small window between tab creation and the DOMTitleChanged event firing where the tab - if it is not created as a delay loaded zombie tab right away - won't have any session store data. However a number of functions (tab zombification and restoring of zombified tabs, undo close tabs) depend on the session store data always being available, so things can fall apart if e.g. a zombification is triggered immediately after opening a new tab.
This also means that a tab which is zombfied immediately after its creation (e.g. when a number of tabs are opened through tab queues on startup) is not included in a session save and will therefore get lost if Firefox is killed.
Therefore, we now always intialise new tabs with some basic session store data.
MozReview-Commit-ID: 9248jJFUaq5
--HG--
extra : transplant_source : %BC%7Ci%20%82%1E7%29%9E%0E7%87%ED-%0B%E0%84%86R%F9
ESLint 2 now flags anonymous generator functions according to
generator-star-spacing. Most of the changes here are correcting that.
MozReview-Commit-ID: 9xg2Gmlaz94
--HG--
extra : rebase_source : e6db0fd0ef477cd4fd2196b1036783f0974c586b
extra : histedit_source : 03eea033884969cc2a340316377318b0487ebdf2
ESLint 2 now flags anonymous generator functions that don't match the
generator-star-spacing rule so this mostly is fixing that.
MozReview-Commit-ID: 5sLaF26sd0E
--HG--
extra : rebase_source : 6008f48c94e4a8e5bd2ed2f8a95e764e4aa39cdb
extra : histedit_source : 6f0151c184ee2e4288f3ec9c5a85a65e975d46e1
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: KHYdAkRvhVr
--HG--
extra : rebase_source : 720cc9d864175248508146a7f4704b4bf3f02439
extra : histedit_source : 6cc0ecbf21a571e1a41d517b67512a3452fac19a
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: DEskVIjiKDM
--HG--
extra : rebase_source : 07ba1d14655f5d761624b105ef025ec88323d4d5
extra : histedit_source : 9e5ab54ce1b1a5ee1f0fb143f8d1450522455e3b
Most of this is fixing functions that in some cases return a value but then
can also run to completion without returning anything. ESLint 2 catches this
where previous versions didn't. Unless there was an obvious other choice I just
made these functions return undefined at the end which is effectively what
already happens.
MozReview-Commit-ID: CRpZy873GP6
--HG--
extra : rebase_source : d355e5f0f13211cbd81e2a91cfe6191f5e84adb2
extra : histedit_source : eb85af7438b493a22fd9a4c32ab254e6a01b7cb3
Rename the rules that ESLint 2 no longer supports to the new names. Ignore the
microformat test suite as it is external code.
MozReview-Commit-ID: BgIxFERjHp1
--HG--
extra : rebase_source : 9f02a87f9a843b427b021caa72db9eb766287151
extra : histedit_source : 954abc7e447ac6cdd36290ade7adec626f4fe4fb
This test simulates a context click in the rule view and selects the
"add rule" item in order to add a new rule.
Adding a rule triggers a ruleview-changed event, and so this test should
start listening for this event before triggering the action, which it
did not do.
MozReview-Commit-ID: BPO8Fgwsq5M
--HG--
extra : rebase_source : e975e57148850c41cfae4d9748809d1f6672aa84
Add coverage for:
* The |openOptionsPage| method when |options_ui| is missing from the manifest.
MozReview-Commit-ID: BwVMzDOECl3
--HG--
extra : transplant_source : %ED%E7%04N%DC%9D%FC%FD%BF%A2%02%D7SQ%3D%8A%EBa%98%A7
Add coverage for:
* passing an invalid |tabId|
* passing an array of URLs to open in |url|
MozReview-Commit-ID: EW8sh0p6hgB
--HG--
extra : transplant_source : %5D%BF%EE%EBM%9C%EA%AFj%0F%7F%AFx%F1%8E%F0QV%1Bb
