This action is not used anywhere since we batch messages and thus use MESSAGES_ADD action.
The tests that were using it now use messagesAdd.
MozReview-Commit-ID: 9DvyrpR4ocC
--HG--
extra : rebase_source : 34d374cff5dddbe27652e6144df989617edc816f
extra : source : 5920bc28fb0437149ab789081d64db38ea183f41
Test was already migrated in Bug 1304003 to browser_webconsole_observer_notifications.js.
MozReview-Commit-ID: DyfVJ49ksSd
--HG--
extra : rebase_source : e2ec3f78e04f87e8951fde4de0e0d3ceabfa57c3
Now that we are using sibling divs for all the cells of the table,
we don't have the same notion of what is a row.
The console table test is adapted to the new component.
MozReview-Commit-ID: HcfzTaRVIcN
--HG--
extra : rebase_source : fdf95ccb5abf8fc9ed362e03d72dae2f03245300
Since table elements (th, tr) do not support sticky headers, the console table now
uses only sibling divs for the cells, with appropriate aria attributes and a CSS grid
to mimic an actual table.
MozReview-Commit-ID: J8hmy7H4GKL
--HG--
extra : rebase_source : 220368d50a36707f7114a4c69580614b79b955e9
If the netmonitor hasn't had `npm install` ran, then running the webconsole tests fail,
because the webconsole depends on netmonitor, and the babel plugin "transform-object-rest-spread"
defined in netmonitor/.babelrc cannot be resolved unless if it's been installed.
MozReview-Commit-ID: KyQgja5rRpg
--HG--
extra : rebase_source : 9a8487fccd7c8641f47dcc405be3c8324bf8474c
There was an exception thrown by the netProviderEnhancer because it
retrieves the networkMessageUpdate and access a property on it.
On non-network message, the networkMessageUpdate is undefined, and
accessing the property throws.
We fix this by simply checking if message is not falsy before accessing
the property.
A couple of tests were added to make sure we don't regress this case. This
required changing the setupStore helper a bit to pass a hud stub to the
createStore function (the net enhancer is called only if the hud has a proxy
object). This made some test fail because they weren't dispatching enough
argument to the networkMessageUpdate action.
MozReview-Commit-ID: 7h35ebHSdbF
--HG--
extra : rebase_source : 089dce93d1de60e4b44936b514627803aa2c5100
Message icons now get the aria-live="off" attribute.
This stops screen readers from automaticaly reading icon descriptions, which might be interesting to read later but make things inefficient when automatically reading new output.
MozReview-Commit-ID: BQOUnTRVkBE
--HG--
extra : rebase_source : 47f1df96910a92961fc739582ffb49956735fdb3
Commands entered by the user now get the aria-live="off" attribute.
This stops screen readers from echoing commands the user typed, which is redundant and inefficient.
MozReview-Commit-ID: GJXiBPMe0W5
--HG--
extra : rebase_source : 9fac3b14115a9f2f54bc8180bed6c0442e0da3f0
The test was failing because it still had pending request to the server while shutting
down the toolbox. This request was probably the one to retrieve the properties of the
object we put in the sidebar.
By waiting the object properties to be fully loaded when opening the sidebar, we should
make the intermittent go away.
MozReview-Commit-ID: 7tY8hvbDVRp
--HG--
extra : rebase_source : cc5479f21c91df1fc0967900fb1022e3ec6dff3d
This patch adds a few console.count stubs and check
that they all render as expected.
MozReview-Commit-ID: IejxMKnLTAz
--HG--
extra : rebase_source : a9df8bd9eb1b78c6f05106c16d48dd31d16087f6
The test was failing because we have more than one
networkUpdate in the store.
As it's not the purpose of this test case to assert the
number of updates, let's just check that we have some,
and that they are removed after MESSAGES_CLEAR.
MozReview-Commit-ID: FgZv8epfP0q
--HG--
extra : rebase_source : 269f8654fa0f9f06c8ece5fe6415f82385553e85
The tests were failing because all the sidebarToggle actions
were renamed to sideBarClose, which made the tests inacurate.
MozReview-Commit-ID: LBkqTzNhaqV
--HG--
extra : rebase_source : 5943924d6fb073cb2375df275665de206aaf857b
This changes the code of the test since it was relying on direct access to the content page.
In order to be able to interact with the element picker, the test-actor and test-actor-registery
files are loaded by head.js.
MozReview-Commit-ID: FyebIiyF31j
--HG--
extra : rebase_source : 83d7304303edc8e8a54cbcc2cc535987b8368207
The patch changes how log we wait before polling again in waitFor, since the timeout
is happening here.
MozReview-Commit-ID: 4ZteEmMBOZk
--HG--
extra : rebase_source : 44078fa03df8ce7650d71ac0ad401a30827f2d83
The test was refactored in Bug 1408932, but it wasn't actually enabled.
MozReview-Commit-ID: 85vI9iX5p2V
--HG--
extra : rebase_source : 03182ab24bd057ad0be9d2e3f3e884c346d53d98