Commit Graph

42 Commits

Author SHA1 Message Date
Tarek Ziadé
b1507c0416 Bug 1581818 - Make sure client.py stays Python 2 compatible r=stephendonner
We need to keep util.py python 2 compatible. The Python 3 helper class
that's used to generate conditioned profiles is moved to its own
module and we're reactivating util.py in flake8

Differential Revision: https://phabricator.services.mozilla.com/D46259

--HG--
extra : moz-landing-system : lando
2019-09-18 15:16:57 +00:00
Tarek Ziadé
5dd9d5bcd0 Bug 1562870 - generate conditioned profiles r=gbrown,bc,aerickson
Generates "conditioned" profiles.

Differential Revision: https://phabricator.services.mozilla.com/D38211

--HG--
extra : moz-landing-system : lando
2019-09-16 19:44:35 +00:00
Mike Hommey
312ec28e99 Bug 1573566 - Move the real libxul definition in a subdirectory. r=froydnj
The current setup, where gtest/libxul uses the static library in
the same directory as the shared libxul, and somehow the backend ignores
gkrust for gtest/libxul, is fragile.

Differential Revision: https://phabricator.services.mozilla.com/D42246

--HG--
rename : toolkit/library/dependentlibs.py => toolkit/library/build/dependentlibs.py
extra : moz-landing-system : lando
2019-08-16 21:44:10 +00:00
Justin Wood
05822ea753 Bug 1542963 - Fix most flake8 issues in python/mozbuild/mozbuild/* r=firefox-build-system-reviewers,chmanchester
Leaving one fix for an explicit review.

Lint python/mozbuild/{mozbuild,mozpack}. r=#build

Differential Revision: https://phabricator.services.mozilla.com/D26641

--HG--
extra : moz-landing-system : lando
2019-05-28 14:22:20 +00:00
Justin Wood
207641b920 Bug 1542963 - flake8 python/mozbuild/mozbuild r=glandium
Lint python/mozbuild/{mozbuild,mozpack}.

Differential Revision: https://phabricator.services.mozilla.com/D26639

--HG--
extra : moz-landing-system : lando
2019-05-28 14:21:43 +00:00
Narcis Beleuzu
65e97bc31e Backed out 6 changesets (bug 1542963) for causing Bug 1552400. a=backout
Backed out changeset 70fbe1a158ae (bug 1542963)
Backed out changeset a1a84e0feabb (bug 1542963)
Backed out changeset 14aa1bd254a4 (bug 1542963)
Backed out changeset 11a714f491d5 (bug 1542963)
Backed out changeset 2715bac40d2f (bug 1542963)
Backed out changeset 8f69c7eeb6fd (bug 1542963)

--HG--
extra : histedit_source : 5903adc5313d6af4fdafb40ae55aaa79856f3726
2019-05-17 11:30:27 +03:00
Justin Wood
9a54c524f0 Bug 1542963 - Fix most flake8 issues in python/mozbuild/mozbuild/* r=#build
Leaving one fix for an explicit review.

Lint python/mozbuild/{mozbuild,mozpack}. r=#build

Differential Revision: https://phabricator.services.mozilla.com/D26641

--HG--
extra : rebase_source : e14d7762c7802d98e24ee8f86b0167d96666d288
extra : intermediate-source : 79b0d1678dd2f6aadf60f480d902ddeca4a52c3a
extra : source : faadf440e7d7b0a8c473e2dee3fc90b27023814a
2019-04-07 15:39:24 -04:00
Justin Wood
8eba83f0f6 Bug 1542963 - flake8 python/mozbuild/mozbuild r=#build
Lint python/mozbuild/{mozbuild,mozpack}.

Differential Revision: https://phabricator.services.mozilla.com/D26639

--HG--
extra : rebase_source : 35f22cf50d69bdf7c570ea02f4dc0d9fb55c5984
extra : intermediate-source : a22ff778b4c2d7b5dd5e928b3421de8e751e974c
extra : source : fe39d1096ffe5cd2b9a2d43af2627bd2b05c79f3
2019-04-07 10:50:02 -04:00
Dave Townsend
8a2398e023 Bug 1541086: Remove the embedding code and update the bug components for widget::headless. r=myk r=bdahl
Differential Revision: https://phabricator.services.mozilla.com/D25800

--HG--
extra : rebase_source : c3ec2eec85909de82e9e2d4ef8ee77b19d4295df
2019-04-02 09:07:54 -07:00
kerlyn
0f9d749554 Bug 1523835 - Added python/mozbuild/mozpack to the flake8 linter and solved the errors, r=ahal
Before this change linting python/mozbuild brought about many errors. Some of this errors could be fixed using |mach lint --fix|. The remaining errors where fixed in this bug.

Differential Revision: https://phabricator.services.mozilla.com/D20138

--HG--
extra : rebase_source : 8bd3d622d2221b981f08b8a080c1198b002cdc49
extra : amend_source : 3f6a70c1b7104a7c2d83e11fe911942771e331ea
2019-03-01 15:36:45 -05:00
Andrew Halberstadt
8a88148150 Bug 1367092 - [flake8] Use a blacklist instead of a whitelist, r=egao
This ensures that the default for new python files is to be linted by flake8.

Depends on D20496

Differential Revision: https://phabricator.services.mozilla.com/D20497

--HG--
extra : moz-landing-system : lando
2019-02-22 21:25:50 +00:00
Andrew Halberstadt
034fd32897 Bug 1367092 - [flake8] Use per-file-ignores to skip __init__.py files under testing/marionette and testing/firefox-ui, r=ato
This allows us to only skip the "unused import" config in these files rather
than the entire thing. This also removes the only two uses of "**" in the
exclusion rules which made things a bit simpler for me later on in the series.

Differential Revision: https://phabricator.services.mozilla.com/D20493

--HG--
extra : moz-landing-system : lando
2019-02-22 14:37:55 +00:00
Andrew Halberstadt
01ca807367 Bug 1515746 - [flake8] Unsupport subdir .flake8 files and use new 'per-file-ignores' config instead, r=egao
This removes all .flake8 files except for the one at the root of the repo.
Instead we use the new 'per-file-ignores' config introduced in 3.7. To ignore
specific errors in a subdirectory, add a line like this to the root .flake8:

[per-file-ignores]
    path/to/subdir/*: E100, F200, ...

The reasons for this change are:

1. Unblock flake8 blacklist (bug 1367092).
2. Simplify configuration and code.
3. Encourage more consistent styling.
4. Improve performance.
5. Greater editor consistency.

Differential Revision: https://phabricator.services.mozilla.com/D18354

--HG--
extra : moz-landing-system : lando
2019-02-07 20:17:02 +00:00
Andrew Halberstadt
a10eff76fa Bug 1515746 - [flake8] Upgrade flake8 and dependencies, r=egao
This bumps flake8 to version 3.7.5.

This also ignores the new lint rules that were added in the new versions.
These rules are de-marked via comment so we know that they should be enabled at
some point (as opposed to the other rules that are (presumably) ignored
intentionally.

Differential Revision: https://phabricator.services.mozilla.com/D18353

--HG--
extra : moz-landing-system : lando
2019-02-07 20:16:45 +00:00
Mike Hommey
70f1ad55e1 Bug 1519307 - Add a new project to build useful parts of breakpad independently. r=froydnj
With `ac_add_options --enable-project=tools/crashreporter` in a
mozconfig, `./mach build` builds minidump_stackwalk, dump_syms
and fileid.

One caveat is that due to limitation in how the build system works
currently, it's cumbersome to keep dump_syms as a host program for
Gecko, and to make it a target program for this project. For now,
keep it as a host program. We're not going to use it on automation,
but it's still convenient to have for quick local builds (I've had
to resort to awful hacks downstream).

Differential Revision: https://phabricator.services.mozilla.com/D16299

--HG--
extra : moz-landing-system : lando
2019-01-11 16:01:15 +00:00
Jed Davis
a60b0462be Bug 1508889 - Remove ipc/chromium from the lists of third-party code. r=Ehsan
The ipc/chromium tree has been forked from its former upstream and
heavily modified, so it's safe to reformat and lint.

However, ipc/chromium/src/third_party (a copy of libevent) is following
its upstream, so that should remain exempt.

Differential Revision: https://phabricator.services.mozilla.com/D12498

--HG--
extra : moz-landing-system : lando
2018-11-21 03:11:37 +00:00
Robert Bartlensky
6cf2bd98ec Bug 1479503: Check infer in ./mach static-analysis autotest. r=nalexander
Now autotest does not require java to be installed, but
it will let the user know that infer is not being tested if java
is missing.

Differential Revision: https://phabricator.services.mozilla.com/D7326

--HG--
extra : moz-landing-system : lando
2018-10-24 21:54:34 +00:00
shindli
0c0c6fddd8 Backed out changeset aae4f349fa58 (bug 1479503) per developer's request on IRC a=backout
--HG--
rename : taskcluster/docker/static-analysis-build/Dockerfile => taskcluster/docker/infer-build/Dockerfile
2018-09-14 16:35:23 +03:00
Robert Bartlensky
af9de513f7 Bug 1479503: Check infer in ./mach static-analysis autotest. r=nalexander
Adds infer to ./mach static-analysis autotest.

Differential Revision: https://phabricator.services.mozilla.com/D5692

--HG--
rename : taskcluster/docker/infer-build/Dockerfile => taskcluster/docker/static-analysis-build/Dockerfile
extra : moz-landing-system : lando
2018-09-13 20:58:03 +00:00
Csoregi Natalia
7ed619163e Backed out changeset 081d8311be59 (bug 1479503) for build bustage - java not found. CLOSED TREE
--HG--
rename : taskcluster/docker/static-analysis-build/Dockerfile => taskcluster/docker/infer-build/Dockerfile
2018-09-12 13:16:06 +03:00
Robert Bartlensky
b4ebd25931 Bug 1479503: Check infer in ./mach static-analysis autotest. r=nalexander
Adds infer to ./mach static-analysis autotest.

Differential Revision: https://phabricator.services.mozilla.com/D4547

--HG--
rename : taskcluster/docker/infer-build/Dockerfile => taskcluster/docker/static-analysis-build/Dockerfile
extra : moz-landing-system : lando
2018-09-12 09:34:30 +00:00
Robert Bartlensky
1a56460275 Bug 1473951: Add infer to taskcluster and build. r=gps
MozReview-Commit-ID: BHi3E6J3nuH

--HG--
extra : rebase_source : a59180efe4fed56222d2847d60133739f38c8ca8
2018-07-06 17:37:16 +01:00
Andreea Pavel
94afea82fc Backed out changeset 4738f8111a82 (bug 1478338) for linting failure at builds/worker/checkouts/gecko/build/moz.configure/android-ndk.configure:8 on a CLOSED TREE 2018-07-25 16:56:19 +03:00
Sylvestre Ledru
d79feb180b bug 1478338 - Fix some flake8 regression in moz.configure/ r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D2356

--HG--
extra : moz-landing-system : lando
2018-07-25 13:43:58 +00:00
Sylvestre Ledru
78e9c0dd0f Bug 1468273 - Add closure-lib and intl/icu into the flake8 ignore list r=ahal
MozReview-Commit-ID: A68UyXSHO9l

--HG--
extra : rebase_source : 92c965aba41d31d47e437ef3e72070fe5d060338
2018-06-12 23:11:40 -07:00
Sylvestre Ledru
b7066a4a1c Bug 1468273 - Ignore ipc/chromium r=ahal
MozReview-Commit-ID: HhXbRSMrTLP

--HG--
extra : rebase_source : 817f9a42af334bdeb73a091468d81fe0d06501a0
2018-06-11 17:31:33 -07:00
Sylvestre Ledru
13b20f9b86 Bug 1468273 - autopep8 on gfx/ r=ted
MozReview-Commit-ID: 8j8EU3E08GP

--HG--
extra : rebase_source : 1f38ac0b7283505622cc95a120a0a0d4cea96803
2018-06-10 14:13:44 +02:00
Andrew Halberstadt
c1bcd49b93 Bug 1473308 - [flake8] Pass custom extension list into the flake8 binary r=marco
We're supposed to be linting both .py and .configure files with flake8. However
we never inform flake8 of this fact.

So e.g running:
./mach lint -l flake8 mobile/android

Will not lint mobile/android/gradle.configure. However since flake8 will run on
a file regardless of its extension if you pass that file in directly, it means
that running:
./mach lint -l flake8 mobile/android/gradle.configure

*Will* cause the file to be linted (and subsequently fail). This fix makes sure
that flake8 knows to look at .configure files in addition to .py. Since this
means many .configure files around the tree will start getting linted for the
first time, we need to exclude them until they can be fixed.

Differential Revision: https://phabricator.services.mozilla.com/D1975

--HG--
extra : moz-landing-system : lando
2018-07-06 12:39:39 +00:00
Ed Lee
144374ea8b Bug 1440421 part 1. Ignore activity-stream and node_modules for linting. r=ahal
MozReview-Commit-ID: EEua2y790cW

--HG--
extra : rebase_source : ce98dcbd82eb1f59594d6fe40e34648b7bd639de
2018-06-06 10:32:43 -07:00
Sylvestre Ledru
0f77e7b850 Bug 1464869 - Also ignore security/nss/ r=ahal
MozReview-Commit-ID: 8m4CbrAaLHl

--HG--
extra : rebase_source : 5643bb18d950e0d1010bea7f4a51f57195830aa9
2018-05-28 20:58:54 +02:00
Sylvestre Ledru
8f2319cae3 bug 1463425 - Add more directories to the flake8 list r=ahal
MozReview-Commit-ID: JMZQonceq8W

--HG--
extra : rebase_source : 1d8d0218f128dede197fa99e5cba1f0101a80384
2018-05-22 06:26:22 -07:00
Sylvestre Ledru
57cd040527 bug 1463425 - Fix flake8 in browser/ r=ahal,gps
MozReview-Commit-ID: 11Kil84u0TP

--HG--
extra : rebase_source : f5ec701490b52bba8b45a790812025c8ab5cf963
2018-05-21 23:13:07 +02:00
Andrew Halberstadt
d2e75d0ea8 Bug 1436802 - [lint] Add some tests for the flake8 linter integration r=andi
This essentially tests tools/lint/python/flake8.py. Though it also adds
a basic framework for testing all the other linters as well. Getting this
added now will allow others to collaborate on adding more tests without
needing to get to 100% coverage for all linters right off the bat.

All python tests under tools/lint/test will run as part of the 'ml' task
on Linux, and the build task on Windows (OSX coverage is currently missing
for python tests).

The flake8 linter currently has a bug where the 'exclude' argument is
ignored. This is why we need to also exclude 'tools/lint/test/files' in
topsrcdir/.flake8, even though it is already listed in the
'mach_commands.py'. Other linters shouldn't need to do this, the exclusion
in 'mach_commands.py' should be good enough. See bug 1277851 for more
details.

MozReview-Commit-ID: 9ho8C83eeuj

--HG--
extra : rebase_source : 0adb01aa81c06f26cb891ae9f92a17f8f9fdf111
2018-03-22 17:24:15 -04:00
Andrew Halberstadt
f354075c7a Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood
This is a new issue that gets linted with flake8 3.5.0. Basically you should
never use a blank except: statement.

This will catch all exceptions, including KeyboardInterrupt and SystemExit
(which is likely not intended). If a catch all is needed, use
`except: Exception`.  If you *really* mean to also catch KeyboardInterrupt et
al, use `except: BaseException`.

Of course, being specific is often better than a catch all.

MozReview-Commit-ID: FKx80MLO4RN

--HG--
extra : rebase_source : 7c74a7d0d81f2c984b47aff3a0ee3448b791177b
2018-01-31 14:32:08 -05:00
Andrew Halberstadt
2255a9eed7 Bug 1395126 - Support cascading configuration for flake8, r=bc
This allows .flake8 files to override one another, and fixes a pretty bad known
bug with our flake8 implementation. For example, say we have a .flake8 file at:
/foo/.flake8

Before this patch, if we ran |mach lint foo/bar|, the configuration defined in
that .flake8 file wouldn't get picked up. It would only work if running the
specific directory that contains it, e.g |mach lint foo|.

This change additionally allows multiple .flake8 files to be used. So if
there's one defined at both:
/.flake8
/foo/.flake8

Then running |mach lint foo/bar| will first apply the root .flake8, then the
one under /foo (overriding earlier configuration).

This bug still doesn't make flake8 configuration perfect though. Any directory
containing a .flake8 file still needs to be explicitly listed in the "include"
section of /tools/lint/flake8.yml. Otherwise in the example above, if running
|mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem
and is likely best solved by fixing flake8's upstream configuration handling.

Unfortunately this means we still can't switch from a whitelist to a blacklist.

MozReview-Commit-ID: 3DZAi1QHYYo

--HG--
extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
2017-08-29 17:32:31 -04:00
Andrew Halberstadt
958af4447e Bug 1288432 - Use new mozlint configuration for flake8 linter, r=bc
MozReview-Commit-ID: 9vC6lI2j5nS

--HG--
rename : tools/lint/flake8.lint.py => tools/lint/flake8_/__init__.py
rename : tools/lint/flake8/flake8_requirements.txt => tools/lint/flake8_/flake8_requirements.txt
extra : rebase_source : 1cc39782391fa15100bf0765c28f21eb11b115e4
2017-06-02 09:46:01 -04:00
James Graham
221562f1a8 Bug 1321956 - Disable flake8 check for 'visually indented line with same indent as next logical line', r=ahal
MozReview-Commit-ID: ChaHkeSDNY8
2016-12-08 09:53:21 -10:00
Prabhjyot Singh Sodhi
ebb9f983f1 Bug 1280571 - Add testing/mochitest to the flake8 linter, r=ahal
MozReview-Commit-ID: INBZaZzcPmF

--HG--
extra : rebase_source : c0ba416f110b2768fc744de0fbee21c765081400
2016-09-28 08:28:04 -04:00
Wes Kocher
765926408d Backed out changeset e1d144423657 (bug 1280571) for making leaks hard to diagnose a=backout CLOSED TREE 2016-09-21 16:56:50 -07:00
Prabhjyot Singh Sodhi
58b6130e52 Bug 1280571 - Add testing/mochitest to the flake8 linter, r=ahal
This also adds E402 (no imports at top of file) to the global ignore list. The
other error codes added were previously ignored by default, but now that we
have started a custom ignore list, need to be listed explicitly.

MozReview-Commit-ID: RtMuVEX6i5

--HG--
extra : rebase_source : 939bc9354f5891c680513d7e9068d0438e169132
2016-09-21 08:49:46 -04:00
Andrew Halberstadt
0094830f2b Bug 1283129 - Flake8 linter is accidentally linting some eslint related .lint files, r=maja_zf
If you run |mach eslint| it will install a bunch of eslint related node_modules. Some of these
modules have '.lint' files in them which erroneously get picked up by the flake8 linter. This
patch makes sure that bare '.lint' files do not get included, they must have some kind of file
name first.

MozReview-Commit-ID: IvBfErnV6jm

--HG--
extra : rebase_source : f8d7aea88a68d830b06c4591ac6862b02554d21c
2016-06-29 10:37:27 -04:00
Andrew Halberstadt
b1445349ea Bug 1270506 - [mozlint] Add python flake8 linter, r=smacleod
For now, only the following two directories will be linted:
python/mozlint
tools/lint

New directories can be added by adding them to the 'include'
directive in tools/lint/flake8.lint. They all default to the
configuration specified in topsrcdir/.flake8. Subdirectories
can override this configuration by creating their own .flake8
file.

MozReview-Commit-ID: Eag48Lnkp3l

--HG--
extra : rebase_source : 6d98c9fef80055a48cc2622848aa04c3045b747e
2016-05-05 17:21:12 -04:00