Commit Graph

88576 Commits

Author SHA1 Message Date
Gabriele Svelto
9283d5f034 Bug 1598258 - Add a list of additional minidumps to the event delivered when a plug-in crashes r=froydnj
This patch adds a new field to the `plugin-crashed` event that holds the list
of additional minidumps associated with a crash report. The test
infrastructure is modified to use it which also fixes a race when processing
the .extra file. The reftest machinery has also been modified to take the new
field into account.

Differential Revision: https://phabricator.services.mozilla.com/D54107

--HG--
extra : moz-landing-system : lando
2019-11-22 07:30:23 +00:00
Sebastian Streich
309ac043a0 Bug 1597704 - Move is OriginPotentially Trustworthy into Principal r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D53830

--HG--
extra : moz-landing-system : lando
2019-11-21 16:29:13 +00:00
Alexandre Poirot
77af789c1f Bug 1597999 - Implements ChromeUtils.getObjectNodeId. r=jimb
This helps retrieving the NodeId for any JS Object you pass in.
This allows identifying a particular object when using HeapSnapshot API.
`HeapSnapshot.computeDominatorTree()` returns a tree of object,
but there is no way to identify a given JS object in it.
Getting the node id of a given JS object helps you browse this tree
from a given object you know is leaking.

Differential Revision: https://phabricator.services.mozilla.com/D53971

--HG--
extra : moz-landing-system : lando
2019-11-21 22:12:20 +00:00
Simon Giesecke
725b7b484b Bug 1596129 - Make use of std::accumulate in IDBObjectStore::AddOrPut. r=dom-workers-and-storage-reviewers,ytausky
Depends on D52865

Differential Revision: https://phabricator.services.mozilla.com/D52866

--HG--
extra : moz-landing-system : lando
2019-11-21 12:40:54 +00:00
Simon Giesecke
be00b51583 Bug 1596129 - Use range-based for, std::find_if, std::unique and avoid insert-sort on a nsTArray in IDBDatabase::Transaction. r=dom-workers-and-storage-reviewers,ytausky
Depends on D52864

Differential Revision: https://phabricator.services.mozilla.com/D52865

--HG--
extra : moz-landing-system : lando
2019-11-21 12:38:12 +00:00
Simon Giesecke
2ac5e4e5ab Bug 1596129 - Make use of std::find_if in IDBDatabase::DeleteObjectStore. r=dom-workers-and-storage-reviewers,ttung
Depends on D52863

Differential Revision: https://phabricator.services.mozilla.com/D52864

--HG--
extra : moz-landing-system : lando
2019-11-21 11:01:55 +00:00
Simon Giesecke
9b32f09fd2 Bug 1596129 - Make use of std::find_if in IDBDatabase::CreateObjectStore. r=dom-workers-and-storage-reviewers,ttung
Depends on D52862

Differential Revision: https://phabricator.services.mozilla.com/D52863

--HG--
extra : moz-landing-system : lando
2019-11-20 15:18:33 +00:00
Simon Giesecke
f81c6cb091 Bug 1596129 - Make use of std::transform, avoid doing an insert sort into an nsTArray in IDBDatabase::ObjectStoreNames. r=dom-workers-and-storage-reviewers,ttung
Depends on D52861

Differential Revision: https://phabricator.services.mozilla.com/D52862

--HG--
extra : moz-landing-system : lando
2019-11-21 08:55:38 +00:00
Simon Giesecke
766fe5ebfe Bug 1596129 - Make use of range-based for in BackgroundRequestChild::ActorDestroy. r=dom-workers-and-storage-reviewers,ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D52861

--HG--
extra : moz-landing-system : lando
2019-11-20 16:21:34 +00:00
Simon Giesecke
dd2dfbdb42 Bug 1596129 - Make use of std::transform instead of custom for loop in BackgroundRequestChild::HandleResponse. r=dom-workers-and-storage-reviewers,ttung
Depends on D52859

Differential Revision: https://phabricator.services.mozilla.com/D52860

--HG--
extra : moz-landing-system : lando
2019-11-20 15:12:34 +00:00
Simon Giesecke
06d137dba8 Bug 1596129 - Merge BackgroundRequestChild array members mPreprocessHelpers and mCloneDatas into one. r=dom-workers-and-storage-reviewers,ttung,asuth
Differential Revision: https://phabricator.services.mozilla.com/D52859

--HG--
extra : moz-landing-system : lando
2019-11-21 16:46:08 +00:00
Daniel Varga
f12c40c242 Backed out changeset afe80b4ff889 (bug 1595934) Requested by ehsan to see if it fixex bug 1597915. On a CLOSED TREE 2019-11-22 02:01:51 +02:00
Daniel Varga
af05b317ec Backed out 7 changesets (bug 1597216, bug 1596777, bug 1536156) for reftest failures at reftest/bipbop_300_215kbps.mp4.lastframe.htm. On a CLOSED TREE
Backed out changeset a3fa99d936f3 (bug 1536156)
Backed out changeset 29dd64930421 (bug 1536156)
Backed out changeset 77c16444e714 (bug 1536156)
Backed out changeset d540f1802ff6 (bug 1536156)
Backed out changeset 8283eed414d2 (bug 1536156)
Backed out changeset 01d2c84810f0 (bug 1597216)
Backed out changeset e0184916cf37 (bug 1596777)
2019-11-22 01:58:42 +02:00
Gabriele Svelto
3233e4e9ef Bug 1598005 - Remove the useless browserDumpID field from the plug-in crash events r=froydnj,baku
Differential Revision: https://phabricator.services.mozilla.com/D53977

--HG--
extra : moz-landing-system : lando
2019-11-21 12:29:58 +00:00
Andreas Pehrson
391dbe5d1b Bug 1536156 - Clear future frames when VideoSink is finished. r=padenot
Depends on D53832

Differential Revision: https://phabricator.services.mozilla.com/D54117

--HG--
extra : moz-landing-system : lando
2019-11-21 12:41:06 +00:00
Andreas Pehrson
531a7211a9 Bug 1536156 - Stop doing EndCloningVisually in Unlink. r=mconley
Unlink must not cause an AddRef on the unlinked object, or it is at risk of
leaking. See 1593739 for an example of where this happens.

EndCloningVisually is dangerous in that it tries to do more than just unlink the
video element. It does AddRef in NotifyUAWidgetSetupOrChange, so that must be
avoided.

Previous patches to this bug make sure that MediaDecoder shutdown takes care of
clearing the secondary video container in the MediaDecoder stack, so this is not
actually necessary anymore.

Differential Revision: https://phabricator.services.mozilla.com/D53832

--HG--
extra : moz-landing-system : lando
2019-11-21 12:40:11 +00:00
Andreas Pehrson
6dcf422797 Bug 1536156 - Simplify setting the current frame in the secondary video container. r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D53733

--HG--
extra : moz-landing-system : lando
2019-11-20 21:51:48 +00:00
Andreas Pehrson
1052205963 Bug 1536156 - Let cloneElementVisually() return a promise that resolves when frames have been rendered. r=alwu,mconley,bzbarsky
This patch does the following:
- Makes cloneElementVisually() return a promise
- Plumbs an event from the MediaDecoderStateMachine's VideoSink to
  HTMLVideoElement
- Hooks the event up to resolve the promise from cloneElementVisually()
- Updates tests and their expectations.

Differential Revision: https://phabricator.services.mozilla.com/D53831

--HG--
extra : moz-landing-system : lando
2019-11-20 21:51:48 +00:00
Andreas Pehrson
4537fe005f Bug 1536156 - Remove unused MediaSink::ClearSecondaryVideoContainer. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D53731

--HG--
extra : moz-landing-system : lando
2019-11-20 21:51:48 +00:00
Andreas Pehrson
8e1d28a54b Bug 1597216 - Handle changes to mMediaSink in MediaDecoderStateMachine. r=alwu
Differential Revision: https://phabricator.services.mozilla.com/D53712

--HG--
extra : moz-landing-system : lando
2019-11-19 16:35:12 +00:00
Andreas Pehrson
9d878d1ca7 Bug 1596777 - Hook up the SecondaryVideoContainer with state mirroring. r=alwu
This better follows how MediaDecoder and MediaDecoderStateMachine was
architected.

Differential Revision: https://phabricator.services.mozilla.com/D53710

--HG--
extra : moz-landing-system : lando
2019-11-20 16:32:52 +00:00
Christoph Kerschbaumer
ca7efe86e5 Bug 1595652: Exempt loads triggered by an extension from XFO. r=jkt,mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D53969

--HG--
extra : moz-landing-system : lando
2019-11-21 12:10:29 +00:00
Hiroyuki Ikezoe
7afdb8487c Bug 1586986 - Fire visual viewport resize events and flush position:fixed elements' layout in the same way what Chrome does. r=botond
On Chrome, visual viewport resize event is fired repeatedly during dynamic
toolbar transitions and visual viewport height obtained by the VisualViewport
API is also changed, but in terms of layout the height value is never used
until the dynamic toolbar height reaches to zero or is changed from zero.
The height used at the time is the height for vh units when the toolbar height
reaches to zero and the ICB height when the toolbar height is changed from zero.
To do so, we need to have another visual viewport size in parallel to the
original one and use them depending on situations.

Differential Revision: https://phabricator.services.mozilla.com/D52338

--HG--
extra : moz-landing-system : lando
2019-11-21 21:36:59 +00:00
Hiroyuki Ikezoe
9b165804d8 Bug 1586986 - Deliver 'fixed-bottom' offset to the top of the pres context on the foreground tab. r=geckoview-reviewers,tnikkel,snorp
The dynamic toolbar transition doesn't affect on background tabs since to
switch tabs the dynamic toolbar should be restored to its original state (i.e.,
completely visible state).

Differential Revision: https://phabricator.services.mozilla.com/D52336

--HG--
extra : moz-landing-system : lando
2019-11-21 21:15:46 +00:00
ssengupta
97bb846b1e Bug 1597959 - Return from IDBDatabase::RenameObjectStore immediately if aObjectStoreId and aName both match. r=sg
Differential Revision: https://phabricator.services.mozilla.com/D53947

--HG--
extra : moz-landing-system : lando
2019-11-21 11:54:40 +00:00
Emilio Cobos Álvarez
74823e8b90 Bug 1559076 - Implement shadow part forwarding (minus invalidation). r=heycam
Some of the stuff, in particular inside GeckoBindings stuff should be
refactored to be less ugly and duplicate a bit less code, but the rest of the
code should be landable as is.

Some invalidation changes are already needed because we weren't matching with
the right shadow host during invalidation (which made existing ::part() tests
fail).

Pending invalidation work:

 * Making exportparts work right on the snapshots.
 * Invalidating parts from descendant hosts.

They're not very hard but I need to think how to best implement it:

 * Maybe get rid of ShadowRoot::mParts and just walk DOM descendants in the
   Shadow DOM.

 * Maybe implement a ElementHasExportPartsAttr much like HasPartAttr and use
   that to keep the list of elements.

 * Maybe invalidate :host and ::part() together in here[1]

 * Maybe something else.

Opinions?

[1]: https://searchfox.org/mozilla-central/rev/131338e5017bc0283d86fb73844407b9a2155c98/servo/components/style/invalidation/element/invalidator.rs#561

Differential Revision: https://phabricator.services.mozilla.com/D53730

--HG--
extra : moz-landing-system : lando
2019-11-21 10:32:32 +00:00
Mirko Brodesser
a0a4ca6055 Bug 1597968: MOZ_ASSERT RangeBoundaryBase doesn't retrieve offset of anonymous child. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D53959

--HG--
extra : moz-landing-system : lando
2019-11-20 20:42:55 +00:00
Tom Tung
05af29c010 Bug 1592934 - Add a telemetry probe to track storage initialization success rate; r=janv
Differential Revision: https://phabricator.services.mozilla.com/D51845

--HG--
extra : moz-landing-system : lando
2019-11-20 10:34:34 +00:00
Tom Tung
6667804ee1 Bug 1592934 - Add a telemetry probe to track temporary storage initialization success rate; r=janv,janerik
Differential Revision: https://phabricator.services.mozilla.com/D51267

--HG--
extra : moz-landing-system : lando
2019-11-21 07:59:34 +00:00
John Dai
fd9869d4f3 Bug 1551758 - Form submission reentrancy protection for 'submit' and 'invalid' event; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D53696

--HG--
extra : moz-landing-system : lando
2019-11-20 19:39:38 +00:00
John Dai
3c293b08a8 Bug 1551758 - Update spec link and comments for CheckValidFormSubmission and CheckFormValidity; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D53166

--HG--
extra : moz-landing-system : lando
2019-11-20 16:14:37 +00:00
John Dai
a7f881e5fc Bug 1551758 - Centralize form submission; r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D53165

--HG--
extra : moz-landing-system : lando
2019-11-20 16:14:39 +00:00
Bogdan Tara
23ebd10305 Backed out 3 changesets (bug 1565956) for crashes complaining about MediaTrackGraphImpl CLOSED TREE
Backed out changeset 15e4c2726222 (bug 1565956)
Backed out changeset 4b18de79a6e3 (bug 1565956)
Backed out changeset 1e45f56e21fb (bug 1565956)
2019-11-21 09:19:51 +02:00
jeffin143
aa897e8496 Bug 1597881 : convert NS_STYLE_STROKE_LINECAP_* to an enum class in nsStyleConsts.h r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D53908

--HG--
extra : moz-landing-system : lando
2019-11-21 06:07:30 +00:00
Ehsan Akhgari
eaec09c277 Bug 1594540 - Fix the off-by-one error that breaks login on Pinterest.com; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D53770

--HG--
extra : moz-landing-system : lando
2019-11-20 18:22:11 +00:00
Karl Tomlinson
a17bf02b27 Bug 1565956 process events for MessagePort r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D53137

--HG--
extra : moz-landing-system : lando
2019-11-21 02:19:07 +00:00
Karl Tomlinson
2d353c6d2c Bug 1565956 use an nsThread for GraphRunner to support MessagePort r=pehrsons
MessagePort::Dispatch(), for example, uses NS_DispatchToCurrentThread(), which
assumes nsThread.

Differential Revision: https://phabricator.services.mozilla.com/D53128

--HG--
extra : moz-landing-system : lando
2019-11-20 23:52:49 +00:00
Karl Tomlinson
7bc05ba5a5 Bug 1565956 annotate GraphDriver::Shutdown MOZ_CAN_RUN_SCRIPT r=pehrsons
Differential Revision: https://phabricator.services.mozilla.com/D53127

--HG--
extra : moz-landing-system : lando
2019-11-18 14:52:35 +00:00
Kashav Madan
649ac773f7 Bug 1596462 - Make browser_aboutnewtab_process_selection.js Fission-compatible, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D53036

--HG--
extra : moz-landing-system : lando
2019-11-21 00:17:00 +00:00
Brad Werth
59271a70be Bug 1391994 Part 1: Add new methods to Element to set attributes via devtools. r=bzbarsky
This expands Element with chrome-only setAttribute methods that give devtools
callers an ExtendedPrincipal with a CSP with a flag set to allow changes to
inline styles. This gives devtools the ability to modify documents with a
Content-Security-Policy.

Differential Revision: https://phabricator.services.mozilla.com/D41313

--HG--
extra : moz-landing-system : lando
2019-11-21 01:45:51 +00:00
Narcis Beleuzu
46f83924c1 Backed out changeset c7b4e89f5ee6 (bug 1594577) for xpcshell failures on test_watchdog_hibernate.js . CLOSED TREE 2019-11-21 02:22:32 +02:00
David Parks
4dc38ba6aa Bug 1577336: Part 7 - Move DXGI async plugin operations to compositor process r=jmathies,mattwoodrow,sotaro,mccr8
Previously, we created TextureD3D11 objects in the content process to back surfaces created for the plugin process.  Those objects were then composited by the async ImageBridge.  In order to remove Win32 kernel operations from content (including DX/GDI operations), this patch bounces the requests from content to the compositor process.  The compositor process maintains 2 textures to be used for all plugin composition -- one for the plugin process and one for display.  The plugin process can freely write to its texture and request composition when it is done, which triggers a blit to the display texture.  This mirrors pre-existing behavior.

Differential Revision: https://phabricator.services.mozilla.com/D46086

--HG--
extra : moz-landing-system : lando
2019-11-20 21:49:35 +00:00
David Parks
18e50987a5 Bug 1577336: Part 6 - Make SurfaceDescriptorGPUVideo a union that contains SurfaceDescriptorRemoteDecoder r=mattwoodrow,jolin
SurfaceDescriptorGPUVideo, which currently only represents RemoteDecoder video, switches from being a struct to a union that holds a SurfaceDescriptorRemoteDecoder struct.  SurfaceDescriptorRemoteDecoder is a new name for the old SurfceDescriptorGPUVideo.  This is done so that we can later add SurfaceDescriptorPlugin as another type of SurfaceDescriptorGPUVideo.

Differential Revision: https://phabricator.services.mozilla.com/D52400

--HG--
extra : moz-landing-system : lando
2019-11-20 21:55:06 +00:00
David Parks
35515bd4e7 Bug 1577336: Part 5 - Create IGPUVideoSurfaceManager for shared parts of RemoteDecoderManagerChild r=mattwoodrow
IGPUVideoSurfaceManager is an interface that the ImageBridgeChild uses to perform GPUVideoImage operations.  RemoteDecoderManagerChild is one.  We define another for plugins later in this patch series.

Differential Revision: https://phabricator.services.mozilla.com/D52397

--HG--
extra : moz-landing-system : lando
2019-11-20 21:33:59 +00:00
David Parks
78fbd97e70 Bug 1577336: Part 4 - Refactor some things in RemoteDecoderManager r=mattwoodrow,jolin
In anticipation of the rest of this patch series, we make 2 changes to the RemoteDecoderManager:
1. Rename RemoteDecoderManagerChild::DeallocateSurfaceDescriptorGPUVideo to DeallocateSurfaceDescriptor
2. Move call to RemoteDecoderManager::GetSource() from GPUVideoTextureClient to RemoteVideoDecoder.

Differential Revision: https://phabricator.services.mozilla.com/D52396

--HG--
extra : moz-landing-system : lando
2019-11-20 21:53:28 +00:00
David Parks
446170c593 Bug 1577336: Part 3 - Fetch Windows plugin async graphics capabilities from gpu or main process r=jmathies,mattwoodrow,froydnj
These operations report whether certain async plugin drawing modes are supported on the host architecture.  They use kernel graphics operations to decide this so they need to be removed from the content process for sandboxing.  We just bounce the requests to the gpu process (or main process on systems without a GPU process).

Differential Revision: https://phabricator.services.mozilla.com/D46085

--HG--
extra : moz-landing-system : lando
2019-11-20 21:33:55 +00:00
David Parks
beb56ea7bc Bug 1577336: Part 2 - Add pref to disble Windows DXGI async plugin surfaces r=jmathies
Use this pref to disable NPDrawingModelAsyncWindowsDXGISurface mode, which will force compatible plugins (Flash) to use NPDrawingModelAsyncBitmapSurface.

Differential Revision: https://phabricator.services.mozilla.com/D46084

--HG--
extra : moz-landing-system : lando
2019-11-20 21:32:24 +00:00
David Parks
6cb9c34c4c Bug 1577336: Part 1 - Remove win32k use from NPDrawingModelAsyncBitmapSurface r=jmathies
This fallback drawing mode primarily uses in-memory textures in the content process (via Readback) but uses gfxPlatform to establish the GPU texture type.  On Windows, this is always Win32 so we can avoid the gfxPlatform call (which uses Win32k heavily).  I believe that this removes all Win32 operations involved in this drawing mode in a content process.

Differential Revision: https://phabricator.services.mozilla.com/D46083

--HG--
extra : moz-landing-system : lando
2019-11-20 21:32:07 +00:00
Perry Jiang
7215838dc1 Bug 1575092 - don't spawn Shared/Service Workers in "web COOP+COEP" processes r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D50815

--HG--
extra : moz-landing-system : lando
2019-11-20 20:02:23 +00:00
Perry Jiang
25638418f9 Bug 1575092 - add "web COOP+COEP" process type helpers r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D50814

--HG--
extra : moz-landing-system : lando
2019-11-20 19:45:14 +00:00