Commit Graph

254 Commits

Author SHA1 Message Date
Joel Maher
edd5fd6be2 Bug 1544460 - fix reftest annotations and enable for osx 10.14. r=jfkthame,kats
fix reftest annotations and enable for osx 10.14.

Differential Revision: https://phabricator.services.mozilla.com/D32463

--HG--
extra : moz-landing-system : lando
2019-05-24 18:01:02 +00:00
Matt Woodrow
42c9b79f0b Bug 1544995 - Always update overflow areas up to the preserve-3d root. r=dbaron
We don't store post-transform overflow areas for frames within preserve-3d, but we do store pre-transform overflow areas.
Rather than just recomputing the changed overflow for the root, we should recompute overflows for all ancestors up to the 3d root.

Differential Revision: https://phabricator.services.mozilla.com/D31213

--HG--
extra : moz-landing-system : lando
2019-05-19 22:39:58 +00:00
Lee Salzman
a00853db4b Bug 1539026 - Skia m74 fuzzing. r=rhunt 2019-03-26 14:52:45 -04:00
Glenn Watson
9b399ba2a8 Bug 1539048 - Support segment rendering for pictures in WR. r=kvark
On some low end GPUs, clip mask rendering can be a significant
GPU cost. One way to reduce this is to support segment rendering
on more primitive types, to reduce the size of clip masks.

This patch adds support for pictures that have clip masks
to take part in segment rendering. This can significantly
reduce the number of fragments that must be drawn into a clip
mask for off-screen picture surfaces.

In future, WR can take advantage of segment rendering to use
clip mask shaders that handle only a single corner at a time.
This will be a further significant performance win to clip mask
render time.

Differential Revision: https://phabricator.services.mozilla.com/D24852

--HG--
extra : moz-landing-system : lando
2019-03-26 21:25:31 +00:00
Glenn Watson
9d856b1091 Bug 1535976 - Add a fast path for common rounded rect clips to WR. r=kvark
Most rounded rect clips in real content are (a) axis aligned and
(b) have uniform radii.

When these conditions are met, we can run a fast path for clip
mask generation that uses significantly fewer ALU shader ops.

This is not typically a bottleneck on desktop GPUs, but can have
a large performance impact on mobile GPUs (and perhaps low end
integrated GPUs).

The Mali shader analyzer reports the slow path for the rounded
rect clip shader to be 94 cycles per fragment, while the fast
path is 10 cycles.

Differential Revision: https://phabricator.services.mozilla.com/D23817

--HG--
extra : moz-landing-system : lando
2019-03-19 19:48:13 +00:00
Bogdan Tara
84581c394f Backed out changeset 70440f88051f (bug 1535976) for /reftests/transform-3d/mask-layer* failures CLOSED TREE 2019-03-19 06:02:09 +02:00
Glenn Watson
7e08c517ab Bug 1535976 - Add a fast path for common rounded rect clips to WR. r=kvark
Most rounded rect clips in real content are (a) axis aligned and
(b) have uniform radii.

When these conditions are met, we can run a fast path for clip
mask generation that uses significantly fewer ALU shader ops.

This is not typically a bottleneck on desktop GPUs, but can have
a large performance impact on mobile GPUs (and perhaps low end
integrated GPUs).

The Mali shader analyzer reports the slow path for the rounded
rect clip shader to be 94 cycles per fragment, while the fast
path is 10 cycles.

Differential Revision: https://phabricator.services.mozilla.com/D23817

--HG--
extra : moz-landing-system : lando
2019-03-18 16:15:45 +00:00
Glenn Watson
43dfba16ac Bug 1524385 - Set the current clip chain on the stacking context item. r=kvark
Differential Revision: https://phabricator.services.mozilla.com/D18527

--HG--
extra : moz-landing-system : lando
2019-02-06 04:35:37 +00:00
Glenn Watson
803eadae41 Bug 1523882 - Rework snapping logic in clip mask generate to fix uneven box shadows. r=kvark,nical
Differential Revision: https://phabricator.services.mozilla.com/D18060

--HG--
extra : moz-landing-system : lando
2019-02-01 23:24:53 +00:00
Kartikaya Gupta
0deb9fd9cb No bug - Adjust fuzziness for reftest on mac which showed up after merging autoland and inbound. r=me on a CLOSED TREE 2019-02-01 10:07:53 -05:00
Noemi Erli
b74da84051 Backed out changeset e6f1ffb7119f (bug 1523882) per dev's request for causing major perf regression a=backout 2019-02-01 08:56:22 +02:00
Glenn Watson
e23265ad97 Bug 1523882 - Rework snapping logic in clip mask generate to fix uneven box shadows. r=kvark,nical
Differential Revision: https://phabricator.services.mozilla.com/D18060

--HG--
extra : moz-landing-system : lando
2019-01-31 20:18:18 +00:00
shindli
4db94822bd Backed out changeset 86daa5d406b6 (bug 1523882) for wrench bustage in reftests/boxshadow/box-shadow-huge-radius.png CLOSED TREE 2019-01-31 22:02:27 +02:00
Glenn Watson
165f400dbd Bug 1523882 - Rework snapping logic in clip mask generate to fix uneven box shadows. r=kvark,nical
Differential Revision: https://phabricator.services.mozilla.com/D18060

--HG--
extra : moz-landing-system : lando
2019-01-31 19:39:02 +00:00
Narcis Beleuzu
8707bfb5f2 Backed out changeset 25ca68e7836e (bug 1523882) for wrench bustages on boxshadow-spread-only-ref.png. CLOSED TREE 2019-01-31 11:49:12 +02:00
Glenn Watson
8844b8b1c8 Bug 1523882 - Rework snapping logic in clip mask generate to fix uneven box shadows. r=kvark,nical
Differential Revision: https://phabricator.services.mozilla.com/D18060

--HG--
extra : moz-landing-system : lando
2019-01-31 09:02:41 +00:00
Glenn Watson
aaa0feb2a4 Bug 1522758 - Optimize drawing axis aligned clip rectangles into clip masks. r=kvark
Differential Revision: https://phabricator.services.mozilla.com/D17606

--HG--
extra : moz-landing-system : lando
2019-01-26 21:11:53 +00:00
Emilio Cobos Álvarez
55f71edc6f Bug 1512537 - Update test expectations. r=kats
Differential Revision: https://phabricator.services.mozilla.com/D14245

--HG--
extra : moz-landing-system : lando
2018-12-13 00:53:07 +00:00
Hiroyuki Ikezoe
816436998c Bug 1506860 - Revert the workaround that we did in bug 1504929. r=birtles
That's because the underlying issue which had caused intermittent failure
has been fixed in 1506988.

Here is the link to the workaround commit;
https://hg.mozilla.org/mozilla-central/rev/c84f0ad36ce9

Differential Revision: https://phabricator.services.mozilla.com/D12861

--HG--
extra : moz-landing-system : lando
2018-11-26 01:35:10 +00:00
Hiroyuki Ikezoe
dec4d0e964 Bug 1506988 - Don't incorporate properties that are prevented from running on the compositor in GetPropertiesForCompositor. r=birtles
Now we no longer update the corresponding display items for the animations that
are prevented from running on the compositor if the animations themselves don't
generate any change hints, e.g the same value is specified in both 'from' and
'to' keyframes.  So that we can enable the reftests that we had been suffering
from continuous MozAfterPaint events.

Depends on D12397

Differential Revision: https://phabricator.services.mozilla.com/D12369

--HG--
extra : moz-landing-system : lando
2018-11-22 03:57:59 +00:00
Hiroyuki Ikezoe
23793e3a21 Bug 1504929 - Start animations once after a MozReftestInvalidate event is received. r=sotaro
We need the same workaround for
https://bugzilla.mozilla.org/show_bug.cgi?id=1489327 .

And unfortunately we have to disable animate-backface-hidden.html on MacOSX opt
builds for WebRender because the test fails intermittently, we will enable it
in bug 1506758.

Depends on D11601

Differential Revision: https://phabricator.services.mozilla.com/D11726

--HG--
extra : moz-landing-system : lando
2018-11-13 10:18:30 +00:00
Lee Salzman
81c20a9e90 Bug 1506129 - Fuzz for fixed WebRender DWrote text render mode. r=kats
Depends on D11509

Differential Revision: https://phabricator.services.mozilla.com/D11510

--HG--
extra : moz-landing-system : lando
2018-11-09 18:55:58 +00:00
Bobby Holley
8ae065a347 Bug 1501073 - Test expectation adjustments. r=kats
Depends on D9610

Differential Revision: https://phabricator.services.mozilla.com/D9611

--HG--
extra : moz-landing-system : lando
2018-10-24 00:49:16 +00:00
Jeff Muizelaar
171146f369 Bug 1492566. Increase the fuzz some more so that things pass. 2018-09-20 13:22:58 -04:00
Jeff Muizelaar
3ed96a1b8e Bug 1492566. Adjust test expectations for https://github.com/servo/webrender/pull/3073
--HG--
extra : rebase_source : 7d090510f12caceaff8c2329e47871dbb5f4de55
2018-09-19 15:52:06 -04:00
Coroiu Cristina
0b8ed772d2 Backed out 2 changesets (bug 1492389) for causing perma reftest failures at tests/reftest/tests/layout/reftests/transform-3d/1035611-1-ref.html a=backout
Backed out changeset 16995931c819 (bug 1492389)
Backed out changeset 592121f27afe (bug 1492389)
2018-09-20 09:47:22 +03:00
Bogdan Tara
86023d88c4 Merge inbound to mozilla-central. a=merge 2018-09-20 07:13:05 +03:00
Matt Woodrow
bb38061683 Bug 1489337 - Don't set preserve-3d to true when creating WebRender commands for nsDisplayPerspective since it's not needed. r=jrmuizel
MozReview-Commit-ID: GiRda3WyTEu

Differential Revision: https://phabricator.services.mozilla.com/D5214

--HG--
extra : moz-landing-system : lando
2018-09-19 19:55:17 +00:00
Cosmin Sabou
64adcb7cf0 Backed out changeset 368cda88b85f (bug 1489337) for reftest failures on transform-3d/1035611-1.html 2018-09-14 07:20:07 +03:00
Matt Woodrow
a2426fa778 Bug 1489337 - Don't set preserve-3d to true when creating WebRender commands for nsDisplayPerspective since it's not needed. r=jrmuizel
MozReview-Commit-ID: GiRda3WyTEu

Differential Revision: https://phabricator.services.mozilla.com/D5214

--HG--
extra : moz-landing-system : lando
2018-09-14 02:20:46 +00:00
Jeff Muizelaar
0aa2870b83 Bug 1490242. Adjust reftests for 3d transfrom changes 2018-09-11 08:47:55 -04:00
Jeff Muizelaar
5609566633 Bug 1492389. Adjust test expectations for https://github.com/servo/webrender/pull/3073 2018-09-19 15:52:06 -04:00
Jeff Muizelaar
745d744d60 Bug 1487885. Mark new passing test as such. 2018-09-05 13:18:12 -04:00
Miko Mynttinen
58f9cc4fc8 Bug 1483659 - Ensure that child overflow areas are included in perspective frame overflow areas r=dbaron
Differential Revision: https://phabricator.services.mozilla.com/D3515

--HG--
extra : moz-landing-system : lando
2018-09-04 16:25:54 +00:00
Jeff Muizelaar
bddd392700 Bug 1487588. Increase fuzz on 3d transform test a bit to avoid orange. 2018-08-30 23:48:32 -04:00
Jeff Muizelaar
4976ed72ee Bug 1487429. Update tests for WebRender changes.
--HG--
extra : rebase_source : 1e64ec6054c073621876f6acffc6f40ed4cbca67
2018-08-30 21:31:07 -04:00
L. David Baron
1e88f0f003 Bug 1369941: Replace single integers N in fuzzy() and fuzzy-if() with 0-N ranges. r=dholbert
This patch was written entirely by the following script:

  #!/bin/bash

  if [ ! -d "./.hg" ]
  then
    echo "Not in a source tree." 1>&2
    exit 1
  fi

  find . -regex '.*\(ref\|crash\)test.*\.list' | while read FILENAME
  do
    echo "Processing ${FILENAME}."
    # The following has four substitutions:
    # * The first one replaces the *first* argument to fuzzy() when it doesn't
    #   have a - in it, by replacing it with an explicit 0-N range.
    # * The second one does the same for the *second* argument to fuzzy().
    # * The third does the same for the *second* argument to fuzzy-if().
    # * The fourth does the same for the *third* argument to fuzzy-if().
    #
    # Note that this is using perl rather than sed because perl doesn't
    # support non-greedy matching, which is needed for the first argument to
    # fuzzy-if.
    perl -pi -e 's/(fuzzy\()([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy\([^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,)([^ ,()-]*)(,[^ ,()]*\))/${1}0-${2}${3}/g;s/(fuzzy-if\([^ ]*?,[^ ,()]*,)([^ ,()-]*)(\))/${1}0-${2}${3}/g' "${FILENAME}"
  done

Differential Revision: https://phabricator.services.mozilla.com/D2974

--HG--
extra : moz-landing-system : lando
2018-08-09 20:10:21 +00:00
Kartikaya Gupta
9d5983979c Bug 1480433 - Update for changes in WR PR 2947. r=jrmuizel
MozReview-Commit-ID: 2GqCI7QXnr7
2018-08-07 14:47:02 -04:00
Boris Chiou
ffa1da7545 Bug 1467277 - Avoid getting zero normalized vector of rotate3d when setting a rotate matrix. r=nical
For example, if we set a transform to rotate3d(0, 0, 1e50, 45deg), the
expected normalized rotate axis is (0, 0, 1).
However, the length is larger than the maximum of float, so the actual value is
(0/inf, 0/inf, 1e50/inf) == (0, 0, 0). Therefore, we scale the vector before
doing normalization to avoid getting a zero vector.

MozReview-Commit-ID: 5LUDWD4RuNj

--HG--
extra : rebase_source : eb82f0b3979bf6ea3cd11b643ebb30a49edc24f8
2018-07-05 15:40:39 -07:00
Kartikaya Gupta
1fb51dfb2b Bug 1461311 - Undo reftest/harness changes from bug 1437036 as they are not needed any more. r=hiro
MozReview-Commit-ID: 3YvyZPNOCzF

--HG--
extra : rebase_source : f49e09dda2924b99dbf6b63a958086b934e23523
2018-06-07 08:23:17 -04:00
Joel Maher
29d83f200e Bug 1392106 - random-if many more tests on win7. r=RyanVM 2018-05-25 13:03:59 -04:00
Kartikaya Gupta
849bc9d409 Bug 1437036 - Stop the reftest harness from waiting for MozAfterPaint during infinite/superlong animations. r=hiro
These tests rely on an optimization within Gecko where it stops firing
MozAfterPaint events if there was no visible change to the generated
layers. This allows the reftest harness to exit the
waiting-for-MozAfterPaint loop and proceed with the test. However, with
webrender, this optimization does not exist and so the loop never exits.
In order to solve this problem, this patch adds an explicit mechanism to
exit the loop by means of a class attribute on the root element of the
test page.

MozReview-Commit-ID: 17ta5kLPDr9

--HG--
extra : rebase_source : 96ea462274724c6c65f1186f473bc1767253fd6b
2018-05-14 08:53:52 -04:00
Kartikaya Gupta
32a1261d0d Bug 1322845 - Update reftest annotations for WebRender on macOS. r=Gankro
MozReview-Commit-ID: 6NufRyb41ia
2018-05-08 22:42:51 -04:00
Andreea Pavel
8daddd690f Backed out 2 changesets (bug 1322845) for failing reftest background-repeat-large-area.html == background-repeat-large-area-ref.html on a CLOSED TREE
Backed out changeset 4fd46cd822bf (bug 1322845)
Backed out changeset abd41b3e63e7 (bug 1322845)
2018-05-09 05:13:08 +03:00
Kartikaya Gupta
93650c1b04 Bug 1322845 - Update reftest annotations for WebRender on macOS. r=Gankro
MozReview-Commit-ID: 6NufRyb41ia
2018-05-08 20:39:51 -04:00
Kartikaya Gupta
77476d5a6b Bug 1453688 - Update reftest annotations for WR PR 2662. r=jrmuizel
MozReview-Commit-ID: B1ts2B1dTA4

--HG--
extra : rebase_source : 8e71036ce898f3ccdf384c225c8a06fb803fad6e
2018-04-17 08:23:39 -04:00
Kartikaya Gupta
0f89486f32 Bug 1452658 - Mark many reftests as fuzzy instead of failing for windows-qr. r=jrmuizel
MozReview-Commit-ID: BDvtV6trKkK

--HG--
extra : rebase_source : 0591564f6cea5c782de6baecc24c3defcef0c4fb
2018-04-10 17:48:16 -04:00
Kartikaya Gupta
9a9c13a09f Bug 1344350 - Mark reftests failing with webrender on windows. r=jrmuizel
Many of these could probably be fuzzed but in the interests of getting
the reftest suite turned on sooner I'm doing a blanket fails-if. This
covers all the reftests where there is more fuzz with webrender on
windows than any of existing annotations account for. In some cases the
fuzz is only a few pixels more than the equivalent Linux fuzz already
annotated, but I'll clean that up in a future bug.

MozReview-Commit-ID: IaKarbnL46d

--HG--
extra : rebase_source : 71889340305b0b12fa8eace722e42bb3faf14419
2018-04-06 11:58:43 -04:00
Jeff Muizelaar
2fd17450bb Bug 1449640. Don't compute a scale for 3d transformed content. r=kats
This matches the behaviour of ChooseScaleAndSetTransform()

MozReview-Commit-ID: LxtkQn2XdYT

--HG--
extra : rebase_source : 9d2a9b1af9bf039def408f86982da835b7120e36
2018-03-27 17:46:34 -04:00
Kartikaya Gupta
a884a297d8 Bug 1434723 - Mark reftest failures exposed by WR PR 2369. r=jrmuizel
MozReview-Commit-ID: 8iNiThVViNY

--HG--
extra : rebase_source : 20b11de78b53563bf7493a358c13f41799d745a2
2018-02-06 10:32:40 -05:00