Commit Graph

21614 Commits

Author SHA1 Message Date
Mihai Alexandru Michis
d5b753448d Backed out changeset 4ffa919d35f9 (bug 1687364) as requested by kershaw.
CLOSED TREE
2021-02-10 16:47:51 +02:00
Jan de Mooij
14360fdec6 Bug 1674777 part 8 - Change nsIArrayBufferInputStream.setData arguments from uint32_t to uint64_t. r=kmag
Similar to the previous patch. Prevent truncation when assigning to mBufferLength.

Differential Revision: https://phabricator.services.mozilla.com/D103760
2021-02-10 08:30:05 +00:00
M. Sirringhaus
9ea20acd3b Bug 1666725 - Make gvfs e10s compatible r=valentin,necko-reviewers
Split channel into parent/child to be able to use dbus in the content sandbox

Differential Revision: https://phabricator.services.mozilla.com/D92206
2021-02-10 07:29:38 +00:00
Simon Giesecke
5ab2e2fc52 Bug 1688833 - Migrate LookupForAdd to WithEntryHandle in netwerk. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D104197
2021-02-09 18:19:37 +00:00
Nika Layzell
661b4db5f0 Bug 1689147 - Part 4: Switch nested and prio to extended attributes, r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D103369
2021-02-09 16:50:22 +00:00
Nika Layzell
63fd915bfb Bug 1689147 - Part 1: Add extended attribute syntax to IPDL, r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D103366
2021-02-09 16:50:21 +00:00
Kershaw Chang
fac6f12751 Bug 1691484 - Avoid crashing when we don't have other service mode records to retry r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D104451
2021-02-09 15:33:44 +00:00
Valentin Gosu
33aa2bcb05 Bug 1691721 - Add DNSPacket::GetRCode and remove TRRSkippedReason argument r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D99760
2021-02-09 14:22:56 +00:00
Valentin Gosu
ac524e72f8 Bug 1691721 - Remove early partial DNS records prefs r=necko-reviewers,kershaw
These prefs were mostly a perf improvement - return the first address family
first then merge the result with the other family.
However, this turned out to cause intermittent issues on some sites, so it
was turned off by default.
Removing these prefs allows us to have the same functionality across all
our resolvers - one request means one callback after both A and AAAA responses
have been received.

Differential Revision: https://phabricator.services.mozilla.com/D99757
2021-02-09 14:22:56 +00:00
Valentin Gosu
e52569a7f9 Bug 1691721 - Hold a strong ref to the nsResolveHostCallback r=necko-reviewers,kershaw
Calling c->remove() will remove the entry from rec->mCallbacks and could
potentially release the object (if this is the last reference).
While unlikely, it's best to avoid this corner case.

Differential Revision: https://phabricator.services.mozilla.com/D99756
2021-02-09 14:22:55 +00:00
Andreea Pavel
74d8a6339f Backed out changeset 29cd566d3c08 (bug 1666725) for build bustages at PNecko.ipdl on a CLOSED TREE 2021-02-09 15:11:47 +02:00
M. Sirringhaus
86e1612919 Bug 1666725 - Make gvfs e10s compatible r=valentin,necko-reviewers
Split channel into parent/child to be able to use dbus in the content sandbox

Differential Revision: https://phabricator.services.mozilla.com/D92206
2021-02-09 12:52:22 +00:00
Kershaw Chang
baf2bcca71 Bug 1686421 - Add probes to understand the usage of https rr r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D103784
2021-02-09 11:03:32 +00:00
Dragana Damjanovic
cca5369888 Bug 1688091 - Improve the telemetry for the HTTP3 connection close reasons. r=necko-reviewers,valentin
neqo now exposes a better info about the close reason and should use it.

Differential Revision: https://phabricator.services.mozilla.com/D102653
2021-02-09 09:51:02 +00:00
Kershaw Chang
3555325696 Bug 1686421 - Add probes to understand how HTTPS RR is used r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D101631
2021-02-09 09:11:45 +00:00
Kershaw Chang
e0a2b0844a Bug 1680688 - Add a delay before we reload PAC url r=necko-reviewers,valentin
Apparently, some VPN software also manipulate PAC url in system settings. In this case, the PAC url may not be available when we detect the network change, so this patch introduce a pref for adding a delay before reloading the PAC.

Differential Revision: https://phabricator.services.mozilla.com/D104449
2021-02-09 09:05:45 +00:00
Dragana Damjanovic
d6e65e8711 Bug 1688850 - Telemetry about HTTP3 0RTT usage r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103049
2021-02-09 08:44:18 +00:00
Jan Varga
89ca2a95fb Bug 1690515 - Add missing do_get_profile calls to appropriate tests; r=dom-workers-and-storage-reviewers,necko-reviewers,sg,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103886
2021-02-09 05:30:57 +00:00
Nils Ohlmeier [:drno]
5fd75514a3 Bug 1691306: move libsrtp from /netwerk to /third_party. r=bwc,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D104335
2021-02-09 01:48:39 +00:00
Valentin Gosu
700f171e16 Bug 1691359 - Don't call TRRIsOkay for cancelled TRR channels r=nhnt11
- Pass status code to cancelled TRR channels
- When TRR timer expires, use NS_ERROR_NET_TIMEOUT_EXTERNAL
- When TRR is cancelled by nsHostResolver use NS_ERROR_ABORT
- Only call TRRIsOkay in OnStopRequest (doing so in TRR::Cancel causes us to
  call it twice for the same TRR)
- Use NS_NewRunnableFunction instead of ProxyCancel runnable object
- Introduce TRR_REQ_CANCELLED skip reason

Differential Revision: https://phabricator.services.mozilla.com/D104371
2021-02-08 12:38:39 +00:00
Kershaw Chang
22a60154b9 Bug 1685942 - Only fallback to original conn info when network error happens r=necko-reviewers,valentin,dragana
Differential Revision: https://phabricator.services.mozilla.com/D102703
2021-02-08 11:46:51 +00:00
Rahul Yedida
d6bd5bcfa1 Bug 1671844 - PAC isPlainHostName() matching ipv6 addresses r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D99021
2021-02-08 13:02:45 +00:00
Nihanth Subramanya
48840a82cd Bug 1688228 - Introduce TRR_NXDOMAIN skip reason and record it when an rcode value of 0x03 is received. r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102774
2021-02-06 13:00:36 +00:00
Nika Layzell
daf01f9769 Bug 1681529 - Part 10: Set StartedReading after calling SetData, r=baku,necko-reviewers,valentin
SetData will check that `mStartedReading` has not been set yet to ensure the
stream is in a non-partially-read state. This can lead to assertion failures
when sending a stream not seeked to the beginning over IPC.

Differential Revision: https://phabricator.services.mozilla.com/D103226
2021-02-04 18:13:19 +00:00
Nika Layzell
9de178dfae Bug 1681529 - Part 7: Wrap the inner streams in a nsMIMEInputStream to make them seekable, r=baku,necko-reviewers,dragana
nsMIMEInputStream has a requirement that the inner nsIInputStream object
implement nsISeekableStream, which is usually enforced by the SetData method.
This check was bypassed by the Deserialize method, which unfortunately meant
that non-seekable IPC payloads could end up within a nsMIMEInputStream when sent
from another process (e.g. due to large nsStringStreams being serialized as
nsPipes over IPC).

This patch uses the SeekableStreamWrapper introduced in the previous patch to
wrap the inner stream when deserializing nsMIMEInputStream, avoiding the
previously mentioned issue.

Differential Revision: https://phabricator.services.mozilla.com/D101806
2021-02-04 18:13:12 +00:00
Valentin Gosu
62039bd713 Bug 1688205 - Record TRR_NO_ANSWERS when decoding a DoH response works but it contains no answers r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D102744
2021-02-05 12:23:46 +00:00
Kershaw Chang
f5f947be77 Bug 1689018 - Convey content disposition information to new redirect channel r=necko-reviewers,Gijs,valentin
Differential Revision: https://phabricator.services.mozilla.com/D104061
2021-02-05 09:52:30 +00:00
Kershaw Chang
660e474854 Bug 1689474 - Make sure sending queries to ODoH proxy is working r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103817
2021-02-04 18:30:45 +00:00
Kershaw Chang
a3582caf5e Bug 1689474 - Update ODoH to draft-04 and make CNAME work r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103816
2021-02-04 08:05:45 +00:00
Nihanth Subramanya
c206347e88 Bug 1689113 - Don't skip TRR unless confirmation explicitly failed. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103170
2021-02-04 17:34:27 +00:00
Kershaw Chang
8373d6cfc5 Bug 1682555 - Add a probe for echConfig sucessful rate r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D103340
2021-02-04 10:49:35 +00:00
Kershaw Chang
d2340e9ce4 Bug 1690220 - Don't query https rr when proxy CONNECT is in use r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D103781
2021-02-03 10:32:34 +00:00
Nils Ohlmeier [:drno]
f982032c7c Bug 1690200: pick SCTP init processing fix from upstream. r=ng
Differential Revision: https://phabricator.services.mozilla.com/D103744
2021-02-04 06:53:06 +00:00
Dorel Luca
9604c3539b Backed out changeset ca3e129f7a36 (bug 1682555) for XPCshell failures in netwerk/test/unit/test_http2-proxy.js. CLOSED TREE 2021-02-04 05:56:53 +02:00
Kershaw Chang
9fcee5ebcf Bug 1682555 - Add a probe for echConfig sucessful rate r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D103340
2021-02-03 21:43:30 +00:00
Dragana Damjanovic
9ff2575792 Bug 1689604 - Remove TCPFastOpen part 3 r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103517
2021-02-03 17:23:45 +00:00
Dragana Damjanovic
61e4c834b7 Bug 1689604 - Remove TCPFastOpen part 2 r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103478
2021-01-29 21:59:55 +00:00
Dragana Damjanovic
7c8dca3ea6 Bug 1689604 - Remove TCPFastOpen part 1 r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103470
2021-02-03 17:08:18 +00:00
Kershaw Chang
4e494b48f7 Bug 1687320 - Avoid doing 0RTT again if the transaction will be restarted r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D103479
2021-02-03 10:02:11 +00:00
Kershaw Chang
5c2914628b Bug 1687364 - Authorization header can't be wildcarded for Access-Control-Allow-Headers r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D102932
2021-02-02 18:39:32 +00:00
Bogdan Tara
abc7c8eeee Backed out 11 changesets (bug 1681529) for talos crashes CLOSED TREE
Backed out changeset c87d0f32d7a6 (bug 1681529)
Backed out changeset b1269f35d525 (bug 1681529)
Backed out changeset 29df8d4c984a (bug 1681529)
Backed out changeset 4def7578ced0 (bug 1681529)
Backed out changeset ce57c5a26c25 (bug 1681529)
Backed out changeset 78b186ec645a (bug 1681529)
Backed out changeset b1d1550a66ca (bug 1681529)
Backed out changeset e8620622208a (bug 1681529)
Backed out changeset 636b1a7c13e4 (bug 1681529)
Backed out changeset a5a8eac68b87 (bug 1681529)
Backed out changeset 968e17db71df (bug 1681529)
2021-02-03 09:29:38 +02:00
Nika Layzell
d42f3a9fc3 Bug 1681529 - Part 10: Set StartedReading after calling SetData, r=baku,necko-reviewers,valentin
SetData will check that `mStartedReading` has not been set yet to ensure the
stream is in a non-partially-read state. This can lead to assertion failures
when sending a stream not seeked to the beginning over IPC.

Differential Revision: https://phabricator.services.mozilla.com/D103226
2021-02-02 23:26:43 +00:00
Nika Layzell
f172ee476b Bug 1681529 - Part 7: Wrap the inner streams in a nsMIMEInputStream to make them seekable, r=baku,necko-reviewers,dragana
nsMIMEInputStream has a requirement that the inner nsIInputStream object
implement nsISeekableStream, which is usually enforced by the SetData method.
This check was bypassed by the Deserialize method, which unfortunately meant
that non-seekable IPC payloads could end up within a nsMIMEInputStream when sent
from another process (e.g. due to large nsStringStreams being serialized as
nsPipes over IPC).

This patch uses the SeekableStreamWrapper introduced in the previous patch to
wrap the inner stream when deserializing nsMIMEInputStream, avoiding the
previously mentioned issue.

Differential Revision: https://phabricator.services.mozilla.com/D101806
2021-02-02 23:26:36 +00:00
Brindusan Cristian
cbdb020883 Backed out 11 changesets (bug 1681529) for mochitest failures at test_reload_large_postdata.html. CLOSED TREE
Backed out changeset f1f988155c82 (bug 1681529)
Backed out changeset f0ba367de05e (bug 1681529)
Backed out changeset dbea9952ec79 (bug 1681529)
Backed out changeset 6e185ec2c4a4 (bug 1681529)
Backed out changeset d0b11c08666a (bug 1681529)
Backed out changeset f2515096b378 (bug 1681529)
Backed out changeset ecd8c3b8fdb4 (bug 1681529)
Backed out changeset 7ea2e9cc8bad (bug 1681529)
Backed out changeset dbc85d0bffaf (bug 1681529)
Backed out changeset f0893f544219 (bug 1681529)
Backed out changeset 91979e21aa8e (bug 1681529)
2021-02-02 22:02:59 +02:00
Nika Layzell
f918e191b0 Bug 1681529 - Part 10: Set StartedReading after calling SetData, r=baku,necko-reviewers,valentin
SetData will check that `mStartedReading` has not been set yet to ensure the
stream is in a non-partially-read state. This can lead to assertion failures
when sending a stream not seeked to the beginning over IPC.

Differential Revision: https://phabricator.services.mozilla.com/D103226
2021-01-29 19:04:03 +00:00
Nika Layzell
55c9ceedc7 Bug 1681529 - Part 7: Wrap the inner streams in a nsMIMEInputStream to make them seekable, r=baku,necko-reviewers,dragana
nsMIMEInputStream has a requirement that the inner nsIInputStream object
implement nsISeekableStream, which is usually enforced by the SetData method.
This check was bypassed by the Deserialize method, which unfortunately meant
that non-seekable IPC payloads could end up within a nsMIMEInputStream when sent
from another process (e.g. due to large nsStringStreams being serialized as
nsPipes over IPC).

This patch uses the SeekableStreamWrapper introduced in the previous patch to
wrap the inner stream when deserializing nsMIMEInputStream, avoiding the
previously mentioned issue.

Differential Revision: https://phabricator.services.mozilla.com/D101806
2021-01-27 21:55:19 +00:00
Kershaw Chang
a04bced733 Bug 1690008 - Clear npnToken when we want to create a non-http3 connection info r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D103690
2021-02-01 21:09:45 +00:00
Kershaw Chang
98f3b6821b Bug 1687413 - Iteratively parse cache-control header to avoid stack overflow r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D103635
2021-02-01 20:47:06 +00:00
Dragana Damjanovic
8d28f38460 Bug 1690000 - Always reset ConnInfo if it is using Http3. r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D103634
2021-02-01 14:05:31 +00:00
Nika Layzell
29c2d4d113 Bug 1682285 - Part 1: Split internal and external load flags, r=kmag,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D103364
2021-01-29 22:06:16 +00:00