Commit Graph

1132 Commits

Author SHA1 Message Date
Alfredo.Yang
d6a0eb9d74 Bug 1417795 - remove mp4_demuxer namespace part3. r=kinetik
MozReview-Commit-ID: 9fM2VjY4Ckk

--HG--
extra : rebase_source : 24d971d44e1d9bd8b1589b4b542d792f75df376d
2017-11-17 08:53:25 +08:00
Alfredo.Yang
a0056437d9 Bug 1417795 - remove mp4_demuxer namespace part2. r=kinetik
MozReview-Commit-ID: F8z1QW6WuUU

--HG--
extra : rebase_source : 9d137794bb1c6465da1d6b7aa6ba50265172ada3
2017-11-16 16:24:22 +08:00
Alfredo.Yang
a2cd247c8f Bug 1417795 - remove mp4_demuxer namespace part1. r=kinetik
MozReview-Commit-ID: 6YrURoOq2wk

--HG--
extra : rebase_source : 3ea026780b210b42bd41163c654580a920d30181
2017-11-16 15:57:15 +08:00
JW Wang
1f62c1d92b Bug 1417869. P3 - pass descriptive messages to NetworkError(). r=jya
MozReview-Commit-ID: 6yaFJvXG3g8

--HG--
extra : rebase_source : 2d1c851098be7eb880a01432c504c6db96d86756
extra : source : a30f9699f49687b23d4ccf955d7a0af8ce0c7653
2017-11-17 11:07:30 +08:00
JW Wang
5a99c6b197 Bug 1417774 - remove unused MediaResource::Tell(). r=bechen
MozReview-Commit-ID: 3qlP4sSh9kM

--HG--
extra : rebase_source : 4002fec6f8c43abb640f9206cd715f3ecb02b373
2017-11-15 17:18:52 +08:00
Andrea Marchesini
4b1b084ce7 Bug 1416724 - part 3 - AbstractThread::Dispatch return value check in dom/media, r=jwwang 2017-11-15 07:58:03 +01:00
shindli
385fb3428c Backed out 4 changesets (bug 1416724) for failing /builds/worker/workspace/build/src/dom/media/hls/HLSDemuxer.cpp:89:5 r=backout on a CLOSED TREE
Backed out changeset 45352aa4319d (bug 1416724)
Backed out changeset 01d1e5263bcd (bug 1416724)
Backed out changeset bc854c315ec8 (bug 1416724)
Backed out changeset 35a50167485d (bug 1416724)
2017-11-15 09:49:04 +02:00
Andrea Marchesini
642cdd108b Bug 1416724 - part 3 - AbstractThread::Dispatch return value check in dom/media, r=jwwang 2017-11-15 07:58:03 +01:00
Andrea Marchesini
3f760d8258 Bug 1415564 - TaskQueue::Dispatch should return an error if failed, r=smaug 2017-11-09 01:43:40 +01:00
Sebastian Hengst
d61954557d merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: Ai6Y5GGfkfT
2017-11-04 10:58:24 +01:00
Jon Coppeard
fd86611724 Bug 1413993 - Remove unused USEC_PER_SEC constant r=jya
This constant is #defined in some MacOS system headers which causes compile errors.
2017-11-03 10:25:26 +00:00
Jean-Yves Avenard
acabf2903c Bug 1295886 - P15. Enable FLAC mochitest on Android. r=gerald
MozReview-Commit-ID: 83mJleAMVro

--HG--
extra : rebase_source : ba445777b70a1b700eb21eb9809fecea76609598
2017-11-02 02:56:04 +01:00
Alastor Wu
c683d23150 Bug 1362440 - part4 : parsing entire content to decide whether it's init segment. r=jya
The spec [1] defines what's the init segment, and the parser would return error
if the format is not correct.

[1] https://w3c.github.io/media-source/webm-byte-stream-format.html

MozReview-Commit-ID: 3nFHHdn5b89

--HG--
extra : rebase_source : 66fe592958801c4f9e2115f7729df2b9ece55ac3
2017-10-30 17:48:43 +08:00
Alastor Wu
65c50bf89e Bug 1362440 - part3 : add tests. r=jya
MozReview-Commit-ID: C4mXuPsMaF4

--HG--
extra : rebase_source : 11b69bde40b1ca336e2b9272aa2ec26c0e78507d
2017-10-30 17:48:35 +08:00
Alastor Wu
7440c83cae Bug 1362440 - part2 : parsing entire content to decide whether it's media segment. r=kinetik
The spec [1] defines what's the media segment, and the parser would return error
if the format is not correct.

[1] https://w3c.github.io/media-source/webm-byte-stream-format.html

MozReview-Commit-ID: 4hq59Pywz2t

--HG--
extra : rebase_source : 1136d2a673f11d612e0eb711db6affdce42bb525
2017-10-30 15:27:30 +08:00
Alfredo.Yang
fc4a02e7c7 Bug 1411815 - use BufferReader instead of ByteReader in ContainerParser. r=kinetik
MozReview-Commit-ID: DB2J7w8PpAJ

--HG--
extra : rebase_source : 113b9832df3ac223c9adbcaa44f224d0c792892b
2017-10-19 11:12:48 +08:00
James Cheng
ed18e57446 Bug 1407919 - Part3 - Add a gtest for testing the extraction function. r=gerald
MozReview-Commit-ID: 7CocV0rLtk7

--HG--
extra : rebase_source : 5fd1ac5e5623b2e4637b0e78541582432a87ac44
2017-10-13 21:17:35 +08:00
Jean-Yves Avenard
38b456068a Bug 1409272 - P2. Pre-roll vorbis by 80ms when seeking. r=gerald
The value by which we pre-roll is inconsequential, so long as we seek to the previous packet than the one we want. So 80ms will do.

MozReview-Commit-ID: 8iPOtjReZnb

--HG--
extra : rebase_source : 42908c6afc84cf783356fb7311ffe99b4ec76d96
2017-10-17 16:07:26 +02:00
Sebastian Hengst
34714cebde merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 2KL1o3EPUk
2017-10-17 23:52:28 +02:00
Alastor Wu
c8a9b504ed Bug 1408987 - Part 2: Make mManager thread-safe. r=jya
mManager would be accessed in both main thread and task queue, and be set on task
queue, so we need to make sure it's thread-safe.

MozReview-Commit-ID: m76KeEsDgB
2017-10-17 16:53:54 +08:00
Alastor Wu
bbdf374f35 Bug 1408987 - Part 1: Add OnTaskQueue() assertion to clarify functions' running thread. r=jya
MozReview-Commit-ID: 36sqB5SlOd
2017-10-17 15:58:44 +08:00
Alastor Wu
def6113401 Bug 1409274 - remove the lock for SourceBufferTaskQueue. r=jya
It would only be accessed on task queue now, so we don't need to lock it.

MozReview-Commit-ID: 6jd36TQW4aA

--HG--
extra : rebase_source : e8bb53a226154312496149ab8f6b00dead49a3b6
2017-10-17 15:46:26 +08:00
Jean-Yves Avenard
e891f573a5 Bug 1407940 - P2. Only ever access mTaskQueue in a thread-safe fashion. r=alwu,gerald
mTaskQueue is only read on the main thread, but read and written on the demuxer's taskqueue. We need to ensure that accesses are synchronised.

MozReview-Commit-ID: Gbc15iYgZOe

--HG--
extra : rebase_source : 006ff3f73c9895fa2f29e56123e690cdf66fe2c5
2017-10-12 13:30:47 +02:00
Jean-Yves Avenard
51e48cb035 Bug 1407940 - P1. Use Mutex in place of Monitor. r=gerald
MozReview-Commit-ID: Dy2WhS0YOq1

--HG--
extra : rebase_source : 9ce10f7c7c811d0f73ef39a6439cac92686f9793
2017-10-12 11:15:20 +02:00
Alastor Wu
b8237a2029 Bug 1247189 - part5 : use IsCurrentThreadIn() as a main criteria to determine whether we're on the task queue or not. r=jya
The use of the TrackBuffersManager once detached is explictly forbidden, as such
OnTaskQueue() can only be used before the DetachTask ran: we now strongly assert
as such.

MozReview-Commit-ID: ycOI4QRElb

--HG--
extra : rebase_source : ecce8ac75587470c15268ab729b068f049702a8a
2017-10-12 10:49:25 +08:00
Alastor Wu
b4c4772190 Bug 1247189 - part4 : ensure we always detach TBM from demuxers. r=jya
Ensure the TBM would always be detached from demuxers, before calling
TBM::detach().

MozReview-Commit-ID: DLWZHB3M3GG

--HG--
extra : rebase_source : 9e455022ba9360fb549222e9ad1238a3ae9d88ad
2017-10-12 10:49:21 +08:00
Alastor Wu
023e34cbe4 Bug 1247189 - part3 : don't process any task after detached. r=jya
From [1], the task was executed after finished detach task. It would be caused
by queuing two detach tasks in the task queue.

If the previous detach task is still waiting in the task queue when we're calling
the second detach(), then we might have two detach tasks in the queue.

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=134315866&repo=try&lineNumber=2540

MozReview-Commit-ID: HohgKqeZy0s

--HG--
extra : rebase_source : 0d20f1b8648acaf2ed8e75b2631e905629c2abaf
2017-10-12 10:49:10 +08:00
Alastor Wu
5a164c7e06 Bug 1247189 - part2 : remove reference to TrackBuffersManagers once detached. r=jya
Should never access the TrackBuffersManager once the SourceBuffer has been detached.

MozReview-Commit-ID: EgVINj9B1vZ

--HG--
extra : rebase_source : 4b4dc3e5c4b507fe4cc40e80f507b575a8b87eb3
2017-10-11 10:55:21 +08:00
Alastor Wu
d9f5f478d9 Bug 1247189 - part1 : should detach TBM after detaching it from demuxers. r=jya
After detaching TBM, we should not access it anymore. So we should finish all
other related detaching process, before detaching TBM.

MozReview-Commit-ID: 8bNzqXVHVyy

--HG--
extra : rebase_source : e135eb3d0fd4e5c41bbac4ebfc8d6fcbd1b32d5b
2017-10-11 10:49:05 +08:00
Ryan VanderMeulen
0dcd727f08 Merge m-c to autoland. a=merge 2017-10-11 17:55:13 -04:00
Tom Ritter
701ee70a22 Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
MozReview-Commit-ID: 4v6tPF5aMz7

--HG--
extra : rebase_source : fe434db73a8da686391462c12b91648348abcdc9
2017-10-09 15:01:48 -05:00
Sebastian Hengst
0ed8d9a86e Backed out changeset 26e324eb052d (bug 1247189) for crashing in /media-source/mediasource-errors.html. r=backout
--HG--
extra : amend_source : 39152d1a0836f9f1e22cc4cc6a0a759f4258e81b
2017-10-11 12:45:50 +02:00
Sebastian Hengst
953fafcc3c Backed out changeset 5b9af87e76a9 (bug 1247189) 2017-10-11 12:45:45 +02:00
Sebastian Hengst
6479b83569 Backed out changeset 36a63b9f8dcb (bug 1247189) 2017-10-11 12:45:40 +02:00
Sebastian Hengst
ebb7218fe9 Backed out changeset 85d236f46b00 (bug 1247189) 2017-10-11 12:45:34 +02:00
Sebastian Hengst
e80bd4f030 Backed out changeset 9be5bbb35797 (bug 1247189) 2017-10-11 12:45:29 +02:00
Jean-Yves Avenard
d34a7ebdc5 Bug 1407243 - Don't immediately fire canplaythrough for infinite/live streams. r=jwwang
MozReview-Commit-ID: 2LQFa8PHvO5

--HG--
extra : rebase_source : 3534a963202658870221fca9cc238185d7e55156
2017-10-10 16:14:24 +02:00
Alastor Wu
8ef6776c31 Bug 1247189 - part5 : use IsCurrentThreadIn() as a main criteria to determine whether we're on the task queue or not. r=jya
The use of the TrackBuffersManager once detached is explictly forbidden, as such
OnTaskQueue() can only be used before the DetachTask ran: we now strongly assert
as such.

MozReview-Commit-ID: ycOI4QRElb

--HG--
extra : rebase_source : 44ea3d0eb292e5c285d0aa4e10eefa41f20beed7
2017-10-11 16:12:13 +08:00
Alastor Wu
f519e79462 Bug 1247189 - part4 : ensure we always detach TBM from demuxers. r=jya
Ensure the TBM would always be detached from demuxers, before calling
TBM::detach().

MozReview-Commit-ID: DLWZHB3M3GG

--HG--
extra : rebase_source : 0334b71534cfaccaf1d8985d827fe4e5d5bf0e9f
2017-10-11 11:01:08 +08:00
Alastor Wu
a4ae0238e3 Bug 1247189 - part3 : don't process any task after detached. r=jya
From [1], the task was executed after finished detach task. It would be caused
by queuing two detach tasks in the task queue.

If the previous detach task is still waiting in the task queue when we're calling
the second detach(), then we might have two detach tasks in the queue.

[1] https://treeherder.mozilla.org/logviewer.html#?job_id=134315866&repo=try&lineNumber=2540

MozReview-Commit-ID: HohgKqeZy0s

--HG--
extra : rebase_source : b1dc3193d839ef3776195901339fae24f328207b
2017-10-11 11:00:57 +08:00
Alastor Wu
afaf8c616f Bug 1247189 - part2 : remove reference to TrackBuffersManagers once detached. r=jya
Should never access the TrackBuffersManager once the SourceBuffer has been detached.

MozReview-Commit-ID: EgVINj9B1vZ

--HG--
extra : rebase_source : 4b4dc3e5c4b507fe4cc40e80f507b575a8b87eb3
2017-10-11 10:55:21 +08:00
Alastor Wu
e750a6aff2 Bug 1247189 - part1 : should detach TBM after detaching it from demuxers. r=jya
After detaching TBM, we should not access it anymore. So we should finish all
other related detaching process, before detaching TBM.

MozReview-Commit-ID: 8bNzqXVHVyy

--HG--
extra : rebase_source : e135eb3d0fd4e5c41bbac4ebfc8d6fcbd1b32d5b
2017-10-11 10:49:05 +08:00
Joel Maher
5ab59bd06c Bug 1401090 - Disable test_FrameSelection.html,test_HaveMetadataUnbufferedSeek.html,test_EndedEvent.html on android for frequent failures. r=me, a=test-only 2017-10-11 08:45:03 -04:00
Gerald Squelart
b0442493e5 Bug 1405531 - Remove unused MediaDataDemuxer::HasTrackType - r=jwwang
The only actual code use in MediaSourceDemuxer can trivially be folded into
its caller GetNumberTracks in the same class.

MozReview-Commit-ID: E6zh98zmJwJ

--HG--
extra : rebase_source : 9358dc37523d6cd7c1a4d5ec62a790db6a092063
2017-10-04 11:40:29 +11:00
Alastor Wu
6881f03d05 Bug 1403478 - part2 : merge 'test_SeekableBefore*' and 'test_SeekableAfter*' into 'test_SeekableBeforeAndAfter*'. r=jya
MozReview-Commit-ID: 3tfdEEV78k8

--HG--
rename : dom/media/mediasource/test/test_SeekableAfterEndOfStream.html => dom/media/mediasource/test/test_SeekableBeforeAndAfterEndOfStream.html
rename : dom/media/mediasource/test/test_SeekableAfterEndOfStreamSplit.html => dom/media/mediasource/test/test_SeekableBeforeAndAfterEndOfStreamSplit.html
rename : dom/media/mediasource/test/test_SeekableAfterEndOfStreamSplit_mp4.html => dom/media/mediasource/test/test_SeekableBeforeAndAfterEndOfStreamSplit_mp4.html
rename : dom/media/mediasource/test/test_SeekableAfterEndOfStream_mp4.html => dom/media/mediasource/test/test_SeekableBeforeAndAfterEndOfStream_mp4.html
extra : rebase_source : 98e2e7c90f9b22526889eca869160999307e0cf7
2017-09-29 11:58:44 +08:00
Alastor Wu
27e06f23ea Bug 1403478 - part1 : check v.seekable before and after calling ms.endOfStream(). r=jwwang,jya
This patch does two things,

(1) check v.seekable after calling ms.endOfStream()
As test name suggests, we check seekable after calling endOfStream()

(2) check the time range of v.seekable
The seekable represents the ranges of the media resource [1], so it would be changed after calling ms.endOfStream().

Before calling the endOfStream(), seekable should be [0, ms.duration)
After calling the endOfStream(), seekable should be [0, ms.buffer.end(0))

[1] https://www.w3.org/TR/html51/semantics-embedded-content.html#dom-htmlmediaelement-seekable

MozReview-Commit-ID: 56AIZYVsHhW

--HG--
extra : rebase_source : a1f1df601dc8523cd5d4e58b41cada3c79d494c1
2017-09-29 11:33:46 +08:00
Alastor Wu
1bc4324cb2 Bug 1403832 - part1 : replace Error.Code() with Error.ErrorName(). r=jya
Use ErrorName() as it provides more useful information for the error detail.

MozReview-Commit-ID: BQUPQGcLd8L

--HG--
extra : rebase_source : 734825c88dfbe79de1e61498dcc24606c50314ee
2017-09-29 00:37:45 +08:00
Sebastian Hengst
ee63f2e30a Backed out changeset 0317bcff40bc (bug 1406687) for build bustage at testing/gtest/gtest/src/gtest.cc:3871: 'Unused' was not declared in this scope. r=backout 2017-10-09 18:52:39 +02:00
Tom Ritter
22d2cdf063 Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
MozReview-Commit-ID: 4v6tPF5aMz7

--HG--
extra : rebase_source : c54b129c6815096035e262322f40aa0884b1ae56
2017-10-09 00:26:16 -05:00
Alastor Wu
a9f36ddd2d Bug 1402681 - part2 : add log. r=jya
MozReview-Commit-ID: 8qINxSCKrvg

--HG--
extra : rebase_source : 962ec20a7882c1854b0b3ea7a8aa6be65c9d0247
2017-09-26 17:48:39 +08:00