Commit Graph

21202 Commits

Author SHA1 Message Date
Nick Alexander
d8db003c57 Bug 1411654 - Part 2: Update Robolectric to 3.5.1. r=mcomella
There were a few API changes, mostly around explicitly creating
Services/Activities/ContentProvider instances, but they were pretty
easy to address.

Sadly, Robolectric doesn't really work with the new aapt2 processing
in Android-Gradle plugin 3.0+ -- see in particular
https://github.com/robolectric/robolectric/issues/3333#issuecomment-324300418
-- so we have to opt-out of the new implementation for now.  Hopefully
plugin 3.1+ will address these issues, which are widespread.

MozReview-Commit-ID: dlbd32kMs6

--HG--
extra : rebase_source : 325bc8142ec9b8a9d5029e7820e8f990d7e1a5fd
2017-11-07 20:26:43 -08:00
Nick Alexander
47c107e74f Bug 1411654 - Part 1: Upgrade to Android-Gradle 3.0+ and build-tools;26.0.2. r=maliu
New Android-Gradle plugins pin the build-tools version, and we want to
be consistent between Gradle and moz.build.

MozReview-Commit-ID: ApWS4rHzPuH

--HG--
extra : rebase_source : 38a9781c472d858f3300cbbcbdc6d2311c465713
2017-10-26 11:00:36 -07:00
Nick Alexander
f4efb03e4e Bug 1411654 - Part 0: Add rudimentary documentation about Gradle integration. r=maliu
This sketches the flavor dimensions.  The important ones are
`audience` and `geckoBinaries`, which I think simplify the situation
greatly.  Coupled with Bug 1417232 centralizing most everything in
`mobile/android/gradle.configure`, the Gradle configuration shouldn't
be so hard to evolve.

MozReview-Commit-ID: DILjVrnLA3F

--HG--
extra : rebase_source : 2373eecc45e670ff7a5697f2e8095a8ea8fb5058
2017-11-15 15:02:18 -08:00
Jim Chen
59bbfb5a7d Bug 1411654 - Pre: Fix CustomTabsSecurityPopup package. r=nalexander
MozReview-Commit-ID: ICTdy9WRlwG

--HG--
extra : rebase_source : d11fb2b2410bf9f1e7971b3c1adf2cb1beee1f67
extra : source : 805627e27bc602593349e7386ce79e7b607e153b
2018-01-09 14:59:55 -05:00
Nick Alexander
38c81ecf69 Bug 1411654 - Pre: Remove unused HomeExpandableListView. r=mcomella
This was added for the Remote Tabs panel in Bug 785199.  That code has
now morphed into the combined history panel, which uses a
RecyclerView.

MozReview-Commit-ID: J6KsVCn8mzh

--HG--
extra : rebase_source : 8e18f57882edee2de1e9decec323ea5831d314c8
2017-11-14 19:32:18 -08:00
Nick Alexander
ff80906133 Bug 1411654 - Pre: Fix checkstyle whitespace error in GeckoHlsPlayer. r=nalexander
MozReview-Commit-ID: 4h1p4J5B8sM

--HG--
extra : rebase_source : 3703ef9e2d083761371449945117cdcb773a4878
2018-01-04 12:26:11 -08:00
Nick Alexander
88e814095b Bug 1411654 - Pre: Clear icon disk storage in test. r=mcomella
Newer versions of Robolectric seem to have different semantics about
clearing disk caches, so this is necessary.  But for older versions,
it shouldn't hurt, and is slightly more clear than relying on an
implicit clear.

MozReview-Commit-ID: LRcaEPasXj8

--HG--
extra : rebase_source : 3b26f65d455c049b6190a9c481f8a4bec4e06dfd
2017-11-07 20:24:04 -08:00
Nick Alexander
95a99b4b2a Bug 1411654 - Pre: Remove unused PerProfileDatabaseProvider. r=mcomella
No idea what is going on with this hierarchy, but this isn't used and
isn't helping anything.

MozReview-Commit-ID: Ir3LxLYHR6M

--HG--
extra : rebase_source : c883a3fa60d1a47b19b53f2bbc7a9c2f0e2cf711
2017-11-07 20:18:56 -08:00
Nick Alexander
39c11c49d5 Bug 1411654 - Pre: Fix dangling resource. r=mcomella
This is just wrong.

MozReview-Commit-ID: EBtKTD07aNu

--HG--
rename : mobile/android/base/resources/values-v17/themes.xml => mobile/android/app/src/main/res/values-v17/themes.xml
extra : rebase_source : 01df9bd8ff4f2d700999ee5d2045890f8acb51ac
2017-11-08 09:47:48 -08:00
Nick Alexander
f866b2dcc8 Bug 1411654 - Pre: Teach |mach gradle| to take GRADLE_FLAGS from the command line. r=maliu
MozReview-Commit-ID: 150llND5h0j

--HG--
extra : rebase_source : 3c1859be6497dddf4cb9f05af7749cdd485776b7
2017-10-25 10:22:42 -07:00
Nick Alexander
c033a8d02c Bug 1430309 - Remove classycle from the tree. r=froydnj
This was added in Bug 1096627 to enforce the baseline GeckoView
layering that we had at that time.  Now that GeckoView is a separate
Gradle project, that layering is automatically enforced.  It's time
for this to go.

MozReview-Commit-ID: Ly35QhgBdWM

--HG--
extra : rebase_source : 2a1807b3b06e332ca7d0980c01aa1e343f4df5d9
2017-11-16 09:58:51 -08:00
Coroiu Cristina
5081234fee Backed out 1 changesets (bug 1430309) for build bustage because of unused rule in mobile/android/moz.build after file removals on a CLOSED TREE
Backed out changeset 0b0cab4592d9 (bug 1430309)
2018-01-15 21:08:48 +02:00
Nick Alexander
6550a090f6 Bug 1430309 - Remove classycle from the tree. r=froydnj
This was added in Bug 1096627 to enforce the baseline GeckoView
layering that we had at that time.  Now that GeckoView is a separate
Gradle project, that layering is automatically enforced.  It's time
for this to go.

MozReview-Commit-ID: Ly35QhgBdWM

--HG--
extra : rebase_source : 8b7b6c5f3386804209bccca48a1549cc74cd0836
2017-11-16 09:58:51 -08:00
Emilio Cobos Álvarez
5a3cf530d2 Bug 1430512: Remove unnecessary use of -moz-border-bottom-colors in aboutBase.css. r=dao
A single color in the color list renders just as border-bottom-color.

This used to have two colors, but was changed in [1], so now it can go away.

[1]: https://hg.mozilla.org/mozilla-central/rev/cfdf310748918c3d5eadc16daa5153091e325995

MozReview-Commit-ID: LDocmCwjkzw

--HG--
extra : rebase_source : 0b5027434d7a964165f547c3c67f31045ecc3df4
2018-01-15 03:27:19 +01:00
Jim Chen
0fe980975c Bug 1426244 - 4. Add mach android geckoview-docs command; r=nalexander
Add a './mach android geckoview-docs' command that generates javadoc for
GeckoView using Gradle. Specifying the '--archive' option will generate
a geckoview-javadoc.jar archive. Specifying the '--upload' option,
intended primarily for Taskcluster, will upload the javadoc to Github
pages under the given user/repository.

MozReview-Commit-ID: HfwXlf8aFhw

--HG--
extra : rebase_source : 25ccbf3380ba2c8f391c48c882256f970be92c9f
2018-01-13 17:41:09 -05:00
Jim Chen
5f1d1d00db Bug 1426244 - 2. Fix javadoc comments; r=droeh,nalexander
Add some missing lines and fix some mistakes in our javadoc comments.

MozReview-Commit-ID: 9Q7qWJJ51Vo

--HG--
extra : rebase_source : afc70812b26de19e610412df014070b75c46017b
2018-01-13 17:41:08 -05:00
Jim Chen
d72cb2053e Bug 1426244 - 1. Fix some errors from javadoc generation; r=nalexander
Tweak the javadoc task arguments to not generate errors for a standard
GeckoView javadoc run.

MozReview-Commit-ID: 931xCtUcX6N

--HG--
extra : rebase_source : 51e13cd4ec4a0ad9ec91e3bf2b52768aa6ba5e16
2018-01-13 17:41:08 -05:00
Dorel Luca
ab63c465d9 Backed out 19 changesets (bug 1411654) for Android nightly bustages a=backout
Backed out changeset 649e7aa405ca (bug 1411654)
Backed out changeset c2e51b70519f (bug 1411654)
Backed out changeset a371f3ef4312 (bug 1411654)
Backed out changeset db978e230556 (bug 1411654)
Backed out changeset 56538ed998cf (bug 1411654)
Backed out changeset 6ff0cdf46a3d (bug 1411654)
Backed out changeset 0e493bacc5e3 (bug 1411654)
Backed out changeset 23cbcf427745 (bug 1411654)
Backed out changeset eda74143389f (bug 1411654)
Backed out changeset 359fadf9b3e9 (bug 1411654)
Backed out changeset 5c64eda20f1e (bug 1411654)
Backed out changeset bffb6a5b78d1 (bug 1411654)
Backed out changeset 43787f4089c3 (bug 1411654)
Backed out changeset 9141bbdfd13b (bug 1411654)
Backed out changeset 108674372ef7 (bug 1411654)
Backed out changeset fb15e1f54987 (bug 1411654)
Backed out changeset 264476c77210 (bug 1411654)
Backed out changeset d23f467218da (bug 1411654)
Backed out changeset 78576ff98660 (bug 1411654)

--HG--
rename : mobile/android/app/src/main/res/values-v17/themes.xml => mobile/android/base/resources/values-v17/themes.xml
2018-01-13 15:17:49 +02:00
Dorel Luca
cad7f53be6 Backed out changeset 113f1c4b9564 (bug 1411654) for android nightly bustages a=backout 2018-01-13 14:07:31 +02:00
Nick Alexander
36512ce4d5 Bug 1411654 - Post: Cull unused variables; guard more with MOZ_BUILD_MOBILE_ANDROID_WITH_GRADLE. r=maliu
MozReview-Commit-ID: 8EGzVISIEQZ

--HG--
extra : rebase_source : 62119e99ded0ca842b53b7bae5efc2ec07fece64
2017-11-14 15:03:52 -08:00
Nick Alexander
85c743be7e Bug 1411654 - Part 5c: Work through ResourceUnused lint issues. r=mcomella
MozReview-Commit-ID: 82rgLEEMQzG

--HG--
extra : rebase_source : 48c033eec89fa2708a7c1bced5c1da3363bc9dd7
2017-11-14 19:20:16 -08:00
Nick Alexander
13f62b22ce Bug 1411654 - Part 5b: Work through WrongConstant lint issues. r=mcomella
MozReview-Commit-ID: 6zJ7EMu9rgO

--HG--
extra : rebase_source : c0727fa0b856e49a55694cd07efb049a413a80d5
2017-11-14 15:36:49 -08:00
Nick Alexander
b2e71b8573 Bug 1411654 - Part 6: Fix checkstyle. r=mcomella
MozReview-Commit-ID: GPRogNGKQBJ

--HG--
extra : rebase_source : d99489c5e1f6dcf9ca10b6ba4571bd9aefae86d7
2017-11-14 09:49:27 -08:00
Nick Alexander
2d91813ebe Bug 1411654 - Part 5: Work through various new lint issues. r=mcomella
MozReview-Commit-ID: AhrT7jbztE3

--HG--
extra : rebase_source : 1241d02bf70fe612be576fc51909be81fc5f3b5f
2017-11-08 10:11:25 -08:00
Nick Alexander
34208b22e7 Bug 1411654 - Part 4: Use flavorDimensions to simplify {with,without}GeckoBinaries logic. r=maliu
MozReview-Commit-ID: 2rbsP6A0BY0

--HG--
extra : rebase_source : d9df7bdb482b8605067303857ab6a3356fa87646
2017-11-09 16:47:05 -08:00
Nick Alexander
c85490413c Bug 1411654 - Part 3: Make each variant handle source from moz.build. r=maliu
The advantage of doing this per-variant is that we can really separate
the 'local' behaviour (re-generate via re-entrant |mach build|
invocations) from the 'official' behaviour (never re-generate via
re-entrance).

This also uses new Android-Gradle plugin 3.0+ APIs to integrate the
generated resources and Java code.

MozReview-Commit-ID: 4pd2iw1nJSb

--HG--
extra : rebase_source : 7f8f8e7b2ec80de1104d51815ff2b66f389a33c3
2017-11-09 13:47:46 -08:00
Nick Alexander
4a8ac4504e Bug 1411654 - Part 2: Update Robolectric to 3.5.1. r=mcomella
There were a few API changes, mostly around explicitly creating
Services/Activities/ContentProvider instances, but they were pretty
easy to address.

Sadly, Robolectric doesn't really work with the new aapt2 processing
in Android-Gradle plugin 3.0+ -- see in particular
https://github.com/robolectric/robolectric/issues/3333#issuecomment-324300418
-- so we have to opt-out of the new implementation for now.  Hopefully
plugin 3.1+ will address these issues, which are widespread.

MozReview-Commit-ID: dlbd32kMs6

--HG--
extra : rebase_source : 1b4a681863e8917b473f4852c4b88fe1f95dc1fd
2017-11-07 20:26:43 -08:00
Nick Alexander
e820c8ca18 Bug 1411654 - Part 1: Upgrade to Android-Gradle 3.0+ and build-tools;26.0.2. r=maliu
New Android-Gradle plugins pin the build-tools version, and we want to
be consistent between Gradle and moz.build.

MozReview-Commit-ID: ApWS4rHzPuH

--HG--
extra : rebase_source : 5a5730b4b9ce84af40a7c73c4f1abba017103f02
2017-10-26 11:00:36 -07:00
Nick Alexander
188f0ab668 Bug 1411654 - Part 0: Add rudimentary documentation about Gradle integration. r=maliu
This sketches the flavor dimensions.  The important ones are
`audience` and `geckoBinaries`, which I think simplify the situation
greatly.  Coupled with Bug 1417232 centralizing most everything in
`mobile/android/gradle.configure`, the Gradle configuration shouldn't
be so hard to evolve.

MozReview-Commit-ID: DILjVrnLA3F

--HG--
extra : rebase_source : 311e1b18a2f0ad60b41d574f3c23aa160ecd56c0
2017-11-15 15:02:18 -08:00
Jim Chen
68b13698a1 Bug 1411654 - Pre: Fix CustomTabsSecurityPopup package. r=nalexander
MozReview-Commit-ID: ICTdy9WRlwG

--HG--
extra : rebase_source : 0b53b99f50e4beb91482fe64387a3e84054b1be4
extra : source : 805627e27bc602593349e7386ce79e7b607e153b
2018-01-09 14:59:55 -05:00
Nick Alexander
f75d5ec93a Bug 1411654 - Pre: Remove unused HomeExpandableListView. r=mcomella
This was added for the Remote Tabs panel in Bug 785199.  That code has
now morphed into the combined history panel, which uses a
RecyclerView.

MozReview-Commit-ID: J6KsVCn8mzh

--HG--
extra : rebase_source : b7dcf3130878987b52a7184438f2d5a84002c2ad
2017-11-14 19:32:18 -08:00
Nick Alexander
137c2a9010 Bug 1411654 - Pre: Fix checkstyle whitespace error in GeckoHlsPlayer. r=nalexander
MozReview-Commit-ID: 4h1p4J5B8sM

--HG--
extra : rebase_source : 0ee258440252e8c87ec375a4d09cc5d8ee60a208
2018-01-04 12:26:11 -08:00
Nick Alexander
19e0281afe Bug 1411654 - Pre: Clear icon disk storage in test. r=mcomella
Newer versions of Robolectric seem to have different semantics about
clearing disk caches, so this is necessary.  But for older versions,
it shouldn't hurt, and is slightly more clear than relying on an
implicit clear.

MozReview-Commit-ID: LRcaEPasXj8

--HG--
extra : rebase_source : fee00a6a068d68e7f7978df56bcad94997d70afb
2017-11-07 20:24:04 -08:00
Nick Alexander
edc447f108 Bug 1411654 - Pre: Remove unused PerProfileDatabaseProvider. r=mcomella
No idea what is going on with this hierarchy, but this isn't used and
isn't helping anything.

MozReview-Commit-ID: Ir3LxLYHR6M

--HG--
extra : rebase_source : d5efb14bff510e2a2982085237c53e27b4c7564d
2017-11-07 20:18:56 -08:00
Nick Alexander
e4d79b18b4 Bug 1411654 - Pre: Fix dangling resource. r=mcomella
This is just wrong.

MozReview-Commit-ID: EBtKTD07aNu

--HG--
rename : mobile/android/base/resources/values-v17/themes.xml => mobile/android/app/src/main/res/values-v17/themes.xml
extra : rebase_source : 6390d41a43e2724e81f4c0ae6c3122f487b3f4a4
2017-11-08 09:47:48 -08:00
Nick Alexander
51a8bbecd7 Bug 1411654 - Pre: Teach |mach gradle| to take GRADLE_FLAGS from the command line. r=maliu
MozReview-Commit-ID: 150llND5h0j

--HG--
extra : rebase_source : eaf3b914608f00a919f1ec19c7ac45b13ba71601
2017-10-25 10:22:42 -07:00
Brindusan Cristian
b102ef421c Merge mozilla-central to autoland r=merge a=merge on a CLOSED TREE 2018-01-12 13:32:23 +02:00
Narcis Beleuzu
4de0807d09 Merge inbound to mozilla-central r=merge a=merge 2018-01-12 13:25:57 +02:00
Mike Hommey
bb2afff5c1 Bug 1425381 - Always enable PIE on Android now that we support only >= 4.1. r=froydnj
--HG--
extra : rebase_source : c73d77ab1274b2dd54a3785a6d77c6e8dcb69f87
2018-01-11 10:42:15 +09:00
Eugen Sawin
7661c6a4ed Bug 1429607 - [1.1] Log some relevant settings during geckoview_example startup. r=snorp 2018-01-11 20:44:43 +01:00
Noemi Erli
188184d4dc Merge mozilla-central to autoland. r=merge a=merge CLOSED TREE 2018-01-12 00:04:40 +02:00
Dylan Roeh
eeb2405042 Bug 1429188 - Change close icon in custom tabs to remove mediarouter dependency. r=walkingice 2018-01-09 13:36:26 -06:00
Margareta Eliza Balazs
a331a849a4 Backed out changeset 6d539e4a02bd (bug 1403519) for lint failures on a CLOSED TREE 2018-01-11 22:32:27 +02:00
Nevin Chen
3cae2260a0 Bug 1423587 - PWA with expired security certificate should open in browser. r=maliu
MozReview-Commit-ID: 1XR3OcP2PpY

--HG--
extra : rebase_source : a5604aadde529bedd116b3107a3324a2c9aab635
2018-01-06 18:56:36 +08:00
Dustin J. Mitchell
522245f2f2 Bug 1403519 - only build docs when necessary r=gps
This marks **/docs/** as exclusively docs, and code that is autodoc'd as
inclusively docs.

That means that a change that purely modifies documentation files will *only*
run `docs` tasks, while a change that modifies autodoc'd source code will
*additionaly* run `docs` tasks.  The tasks do not run by default.

MozReview-Commit-ID: G9tOK0AwtrI

--HG--
extra : rebase_source : 8dd971e5c9b0eb5f47895664a4ea49442f303ecb
extra : source : 0881de9b2b5e36ec37cc866f1d4af109da57a919
2017-10-02 18:22:56 +00:00
Jim Chen
258d33e8ca Bug 1427079 - Don't let disposed window be read from parcels; r=snorp
It's possible for parcels derived from the session to outlast the
session lifecycle. This patch makes us return null when trying to
retrieve window objects using stale parcels.

MozReview-Commit-ID: 3Vp6T3uCEBt

--HG--
extra : rebase_source : fceda356bf812d80d81f4e35cbc3f74ad6151d77
2018-01-11 13:45:54 -05:00
Ciure Andrei
f7400ad72e Merge inbound to mozilla-central r=merge a=merge 2018-01-11 11:54:56 +02:00
Ciure Andrei
9bb37dfa63 Backed out changeset b6d240f90874 (bug 1427079) for failing testBookmarklets for the robocop-1 job a=backout 2018-01-11 11:52:41 +02:00
Cameron McCormack
3c49d82e69 Bug 1427419 - Part 27: Remove inIDOMUtils. r=bz
And rename inDOMUtils.cpp to InspectorUtils.cpp.

MozReview-Commit-ID: IIqo25MHsQE

--HG--
rename : layout/inspector/inDOMUtils.cpp => layout/inspector/InspectorUtils.cpp
2018-01-11 12:38:01 +08:00
Cameron McCormack
45c9e50a65 Bug 1427419 - Part 19: Move inIDOMUtils.getChildrenForNode to InspectorUtils. r=bz
MozReview-Commit-ID: 5AznAfpZIuN
2018-01-11 12:38:00 +08:00