Commit Graph

8142 Commits

Author SHA1 Message Date
Jonathan Kew
bc9c7169fe Bug 1641805 - Remove DownloadPDFSaver, no longer needed in a post-Fennec world. r=paolo,mak
Differential Revision: https://phabricator.services.mozilla.com/D84012
2020-07-20 16:10:09 +00:00
Mark Banner
56b100bc3a Bug 1653195 - Update eslint-plugin-mozilla's eslint-visitor-keys to be the same as the top-level include. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D84136
2020-07-20 12:33:56 +00:00
Gerald Squelart
126afc3ab4 Bug 1653181 - Profiler feature 'audiocallbacktracing' controls Start/StopAudioCallbackTracing(), off by default - r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D83749
2020-07-17 11:22:23 +00:00
Gerald Squelart
698881bb66 Bug 1653181 - Refactor Start/StopAudioCallbackTracing calls - r=canaltinova
Start/StopAudioCallbackTracing calls are always around locked_profiler_start/stop, this patch brings these calls inside the locked_ functions.

Differential Revision: https://phabricator.services.mozilla.com/D83748
2020-07-17 11:21:50 +00:00
Mitchell Hentges
ccdcc211eb Bug 1653049: Docs support markdown tables r=championshuttler
Glean generates telemetry documentation in markdown and uses tables.

This revision adds support for rendering markdown tables using an extension.

Differential Revision: https://phabricator.services.mozilla.com/D83685
2020-07-17 17:11:33 +00:00
Gerald Squelart
4c769ee76a Bug 1651102 - Safely delay handling of child profile buffer updates - r=canaltinova
Profile buffer updates could be triggered from a number of locations, including scopes where profiler and/or system locks are held, making deadlocks possible if profiler and/or system function are called.
So instead of dispatching updates to the main thread (which may use OS task queue functions), we fold updates into a static storage. The profiler sampler loop regularly triggers processing of these pending updates.

Differential Revision: https://phabricator.services.mozilla.com/D83747
2020-07-17 11:21:38 +00:00
Gerald Squelart
7ad0136123 Bug 1651102 - Safely delay handling of parent profile buffer updates - r=canaltinova
Profile buffer updates could be triggered from a number of locations, including scopes where profiler and/or system locks are held, making deadlocks possible if profiler and/or system function are called.
So instead of dispatching updates to the main thread (which may use OS task queue functions), we fold updates into a static storage. When child updates arrive, we can safely handle parent updates as well.

Child updates are assumed to arrive regularly enough to properly handle parent updates.
But in the worst case, if no updates came from children, it should mean nothing is happening, and in any case we wouldn't know how the memory is used elsewhere. Note that the chunk manager still enforces local limits automatically, so memory usage would still get limited.

Differential Revision: https://phabricator.services.mozilla.com/D83746
2020-07-17 11:21:15 +00:00
Gerald Squelart
2a75e1761c Bug 1651102 - Remove unused ProfileBufferGlobalController members - r=canaltinova
Differential Revision: https://phabricator.services.mozilla.com/D83745
2020-07-17 11:20:57 +00:00
Gerald Squelart
db28bc0ab0 Bug 1648324 - Add timeout when waiting for child profiles - r=canaltinova
Knowing the time it takes for the parent process to gather its profile, we expect sub-processes not to take longer than twice that time (plus a bit more).
Each time we receive a profile, the timer is restarted* to allow more time for pending processes.
If the most current timer fires, we assume that pending processes may be frozen and unable to ever respond, so we use all profiles gathered so far.
(There is currently no indication to the user that processes are missing, this should be added in the future.)

* Tech detail: We just cancel the current timer and forget about it, then start a new one and keep track of it. When a timer fires, we can compare its address to the address of the last (most current) timer, and only that one can force the end of profile-gathering.

Differential Revision: https://phabricator.services.mozilla.com/D83626
2020-07-16 22:56:57 +00:00
Tomislav Jovanovic
0c81930a84 Bug 1587541 - Make tab.executeScript, insertCSS, removeCSS Fission compatible r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D81772
2020-07-15 14:30:17 +00:00
Randell Jesup
fa153eb95d Bug 1642772: name processes in the profiler with eTLD+1 r=gerald,dveditz
Differential Revision: https://phabricator.services.mozilla.com/D77926
2020-07-15 18:00:54 +00:00
Myeongjun Go
32cbdb3b33 Bug 1649497 - [perfdocs] Port mozperftest into Performance Testing r=sparky,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82207
2020-07-15 17:13:30 +00:00
Emil Farisan
bac22e4499 Bug 1651606 - fix the 404 not found issue when accessing the generated docs link on S3. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D83265
2020-07-15 11:34:04 +00:00
Csoregi Natalia
2d34e224ae Backed out changeset 448679382b06 (bug 1649497) for linting failures on framework_gatherers.py. CLOSED TREE 2020-07-14 20:20:48 +03:00
Myeongjun Go
62777a18b5 Bug 1649497 - [perfdocs] Port mozperftest into Performance Testing r=sparky,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D82207
2020-07-14 16:55:56 +00:00
Andrew Halberstadt
88d8a92a39 Bug 1649194 - [tryselect] Fixup cram test bustage r=marco
Differential Revision: https://phabricator.services.mozilla.com/D83530
2020-07-14 15:47:30 +00:00
Andrew Halberstadt
85ea78dea5 Bug 1649194 - [try] Make 'mach try auto' the default selector (replaces try syntax), r=marco
Try syntax users wishing to preserve their default selector can modify
~/.mozbuild/machrc (create it if it doesn't exist), and add:

[try]
default = syntax

Depends on D82983

Differential Revision: https://phabricator.services.mozilla.com/D82985
2020-07-14 14:44:05 +00:00
Andrew Halberstadt
8bfb464356 Bug 1649194 - [try] Remove 'experimental' warning with |mach try auto|, r=marco
Differential Revision: https://phabricator.services.mozilla.com/D82983
2020-07-10 19:53:26 +00:00
championshuttler
7670b95ed4 Bug 1498604 - Update the message to use mach npm now.r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D83418
2020-07-13 23:12:38 +00:00
Andreea Pavel
6587206412 Backed out changeset 328b97bc228e (bug 1587541) for causing bug 1652665 a=backout DONTBUILD 2020-07-14 11:30:47 +03:00
Dan Mosedale
e9c23bbb90 Bug 1652173 - implement mach node and mach npm, r=nalexander
Differential Revision: https://phabricator.services.mozilla.com/D83204
2020-07-13 21:31:31 +00:00
Tom Prince
1691c9892d Bug 1652184: Report to perherder stats about bugbug timings; r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D83212
2020-07-13 19:53:00 +00:00
Tom Prince
10f35da9c8 Bug 1646834: [scriptworker-canary] Split linux signing tasks to handle partials; r=rail
Since partials have started verifying signatures, the partial task has been failing in
`mach try scriptworker`. Since we are not concerned with the partial task itself,
split the tasks into two groups, so that it does not need to run.

Differential Revision: https://phabricator.services.mozilla.com/D83370
2020-07-13 18:46:51 +00:00
Mark Banner
a5ae60cdd9 Bug 1652130 - Switch the Mozilla eslint parser to use multi-ini. r=mossop
Depends on D83176

Differential Revision: https://phabricator.services.mozilla.com/D83177
2020-07-13 18:05:18 +00:00
Mark Banner
cdec147c98 Bug 1627766 - Add eslint-plugin-html to eslint-plugin-mozilla's package.json. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D83176
2020-07-13 18:03:21 +00:00
Tom Prince
6ba2d68aa3 Bug 1651867: Fix failing mozlint tests. r=ahal
The root fixutre was accidentaly made not a fixture, due to a bad rebase.

Differential Revision: https://phabricator.services.mozilla.com/D83020
2020-07-13 14:37:58 +00:00
Gerald Squelart
8049dc9c3e Bug 1651086 - Allow profiler_register_thread from thread with already-registered id - r=canaltinova
It is possible that some threads fail/forget to unregister themselves, in which case a registered thread id could get recycled by a later thread, which was not allowed before this patch.

Note: The thread name cannot currently be changed. We record a special marker with the new name, so the frontend could process it to split the thread track at that point.

We also record a marker when profiler_unregister_thread is called from an already-unregistered thread, this could help find reg/unreg mismatches or nesting in Firefox threads.

Differential Revision: https://phabricator.services.mozilla.com/D83293
2020-07-13 13:18:29 +00:00
Gerald Squelart
7610ff4326 Bug 1651086 - Handle tgkill failure - r=canaltinova
On Linux (including Android), it was assumed that a registered thread could always be suspended through `tgkill`.
However in some cases a thread may not be correctly unregistered, in which case this would trigger `MOZ_ASSERT` or wait forever in the following loop.

This will especially be needed when `profiler_{,un}register_thread()` are made less strict in the following patch.

Windows and Mac already handle suspension failures.

Differential Revision: https://phabricator.services.mozilla.com/D83292
2020-07-13 13:14:32 +00:00
Tomislav Jovanovic
0d4b27f0d1 Bug 1587541 - Make tab.executeScript, insertCSS, removeCSS Fission compatible r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D81772
2020-07-13 10:28:42 +00:00
Narcis Beleuzu
895e17157a Backed out changeset aeaa527e6119 (bug 1587541) for mochitest failures on test_chrome_ext_contentscript_telemetry.html . CLOSED TREE 2020-07-13 05:28:48 +03:00
Tomislav Jovanovic
d1e60a800a Bug 1587541 - Make tab.executeScript, insertCSS, removeCSS Fission compatible r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D81772
2020-07-13 00:32:43 +00:00
Harry Twyford
e0287bb730 Bug 1645521 - Part 3 - Port unifiedcomplete tests. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D80294
2020-07-12 17:35:02 +00:00
Narcis Beleuzu
8e31f424cf Backed out changeset 60840d7cfef1 (bug 1587541) for Documentation opt failure. CLOSED TREE 2020-07-12 22:46:00 +03:00
Tomislav Jovanovic
17939666b8 Bug 1587541 - Make tab.executeScript, insertCSS, removeCSS Fission compatible r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D81772
2020-07-12 17:11:58 +00:00
Csoregi Natalia
b74c685d0f Backed out 6 changesets (bug 1650099, bug 1647881, bug 1645521, bug 1645324) for causing Bug 1652024.
Backed out changeset f66c5cce9088 (bug 1650099)
Backed out changeset bf67c2159244 (bug 1645324)
Backed out changeset 76d81e1e728b (bug 1645521)
Backed out changeset ab3766fa81f9 (bug 1645521)
Backed out changeset ff56bb6cbfb7 (bug 1645521)
Backed out changeset aceb6f9acf3b (bug 1647881)
2020-07-12 17:58:28 +03:00
Harry Twyford
3ab8f9b1e3 Bug 1645521 - Part 3 - Port unifiedcomplete tests. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D80294
2020-07-09 05:02:47 +00:00
Cosmin Sabou
71bfce5442 Backed out 5 changesets (bug 1650099, bug 1645521, bug 1645324) as requested by harry for causing bug 1652024.
Backed out changeset 93abbd32c314 (bug 1650099)
Backed out changeset 366f7bfe267c (bug 1645324)
Backed out changeset b92a18e970ee (bug 1645521)
Backed out changeset d57d3a47b1ad (bug 1645521)
Backed out changeset 41e4a6353913 (bug 1645521)
2020-07-11 02:03:18 +03:00
Tom Prince
388e735d63 Bug 1649168: Add scriptworker-canary action and corresponding task; r=rail
Add an action that will trigger a task that runs
`mach release push-scriptworker-canary`
to test a new scriptworker deployment.

Differential Revision: https://phabricator.services.mozilla.com/D82821
2020-07-10 16:12:05 +00:00
Tom Prince
6d84883e1d Bug 1649168: Add mach release push-scriptworker-canary command; r=rail
This will make several pushes to try, to test newly deployed scriptworker
versions.

Differential Revision: https://phabricator.services.mozilla.com/D82819
2020-07-10 16:11:00 +00:00
Tom Prince
7ff3369322 Bug 1649168: Allow specifying arbitrary routes for `mach try scriptworker; r=rail
This will be used to notify releng, when failures happen in scriptworker-canary
runs.

Differential Revision: https://phabricator.services.mozilla.com/D82818
2020-07-10 16:10:57 +00:00
Tom Prince
204d796929 Bug 1651731: [lint] Python and shell files without #! should not be executable; r=linter-reviewers,perftest-reviewers,geckoview-reviewers,agi,sylvestre,sparky
Differential Revision: https://phabricator.services.mozilla.com/D82954
2020-07-09 20:29:18 +00:00
Tom Prince
2c52622b85 Bug 1651731: [lint] Add a bunch more types of files that should never be executable; r=linter-reviewers,perftest-reviewers,geckoview-reviewers,preferences-reviewers,agi,sylvestre,sparky
Differential Revision: https://phabricator.services.mozilla.com/D82953
2020-07-09 21:28:49 +00:00
Tom Prince
2244b1cc7c Bug 1651731: [lint] Only allow files that are typically executable to have shebang lines override permission check; r=linter-reviewers,sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D82949
2020-07-09 21:16:32 +00:00
Kris Maglione
a1cb850855 Bug 1464542: Part 3c - Change Services.jsm to use the C++-implemented services cache. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D81420
2020-07-09 21:42:53 +00:00
Kris Maglione
6a39211860 Bug 1464542: Part 3b - Add existing Services.jsm registrations to the new services cache. r=mccr8,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D81419
2020-07-09 21:42:25 +00:00
Csoregi Natalia
b355fcc4bf Backed out 6 changesets (bug 1464542) for xpcshell failures on test_Services.js. CLOSED TREE
Backed out changeset b50af9005851 (bug 1464542)
Backed out changeset 9d3a0ea2cf65 (bug 1464542)
Backed out changeset 71c3475fcbc2 (bug 1464542)
Backed out changeset 51ff93220a95 (bug 1464542)
Backed out changeset e84de1547c09 (bug 1464542)
Backed out changeset bbecc16d08eb (bug 1464542)
2020-07-09 23:19:26 +03:00
Axel Hecht
595a699c3e Bug 1649441, port ICU update docs into firefox-source-docs, r=jwalden
This is just a copy via pandoc, and some minor fixups. No actual
content changes, aside of linter fixes.

Differential Revision: https://phabricator.services.mozilla.com/D81703
2020-07-07 11:24:08 +00:00
Harry Twyford
2830a9e611 Bug 1645521 - Part 3 - Port unifiedcomplete tests. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D80294
2020-07-09 05:02:47 +00:00
Kris Maglione
d0524196c2 Bug 1464542: Temporarily remove user-services.js test to fix bustage.
Differential Revision: https://phabricator.services.mozilla.com/D82972
2020-07-09 18:44:49 +00:00
Sylvestre Ledru
711e975c18 Bug 1650834 - mozlint/pylint - remove useless code r=marco
Differential Revision: https://phabricator.services.mozilla.com/D82490
2020-07-09 14:09:49 +00:00