Commit Graph

3611 Commits

Author SHA1 Message Date
Cristian Tuns
98a512a1b6 Backed out 2 changesets (bug 1745650) for causing mochitest failures on browser_slow_download.js CLOSED TREE
Backed out changeset 7f7864031ae3 (bug 1745650)
Backed out changeset 23081f3b923f (bug 1745650)
2022-01-07 08:07:51 -05:00
lyavor
8b1cb2caad Bug 1745650 - If a download upgrades to https via httpsFirst-/httpsOnly - mode it fails. r=ckerschb,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D133882
2022-01-07 12:18:32 +00:00
Katherine Patenio
024fdf5a8d Bug 1741431 - fix Save Link As... for plain text files when download improvements pref is enabled r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D134477
2022-01-06 04:09:50 +00:00
Csoregi Natalia
2f0f82ae58 Backed out 2 changesets (bug 1745650) for failures on browser_slow_download.js. CLOSED TREE
Backed out changeset f94ea51101a1 (bug 1745650)
Backed out changeset dd8809f8bb92 (bug 1745650)
2022-01-03 20:24:32 +02:00
lyavor
1f39d39c47 Bug 1745650 - If a download upgrades to https via httpsFirst-/httpsOnly - mode it fails. r=ckerschb,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D133882
2022-01-03 17:25:45 +00:00
Masatoshi Kimura
d239dee2d2 Bug 1680139 - Stop re-escaping IDN blocklisted characters in uriloader/exthandler/. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D134656
2021-12-30 20:59:12 +00:00
Narcis Beleuzu
a18766749b Backed out changeset fbeb948af56d (bug 1680139) for bc failures browser_download_open_with_internal_handler.js 2021-12-30 20:17:25 +02:00
Masatoshi Kimura
04fd3c299a Bug 1680139 - Stop re-escaping IDN blocklisted characters in uriloader/exthandler/. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D134656
2021-12-30 17:32:05 +00:00
Mike Hommey
fce6eb7d83 Bug 1747165 - Replace TK_FLAGS/TK_LIBS with MOZ_GTK3_FLAGS/MOZ_GTK3_LIBS. r=firefox-build-system-reviewers,andi
Differential Revision: https://phabricator.services.mozilla.com/D134464
2021-12-23 20:29:07 +00:00
Kagami Sascha Rosylight
1af44698e9 Bug 1539884 - Part 33: Mark nsDocLoader::DocLoaderIsEmpty as CAN_RUN_SCRIPT r=masayuki
Differential Revision: https://phabricator.services.mozilla.com/D134416
2021-12-23 16:27:25 +00:00
Cristian Tuns
e1e31e01f2 Backed out 2 changesets (bug 1747165) for causing nightly blockers(bustages) a=backout
Backed out changeset 4b1ab0915c94 (bug 1747165)
Backed out changeset 96043d814772 (bug 1747165)
2021-12-23 08:00:54 -05:00
Mike Hommey
b55194a16f Bug 1747165 - Replace TK_FLAGS/TK_LIBS with MOZ_GTK3_FLAGS/MOZ_GTK3_LIBS. r=firefox-build-system-reviewers,andi
Differential Revision: https://phabricator.services.mozilla.com/D134464
2021-12-22 23:56:24 +00:00
Sam Foster
57b6662c96 Bug 1738916 - when users want asking where to save files, do not ask for files automatically opened with helper applications, r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D133957
2021-12-21 22:20:26 +00:00
Butkovits Atila
f34d31e093 Backed out changeset 00c6ddc131a4 (bug 1738916) for causing failures at browser_default_audio_filename.js . CLOSED TREE 2021-12-21 15:48:12 +02:00
Sam Foster
b002b9f187 Bug 1738916 - when users want asking where to save files, do not ask for files automatically opened with helper applications, r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D133957
2021-12-21 12:48:04 +00:00
Anny Gakhokidze
a4eca0ad6f Bug 1721217 - Part 6: Don't cancel concurrent loads if they are downloads, r=nika,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D126846
2021-12-16 22:27:17 +00:00
Anny Gakhokidze
e287016843 Bug 1721217 - Part 3: Fix tests that try to open URIs for download, r=nika,preferences-reviewers
Previously, the tests were waiting for the load event, which was being emitted
for the initial about:blank. With the pref enabled, this event is no longer
propagated/fired to the content process. Instead of notifying the content
process that it needs to emit a load event for about:blank, we can instead make
the tests wait for a STATE_STOP event.

Differential Revision: https://phabricator.services.mozilla.com/D126843
2021-12-16 22:27:16 +00:00
Peter Van der Beken
a33a4db25e Bug 1744397 - Simplify refresh code: pass around delay as an unsigned int. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D132863
2021-12-16 22:27:08 +00:00
Norisz Fay
333caceb64 Backed out 5 changesets (bug 1742865, bug 1744397) for causing wpt failures on attr-meta-http-equiv-refresh/parsing.html CLOSED TREE
Backed out changeset 7b01edc5a0e0 (bug 1744397)
Backed out changeset 41abd4b7d2c0 (bug 1744397)
Backed out changeset 634641e3a05a (bug 1744397)
Backed out changeset 6e7755177481 (bug 1744397)
Backed out changeset e9fc94b33da9 (bug 1742865)
2021-12-14 13:25:58 +02:00
Peter Van der Beken
bfbe9b27fe Bug 1744397 - Simplify refresh code: pass around delay as an unsigned int. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D132863
2021-12-14 10:14:00 +00:00
Bernard Igiri
a34452e314 Bug 1733621 - Verify that user preferences are honored when improvements_to_download_panel is set r=Gijs
Added unit tests to verify that various file types and header configurations follow the mime preferredAction settings correctly when improvements_to_download_panel is set.

Differential Revision: https://phabricator.services.mozilla.com/D127759
2021-12-09 14:47:17 +00:00
Nick Alexander
02dda268a6 Bug 1742879 - Let Cu.createCommandLine accept arguments and state. r=nika
There's a lot of history in this area that mostly explains why this
has not been supported in the past, leading to several awkward
workarounds in tests.  But it doesn't appear that there's any reason
to prevent tests from creating actual command lines, so that's what we
allow here.

I've elected to flesh out `Cu.createCommandLine` rather than expose
`.init(..._)` directly since `Cu.createCommandLine` is already used in
the relevant tests and is only used in tests.  And I've made the
arguments required, rather than optional, so that consumers think
about the arguments, in particular `state`.

Differential Revision: https://phabricator.services.mozilla.com/D132089
2021-12-02 19:06:44 +00:00
Noemi Erli
4aa2f8759e Backed out 2 changesets (bug 1742879) for causing build bustage in nsDebug.h CLOSED TREE
Backed out changeset 994d0986757c (bug 1742879)
Backed out changeset d4b8e45faaec (bug 1742879)
2021-12-02 09:34:25 +02:00
Nick Alexander
a8c4c5c97b Bug 1742879 - Let Cu.createCommandLine accept arguments and state. r=nika
There's a lot of history in this area that mostly explains why this
has not been supported in the past, leading to several awkward
workarounds in tests.  But it doesn't appear that there's any reason
to prevent tests from creating actual command lines, so that's what we
allow here.

I've elected to flesh out `Cu.createCommandLine` rather than expose
`.init(..._)` directly since `Cu.createCommandLine` is already used in
the relevant tests and is only used in tests.  And I've made the
arguments required, rather than optional, so that consumers think
about the arguments, in particular `state`.

Differential Revision: https://phabricator.services.mozilla.com/D132089
2021-12-02 04:02:07 +00:00
Gijs Kruitbosch
e36840652c Bug 1705211, r=nika,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D131856
2021-12-01 12:36:07 +00:00
Chris Peterson
f6fdbf028a Bug 1738401 - Remove -Wno-shadow warning suppressions. r=firefox-build-system-reviewers,glandium
-Wshadow warnings are not enabled globally, so these -Wno-shadow suppressions have no effect. I had intended to enable -Wshadow globally along with these suppressions in some directories (in bug 1272513), but that was blocked by other issues.

There are too many -Wshadow warnings (now over 2000) to realistically fix them all. We should remove all these unnecessary -Wno-shadow flags cluttering many moz.build files.

Differential Revision: https://phabricator.services.mozilla.com/D132289
2021-12-01 06:40:04 +00:00
Narcis Beleuzu
4c87b2e488 Backed out 12 changesets (bug 1721217) for bc failures on browser_TopLevelNavigationDelegate.js
Backed out changeset 5fe3c617d521 (bug 1721217)
Backed out changeset c131e4a6d9d5 (bug 1721217)
Backed out changeset a59210a5b400 (bug 1721217)
Backed out changeset 74362b0c39c0 (bug 1721217)
Backed out changeset c8075b91d660 (bug 1721217)
Backed out changeset 46512deaf0e5 (bug 1721217)
Backed out changeset b38bc569d227 (bug 1721217)
Backed out changeset ee9bd012fda8 (bug 1721217)
Backed out changeset 7aa2726a0982 (bug 1721217)
Backed out changeset 885ced5f4bb4 (bug 1721217)
Backed out changeset 7d3f99ca3f44 (bug 1721217)
Backed out changeset 2f5a0164679a (bug 1721217)
2021-12-01 03:38:10 +02:00
Marian-Vasile Laza
74bbbc347e Backed out changeset 9c044551012e (bug 1705211) for causing bc test failures on browser_protocol_ask_dialog_external.js. CLOSED TREE 2021-12-01 03:09:59 +02:00
Gijs Kruitbosch
9ec163c376 Bug 1705211, r=nika,ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D131856
2021-11-30 23:38:57 +00:00
Anny Gakhokidze
48e144a44c Bug 1721217 - Part 6: Don't cancel concurrent loads if they are downloads, r=nika,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D126846
2021-11-30 16:31:36 +00:00
Anny Gakhokidze
dd2f9d54f7 Bug 1721217 - Part 3: Fix tests that try to open URIs for download, r=nika,preferences-reviewers
Previously, the tests were waiting for the load event, which was being emitted
for the initial about:blank. With the pref enabled, this event is no longer
propagated/fired to the content process. Instead of notifying the content
process that it needs to emit a load event for about:blank, we can instead make
the tests wait for a STATE_STOP event.

Differential Revision: https://phabricator.services.mozilla.com/D126843
2021-11-30 16:31:35 +00:00
Micah Tigley
0732a24662 Bug 1739145 - Create the DownloadSpamProtection module when needed. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D132178
2021-11-26 22:58:01 +00:00
Butkovits Atila
997b16c37a Backed out changeset 0b1c2e4169ab (bug 1739145) for causing failures at browser_download_spam_protection.js. CLOSED TREE 2021-11-26 19:10:38 +02:00
Micah Tigley
5840184c47 Bug 1739145 - Create the DownloadSpamProtection module when needed. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D132178
2021-11-26 16:35:11 +00:00
Narcis Beleuzu
a322582a00 Backed out 11 changesets (bug 1721217) for bc failures on browser_scrollPositions.js . CLOSED TREE
Backed out changeset 750f4a84b30e (bug 1721217)
Backed out changeset c4eb4ad769ad (bug 1721217)
Backed out changeset 81af11d67439 (bug 1721217)
Backed out changeset 548f2441b7c6 (bug 1721217)
Backed out changeset cd584129321a (bug 1721217)
Backed out changeset f5f5291d1da8 (bug 1721217)
Backed out changeset 9ad66ceec1e2 (bug 1721217)
Backed out changeset 10b53a21bb23 (bug 1721217)
Backed out changeset 3755cfbe22fe (bug 1721217)
Backed out changeset 71436dc6c4c4 (bug 1721217)
Backed out changeset ecf33b73ae60 (bug 1721217)
2021-11-26 01:51:03 +02:00
Anny Gakhokidze
600c61e9f6 Bug 1721217 - Part 6: Don't cancel concurrent loads if they are downloads, r=nika,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D126846
2021-11-25 20:40:58 +00:00
Anny Gakhokidze
eb4cd509d5 Bug 1721217 - Part 3: Fix tests that try to open URIs for download, r=nika,preferences-reviewers
Previously, the tests were waiting for the load event, which was being emitted
for the initial about:blank. With the pref enabled, this event is no longer
propagated/fired to the content process. Instead of notifying the content
process that it needs to emit a load event for about:blank, we can instead make
the tests wait for a STATE_STOP event.

Differential Revision: https://phabricator.services.mozilla.com/D126843
2021-11-25 20:40:57 +00:00
Neil Deakin
cc92684988 Bug 1742823, handle pdf in this test when improvements pref is either on or off, r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D132044
2021-11-24 20:13:20 +00:00
ssummar
b9d6fce436 Bug 1530209 - Removed context argument from various methods. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D129797
2021-11-24 11:25:41 +00:00
Ava Katushka ava8katushka
0acad0b8d2 Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D123943
2021-11-23 17:13:39 +00:00
Micah Tigley
664bf584e2 Bug 1740142 - Rename LaunchWithApplication to SetDownloadToLaunch. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D131714
2021-11-23 16:18:50 +00:00
Narcis Beleuzu
9275af0574 Bug 1719892 - Fix lint failure on browser_shows_where_to_save_dialog.js. a=lint-fix CLOSED TREE 2021-11-23 18:16:25 +02:00
Marian-Vasile Laza
efc39e6017 Bug 1719892 - lint fix r=fix 2021-11-23 17:18:38 +02:00
Neil Deakin
a2e1f72f45 Bug 1719892, when pdfs are set to open internally, open downloads or responses marked as content-disposition: attachment directly using the pdf viewer instead of downloading them locally first, r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D131004
2021-11-23 14:56:17 +00:00
Neil Deakin
02e36bd84b Bug 1719892, have some download tests use svg instead of pdf as otherwise the pdf viewer will open instead of downloading, r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D131003
2021-11-23 14:56:17 +00:00
Neil Deakin
639f4e1dc0 Bug 1719892, copy mime handler action over to child process properly, r=nika
Differential Revision: https://phabricator.services.mozilla.com/D131001
2021-11-23 14:56:16 +00:00
Neil Deakin
d880340507 Bug 1737696, skip spam check for downloads that were saved; this allows the save link context menu item to work properly, r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D130999
2021-11-20 12:45:28 +00:00
Katherine Patenio
cf8aa80ecf Bug 1736924 - create one-time migration for alwaysAsk mimetype prefs to saveToDisk if downloads improvements pref is enabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D130136
2021-11-17 23:31:24 +00:00
Katherine Patenio
35d7e08ca3 Bug 1738129 - fix Save Link As... for PDF files to show save dialog with downloads improvements pref enabled. r=Gijs,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D131310
2021-11-17 18:35:44 +00:00
Andi-Bogdan Postelnicu
1faa3d40cf Bug 1519636 - Reformat recent changes to the Google coding style. r=firefox-build-system-reviewers,mhentges,sylvestre
Reformat with clang-format version 12.0.1 (taskcluster-FYV2l5wGTseBAhiqf8cxfQ)

Differential Revision: https://phabricator.services.mozilla.com/D131114
2021-11-16 08:07:29 +00:00