Commit Graph

80 Commits

Author SHA1 Message Date
Kartikaya Gupta
db517f8f24 Bug 716673 - Split out the Axis class from the PanZoomController. r=pcwalton 2012-01-10 10:06:08 -05:00
Kartikaya Gupta
4db2ca3cad Bug 716673 - Split out a SubdocumentScrollHelper from the PanZoomController. r=pcwalton 2012-01-10 10:06:05 -05:00
Kartikaya Gupta
c7f1933c6f Bug 716673 - Encapsulate the fling state in Axis. r=pcwalton 2012-01-10 10:06:03 -05:00
Kartikaya Gupta
a807c16fe2 Bug 716673 - Encapsulate the velocity, locked, and disableSnap variables in Axis. r=pcwalton 2012-01-10 10:06:01 -05:00
Kartikaya Gupta
779c978c29 Bug 716673 - Use the locked velocity instead of unlocked velocity in a couple of places. r=pcwalton 2012-01-10 10:05:59 -05:00
Kartikaya Gupta
7f58eba51b Bug 716673 - Fix up the advanceFling() step. r=pcwalton
- Refactor the code a little to ensure we don't do any flinging
  if the panning is being overridden.
- Collapse duplicated/inconsistent code in the fling-termination
  conditions so that it makes sense now.
2012-01-10 10:05:57 -05:00
Kartikaya Gupta
cb0894c39b Bug 716673 - Collapse unused WAITING_TO_SNAP and SNAPPING flingstates into STOPPED. r=pcwalton 2012-01-10 10:05:55 -05:00
Kartikaya Gupta
45e0c4fb28 Bug 716673 - Completely encapsulate Axis variables lastTouchPos and touchPos. r=pcwalton 2012-01-10 10:05:53 -05:00
Kartikaya Gupta
0c3774c55e Bug 716673 - Completely encapsulate Axis variable firstTouchPos. r=pcwalton 2012-01-10 10:05:51 -05:00
Kartikaya Gupta
889037cae5 Bug 716673 - Refactor some more duplicated code from the track() functions. r=pcwalton 2012-01-10 10:05:49 -05:00
Kartikaya Gupta
4a33731d51 Bug 716673 - Refactor some repeated code into a startTouch method. r=pcwalton 2012-01-10 10:05:48 -05:00
Kartikaya Gupta
bfaab2e6a1 Bug 716673 - Misc cleanups in PanZoomController. r=pcwalton
- Remove unused imports.
- Move all class variables together, and make some final.
- Fix up some comments.
- Remove unused methods.
- Remove some dead code
- Move some functions around so they are grouped based on behaviour.
2012-01-10 10:05:46 -05:00
Kartikaya Gupta
6d25567591 Bug 716673 - Remove some dead code. r=pcwalton
Events that come in for the non-primary pointer are ACTION_POINTER_DOWN
rather than ACTION_DOWN, so this code will never get exercised.
2012-01-10 10:05:43 -05:00
Kartikaya Gupta
33da0d74c0 Bug 716673 - Refactor some code that sends messages to Gecko. r=pcwalton 2012-01-10 10:05:42 -05:00
Kartikaya Gupta
27e3a608b8 Bug 716673 - Remove unnecessary finalize() function. r=pcwalton
The finalize will never be called because GeckoAppShell holds
on to the PZC (as a GeckoEventListener) thereby preventing it
from ever getting GC'd.
2012-01-10 10:05:40 -05:00
Chris Peterson
a4d87cd62d Bug 714874 - Fix Java warnings about redundant casts. r=pcwalton r=dougt a=dougt 2012-01-06 12:21:49 -08:00
Chris Peterson
043eb9f603 Bug 714874 - Fix some Java warnings. r=dougt a=dougt 2012-01-05 10:49:33 -08:00
Kartikaya Gupta
5355c82048 Bug 715164 - Guard against another race condition in PZC. r=pcwalton 2012-01-05 18:13:25 -08:00
Kartikaya Gupta
f37b760178 Bug 715011 - Ensure that panning of subwindows can still happen while the top window is locked on one or both axes. r=Cwiiis 2012-01-04 13:25:11 -05:00
Patrick Walton
2c44c1df90 Bug 709492 - Part 3: Tie viewport updates to drawing to avoid page transition flicker. r=kats 2012-01-03 22:55:04 -08:00
Mark Finkle
cce1d95b44 Bug 714711 - A few unused local variables in PanZoomController.onScaleEnd [r=kats] 2012-01-03 12:19:49 -05:00
Kartikaya Gupta
caaac783fd Bug 713586 - Robustify against undetected race conditions. r=pcwalton
The exception in bug 713586 can only occur if there are race conditions
in the PanZoomController that we haven't fixed yet. Until the race conditions
are fixed, we can robustify the code from dying horribly by making
the bounce-related variables local to the BounceRunnable, so that
different BounceRunnables running concurrently don't interfere with each
other.
2012-01-02 19:06:49 -05:00
Patrick Walton
c57479bcc5 Backed out bug 709492 due to breakage with external urls. r=backout 2011-12-30 18:47:06 -05:00
Kartikaya Gupta
03f0854162 Bug 713729 - Ensure that a fling is in progress when doing velocity-based fling adjustments. r=pcwalton 2011-12-29 22:29:16 -05:00
Patrick Walton
d02d8fac81 Bug 709492 - Part 4: Hide the page when navigating, and expose it when the new page appears. r=kats 2011-12-29 15:10:30 -08:00
Kartikaya Gupta
45b0983cd1 Bug 712386 - Limit how much zoom can be applied. r=Cwiiis 2011-12-27 00:56:57 -05:00
Geoff Lankow
84b1787268 Backed out 3 changesets (bug 710297, bug 712386, bug 712761) for perma-orange on Android native m1 and m2
Backed out changeset 3b1e6033d3ff (bug 712761)
Backed out changeset bb41941cdf9d (bug 710297)
Backed out changeset d4f9960e286a (bug 712386)
2011-12-28 01:00:02 +13:00
Margaret Leibovic
5bfe949de1 Bug 711216 - Form autocomplete popup doesn't disappear when input gets out of view after pinch zoom [r=mfinkle] 2011-12-21 17:03:21 -08:00
Kartikaya Gupta
954005ec2a Bug 712386 - Limit how much zoom can be applied. r=Cwiiis 2011-12-27 00:56:57 -05:00
Kartikaya Gupta
41bc5109b2 Bug 711453 - Fix infinite zoom scale. r=pcwalton 2011-12-20 17:15:09 -05:00
Kartikaya Gupta
6d82dbf388 Bug 709817 - Don't clobber mState if animations are aborted. r=pcwalton
Ensure that if the animation is aborted by changing the value of
mState (such as if we get an onTouchStart and set the mState to
TOUCHING), then we don't clobber it and set it back to NOTHING.
Only set it back to NOTHING when the animation finishes normally.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
cc417ad0e7 Bug 709817 - Ensure PZC is always accessed on the UI thread. r=pcwalton
Ensure that all public functions in PZC are always called from
the UI thread, so that internal variables are not mutated on
different threads. I also made animatedZoomTo private so that
it can't be inadvertently called from a non-UI thread outside
the class.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
3114ee3c37 Bug 709817 - (Cleanup) Replace geometryChanged() with abortAnimation() and remove dead calls. r=pcwalton
Since the geometryChanged function does nothing if the parameter passed
in is false, better to rename the function to be more indicative of
what it actually does, and remove all the resulting dead code.
2011-12-20 16:53:39 -05:00
Kartikaya Gupta
f54e1685bd Bug 712037 - Add lots of logging to help diagnose viewport issues. r=Cwiiis 2011-12-19 22:32:41 -05:00
Kartikaya Gupta
688ba96c8d Bug 711232 - Avoid unnecessary bounce animations. r=pcwalton 2011-12-16 17:01:02 -05:00
Kartikaya Gupta
9ab8826a15 Bug 711453 - Avoid potentially corrupting the fling velocity. r=pcwalton 2011-12-19 09:26:41 -05:00
Doug Turner
944da30fea Backout of 9d027bf631d3 2011-12-17 21:52:54 -08:00
Kartikaya Gupta
4a884dba9a Bug 711232 - Avoid unnecessary bounce animations. r=pcwalton 2011-12-16 17:01:02 -05:00
Patrick Walton
f6866f0ce1 Bug 710119 - Use a low friction for long flings and a high friction for short ones. r=Cwiiis 2011-12-15 12:04:49 -08:00
Kartikaya Gupta
5a96405374 Bug 708893 - Allow panning after releasing pinch zoom finger. r=pcwalton 2011-12-15 14:50:04 -05:00
Kartikaya Gupta
0fd6d2a2bc Bug 710393 - Stop using Math.copySign which doesn't exist on Froyo. r=Cwiiis a=ehsan 2011-12-14 16:57:29 -05:00
Sriram Ramasubramanian
172c1f9c60 Bug 695444 - Form history autocomplete. r=mfinkle a=android-only 2011-12-06 16:44:08 -08:00
Patrick Walton
a6ee503da0 Bug 710096 - Hold the monitor on the layer controller when adjusting and rendering the viewport metrics. r=Cwiiis a=java-only 2011-12-13 14:43:08 -08:00
Doug Turner
c03f186609 Bug 709595 - Add a name for each java thread and timer to aide with debugging. r=blassey
--HG--
extra : rebase_source : 1f5472ef5301739425b162d5ce4b28a577daf0fb
2011-12-12 16:27:35 +08:00
Chris Lord
51e3c16d50 Bug 705092 - Kinetic scrolling is too slow. r=pcwalton a=java-only
This introduces a friction factor, so that the deceleration is relative to
the current velocity. Now, the faster you scroll, the slower the view
decelerates, allowing you to page through longer pages easier.
2011-12-12 18:56:15 +00:00
Kartikaya Gupta
6f7f212151 Bug 704738 - Resize page content on device rotation. r=Cwiiis a=java-only
Some cleanup: ensure we abort and re-bounce the viewport
if the device is rotated during a double-tap zoom. Also
rename variables to be more appropriate
2011-12-12 11:22:34 -05:00
Kartikaya Gupta
b1ca40ea1a Bug 708683 - Fix NaN viewport values. r=pcwalton
The zero page width and height values were
causing the zoom scale to go to Infinity, introducing
all sorts of badness in the viewport values.
2011-12-09 22:57:57 -05:00
Mark Finkle
1889190bef Backout 03ed6af51318, c65be44ac489, 0ce8da61c6cc, bcc015450e7a because of mochitest failures r=mfinkle a=mfinkle 2011-12-12 09:02:01 -05:00
Doug Turner
73940d0817 Bug 709595 - Add a name for each java thread and timer to aide with debugging. r=blassey
--HG--
extra : rebase_source : 552494a1086e706109296ca4c503c1d75796d852
2011-12-12 16:27:35 +08:00
Patrick Walton
891ca8a49d Bug 708947 - Repair overscroll resistance, and add overscroll resistance when zooming. r=kats 2011-12-09 12:06:15 -08:00