Commit Graph

7856 Commits

Author SHA1 Message Date
Andi-Bogdan Postelnicu
dce3119e29 Bug 1650335 - for clang-tidy based analysis do not set cpp std option. r=marco
Differential Revision: https://phabricator.services.mozilla.com/D151101
2022-07-06 08:15:33 +00:00
Narcis Beleuzu
ea20959e2d Backed out 1 changesets (bug 1773520) for breaking the ./mach ide vscode
Backed out changeset d9571dde686f (bug 1773520)
2022-07-01 09:32:36 +03:00
Iulian Moraru
eaae7245b9 Backed out 3 changesets (bug 1762571) for causing xpcshell failures on test_trr_httpssvc_wrap.js. CLOSED TREE
Backed out changeset 9e6eb444acb4 (bug 1762571)
Backed out changeset f24051722cee (bug 1762571)
Backed out changeset 0ead2f6d0582 (bug 1762571)
2022-06-30 18:43:06 +03:00
Mark Banner
72f5384587 Bug 1762571 - Upgrade NodeJS to v12 for the build system and v16 for tests. r=firefox-build-system-reviewers,glandium
Differential Revision: https://phabricator.services.mozilla.com/D147173
2022-06-30 13:23:24 +00:00
Gabriele Svelto
af54b91951 Bug 1776195 - Do not install watchman on openSUSE anymore because it's often broken r=andi
Differential Revision: https://phabricator.services.mozilla.com/D150110
2022-06-30 12:41:31 +00:00
Gijs Kruitbosch
e5852b6d8d Bug 1773520 - add vscode build backend by default if vscode is installed, r=firefox-build-system-reviewers,nalexander,glandium
Differential Revision: https://phabricator.services.mozilla.com/D150147
2022-06-30 08:38:02 +00:00
Alessio Placitelli
9fa5e395be Bug 1776219 - Gracefully handle psutils failures in mach telemetry. r=firefox-build-system-reviewers,ahochheiden
On OpenBSD/i386, psutils fails in the generator used to enumerate the
active processes, breaking the build.

Differential Revision: https://phabricator.services.mozilla.com/D150462
2022-06-29 09:03:28 +00:00
Ryan VanderMeulen
f9c1827b88 Bug 1776461 - Don't define the WIN32 and _WIN32_IE macros in mozilla-config.h if they're already defined. r=firefox-build-system-reviewers,ahochheiden
Differential Revision: https://phabricator.services.mozilla.com/D150268
2022-06-28 18:56:34 +00:00
Tom Ritter
8a1bfc40d7 Bug 1772198 - Add a new filetype lint job r=linter-reviewers,ahal
Depends on D149309

Differential Revision: https://phabricator.services.mozilla.com/D149306
2022-06-24 20:07:07 +00:00
Tom Ritter
a88546bae0 Bug 1772198 - Only require an origin revision if the vendoring section is present r=jewilde
Depends on D149308

Differential Revision: https://phabricator.services.mozilla.com/D149309
2022-06-24 20:07:07 +00:00
Gabriele Svelto
5778d59b9a Bug 1776184 - Handle Debian unstable when installing watchman during bootstrap r=andi
Differential Revision: https://phabricator.services.mozilla.com/D150233
2022-06-24 19:51:12 +00:00
Ryan VanderMeulen
b667d62420 Bug 1776344 - Properly strip newlines when reading path files. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D150257
2022-06-24 18:34:58 +00:00
Gabriele Svelto
7ad6cca012 Bug 1774298 - Install watchman only on Debian 11+ r=andi
Differential Revision: https://phabricator.services.mozilla.com/D149358
2022-06-22 10:08:23 +00:00
Mike Hommey
0985192f22 Bug 1760484 - Add webrtc configs for arm64 openbsd. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D149473
2022-06-21 20:03:56 +00:00
Mike Hommey
9b1024c681 Bug 1738845 - Add webrtc configs for arm and ppc64 linux. r=mjf
Adding arm alone breaks ppc64el.

Differential Revision: https://phabricator.services.mozilla.com/D134738
2022-06-21 20:03:56 +00:00
Mike Hommey
0317120cba Bug 1738845 - Add some missing combinations of conditions to GN processing. r=firefox-build-system-reviewers,andi
Ideally, the code would handle things in a more general way that doesn't
require manually dealing with these lists, but this would require more
testing than there is time left before 102 releases.

While here, remove HOST_CPU_ARCH, which is always the same and thus
never appears in a condition.

This changes none of the generated moz.builds for the current
configuration (but changes the outcome when adding new configurations)

Differential Revision: https://phabricator.services.mozilla.com/D149850
2022-06-21 20:03:55 +00:00
Mike Hommey
14fe89a8ed Bug 1775183 - Remove fork_interpose.py. r=firefox-build-system-reviewers,nalexander
Its use was removed in bug 1720591.

Differential Revision: https://phabricator.services.mozilla.com/D149840
2022-06-21 06:44:55 +00:00
Mike Hommey
602a4659ca Bug 1773223 - Remove now irrelevant gn processor tests.
Differential Revision: https://phabricator.services.mozilla.com/D149814
2022-06-21 02:30:46 +00:00
Mike Hommey
ff501ba00a Bug 1773223 - Filter-out _FORTIFY_SOURCE in GN processing. r=firefox-build-system-reviewers,andi
This is redundant with the build system setting it in
toolchain.configure.

Differential Revision: https://phabricator.services.mozilla.com/D149471
2022-06-21 02:30:46 +00:00
Mike Hommey
6bf54e3307 Bug 1773223 - Make the definition of MOZ_X11 independent of the OS. r=firefox-build-system-reviewers,ahochheiden
Differential Revision: https://phabricator.services.mozilla.com/D149474
2022-06-21 02:30:45 +00:00
Mike Hommey
217bd35159 Bug 1773223 - Make the GN processor an independent script. r=firefox-build-system-reviewers,mjf,ahochheiden
The way the processor works currently is that it relies on two different
build backends, one of which produces json files for specific
configurations, and the other which produces moz.build files from the
aggregate of all those configs.

Each of these json files is huge, and we actually don't have enough to
support all the platforms we're supposed to be supporting. Adding more
files is not enticing.

Now that we've made the first step described above work in a single pass
on a single machine (as opposed to multiple passes on multiple machines
previously), we can actually merge both steps and avoid producing the
intermediate json files altogether. This will allow to add more
configurations without having to worry about the weight of those files.

And because this all doesn't need to depend on having the first step
hooked up in the build system, we make the whole an independent script
rather than a build backend.

Differential Revision: https://phabricator.services.mozilla.com/D149210
2022-06-21 02:30:37 +00:00
Ryan VanderMeulen
78ab363cf5 Bug 1738054 - Remove obsolete "skip-if = python == 2" keys from testing manifests and re-enable some skipped tests which now pass. r=ahochheiden
Differential Revision: https://phabricator.services.mozilla.com/D149573
2022-06-21 01:46:44 +00:00
smolnar
feea9954b2 Backed out 6 changesets (bug 1738845, bug 1773223, bug 1760484) for causing multiple failures CLOSED TREE
Backed out changeset e759ac4fb646 (bug 1773223)
Backed out changeset 20c541be9a37 (bug 1760484)
Backed out changeset 653d2024a187 (bug 1738845)
Backed out changeset fd9540114bfd (bug 1773223)
Backed out changeset f24f3dfa49aa (bug 1773223)
Backed out changeset 11f3375a4a70 (bug 1773223)
2022-06-21 03:00:53 +03:00
Mike Hommey
7451720a4e Bug 1773223 - Remove now irrelevant gn processor tests.
Differential Revision: https://phabricator.services.mozilla.com/D149814
2022-06-20 22:04:22 +00:00
Mike Hommey
854b9ec966 Bug 1760484 - Add webrtc configs for arm64 openbsd. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D149473
2022-06-20 22:04:22 +00:00
Mike Hommey
0146508375 Bug 1738845 - Add webrtc configs for arm and ppc64 linux. r=mjf
Adding arm alone breaks ppc64el.

Differential Revision: https://phabricator.services.mozilla.com/D134738
2022-06-20 22:04:21 +00:00
Mike Hommey
1bec54f814 Bug 1773223 - Filter-out _FORTIFY_SOURCE in GN processing. r=firefox-build-system-reviewers,andi
This is redundant with the build system setting it in
toolchain.configure.

Differential Revision: https://phabricator.services.mozilla.com/D149471
2022-06-20 22:04:20 +00:00
Mike Hommey
ca6dabc47f Bug 1773223 - Make the definition of MOZ_X11 independent of the OS. r=firefox-build-system-reviewers,ahochheiden
Differential Revision: https://phabricator.services.mozilla.com/D149474
2022-06-20 22:04:20 +00:00
Mike Hommey
9b835365cc Bug 1773223 - Make the GN processor an independent script. r=firefox-build-system-reviewers,mjf,ahochheiden
The way the processor works currently is that it relies on two different
build backends, one of which produces json files for specific
configurations, and the other which produces moz.build files from the
aggregate of all those configs.

Each of these json files is huge, and we actually don't have enough to
support all the platforms we're supposed to be supporting. Adding more
files is not enticing.

Now that we've made the first step described above work in a single pass
on a single machine (as opposed to multiple passes on multiple machines
previously), we can actually merge both steps and avoid producing the
intermediate json files altogether. This will allow to add more
configurations without having to worry about the weight of those files.

And because this all doesn't need to depend on having the first step
hooked up in the build system, we make the whole an independent script
rather than a build backend.

Differential Revision: https://phabricator.services.mozilla.com/D149210
2022-06-20 22:04:12 +00:00
Mike Hommey
4df4a8ea7b Bug 1773223 - Move some json fixups into the GN processor. r=firefox-build-system-reviewers,andi
As we're shortly going to stop producing the intermediate json files,
we want the fixups to happen in the GN processor.

Ideally, we'd move them all, but cleaning up -isysroot is more involved,
while we won't need it once we don't use intermediate json files, so we
leave the -isysroot cleanup in fixup_json.py for now.

While here, `gn_out["targets"][target_fullname]` doesn't need to be set
on every iteration of the loop.

Differential Revision: https://phabricator.services.mozilla.com/D149209
2022-06-20 21:50:59 +00:00
Mike Hommey
a76a542e22 Bug 1773223 - Remove unused parameters. r=firefox-build-system-reviewers,andi
Also replace uses of config objects, which are only used for topsrcdir.

Differential Revision: https://phabricator.services.mozilla.com/D149208
2022-06-20 21:50:58 +00:00
Mike Hommey
1a668b3ceb Bug 1773223 - Use the GN binary path passed into generate_gn_config. r=firefox-build-system-reviewers,andi
The path is given to the function, there is no need to get it from
config.substs.

Differential Revision: https://phabricator.services.mozilla.com/D149207
2022-06-20 21:50:58 +00:00
Mike Hommey
2d53f2f5d7 Bug 1773223 - Remove variable expansion in the GN processor. r=firefox-build-system-reviewers,andi
This was cargo culted from the gyp processor, but is not used.

Differential Revision: https://phabricator.services.mozilla.com/D149206
2022-06-20 21:50:58 +00:00
Mike Hommey
9ed6ee8e5b Bug 1773223 - Generate webrtc moz.builds for all platforms at once. r=mjf,firefox-build-system-reviewers,ahochheiden
The current script requires to be run on 4 different host platforms each
of which would handle a subset of a total of 32 mozconfigs. That is not
sustainable, and there are already missing configs that break tier-3
platforms.

This replaces the current setup with one that handles all platforms in
one go, although we still keep the internal sequence of GcConfigGen ->
fixup_json -> GnMozbuildWriter.

The downside is that because this relies on the upstream webrtc build
system supporting cross-compilation, and that it actively rejects some
configurations, we need some local hacks to make it work on Linux and
Mac, but for now, we have to leave out Windows, which requires more
work.

For some reason, that removes some duplicated include directories in the
json files, which moves things a little in one moz.build file.

We also remove the mozconfigs we don't use anymore.

Differential Revision: https://phabricator.services.mozilla.com/D149205
2022-06-20 21:50:57 +00:00
Cosmin Sabou
18f908cae1 Backed out 11 changesets (bug 1738845, bug 1760484, bug 1773223) for causing build bustages and python failures. CLOSED TREE
Backed out changeset 2faea2e0af45 (bug 1773223)
Backed out changeset 85f0cccbd2a8 (bug 1760484)
Backed out changeset 67ee3490fe22 (bug 1738845)
Backed out changeset 2d0053357489 (bug 1773223)
Backed out changeset 7eccf21b04f2 (bug 1773223)
Backed out changeset 5e1c0d1d4018 (bug 1773223)
Backed out changeset c73d516d7d7f (bug 1773223)
Backed out changeset 05e201f82758 (bug 1773223)
Backed out changeset fe0095ad6576 (bug 1773223)
Backed out changeset 264adb57bb3c (bug 1773223)
Backed out changeset f349d4ad0088 (bug 1773223)
2022-06-21 00:22:01 +03:00
Mike Hommey
e426a9a864 Bug 1773223 - Remove now irrelevant gn processor tests.
Differential Revision: https://phabricator.services.mozilla.com/D149814
2022-06-20 21:16:52 +00:00
Mike Hommey
a118055664 Bug 1760484 - Add webrtc configs for arm64 openbsd. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D149473
2022-06-20 20:58:39 +00:00
Mike Hommey
9614f2583b Bug 1738845 - Add webrtc configs for arm and ppc64 linux. r=mjf
Adding arm alone breaks ppc64el.

Differential Revision: https://phabricator.services.mozilla.com/D134738
2022-06-20 20:58:39 +00:00
Mike Hommey
55bfe51945 Bug 1773223 - Filter-out _FORTIFY_SOURCE in GN processing. r=firefox-build-system-reviewers,andi
This is redundant with the build system setting it in
toolchain.configure.

Differential Revision: https://phabricator.services.mozilla.com/D149471
2022-06-20 20:58:38 +00:00
Mike Hommey
d975b31305 Bug 1773223 - Make the definition of MOZ_X11 independent of the OS. r=firefox-build-system-reviewers,ahochheiden
Differential Revision: https://phabricator.services.mozilla.com/D149474
2022-06-20 20:58:38 +00:00
Mike Hommey
cc1144c5b9 Bug 1773223 - Make the GN processor an independent script. r=firefox-build-system-reviewers,mjf,ahochheiden
The way the processor works currently is that it relies on two different
build backends, one of which produces json files for specific
configurations, and the other which produces moz.build files from the
aggregate of all those configs.

Each of these json files is huge, and we actually don't have enough to
support all the platforms we're supposed to be supporting. Adding more
files is not enticing.

Now that we've made the first step described above work in a single pass
on a single machine (as opposed to multiple passes on multiple machines
previously), we can actually merge both steps and avoid producing the
intermediate json files altogether. This will allow to add more
configurations without having to worry about the weight of those files.

And because this all doesn't need to depend on having the first step
hooked up in the build system, we make the whole an independent script
rather than a build backend.

Differential Revision: https://phabricator.services.mozilla.com/D149210
2022-06-20 20:58:30 +00:00
Mike Hommey
15773069c3 Bug 1773223 - Move some json fixups into the GN processor. r=firefox-build-system-reviewers,andi
As we're shortly going to stop producing the intermediate json files,
we want the fixups to happen in the GN processor.

Ideally, we'd move them all, but cleaning up -isysroot is more involved,
while we won't need it once we don't use intermediate json files, so we
leave the -isysroot cleanup in fixup_json.py for now.

While here, `gn_out["targets"][target_fullname]` doesn't need to be set
on every iteration of the loop.

Differential Revision: https://phabricator.services.mozilla.com/D149209
2022-06-20 20:58:29 +00:00
Mike Hommey
be1274bc3b Bug 1773223 - Remove unused parameters. r=firefox-build-system-reviewers,andi
Also replace uses of config objects, which are only used for topsrcdir.

Differential Revision: https://phabricator.services.mozilla.com/D149208
2022-06-20 20:58:29 +00:00
Mike Hommey
6e8d397004 Bug 1773223 - Use the GN binary path passed into generate_gn_config. r=firefox-build-system-reviewers,andi
The path is given to the function, there is no need to get it from
config.substs.

Differential Revision: https://phabricator.services.mozilla.com/D149207
2022-06-20 20:58:29 +00:00
Mike Hommey
9cb3379538 Bug 1773223 - Remove variable expansion in the GN processor. r=firefox-build-system-reviewers,andi
This was cargo culted from the gyp processor, but is not used.

Differential Revision: https://phabricator.services.mozilla.com/D149206
2022-06-20 20:58:28 +00:00
Mike Hommey
7e5d9b75ba Bug 1773223 - Generate webrtc moz.builds for all platforms at once. r=mjf,firefox-build-system-reviewers,ahochheiden
The current script requires to be run on 4 different host platforms each
of which would handle a subset of a total of 32 mozconfigs. That is not
sustainable, and there are already missing configs that break tier-3
platforms.

This replaces the current setup with one that handles all platforms in
one go, although we still keep the internal sequence of GcConfigGen ->
fixup_json -> GnMozbuildWriter.

The downside is that because this relies on the upstream webrtc build
system supporting cross-compilation, and that it actively rejects some
configurations, we need some local hacks to make it work on Linux and
Mac, but for now, we have to leave out Windows, which requires more
work.

For some reason, that removes some duplicated include directories in the
json files, which moves things a little in one moz.build file.

We also remove the mozconfigs we don't use anymore.

Differential Revision: https://phabricator.services.mozilla.com/D149205
2022-06-20 20:58:27 +00:00
andrej
b5f60d8890 Bug 1773621 - Remove panda.tv from list of sites tested on WebPageTest. r=perftest-reviewers,AlexandruIonescu
A week ago we received a notification that we had a test that the WPT chrome tests were perma failing on [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1773621 | bugzilla ]]
After going through the fail logs I realized it was because of website "panda.tv" directing to a unable to connect page message, after some digging it was not returning proper data because panda.tv has not been a company since March 2019(bankruptcy filing), why this only is causing an issue now I believe is because of some kind of update from WPT as I can see a noticeable UI difference on the test results page from before and after the failures started.

My resolution was to remove Panda.tv from our test list and that seems to have resolved the issue.

I also updated the error message to display which website is causing the issue so that if this happens again I don't need to go through each and every webpagetest result to know which of the 40 websites are having an issue.

Differential Revision: https://phabricator.services.mozilla.com/D149642
2022-06-20 14:16:41 +00:00
Jan-Erik Rediger
51f960bd09 Bug 1773255 - Update to Glean v50.1.0 r=chutten,supply-chain-reviewers
Including glean_parser 6.1.1

Two important things in there:
* glean_parser: [data-review] Include extra keys' names and descriptions in data review template
* Glean: Derive `serde::{Deserialize, Serialize}` on `Lifetime` and `CommonMetricData`

Differential Revision: https://phabricator.services.mozilla.com/D149381
2022-06-15 15:39:33 +00:00
ahochheiden
66564fb0f0 Bug 1276019 - Add Microsoft Defender Antivirus exclusions automatically during source bootstrap r=glob
I also added `%USERPROFILE%/.mozbuild` to the exclusion list and updated the windows_build docs to reflect the changes made.

Differential Revision: https://phabricator.services.mozilla.com/D149199
2022-06-15 01:37:11 +00:00
Tooru Fujisawa
328ebe7e6b Bug 1769405 - Part 4: Detect mismatch between the default mozconfig and the selected build target. r=firefox-build-system-reviewers,glandium
When `./mach bootstrap` is called with the default mozconfig file,
verify the content matches the selected build target, and if not,
show a warning and ask whether to overwrite or not.

Differential Revision: https://phabricator.services.mozilla.com/D146384
2022-06-14 18:13:54 +00:00