Commit Graph

57 Commits

Author SHA1 Message Date
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Edgar Chen
e2745056eb Bug 1543439 - Part 4: Add tests; r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D32600

--HG--
extra : moz-landing-system : lando
2019-05-28 23:47:48 +00:00
Tim Nguyen
c1f5b7a338 Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D23045

--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/search-textbox.js
extra : moz-landing-system : lando
2019-05-13 18:12:37 +00:00
Coroiu Cristina
cc280c4be9 Backed out changeset c5798de806e2 (bug 1521280) for crashing when searching about:config for upcoming beta (bug 1551013)
--HG--
extra : rebase_source : 8f936159c23d09bf227ce4f5eb6f2d96d33bbff1
2019-05-13 08:50:28 +03:00
Tim Nguyen
1a57aab68e Bug 1521280 - Convert search-textbox to a custom element. r=dao,bgrins
Differential Revision: https://phabricator.services.mozilla.com/D23045

--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/search-textbox.js
extra : moz-landing-system : lando
2019-05-10 11:46:49 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Paolo Amadini
2a67f25fbd Bug 1454360 - Use "arrowscrollbox" in the "popup-scrollbars" binding. r=NeilDeakin
This prepares this binding for the unification with the "popup" binding, and removes the last consumer of the scrollByIndex method of XULScrollElement.

Because some code paths in "arrowscrollbox" are optimized using requestAnimationFrame, the related scrolling tests are now asynchronous.

Differential Revision: https://phabricator.services.mozilla.com/D15276

--HG--
extra : rebase_source : f5d26df106785f2c0d158b8a23a648a71ab06b2d
2019-01-04 15:07:12 +00:00
Emilio Cobos Álvarez
a73c2d572b Bug 1511138 - Fix getComputedStyle usage of SelectChild. r=mconley
I missed the failure in browser_selectpopup_colors.js since it doesn't run on
Linux. Fix the getComputedStyle usage in that code by using
getDefaultComputedStyle, which is what it really wants.

Also, do a bit of cleanup while at it: uaBackgroundColor was unused, and uaColor
was wrong (we don't override the ua color of the <option> element, it just
inherits, so it's the same as the <select> color, and that's what we were
comparing it against anyway).

Differential Revision: https://phabricator.services.mozilla.com/D13956
2018-12-07 14:24:49 -05:00
arthur.iakab
168846ee68 Backed out 5 changesets (bug 1511138) for causing eslint failure on SelectChild.jsm CLOSED TREE
Backed out changeset daee82295b3c (bug 1511138)
Backed out changeset d23c9c3e1566 (bug 1511138)
Backed out changeset a99600391704 (bug 1511138)
Backed out changeset 4ef293b90887 (bug 1511138)
Backed out changeset 4df286b234b3 (bug 1511138)
2018-12-07 20:55:24 +02:00
Emilio Cobos Álvarez
ca9c4ff03a Bug 1511138 - Fix getComputedStyle usage of SelectChild. r=jaws,mconley
I missed the failure in browser_selectpopup_colors.js since it doesn't run on
Linux. Fix the getComputedStyle usage in that code by using
getDefaultComputedStyle, which is what it really wants.

Also, do a bit of cleanup while at it: uaBackgroundColor was unused, and uaColor
was wrong (we don't override the ua color of the <option> element, it just
inherits, so it's the same as the <select> color, and that's what we were
comparing it against anyway).

Differential Revision: https://phabricator.services.mozilla.com/D13956
2018-12-07 13:01:06 -05:00
Julian Descottes
260b1e16a3 Bug 1467712 - Fail if SimpleTest ok() is called with more than 2 arguments;r=Standard8
Depends on D10417

Differential Revision: https://phabricator.services.mozilla.com/D10418

--HG--
extra : moz-landing-system : lando
2018-11-01 13:50:27 +00:00
Emma Malysz
696ceb303f Bug 1465219, use XULMenuElement, a subclass of nsXULElement, instead of MenuBoxObject for menu and menulist elements, r=paolo,bz
MozReview-Commit-ID: 5253hAlxbhw

--HG--
rename : dom/webidl/MenuBoxObject.webidl => dom/chrome-webidl/XULMenuElement.webidl
rename : layout/xul/MenuBoxObject.cpp => dom/xul/XULMenuElement.cpp
rename : layout/xul/MenuBoxObject.h => dom/xul/XULMenuElement.h
2018-07-31 12:30:17 -07:00
Brian Grinstead
150199f6f8 Bug 1488938 - Round two: migrate mochitest-browser tests to use element variations of firstChild, etc;r=Gijs
This is a follow up to Bug 1482667. The list of callers was gathered by instrumenting
the webidl calls to these methods and dumping JS stack when they are called in browser.xul.

Differential Revision: https://phabricator.services.mozilla.com/D5185

--HG--
extra : moz-landing-system : lando
2018-09-07 15:31:38 +00:00
Gijs Kruitbosch
ef7146a4be Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : rebase_source : e51b66bb18d0e600814b48d5cd3ec9d5dea3028a
extra : source : 96b5a88ac0041a1bd382a731749e1fca9aa911ed
2018-09-03 14:43:38 +01:00
Margareta Eliza Balazs
ffea0ab6ab Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-08-31 12:27:44 +03:00
Margareta Eliza Balazs
5ddcd7b745 Backed out changeset 96b5a88ac004 (bug 1486824) for causing frequent failures e.g: browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about.js a=backout 2018-08-31 12:17:27 +03:00
Mark Banner
691543ee89 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439

--HG--
extra : moz-landing-system : lando
2018-08-31 05:59:17 +00:00
Gijs Kruitbosch
9d70cb3843 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
2018-08-30 15:07:36 +00:00
Narcis Beleuzu
a4ec006bb0 Backed out changeset 4e195f7b2d6b (bug 1486824) for clipboard failures on OSX browser_editcontrols_update. a=backout 2018-08-30 15:59:59 +03:00
Gijs Kruitbosch
a8e2b8e702 Bug 1486824 - change BrowserTestUtils to just call OpenBrowserWindow so it does the same thing as opening a window normally, r=mconley,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D4466

--HG--
extra : moz-landing-system : lando
2018-08-29 17:58:25 +00:00
Brian Grinstead
4995c61b0f Bug 1482667 - Migrate mochitest-browser tests in browser/ to use element variations of firstChild, etc;r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3530

--HG--
extra : moz-landing-system : lando
2018-08-17 16:45:52 +00:00
Kris Maglione
08e6ae3629 Bug 1472491: Part 5q - Add SelectChild actor. r=felipe
MozReview-Commit-ID: J5MAJMbblyr

--HG--
rename : toolkit/modules/SelectContentHelper.jsm => toolkit/actors/SelectChild.jsm
extra : rebase_source : 4ade8f5f0f3b68124c5f0f3cf2eae545db4b6854
2018-07-29 21:59:16 -07:00
Joel Maher
50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Masayuki Nakano
cf83ee7bb4 Bug 1438157 - part 2: Remove unnecessary second argument of EventUtils.synthesizeKey() r=smaug
Note that this patch also replaces legacy VK_* with KEY_*, and replaces
synthesizeKey() for inputting some characters with sendString() because
it's better and clearer what it does and it sets shiftKey state properly.

MozReview-Commit-ID: De4enbjux3T

--HG--
extra : rebase_source : 2296b84bff8e22f01eeb48cd8614fac5db11136a
2018-02-15 04:15:39 +09:00
Masayuki Nakano
8917ac460f Bug 1436926 - part 2: Remove unnecessary KeyboardEvent.code specification of callers of EventUtils.synthesizeKey() r=smaug
Now, callers of EventUtils.synthesizeKey() don't need to specify
KeyboardEvent.code value anymore if they assume that active keyboard layout
is US keyboard layout.

Note that this patch changes the meaning of only test_bug551434.html.
Some callers in it don't match the key value and code value but that looks
like that they don't checking such odd keyboard events.  So, they must be
bug of the test.

MozReview-Commit-ID: Itxo7yZ9rkK

--HG--
extra : rebase_source : 856ef3715c924ca16e993ea57d92d1243b5cc6be
2018-02-09 19:17:26 +09:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Peter Van der Beken
6241d3800f Bug 1391118 - xslt-generated select tag pull-down does not respond to clicks. r=jaws 2017-08-22 14:23:33 +02:00
Zibi Braniecki
a7b00209a5 Bug 1386015 - Do not generate styling for each element with inherited color. r=jaws
This patch does a minor refactor of the code used to style popup menu for
the <select> element.
It improves the custom styling experience on MacOS, preserves the functionality
on Windows and removes the unnecessary per-item CSS rules significantly
improving the performance of opening the <select> list.


MozReview-Commit-ID: 7myXq8aDAWr

--HG--
extra : rebase_source : 3ff52f832ec471cca0942e5d8a39961dbc84cff4
2017-08-11 17:38:14 -07:00
Andrew Halberstadt
d2109610fb Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : 8607b3964da207a6076c79b6f1d75b40503cdd7d
2017-08-10 14:48:21 -04:00
Phil Ringnalda
0ff5a4285d Backed out changeset 6896f93a2327 (bug 1385352) for not making it to m-c before the next violation of its new linting rule merged to autoland
MozReview-Commit-ID: 3HDE2C3wSU0
2017-08-10 20:21:19 -07:00
Andrew Halberstadt
f625fd5c37 Bug 1385352 - Enable 'mozilla/no-arbitrary-setTimeout' eslint rule on browser-chrome tests, r=standard8
MozReview-Commit-ID: 5lO0uAjHMsw

--HG--
extra : rebase_source : d72a88962ec8d843e7be99e25f710887f01b6e1a
2017-08-10 14:48:21 -04:00
Felipe Gomes
6c556d68fe Bug 1383205 - Update transitionend properties of <option> elements on a deferred task. r=jaws
Also, we only care about the properties that we support and that are animatable, as the non-animatable ones do not generate transitionend events

MozReview-Commit-ID: 5KZvJeGwfP3
2017-07-30 23:06:29 -03:00
Florian Quèze
5e3539e504 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Jared Wein
c352d05b9b Bug 1343569 - Delay hiding the popup on blur if the search field gains focus. r=enndeakin+6102
Since the order of events is 'blur' followed by 'focus', we send a message from the content process to the parent process and wait for a reply to give enough time for the parent process to signal that the 'blur' was related to the focusing of the search field. If the parent process hasn't signaled as such, then the content process will proceed with hiding the dropdown.

MozReview-Commit-ID: 6ngoo9uHcsM

--HG--
extra : rebase_source : caf43a975827aec71ba82fe39435b05c954673bc
2017-04-25 20:19:42 -04:00
Jared Wein
29cbea21ed Bug 1355078 - Restore scroll position after updating select popup. r=mossop
MozReview-Commit-ID: 7HfuUCymDz

--HG--
extra : rebase_source : ca73fb30b6f77ddfd7718a6dd3fc747a8533bc8c
2017-04-11 01:36:07 -04:00
Jared Wein
169ec2a84e Bug 1354196 - Forward the text-shadow CSS property to the select popup for styling. r=mossop
MozReview-Commit-ID: 3jzZOIiJyXT

--HG--
extra : rebase_source : 1c223d7c90c72c32386a46dccaa745fd19418fae
2017-04-10 16:03:03 -04:00
Mark Banner
92c422a2d6 Bug 1342459 - Add a rule to automatically detect ContentTask.spawn and inject the relevant globals. r=mossop
This reduces the amount of places where we need to specify the mozilla/frame-script environment. It does have
the side effect of allowing those globals in the whole file, but that is what specifying the environment would
do, and this is also for mochitest test files only.

MozReview-Commit-ID: 1LLFbn6fFJR

--HG--
extra : rebase_source : 82a6934d90bbbbd25f91b7b06bf4f9354e38865a
2017-04-05 10:00:25 +01:00
Mark Banner
1087fc1884 Bug 1352969 - Fix various ESLint no-undef issues in browser/base (no-undef is not enabled yet). r=mossop
MozReview-Commit-ID: BuTyJAfUoWR

--HG--
extra : rebase_source : 482bdc039362347f35aec9fd15e07a143dccb860
2017-02-22 17:02:59 +00:00
Jared Wein
8507a1dbb7 Bug 1352963 - Update the styling of the select popup after transitionend. r=mossop
MozReview-Commit-ID: 5WuRvMDYahZ

--HG--
extra : rebase_source : ab841ad17194a7ff9506155e13747bb9bd750833
2017-04-03 22:52:16 -04:00
Jared Wein
ea4c7c16b9 Bug 1350670 - Extend the MutationObserver to cover attributes in case the page sets styles through style, class, ID or other attributes. r=mossop
MozReview-Commit-ID: 3tYjbqH9zYb

--HG--
extra : rebase_source : ae593c3f8ac627ebb058d5f486d5b34ea2f63c9e
2017-03-29 12:47:13 -04:00
Phil Ringnalda
8198cb8936 Backed out changeset adf939cb9b0b (bug 1350670) for Mac and Windows browser_selectpopup_colors.js failures
CLOSED TREE
2017-03-28 19:37:49 -07:00
Jared Wein
6ac4051094 Bug 1350670 - Extend the MutationObserver to cover attributes in case the page sets styles through style, class, ID or other attributes. r=mossop
MozReview-Commit-ID: 3tYjbqH9zYb

--HG--
extra : rebase_source : 569a036dee7ae690ee4ef5ab8c39e1dad5a7350a
2017-03-28 17:04:32 -04:00
Jared Wein
747461066a Bug 1350774 - Some pages may style their <option> elements based on the :focus of the <select>, so :focus should be locked on the <select> during color computation. r=mossop
MozReview-Commit-ID: D0WZU6wFctG

--HG--
extra : rebase_source : f985fa43fdcf13841e31357b736b5b472a217b36
2017-03-28 15:43:33 -04:00