These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.
MozReview-Commit-ID: 45aYzVHwRYv
--HG--
extra : rebase_source : 0bf4fc4effc9de9e431ee50dfcf5fc7206e252cf
This also adds the icons in non-photon. They seem to work fine there, so I don't think this is a problem.
MozReview-Commit-ID: GkvT3i2jnD1
--HG--
extra : rebase_source : 80d33d329b5740328aa82dd5401475264700e57a
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.
MozReview-Commit-ID: 45aYzVHwRYv
--HG--
extra : rebase_source : 0bf4fc4effc9de9e431ee50dfcf5fc7206e252cf
These rules are set explicitly to allow the two views to be displayed next to
each other briefly when the slide-in transition starts.
This patch also applies the last remaining photon styles to the temporary panel,
which is used by the new Library widget as well.
MozReview-Commit-ID: 45aYzVHwRYv
--HG--
extra : rebase_source : f142e3dbba0d70effe129dad43f139e494070d82
I updated, extended and refined Paolo's descriptionHeightWorkaround method to
support multi-line toolbar button labels.
Made the app menu use that method to ensure no scrollbars appear.
Also updated the styling of the banner to have icon and label align correctly
with those of the other buttons inside the panelview.
MozReview-Commit-ID: IzbahG0kyTu
--HG--
extra : rebase_source : 8a6c4e5ac7b1c0d30f53b732730629b5d8ca7166
Add a Send to Device subview to the page action panel. When the page isn't
sendable, disable the Send to Device menu item. When the user doesn't have any
devices, show a menu item that opens the Firefox Account preferences pane.
Generalize gSync.populateSendTabToDevicesMenu() so that it can be used to
populate any kind of container, not only a menupopup with menuitems.
Add an SVG that shows a phone and an SVG that shows a desktop.
MozReview-Commit-ID: EZQKAEAr08q
--HG--
extra : rebase_source : bda87f105712a6c6ba83da1a78179eee93b5f4d0
There are two issues this addresses:
1) Update badges were showing in the middle of the hamburger
button for high-DPI displays. This was because I failed to
copy the margin-inline-end from the low-DPI styles to the
high-DPI styles, and so the high-DPI's margin settings were
overriding those.
2) Somehow the drop from -9px to -8px in the margin caused the
icon to start eating into the second row of the hamburger,
which was not intended, and was not happening when I wrote
the initial code, or else I made some mistake when I was
testing. In any case, I'm not sure of the reason for the
discrepancy, but this change undoes it and looks fine.
These two changes are together because they touch the same code.
Since the high-DPI margin ends up not being different from the
low-DPI margin, we're just deleting the high-DPI's entry.
Images:
low-dpi - https://d2ppvlu71ri8gs.cloudfront.net/items/021F0M3u1Z3q1m271d2G/low-dpi.PNG
high-dpi - https://d2ppvlu71ri8gs.cloudfront.net/items/31313s420d2R373f271Z/high-dpi.PNG
MozReview-Commit-ID: 7Np4x1DSUuN
--HG--
extra : rebase_source : 4bc5da0fd3c353b83e09bf9528949f729484156b
The height of the "panelmultiview" binding is now determined by the stack layout code, and doesn't have to be calculated manually via JavaScript anymore. This allows the removal of mutation and overflow observers, and reduces the number of synchronous layouts being made.
There is still a workaround included for wrapping blocks not being taken into account in height calculations.
MozReview-Commit-ID: 9rrPU5O5hUx
--HG--
extra : rebase_source : b872c14a553c4293ac476d5d22c634a5a0f6cb24
extra : intermediate-source : bf96469b6ea7daee29eb75a60d11f017a1c86a64
extra : source : 719bb4e7286fbd3baf32061929e4b7d9f953c671
This also improves the styling of checkbox buttons inside the menu and improves
support for adopting panelviews into the app menu from another area properly.
MozReview-Commit-ID: 1I9CeBx3zrz
--HG--
extra : rebase_source : 2db487c3e8fb56bca20f8bf51367b724c677b10f
