Commit Graph

634 Commits

Author SHA1 Message Date
Phil Ringnalda
7b2b8a1c8a Back out ea9410c65673 (bug 769791) for mochitest-chrome bustage 2012-07-03 21:36:45 -07:00
Adam Dane [:hobophobe]
484e6f3083 Bug 769791 - Optimize nsSelection::GetIndicesForInterval for adding ranges to the end. r=smaug 2012-07-03 18:19:42 -05:00
David Zbarsky
d2ee12f6f9 Bug 763350 - Clean up some includes in content/ and dom/ r=smaug 2012-07-01 16:45:59 -07:00
Aryeh Gregor
ed5ae0b680 Bug 767169 part 1 - Partial cleanup of Selection::selectFrames; r=ehsan 2012-06-28 14:29:56 +03:00
Aryeh Gregor
6c6dd2829d Bug 766845 part 2 - Make CloneRange() return already_AddRefed<nsRange>; r=smaug 2012-06-25 14:44:11 +03:00
Aryeh Gregor
cdc6c34c93 Bug 762183 part 2 - Publicize nsSelectionIterator; r=ehsan 2012-06-12 17:15:23 +03:00
Aryeh Gregor
7737d5d63f Bug 762862 - Rename nsTypedSelection to mozilla::Selection; r=ehsan
--HG--
rename : layout/generic/nsTypedSelection.h => layout/generic/Selection.h
2012-06-08 17:20:55 +03:00
Jignesh Kakadiya
556a73089d Bug 751785 - Make Selection.toString() API use DOMString instead of wstring 2012-06-09 15:15:12 -07:00
Mats Palmgren
61427b43eb Bug 758589 - Make Selection.toString() return early (with empty result string) if the shell is destroyed. r=smaug 2012-05-30 15:03:19 +02:00
Phil Ringnalda
045f134b35 Back out 6d605438199c (bug 758589) for bug 759243 2012-05-28 22:44:57 -07:00
Mats Palmgren
02dba7be98 Bug 758589 - Make Selection.toString() return early (with empty result string) if the shell is destroyed. r=smaug 2012-05-29 02:50:42 +02:00
Robert O'Callahan
3c90d15cd6 Bug 757807. Don't store an nsMouseEvent in nsFrameSelection, it's unnecessary and leaky. r=smaug 2012-05-24 22:36:08 +12:00
Gervase Markham
82ff7027aa Bug 716478 - update licence to MPL 2. 2012-05-21 12:12:37 +01:00
Ms2ger
feba9c5092 Bug 755200 - Simplify SetSelectionAroundHeadChildren; r=ehsan 2012-05-18 10:29:39 +02:00
Ms2ger
0a9de2eb5f Bug 750053 - Part a: Add nsISelection::Collapsed(); r=smaug 2012-05-18 10:29:39 +02:00
Trevor Saunders
bfcb62b32b bug 693933 - make nsFrameSelection::GetSelection() return nsTypedSelection* r=smaug 2012-04-06 17:54:38 -04:00
Robert O'Callahan
5365ff4dde Bug 681192. Part 7: nsTypedSelection should be scrolling a 0,0 size into view to get a particular coordinate into view, not 1,1. r=matspal
When asked to scroll a 1,1 appunit rectangle into view, ScrollFrameRectIntoView will now actually
succeed!
For example if the window is 6000 appunits high and we ask to scroll a 1x1 rect at 0,6000 into view,
before bug 681192 was fixed we'd actually fail to do so. We'd compute a desired scroll destination of 0,1,
and ScrollTo would round that to 0,0 and we wouldn't scroll at all.
Now, we compute a desired scroll destination of 0,1 but also an allowed scroll range for y of
"1 to <someting large>", so ScrollFrameRectIntoView will scroll down by a full pixel to 0,60. This is correct ---
it gets the subpixel area into view, which the previous code didn't --- but it's not really what DoAutoScroll
wants, at least the way test_mousecapture.xul is written. test_mousecapture.xul expects DoAutoScroll to scroll
windowheight+N into view by scrolling down by exactly N pixels, so the desired point is exactly at the bottom
edge of the window rect. Using a zero-sized rect achieves this.

--HG--
extra : rebase_source : 5d3d8cc4417c35dc88ad296a4f13e01d2c1c9233
2012-05-10 17:24:19 +12:00
Mats Palmgren
fbfd445216 Bug 735641 - No way to deselect image of image document after select all (Ctrl+A). r=bz 2012-05-04 02:14:01 +02:00
Mats Palmgren
fb481c3dad Bug 748961 - Flush styles to ensure frames are created. r=smaug,Ms2ger 2012-05-04 02:14:01 +02:00
Masayuki Nakano
5c0d118456 Bug 630811 part.2 Replace nsInputEvent::isShift, nsInputEvent::isControl, nsInputEvent::isAlt and nsInputEvent::isMeta r=smaug 2012-04-25 12:00:02 +09:00
Ehsan Akhgari
4ec820fdcb Bug 726592 - Uninitialised value use in nsTextFrame::GetChildFrameContainingOffset; r=roc
--HG--
extra : rebase_source : 3e5d2fafc028edb2940bef07302161670692d5a1
2012-03-26 09:09:38 -07:00
Adam Dane [:hobophobe]
a4e77c0d40 Bug 720126 - Update scroll API to use ScrollAxis parameters (where and when). r=roc 2012-03-19 21:09:50 -05:00
Aryeh Gregor
ad217f921d Bug 719523 - Selection.selectAllChildren() on a Document always produces end offset of 1; r=ehsan 2012-03-16 12:56:54 -04:00
Aryeh Gregor
de65e0a8ea Bug 719515 - Selection.extend() should replace the existing range, not mutate it; r=ehsan 2012-03-15 14:26:32 -04:00
Aryeh Gregor
e9f5626ad7 Bug 719518 - Selection.extend() with no ranges should throw standard exception type; r=ehsan 2012-03-14 14:27:30 -04:00
Mats Palmgren
5a6c96f815 Bug 732941 - Deal with OOM when copying nsCOMArray. r=bz 2012-03-11 03:32:27 +01:00
Nathan Froyd
68a79f10ae Bug 731615 - Eliminate duplicate headers in layout. rs=smontagu 2012-02-29 10:57:47 -05:00
Aryeh Gregor
82315b5bd1 Bug 719503 - selection.deleteFromDocument() throws for collapsed selection; r=ehsan 2012-02-22 10:38:25 -05:00
Ms2ger
dc8871e80a Bug 722406 - Part a: Introduce nsISelection::CollapseNative; r=smaug 2012-02-01 11:54:22 +01:00
Ehsan Akhgari
efb9965ff2 Bug 171237 - Part 2: Correct the calls to ScrollIntoView which were not updated as part of bug 605138; r=roc 2012-01-11 20:19:19 -05:00
Ehsan Akhgari
1ea713b5e0 Bug 171237 - Center the search results instead of scrolling only enough to show them in order to provide more visual context; r=roc 2012-01-11 20:18:23 -05:00
David Zbarsky
e38d101da0 Bug 682611 - Part 2: Remove nsIRange; r=smaug 2012-01-10 15:19:54 +01:00
Olli Pettay
6623e31896 Bug 714162 - Don't traverse certainly alive selections, additional patch, r=mccr8 2012-01-06 21:08:08 +02:00
Olli Pettay
a287345bde Bug 714162 - Don't traverse certainly alive selections, r=mccr8 2011-12-30 12:47:23 +02:00
Mats Palmgren
36ff8658d6 Bug 712937 - Null-check aRange. r=bzbarsky 2011-12-24 05:08:23 +01:00
Nicholas Nethercote
24d2c81ee1 Bug 711908 - Fix a bunch of GCC warnings in layout. r=dbaron. 2011-12-19 19:46:39 -08:00
Mats Palmgren
498185f3f0 Bug 619273 - Move the selection state bit from frames to content nodes. r=smaug 2011-12-20 10:15:41 +01:00
Jeff Walden
2e53b58879 Bug 711799 - Add parentheses to a bunch of && expressions nested within || expressions. r=dholbert 2011-12-18 01:00:47 -05:00
Jeff Walden
df2b7cbc5c Bug 704127 - Implement MOZ_FINAL as a modifier for classes and virtual member functions. r=cjones
--HG--
extra : rebase_source : d95a3b3e726f810f299314358ba8c5e23557698e
2011-11-20 22:21:16 -08:00
Jeff Muizelaar
31a79df660 Bug 698107. layout: Return nsnull instead of false. r=bz
Caught by a clang warning.

--HG--
extra : rebase_source : 384a3451b7e54f8afb40f5e8a94000c00a54cc6d
2011-11-08 18:09:22 -05:00
Ehsan Akhgari
92064e6d3f Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
Michael Wu
d2b70213ac Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
David Zbarsky
feef9bcb83 Bug 672536 - Merge nsISelection2 into nsISelectionPrivate r=smaug 2011-08-07 16:17:00 -04:00
David Zbarsky
110e54925e Bug 672536 - Merge nsISelection3 into nsISelection r=smaug 2011-08-07 16:18:00 -04:00
Masayuki Nakano
bfc72b90bf Bug 675865 backout new dragginf for selection handling code from Mozilla8 r=smaug (backed out patches are: bug 552707, bug 644621, bug 670058, bug 670508, bug 671319) 2011-08-03 12:39:02 +09:00
Ehsan Akhgari
5ce917a794 Bug 674558 - Implement the HTML5 selectionDirection property for text controls (input and textarea); r=bzbarsky 2011-07-28 13:51:22 -04:00
Mounir Lamouri
57fe0a2e82 Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-20 12:18:54 -07:00
Ehsan Akhgari
8aa36b3b5c Revert to changeset e0ce7821fce1 because the latest push broke all of the builds DONTBUILD 2011-07-19 16:25:54 -04:00
Mounir Lamouri
b6d655dff0 Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-19 11:22:43 -07:00
Mounir Lamouri
58e2fd59fd Backed out bug 669310, bug 668013, bug 667887 and bug 669886 due to build bustage. 2011-07-19 10:49:48 -07:00
Mounir Lamouri
8ae6e80c16 Bug 669310 - Fixes various includes and forward declarations. f=Ms2ger r=jst 2011-07-18 17:05:10 -07:00
Masayuki Nakano
3511882bcf Bug 670058 Stop drag handling for selection when the dragging frame selection detaches presShell r=smaug 2011-07-11 13:20:46 +09:00
Masayuki Nakano
35028f63a8 Bug 552707 While we're expanding selection by dragging, the selection root element should capture mouse events and all scrollable elements should be scrollable r=roc+smaug, ui=faaborg 2011-07-06 11:16:18 +09:00
Craig Topper
454ea34e1f Bug 654369 - Part 9: Remove OOM checks from layout/generic r=bz
--HG--
extra : rebase_source : b828e73151ceb8cb59e1d8f7c0671dc88397057c
2011-04-28 22:02:16 -07:00
Masayuki Nakano
7b13fbd2d9 Bug 659536 part.2 Replace nsContentUtils::GetIntPref() with Preferences::GetInt() or Preferences::GetUint() r=roc 2011-05-25 15:32:00 +09:00
Masayuki Nakano
caee4cc73f Bug 659533 Replace nsContentUtils::GetBoolPref() with Preferences::GetBool() r=roc 2011-05-25 15:31:59 +09:00
Craig Topper
6d35e0da33 Bug 658143 - Part 3: Remove nsFrameSelection QI and createInstance support. r=roc 2011-05-18 22:28:54 -07:00
Dão Gottwald
c51a4c6569 Bug 451833 - Highlight the domain name in the address bar. r=roc,sdwilsh ui-r=faaborg
--HG--
extra : rebase_source : 1010ad246e94e271a0efaaca13356aff5d4b3bc3
2011-05-02 19:50:18 +02:00
Zack Weinberg
8648dcc368 Bug 651017, part 1: minimize inclusion of ns*DeviceContext.h; move the printing error codes to nsIDeviceContextSpec.h; os2 small widget cleanup.
--HG--
extra : rebase_source : 5b7cebe68f71a760463e3522b159c7cde8a72f5e
2011-04-16 18:22:41 -07:00
Robert O'Callahan
a7b4f1246b Bug 641426. Part 5: Avoid operator== where possible to distinguish between 'equal edges' and 'equal areas' for rectangles. r=dbaron,sr=cjones 2011-04-19 15:07:23 +12:00
Ehsan Akhgari
93de29b2e6 Bug 642823 - Make the behavior of nsISelection::Modify consistent for word selection across platforms by not eating spaces on any platform; r=roc 2011-03-20 15:49:06 -04:00
Olli Pettay
23707f899e Bug 637621, allow selection collapse more often, r+a=jst
--HG--
extra : rebase_source : 216a2405f929ca00cc4982ebb39230b4f3018dc1
2011-03-02 16:55:12 +02:00
Mats Palmgren
418ee669d2 Bug 602331 - selection addRange cannot select nodes that are being dynamically appended to the DOM. r=roc a=blocking2.0:final 2011-01-14 01:22:26 +01:00
timeless@mozdev.org
84cfaf02e5 Bug 620304 crash [@ nsTypedSelection::GetIndicesForInterval] if !aStartIndex/!aEndIndex, r+a=jst 2010-12-20 01:19:00 -08:00
Jonathan Kew
e79e7e7398 bug 332636 - fix editor's handling of surrogate-pair combining marks with backspace. r=ehsan a=roc 2010-12-16 14:17:41 -08:00
Jonathan Kew
63186a7fc6 Backed out changeset 1958ebae93cc for causing mochitest orange. a=backout 2010-12-16 15:15:35 -08:00
Jonathan Kew
ff27ba6ff2 bug 332636 - fix editor's handling of surrogate-pair combining marks with backspace. r=ehsan a=roc 2010-12-16 14:17:41 -08:00
Timothy Nikkel
232d0b4160 Bug 559993. Scroll the whole selection into view, not just the focus point when finding on a page. r=roc a=blocking-final+ 2010-11-24 19:35:02 -06:00
Ms2ger
d3ebaf1d84 Bug 589623 - Raise INVALID_STATE_ERR exceptions from Selection.collapseTo{Start|End}; r+a=jst 2010-11-06 10:40:13 +01:00
Ms2ger
9d43bc33c9 Bug 589621 - Throw the correct exception for Selection.getRangeAt called with out-of-bounds values; r=sicking a=bsmedberg 2010-11-06 10:40:04 +01:00
Ehsan Akhgari
7e43b5d1ec Bug 389321 - Part 1: Don't choke on textnodes which don't have a primary frame; r=roc a=blocking-betaN+ 2010-08-17 15:25:53 -04:00
Ehsan Akhgari
51e10b8989 Bug 605138 follow-up: fix Thunderbird bustage. r=me a=bustage 2010-10-25 14:24:40 -04:00
Ehsan Akhgari
b42904ff2d Bug 605138 - Part 2: Refactor nsTypedSelection::ScrollIntoView to use flags instead of parameters; r=roc a=blocking-final+ 2010-10-22 18:41:55 -04:00
Ehsan Akhgari
7883671dc5 Bug 605138 - Scripts from topix.net apparently causing page to scroll down when opening; r=roc a=blocking-final+ 2010-10-21 16:56:20 -04:00
Neil Deakin
614c1ef9c5 Bug 578667, text not highlighting when selectiondrag is outside frame, r=mats,a=blocking 2010-10-25 10:06:30 -04:00
Boris Zbarsky
7c8ff20187 Bug 594808. If the given range is detached, don't try to work with its start/end containers. r=sicking 2010-10-20 20:24:15 -04:00
Ehsan Akhgari
8fa798f748 Bug 604314 - "ASSERTION: unexpected disconnected nodes"; r,a=roc
--HG--
extra : rebase_source : be7c85abe0c8c84c5663a871ee831863c4823bad
2010-10-18 23:24:39 -04:00
Ehsan Akhgari
beac06ac9c Bug 586662 - Part 3: Don't attempt to compare unrelated points when manipulating selections; r=roc a=blocking-betaN+ 2010-09-23 14:44:01 -04:00
Justin Lebar
f86987c51a Bug 581051 - Move selection.modify() from nsISelection.idl into nsISelection3.idl. r,approval2.0=jst
--HG--
extra : rebase_source : 9008b467241f21bc66d5fca734d916400d21e3b2
2010-07-22 11:02:06 -07:00
Timothy Nikkel
20d255fcc2 Bug 563878. Part 15. Fix GetOffsetTo callsites. r=mats 2010-07-18 21:23:48 -05:00
Jesse Ruderman
9478c01a40 Remove stray line breaks from NS_ERROR messages, since they interfere with log processing. rs=jst
--HG--
extra : rebase_source : 87421691da969e0ebe5fbfbc44cd8f18617d1351
2010-06-17 13:28:38 -07:00
Ehsan Akhgari
39534c1d71 Bug 332636 - Handle backspace for Unicode plane 1 characters correctly; r=roc
--HG--
extra : rebase_source : a343610b06983d3328f3ddb2e7025193ab275094
2010-06-04 13:28:19 -04:00
Mats Palmgren
a180f952fd Bug 39098 - Elements with visibility:hidden, visibility:collapse, or display:none get copied to the clipboard. r=dbaron 2010-05-25 01:24:15 +02:00
Mats Palmgren
64294ccd1a Backout bug 39098 due to Tinderbox orange. 2010-05-21 18:28:39 +02:00
Mats Palmgren
76d0a556b0 Bug 39098 - Elements with visibility:hidden, visibility:collapse, or display:none get copied to the clipboard. r=dbaron 2010-05-21 15:52:07 +02:00
Boris Zbarsky
d136b98028 Bug 562688 part 11. Eliminate eELEMENT usage in layout/generic. r=dbaron 2010-04-30 09:12:06 -04:00
Boris Zbarsky
9c2ad4b2aa Bug 562688 part 4. Change GetRootContent and the like to return Elements. r=jst, sr=sicking 2010-04-30 09:12:05 -04:00
Justin Lebar
5befe0c6b2 Bug 496275 - Expose JS API for modifying page's selection. r=mats, sr=jst 2010-04-28 19:47:23 +02:00
Peter Van der Beken
85c9e641b0 Fix for bug 533637 (Speed up unwrapping a node in quickstubs that use nsINode (dromaeo)). Pair every DOMCI to a specific C++ class. r=jst.
--HG--
extra : rebase_source : 9a7823b365cfca04bb08c5be94eab29d218f1e61
2010-01-12 14:08:43 +01:00
Craig Topper
c82a6bc194 Bug 253889: DeCOMtaminate nsIPresShell - GetCaret(). r=roc
--HG--
extra : rebase_source : 2a05050d8cbb10dd3bb763d5d5a158cc5f3dd814
2010-03-31 08:39:31 -04:00
Kyle Huey
5278cfe428 Backed out changeset 4b8936ac4a31 2010-03-30 19:56:44 -04:00
Craig Topper
61dba9a452 Bug 253889: More deCOMtamination of nsIPresShell. r=roc 2010-03-28 19:21:11 -04:00
Craig Topper
fd9001c409 Bug 554253 - Convert nsCOMPtr<nsPresContext> to nsRefPtr<nsPresContext>. r=roc
--HG--
extra : rebase_source : d828daca07188864d055f3d1a72f5217632eb358
2010-03-25 14:17:11 +01:00
Craig Topper
3d7073c4a5 Bug 253889: DeCOMtaminate nsIPresShell r=roc 2010-03-20 17:54:19 -04:00
Peter Van der Beken
e1c6294f66 Fix for bug 552716 (Remove NS_INTERFACE_MAP_ENTRY_CONTENT_CLASSINFO). r=jst.
--HG--
extra : rebase_source : 8e03b54ff6117dcac27188b296c59dcafbb6db78
2010-03-17 16:09:05 +01:00
Mats Palmgren
e5f8b2f7e8 Bug 544852, part 1: Remove nsCaret::GetCaretCoordinates. r=roc 2010-03-14 23:52:07 +01:00
Jonas Sicking
c7c7514f75 Bug 534136 Part 2: Use 16bit-char buffers inside atoms. r=bz sr=mrbkap 2010-03-08 07:45:00 -08:00
Mats Palmgren
29c9316331 Null-check the root pres context result. Unregister the plugin frame earlier, at Stop instead of Destroy time. b=521426 r=roc 2010-01-26 14:10:12 +01:00
Masayuki Nakano
019fb76261 Bug 539531 - Crash when I click-and-drag on a "Gordon" flash emulation [@ nsFrameSelection::ConstrainFrameAndPointToAnchorSubtree(nsIFrame*, nsPoint&, nsIFrame**, nsPoint&) ]. r=bz 2010-01-20 11:22:09 +01:00
Robert O'Callahan
29d6e5186d Bug 526394. Part 26: Rework nsSelection to use frames only. r=mats 2009-09-10 17:16:18 +12:00
Robert O'Callahan
cfa270791d Bug 526394. Part 17: Convert some selection-related code in nsTextControlFrame and nsSelection. r=mats 2009-09-03 17:23:47 +12:00
Robert O'Callahan
785abafda3 Bug 526394. Part 5: Fix up a bunch of sites to use nsIScrollableFrame instead of nsIScrollableView. r=mats 2009-09-01 23:29:27 +12:00
Boris Zbarsky
3f71dc9eea Bug 537419. mContent might be null here. r=dbaron 2009-12-31 20:37:57 -05:00
Boris Zbarsky
8b56c4f81d Bug 500882 part 5. Switch layout module to using the new GetPrimaryFrame API. r=roc 2009-12-24 16:20:06 -05:00
Masayuki Nakano
4bf3154454 Bug 42676 Can't drag to extend selection out of blocks with overflow:hidden/auto/scroll r=Olli 2009-12-12 13:25:21 +09:00
Robert O'Callahan
6050028e36 Bug 527306. Remove problematic flush in selectFrames. r=bz 2009-11-16 11:52:31 +13:00
Olli Pettay
29a1020c7d Bug 520070, r=bz
--HG--
extra : rebase_source : fcdc0ee7c15269db40c02b7cd930c6117d0a2fe2
2009-10-05 13:10:31 +03:00
David Zbarsky
3d96b7b4a7 Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst 2009-08-24 16:02:07 -04:00
Graeme McCutcheon
ad641e5247 Bug 510575 - fix calculation of bounds in nsTypedSelection::GetIndicesForInterval, and ensure range adding code always checks for duplicates. r=roc 2009-09-25 11:11:42 +01:00
Graeme McCutcheon
164332ae56 Bug 493111 - ASSERTION: Range index not returned. r=roc 2009-09-22 19:05:39 +01:00
Neil Deakin
a7f4a724cd Bug 516991, get the right scrollable view from within the selection scroll timer, otherwise scrolling is jumpy, r=roc 2009-09-17 16:33:29 -04:00
Mats Palmgren
dea07412a1 Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc 2009-09-16 17:01:36 +02:00
Neil Deakin
51b0e867e6 Bug 503943, add mouse capturing api to elements, remove capturing from views, r=roc,sr=smaug 2009-09-13 09:13:16 -04:00
Neil Deakin
cef5702d08 Bug 503943, back out mouse capture patch, CLOSED TREE 2009-09-10 12:11:41 -04:00
Neil Deakin
6d007b6255 Bug 503943, add mouse capturing api to elements, remove capturing from views, r=roc,sr=smaug 2009-09-10 08:51:36 -04:00
Alexander Surkov
1c8c857964 Bug 417929 - nsIAccessiblTable selectRows does not unselect previously selected rows, r=marcoz, davidb, ginn, smaug, sr=roc 2009-09-10 11:06:54 +08:00
Boris Zbarsky
8f435d226b Backed out changeset 4aa19414e651 (bug 488249) to fix test orange.
--HG--
extra : rebase_source : ae1c0155ec32b0887eff27ded77c6ba2b37dda64
2009-08-24 20:51:57 -04:00
David Zbarsky
0aa6350041 Bug 488249. Replace IsNodeOfType(eHTML) checks with namespace checks. r+sr=jst 2009-08-24 16:02:07 -04:00
Hashem Masoud
b71a1a1cfa Bug 489502 - Replace NS_ASSERTION(0, ...) by NS_ERROR(...) in mozilla-central; r=benjamin 2009-08-14 16:09:00 +02:00
timeless@mozdev.org
3c817bcdd3 Bug 506645 nsTypedSelection::AddItem doesn't always null check aOutIndex
r=smaug
2009-08-12 11:49:55 +02:00
timeless@mozdev.org
58d9ac5cce Bug 506258 nsFrameSelection::ConstrainFrameAndPointToAnchorSubtree doesn't seem to use anchorFrame or anchorFrameOffset
r=roc
2009-08-12 11:49:54 +02:00
Robert O'Callahan
421cab991c Bug 506874. Don't temporarily remove ranges from the selection while we alter the frame state. Also adds a bunch of selection tests. r=smaug
--HG--
extra : rebase_source : 5d4fd55728e1167cc57451b5c80a46643191678b
2009-08-03 14:12:57 +12:00
Michael Kohler
4b7c87c984 Bug 106386 - Correct misspellings in source code (old); Part 2; r=timeless 2009-07-27 10:47:02 +02:00
Robert O'Callahan
8bab94a96a Bug 371839. Simplify SetSelected signature and semantics, and reimplement it in nsTextFrame much more efficiently. r=bzbarsky
--HG--
extra : rebase_source : 18c390e3ebd09de82b1a23699c56b741f928ca37
2009-07-27 10:05:41 +12:00
Graeme McCutcheon
1c6412faca Bug 348681 follow-up comment fix. 2009-05-09 22:36:17 +01:00
Graeme McCutcheon
7c815c938d Bug 348681 - Don't allow overlapping ranges in the selection. r+sr=roc 2009-05-09 22:30:19 +01:00
L. David Baron
e51a27d783 Traverse and unlink selection listeners. (Bug 490071) r+sr=peterv 2009-05-08 21:59:26 -07:00
Masayuki Nakano
cfff67f8c9 Bug 482138 [TSF] nsTextFrame has to draw composition string by TIP specified style r+sr=roc 2009-04-23 12:27:12 +09:00
Boris Zbarsky
d631c2329b Bug 488417. Need to hold strong refs to ranges across calling RemoveRange. r+sr=roc 2009-04-21 15:57:40 -04:00
Boris Zbarsky
bff20cf17a Bug 486547. Fix build bustage on Windows 2009-04-06 14:39:02 -04:00
Boris Zbarsky
15b0e0b5f3 Bug 486547 part 7. Simplify some more of the table code in nsFrameSelection. r+sr=smaug 2009-04-06 13:21:30 -04:00
Boris Zbarsky
aa115a4e74 Bug 486547 part 6. Simplify some cell-related code in nsFrameSelection. r+sr=smaug 2009-04-06 13:20:32 -04:00
Boris Zbarsky
17796c6f64 Bug 486547 part 5. Switch various table cell selection stuff off nsIDOMRange. r+sr=smaug 2009-04-06 13:20:30 -04:00
Boris Zbarsky
fe07c58568 Bug 486547 part 4. Switch some more code off nsIDOMNode/nsIDOMRange r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky
75e8ba1c24 Bug 486547 part 3. Eliminate the Fetch*Node methods of nsTypedSelection. r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky
f92fc0c496 Bug 486547 part 2. Switch nsFrameSelection::mMaintainRange to storing nsIRange, not nsIDOMRange. r+sr=smaug 2009-04-06 13:17:38 -04:00
Boris Zbarsky
081b4b02e7 Bug 486547 part 1. Switch nsTypedSelection to storing nsIRange, not nsIDOMRange, objects. r+sr=smaug 2009-04-06 13:17:37 -04:00
Olli Pettay
b6cf78a6a8 Bug 478245 - Crash [@ nsEventStateManager::PreHandleEvent], r+sr=dbaron 2009-03-11 17:43:08 +02:00
Olli Pettay
58e1a51801 Bug 466856 - Crash [@ nsTypedSelection::CopyRangeToAnchorFocus], r+sr=roc 2009-02-26 18:36:34 +02:00
Peter Van der Beken
122dcedc98 Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz. 2009-01-14 13:24:10 +01:00
Peter Van der Beken
c31332c26a Back out changeset 9fd8740decb8 (Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles).) to try to fix orange. 2009-01-14 15:12:37 +01:00
Peter Van der Beken
2353ea8945 Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz. 2009-01-14 13:24:10 +01:00
Benjamin Smedberg
3498a5f86e Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.

--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
Benjamin Smedberg
73a6fab34b Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal. 2009-01-09 11:35:24 -05:00
Benjamin Smedberg
802d1a10c7 Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted

Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.

r+sr=roc

This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
Uri Bernstein
030cd64a09 Set mMaintainRange to null when there is no selection. b=470212 r=mats sr=roc 2009-01-08 22:17:49 +01:00
Mats Palmgren
4097da34ae Don't crash if views were destroyed while flushing notifications. b=421839 r+sr=roc 2008-12-08 00:11:37 +01:00
Vladimir Vukicevic
5ab3bffacb b=461813, crash in nsFrameSelection::HandleDrag; r+sr=roc 2008-11-04 11:29:13 -08:00
Markus Stange
1b2252f6c6 Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc 2008-11-04 15:38:16 +01:00
Benjamin Smedberg
bb3bf9ec94 Bug 461212 - deCOM frame traversal (relanding) r=mats.palmgren sr=roc 2008-10-30 10:15:22 -07:00
Benjamin Smedberg
555c5a8f1c Backed out changeset affcc1c08bc0 (deCOM frame enumerator) due to regression from it or bug 461410. 2008-10-28 02:47:40 -04:00
Benjamin Smedberg
2127dcfc13 Bug 461212 - deCOM frame enumerator, r=mats.palmgren sr=roc 2008-10-28 00:47:19 -04:00
Uri Bernstein
2ed96f2ef8 Bug 459921 - Double-click-and-drag selects previous word when dragging to left half of first letter of a word. r+sr=roc. 2008-10-21 11:52:52 +02:00
Uri Bernstein
269b19b637 Bug 415707 - multiple text selection improvement doesn't work with double-click "word-by-word" or triple-click "paragraph" modes. r+sr=roc. 2008-10-17 21:46:33 +02:00
Theppitak Karoonboonyanan
88e1b95b7b Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc 2008-10-16 20:44:32 +13:00
Olli Pettay
3cba110fca bug 302775 - extractContents doesn't work if start and end node of a Range object is an attribute node, r=peterv, sr=sicking 2008-10-15 12:40:28 +03:00
Uri Bernstein
ce54716f69 Bug 459660: Remove two unused members of nsTypedSelection and their accessors. r+sr=roc. 2008-10-13 23:25:21 +02:00
Uri Bernstein
3f918b6ada Bug 459588: Kill OLD_SELECTION code. r+sr=roc. 2008-10-13 00:11:51 +02:00
Uri Bernstein
3481ddfc0c Bug 426766: Cursor keys behave weirdly in "view source" window. r+sr=roc. 2008-10-09 12:07:16 +02:00
Uri Bernstein
361456a3f9 Bug 458089: Kill VISUALSELECTION code. r=smontagu, sr=roc. 2008-10-09 12:05:30 +02:00
Alexander Surkov
5ac5f8dad5 Bug 456944 - Crash when spell checking selection changes, r=smaug, sr=roc 2008-10-08 20:53:14 +08:00
Graeme McCutcheon
bc94c13609 Bug 451252 - "Highlight All" find selection not visible in elements that have -moz-user-select: none set; r+sr=roc 2008-09-07 16:12:50 +02:00
Uri Bernstein
8c80506f1c Merge commit for bug 210197 2008-08-09 19:34:08 +03:00
Uri Bernstein
514fbf8ecc Unconditionally reset mDragSelectingCells to false on mouse-up, so that the system doesn't remain in table selection mode when dragging outside a table. bug=210197. r+sr=mats.palmgren 2008-08-09 18:09:37 +03:00
Asaf Romano
c9d1d9a951 Bug 263683 - Findbar's Highlight feature should not manipulate the DOM. Patch by Graeme McCutcheon <graememcc_firefox@graeme-online.co.uk>, r=me,roc. sr=roc. 2008-07-30 23:48:56 +03:00
Alexander Surkov
d6ba6d4413 bug 345759 - Spell as you type not accessible, r=aaronlev, r=Olli.Pettay, sr=neil 2008-07-17 14:06:24 +02:00
John Daniels
b006229ae6 Bug 419532 – deCOMtaminate nsICaret. r+sr=roc 2008-07-16 12:52:01 +02:00
Benjamin Smedberg
556cf36dc9 Bug 442729 - Annotate stack-only classes in layout, r+sr=roc 2008-07-01 15:16:45 -04:00
gavin@gavinsharp.com
908c443de8 Bug 423523: Caret can leave div w/ contenteditable = true with repeated arrow keys, patch by Chris Pearce <chris@pearce.org.nz>, r+sr=peterv, a=beltzner 2008-04-23 15:33:14 -07:00
dbaron@dbaron.org
4589e85ab3 Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons 2008-04-14 18:04:18 -07:00
uriber@gmail.com
1f2fa3ef01 When adding a range to the selection, set the anchor focus to the added range, rather than the last range in the selection. bug=392746 r+sr=roc a1.9=beltzner. Mochitest (v3) by Martijn Wargers. 2008-03-31 10:47:42 -07:00
uriber@gmail.com
8563131a37 reverting fix for 392746 due to unexplained failure of /tests/toolkit/content/tests/widgets/test_colorpicker_popup.xul 2008-03-30 14:55:37 -07:00
uriber@gmail.com
06d2ad2c92 When adding a range to the selection, set the anchor focus to the added range, rather than the last range in the selection. bug=392746 r+sr=roc a1.9=beltzner. Mochitest by Martijn Wargers. 2008-03-30 11:13:29 -07:00
masayuki@d-toybox.com
1c98c2e245 Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner 2008-02-28 07:28:37 -08:00
masayuki@d-toybox.com
076b8bba8e backing out the previous patch, becaused qm-centos5-01 dep unit test is orange 2008-02-28 05:59:25 -08:00
masayuki@d-toybox.com
600836e7ed Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner 2008-02-28 03:01:56 -08:00
mats.palmgren@bredband.net
decb9c279b Make nsTypedSelection ctors initialize all members (fixes an UMR) and reorder members to save space. b=417895 r+sr=roc a=blocking1.9 2008-02-26 07:04:14 -08:00
roc+@cs.cmu.edu
709741beff Bug 157546. 'Delete' key should delete entire cluster. patch by Theppitak Karoonboonyanan, r+sr=roc,a=schrep 2008-02-21 18:24:04 -08:00
reed@reedloden.com
36a557fc04 Back out patch from Theppitak Karoonboonyanan in bug 157546 due to test failures. 2008-02-20 03:10:16 -08:00
reed@reedloden.com
61f93061b0 Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=schrep] 2008-02-20 02:19:31 -08:00
reed@reedloden.com
2eddcd6e28 Back out Theppitak Karoonboonyanan's patch from bug 157546 due to a regression (bug 417745). 2008-02-15 12:20:55 -08:00
reed@reedloden.com
636da4197c Bug 157546 - "[CTL-Thai] IM: <delete> key should delete WHOLE Thai "display cell"" [p=thep@linux.thai.net (Theppitak Karoonboonyanan) r+sr=roc a1.9=beltzner] 2008-02-14 21:30:34 -08:00
Olli.Pettay@helsinki.fi
a0a74f16e7 Bug 368760, r=mats, sr=roc, a=blocking1.9+ 2007-11-22 12:47:33 -08:00
tglek@mozilla.com
8cf3fb1c90 Clean up prbool misuse in layout. bug 398312, r+sr+a=dbaron 2007-10-09 17:00:05 -07:00
joshmoz@gmail.com
f219b51c26 remove XP_MAC usage. b=281889 r=cbarrett sr=roc a=roc 2007-10-01 16:20:37 -07:00
surkov.alexander@gmail.com
26ecb5656e Bug 371680 - expose nsIAccessibleText::scrollSubstringTo, r=aaronlev, roc, sr=roc, a=roc 2007-08-23 21:54:45 -07:00
bzbarsky@mit.edu
733ec5dc31 Make sure layout is up to date before moving the caret. Bug 375436 followup to fix orange, pending reviews from roc. 2007-08-21 22:13:24 -07:00
bzbarsky@mit.edu
e51e8403e6 Make sure to process style updates before reflow, and both before painting. Bug 375436, r+sr=roc, a=dbaron 2007-08-21 19:57:06 -07:00
philringnalda@gmail.com
42675246db Bug 390423 - Simplify the signature of nsIFrame::GetPointFromOffset, patch by Ben Karel <web+moz@eschew.org>, r=aaronlev/elif, sr=roc, a1.9=dbaron 2007-08-16 20:43:00 -07:00
mats.palmgren@bredband.net
37fce74e9b Make GetFirstCellNodeInRange() deal with document node in the range. b=391747 r=Olli.Pettay sr+a=roc 2007-08-16 05:42:25 -07:00
mats.palmgren@bredband.net
7940ebdc50 Use NS_IMPL_ISUPPPORTS macros where possible. b=387211 r=neil sr=dbaron a19=pavlov 2007-08-07 08:18:36 -07:00
jwalden@mit.edu
6d7584839a Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros. 2007-07-08 00:08:04 -07:00
peterv@propagandism.org
6662efd338 Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking. 2007-06-27 19:48:16 -07:00
peterv@propagandism.org
90c374d7c3 Backing out to fix orange. 2007-06-27 16:21:05 -07:00
peterv@propagandism.org
7bf2741259 Fix for bug 237964 (Allow editable areas in browser (contentEditable)). r/sr=sicking. 2007-06-27 15:29:45 -07:00
mrbkap@gmail.com
3abd13b642 Don't depend on undefined behavior (sign extension on right shift). bug 385259, r=mats.palmgren sr=jst 2007-06-25 14:53:21 -07:00
bzbarsky@mit.edu
eeaa1a101b Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc. 2007-03-30 14:11:41 -07:00
Olli.Pettay@helsinki.fi
04a93cc490 Bug 375093, Crash [@ nsTypedSelection::ScrollIntoView] when right-clicking paste in input which then gets destroyed oninput, r+sr=dbaron 2007-03-23 10:32:34 -07:00
Olli.Pettay@helsinki.fi
74955417c0 Bug 374937, Crashes [@ nsTypedSelection::GetFrameSelection], r+sr=roc 2007-03-22 17:06:38 -07:00
Olli.Pettay%helsinki.fi
1f2499afdc Bug 373586 , r+sr=roc 2007-03-19 10:23:29 +00:00