Commit Graph

61393 Commits

Author SHA1 Message Date
Cameron McCormack
3f1ff5c074 Bug 1419645 - Make VerifyReflow work with stylo. r=dbaron
MozReview-Commit-ID: 3ZSQqes8nmA

--HG--
extra : rebase_source : ed4be0144651b2c0343f1d17245401662e089389
2017-11-22 12:03:24 +08:00
Cameron McCormack
a4faae04a1 Bug 1419709 - Move a few nsStyleStructID-related static methods out of nsRuleNode.h r=emilio
MozReview-Commit-ID: GyEMmvlH4mh

--HG--
extra : rebase_source : feffb9d535fda9316dc9e34a5170ffabda3b5e22
2017-11-22 18:08:33 +08:00
Emilio Cobos Álvarez
72a1d3ff81 Bug 1419554: Teach the restyle root code about elements outside of the flattened tree. r=heycam
The textarea is inserted under a Shadow host, with no matching insertion point,
so its flattened tree parent node is null.

We're treating this case in the restyle root code as "the parent is the
document", but that's very wrong.

MozReview-Commit-ID: JlzUMRIYaYZ

--HG--
extra : rebase_source : feeaf7a7333097aa87b35358172472790f6c74a7
2017-11-22 14:15:34 +01:00
Margareta Eliza Balazs
2cb7aeff33 Backed out 5 changesets (bug 1417709) for failing X in devtools/shared/tests/unit/test_css-properties-db.js r=backout on a CLOSED TREE
Backed out changeset 5670c9582add (bug 1417709)
Backed out changeset 50f0febe43a0 (bug 1417709)
Backed out changeset 29e6c0d82193 (bug 1417709)
Backed out changeset e3a6c5b74595 (bug 1417709)
Backed out changeset a0fe569c86c0 (bug 1417709)
2017-11-23 01:17:07 +02:00
Brian Grinstead
2214548e2c Bug 1416493 - Remove the menuseparator XBL binding;r=Gijs
Key accessibility off of the tag name instead of the role attribute
and load styles in global.css instead of <resources>

MozReview-Commit-ID: Epv0rHHzbz0

--HG--
extra : rebase_source : 2239c8ccca8d899b4c4144faab7212f120f00e23
2017-11-22 13:47:09 -08:00
shindli
a0b20fcb81 Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE 2017-11-22 23:42:02 +02:00
Sebastian Hengst
925c9f36c0 Backed out 4 changesets (bug 1417251) for reftest failures, e.g. in box-decoration-break-with-outset-box-shadow-1.html. r=backout on a CLOSED TREE
Backed out changeset cdd6eb876d3d (bug 1417251)
Backed out changeset c2b174094be3 (bug 1417251)
Backed out changeset 9a85c4bd47e4 (bug 1417251)
Backed out changeset a9f5ffd87cd5 (bug 1417251)
2017-11-22 18:34:58 +02:00
James Willcox
bacda12532 Bug 1409113 - Add nsIPresShell::HasHandledUserInput() r=masayuki
MozReview-Commit-ID: 3Yr5UmFJx5h
2017-11-22 10:09:04 -06:00
Jonathan Watt
cecce2a5cf Bug 1417251 fixup part 2 - Guard against gCurrentURL being null. r=me
MozReview-Commit-ID: KyCLANeYFwS
2017-11-03 13:18:51 +00:00
Jonathan Watt
838eb11c41 Bug 1417251, part 2 - Remove skip-if(styloVsGecko) for various reftests. r=bz
MozReview-Commit-ID: AvbAi2ObY5P
2017-11-03 12:46:18 +00:00
Jonathan Watt
c73cc60a66 Bug 1417251, part 1 - Make the reftest harness support loading of consecutive URIs differing only by hash. r=dbaron,bz
When the URIs of consecutively loaded tests/references differed only by hash
we would previously do an anchor scroll causing us to fail timing out
waiting for a 'load' event that would never come.  This change makes us load
such URIs using nsIWebNavigation.LOAD_FLAGS_BYPASS_CACHE to force a reload of
the document.

MozReview-Commit-ID: 6Fhy9h1tZol
2017-11-03 08:35:08 +00:00
Jonathan Watt
2f89e4a502 Bug 1417251, part 0 - Fix race in layout/reftests/css-ui/caret-color-01-ref.html. r=me
Previously the test relied on Ahem.ttf being preloaded. It now uses
MozReftestInvalidate to make sure the Web font is loaded before
calling getBoundingClientRect.

MozReview-Commit-ID: FcW3CCRu6iW
2017-11-02 21:17:50 +00:00
Andrea Marchesini
ad64933e5a Bug 1419382 - Moving ownership of nsIInputStream when using netUtil functions - part 2 - NS_NewInputStreamChannel, r=smaug 2017-11-22 11:18:36 +01:00
Ciure Andrei
c7cf019289 Merge mozilla-central to mozilla-inbound. r=merge a=merge CLOSED TREE 2017-11-22 12:20:25 +02:00
Emilio Cobos Álvarez
45e3d61978 Bug 1419355: Add a test for non-content-accessible properties. r=xidorn
MozReview-Commit-ID: 8xYR59rj7cL
2017-11-22 10:55:25 +01:00
Ciure Andrei
4c8b383855 Backed out 1 changesets (bug 1417903) for permafailing /css/vendor-imports/mozilla/mozilla-central-reftests/masking/mask-mode-d.html r=backout a=backout on a CLOSED TREE
Backed out changeset fec67e7c728d (bug 1417903)
2017-11-22 11:46:40 +02:00
KuoE0
838454dac7 Bug 1419337 - Remove aStyleContext parameter from nsFrameConstructorState::AddChild(). r=TYLin
We don't use aStyleContext inside nsFrameConstructorState::AddChild(), so I
think we should remove it.

MozReview-Commit-ID: JQUlEDyVcUj

--HG--
extra : rebase_source : 0569c6c010e98915bb288da16457e1d3c62403cd
2017-11-21 18:01:53 +08:00
Cameron McCormack
0a5fdb11a0 Bug 1419652 - Remove HandleRefPtr. r=TYLin
This class was used back when we didn't have a base class for CSSStyleSheet
and ServoStyleSheet.  Now it's unused.

MozReview-Commit-ID: 8xaMAA3Opf7

--HG--
extra : rebase_source : fe507762ba80ab54ca2a87e84faa8bc1a1a8590f
2017-11-22 13:11:12 +08:00
Hiroyuki Ikezoe
e41b79a2e7 Bug 1418867 - Crash test for the case where the parent element has no style data for pseudo. r=emilio
MozReview-Commit-ID: 977gqyZTob2

--HG--
extra : rebase_source : b8c5887782fd461f403467b3f761596d53e2133c
2017-11-22 12:20:15 +09:00
Hiroyuki Ikezoe
33e7b8838f Bug 1418867 - Pass element or pseudo element to Servo_StyleSet_GetBaseComputedValuesForElement(). r=emilio
MozReview-Commit-ID: Ae3iZ6g3x3c

--HG--
extra : rebase_source : 8d07ac08d63cfdb96cb07a73ed86b268d6b5026e
2017-11-22 11:03:40 +09:00
Hiroyuki Ikezoe
1646278bfe Bug 1418867 - getUnanimatedComputedStyle throws an exception for non-existent pseudo element. r=birtles
This is a prerequisite change for passing pseudo element to
Servo_StyleSet_GetBaseComputedValuesForElement which will be done in the next
commit.

MozReview-Commit-ID: HEGF2wjBGEP

--HG--
extra : rebase_source : 58d5991f3e4559c4215292ee8c48f79b38acb54a
2017-11-22 09:57:31 +09:00
Matt Woodrow
9165b3a1fb Bug 1418945 - Always use the new-list ordering when merging display list since it's guaranteed to be correct. r=miko 2017-11-22 15:10:31 +13:00
Matt Woodrow
69caf9d4bd Bug 1417947 - Mark the correct frame as modified when invalidating due to blend mode. r=miko 2017-11-22 15:10:22 +13:00
Coroiu Cristina
9eb4f34b0a Merge mozilla-central to inbound. r=merge a=merge on a CLOSED TREE 2017-11-22 01:50:20 +02:00
Coroiu Cristina
d6a2b15dbc Merge inbound to mozilla-central r=merge a=merge 2017-11-22 01:32:34 +02:00
Bas Schouten
455444a0f4 Bug 1417903: Make ImageRenderer use IntoLuminanceSource. r=dvander
MozReview-Commit-ID: 4fr3Koliieq
2017-11-22 00:27:34 +01:00
Jonathan Kew
09faef79f5 Bug 1418724 - part 2 - Force reflow of all content when locale prefs change, so that we can pick up modifications to the preferred ordering of CJK fonts without requiring restart or page reload. r=m_kato 2017-11-21 11:02:20 +00:00
Cameron McCormack
1dbd7f57c6 Bug 1418245 - Move @-moz-document matching function out of css::DocumentRule. r=TYLin
MozReview-Commit-ID: 81dCiFosF0V

--HG--
extra : rebase_source : 9852380c896530538e2b5b1415513cedb4b2e5e1
2017-11-17 17:31:22 +08:00
Emilio Cobos Álvarez
4061ff0e69 Bug 1417781: Consider style structs as not equal if visited styles on them are changed. r=heycam
This change should be also fine for the Gecko callers, but please double-check.

MozReview-Commit-ID: 5ZntHeBt5wC

--HG--
extra : rebase_source : d623693f690e933ccc67881795b3e4f5289e9fa4
2017-11-21 00:53:51 +01:00
Cameron McCormack
c4a2859c9e Bug 1418899 - Followup speculative Windows build fix. (CLOSED TREE) 2017-11-21 17:11:40 +08:00
Cameron McCormack
0a20585745 Bug 1418899 - Part 4: Move image layer filling function out of nsRuleNode. r=cjku
MozReview-Commit-ID: 2FXGFEkpIKE

--HG--
extra : rebase_source : 280c85f0e53e6426289580a345685898888ed266
2017-11-20 13:53:58 +08:00
Cameron McCormack
630cd9c74f Bug 1418899 - Part 3: Use a single image layer array filling function. r=cjku
We were accidentally using the background one for the mask layers list anyway,
and I don't think the overhead of filling the arrays for the two properties
mask layers don't use is a problem.

MozReview-Commit-ID: 7LDiYGrnUd5

--HG--
extra : rebase_source : 573d70e0e8c4d110ca6da2846e6fd2887b1fded2
2017-11-20 13:44:22 +08:00
Cameron McCormack
3991f1ba0d Bug 1418899 - Part 2: Move some font-related static methods out of nsRuleNode. r=TYLin
MozReview-Commit-ID: 3l9L6bHr0PJ

--HG--
extra : rebase_source : 4d60e21f70a0e8b7a54b009ca6f5d6c2c90a80bd
2017-11-20 12:43:21 +08:00
Cameron McCormack
d8a0eb82de Bug 1418899 - Part 1: Remove some unused method declarations on nsRuleNode. r=TYLin
MozReview-Commit-ID: FOBOjJRJCea

--HG--
extra : rebase_source : ff3bf2cccf2ec21bdbaf61c8112ee97bc3306bfe
2017-11-20 13:09:16 +08:00
Ting-Yu Lin
dc7e13b5d5 Bug 1418905 - Move nsRuleNode::ComputeCoordPercentCalc() into nsStyleCoord. r=heycam
MozReview-Commit-ID: GLLseBxhUiP

--HG--
extra : rebase_source : 2940610dbb5e81e463db82459a46a54eb693e5cb
2017-11-20 14:05:19 +08:00
Ting-Yu Lin
320b123d4b Bug 1418905 - Move nsRuleNode::ComputeComputedCalc() into nsStyleCoord. r=heycam
MozReview-Commit-ID: LFxZGzyyii6

--HG--
extra : rebase_source : 516a8ed1a372d483f4c96cd392c1d382b0b4e38a
2017-11-20 13:30:27 +08:00
Miko Mynttinen
8f00af8953 Bug 1415485 - Make the pref layout.display-list.retain live again r=mattwoodrow
MozReview-Commit-ID: 6QFc4Sq3WiC

--HG--
extra : rebase_source : 268c2959d38e955d1af9ab39fdb8cce0146788e3
extra : intermediate-source : 7ee9657574a2ee223b6184d1657803a0d382be59
extra : source : 558439637eba09eaae8a653ffc77d5830b16ff42
2017-11-09 16:10:21 +01:00
Gerald Squelart
d886d393e0 Bug 1418851 - Inlined constant-time definition of nsDisplayItem::Count() - r=mattwoodrow
The "linear time" comment was rendered incorrect by bug 1404181.
And as the body is now only returning a member variable, it's more efficient
and maintainable to just have it to the header.

MozReview-Commit-ID: 4vjB1PyemxR

--HG--
extra : rebase_source : 8089dd66218922a07ffcca9a35f9809522752255
2017-11-21 09:14:32 +11:00
Brindusan Cristian
9bd6ed7630 Merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
--HG--
extra : amend_source : 4c68fb1a967a7c1b64e9779851573eb29a412908
2017-11-21 00:24:13 +02:00
Cosmin Sabou
fdc83a94aa Merge inbound to mozilla-central r=merge a=merge 2017-11-21 00:01:02 +02:00
Joel Maher
dd460b6416 Bug 1418406 - Disable css-invalid/select/select-disabled-fieldset-1.html on android for perma failures. r=me, a=testonly 2017-11-20 04:59:53 -05:00
Cameron McCormack
468dc30c34 Bug 1418872 - Move ControlCharVisibilityDefault() out of nsCSSParser. r=TYLin
MozReview-Commit-ID: EkNq7lREGgA

--HG--
extra : rebase_source : 689d4a9baa6c05acafb72fa6b042b21b4befd752
2017-11-20 10:46:45 +08:00
Hiroyuki Ikezoe
49f31bb414 Bug 1418059 - Stop eagerly CSS animations on the root of display:none subtree. r=birtles
Otherwise we do update keyframes data unnecessarily.

MozReview-Commit-ID: ys4BEF1kxX

--HG--
extra : rebase_source : 725aef9a4be9296bc992f6128be7c62b4c2b01e1
2017-11-20 13:56:26 +09:00
Ting-Yu Lin
264402226f Bug 1417376 Part 3 - Pass nsPoint parameters by const references instead of values. r=mats
It's good to save some copy constructor calls.

MozReview-Commit-ID: 6TveqwkOvc0

--HG--
extra : rebase_source : 02e678f985c074f6c972cf8478e233aa5e4607db
2017-11-15 17:55:36 +08:00
Ting-Yu Lin
7326c2887e Bug 1417376 Part 2 - Pass nsPoint parameters by const references instead of references. r=mats
MozReview-Commit-ID: 6TveqwkOvc0

--HG--
extra : rebase_source : d4674181a6198279bedbfc2efe4e0b1715c91d51
2017-11-15 18:26:10 +08:00
Markus Stange
fd4ef8574d Bug 1418836 - Add restyle markers in a place that I missed in bug 1350930. r=bz
MozReview-Commit-ID: 4lj6W02JwHM

--HG--
extra : rebase_source : eb1665225f5742ab9871f1bb6ac202bf16ac2ac0
2017-11-19 16:44:08 -05:00
Emilio Cobos Álvarez
ca0edc11ac Bug 1415843: Remove an unneeded call to AdjustAppendParentForAfterContent. r=bz
I don't know why GetInsertionPrevSibling would get the parent wrong.

IsValidSibling handles the frameset case and a lot of the table caption cases.

The table caption cases IsValidSibling can't handle are due to elements which
create frames based on something other than display.

For those cases, while IsValidSibling will return incorrect results, we will end
up seeing that the parent frame is the wrong type after creating the frame
construction items for the new stuff and reframe under WipeContainingBlock.

MozReview-Commit-ID: 5b3L4CB6Oxl

--HG--
extra : rebase_source : c3559dae0b5f4de72fbf5031bdded48f79df6216
2017-11-08 15:38:09 +01:00
Emilio Cobos Álvarez
ebfcd1dbd3 Bug 1414999: Synchronously clean style data from the DOM tree when the shell goes away. r=bz
There's nothing preventing the flat tree from changing while the document
doesn't have a shell. In that case, we really really don't want to lose track
of elements with stale style data, since then we'll mess up.

It's ok to _not_ clear the style data when the document goes into the BFCache
though, because the document is thrown away if other document runs script and
touches the cached DOM.

MozReview-Commit-ID: 4W3xDAnnLPL
2017-11-20 22:11:23 +01:00
Emilio Cobos Álvarez
1e0a205233 Bug 1418560: Don't build IsFlattenedTreeChild in release builds. r=bustage
MozReview-Commit-ID: GP7Qds5loBI
2017-11-20 18:07:06 +01:00
Emilio Cobos Álvarez
02c0028d6e Bug 1418560: Properly return null from GetFlattenedTreeParent if the node is XBL fallback content and the binding is active. r=heycam
Otherwise we may inappropriately style it or what not. This asserts with the
patches of bug 1414999 plus the cleanup of bug 1418456, since we no longer do
StyleNewChildren (which walks over the flattened tree children).

Too bad that GetXBLBinding is a virtual call in Gecko, probably can do just
MAY_BE_IN_BINDING_MGR...

MozReview-Commit-ID: CNU0YdKeaR0
2017-11-20 17:32:07 +01:00