Commit Graph

4280 Commits

Author SHA1 Message Date
ffxbld
7a35fa9703 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-03-09 15:41:51 +00:00
Mark Banner
2c4e35b0a6 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509

--HG--
extra : moz-landing-system : lando
2020-03-08 21:45:16 +00:00
Mark Banner
15cfe23b88 Bug 1620542 - Automatically fix ESLint errors in .eslintrc.js files. r=mossop
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D65703

--HG--
extra : moz-landing-system : lando
2020-03-07 10:09:44 +00:00
Lina Cambridge
be55ac8482 Bug 1615931 - Handle invalid bookmark URLs in new bookmark sync. r=markh,LougeniaBailey
This commit changes `Store::local_row_to_item` to validate local URLs,
and flags items with malformed URLs as invalid. These items are either
replaced with valid remote copies, if they exist, or deleted if not.
Additionally, `BaseBookmarksStore#_calculateIndex` no longer throws
when determining the sort index for an item with an invalid URL.

As an aside, we use the `url` crate to parse URLs. This is the same
crate as used by `MozURL`, which, in turn, backs the JS `URL`
constructor...so URLs should be validated the same way in Rust and JS.

Differential Revision: https://phabricator.services.mozilla.com/D64695

--HG--
extra : moz-landing-system : lando
2020-03-02 02:11:13 +00:00
Christian Holler
a801538b51 Bug 1344085 - Re-enable sync services tests under ASan. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D64565

--HG--
extra : moz-landing-system : lando
2020-02-28 03:57:50 +00:00
ffxbld
0d739c0fa1 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-02-10 10:58:31 +00:00
Christian Holler
71231ac083 Bug 1612707 - Disable various slow tests under TSan. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D61562

--HG--
extra : moz-landing-system : lando
2020-02-04 14:34:07 +00:00
Mark Banner
77a7218e90 Bug 1609966 - Enable ESLint for services/sync/modules/constants.js. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D60280

--HG--
extra : moz-landing-system : lando
2020-01-17 19:27:31 +00:00
Siddhant085
676ce0d13c Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-16 18:38:54 +00:00
Shane Caraveo
8351044ded Bug 1524327 remove MOZ_ALLOW_LEGACY_EXTENSIONS and extensions.legacy.enabled r=zombie,aswan
Legacy extensions are no longer loaded, so we can drop the build config for it.  We
still need flags for handling experimental APIs since what we require differs between builds
and distributions.

Differential Revision: https://phabricator.services.mozilla.com/D57413

--HG--
extra : moz-landing-system : lando
2020-01-15 21:38:40 +00:00
shindli
3d28702804 Backed out changeset 1bdfd7c37b02 (bug 1511700) for causing newtab node test failure CLOSED TREE 2020-01-13 22:33:58 +02:00
Siddhant085
d48342d7db Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753

--HG--
extra : moz-landing-system : lando
2020-01-13 16:25:39 +00:00
ffxbld
96ff1ca153 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2020-01-06 15:53:38 +00:00
Mark Hammond
2f0396d567 Bug 1582317 - record the sync storage node type in the sync telemetry ping. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D55196

--HG--
extra : moz-landing-system : lando
2019-12-14 04:26:05 +00:00
Mark Hammond
695f37d9b1 Bug 1597868 - refresh the fxa device list each 2 hours instead of each sync. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D55590

--HG--
extra : moz-landing-system : lando
2019-12-03 16:07:46 +00:00
ffxbld
2eb3b6566d Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-12-02 11:59:11 +00:00
Mark Hammond
818e5a5c52 Bug 1598997 - Mock profile fetching function in xpcshell tests. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D54450

--HG--
extra : moz-landing-system : lando
2019-11-25 21:21:46 +00:00
Moritz Birghan
975648e245 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-11-18 13:03:58 +00:00
Mark Hammond
c56be6e72f Bug 1594704 - ensure sync data choices made before connecting sync are honored. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D53138

--HG--
extra : moz-landing-system : lando
2019-11-15 19:12:16 +00:00
Mark Hammond
7979d6602b Bug 1596659 - Delete declineDisabled from engines.js. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D53141

--HG--
extra : moz-landing-system : lando
2019-11-15 20:04:53 +00:00
Mark Hammond
e57be9d2f3 Bug 1594929 - Remove invalidateCertificate from FxAccountsKeys.jsm. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D52623

--HG--
extra : moz-landing-system : lando
2019-11-12 04:05:28 +00:00
rfkelly
048a518c75 Bug 1591312 - Revert to using BrowserID to generate OAuth tokens. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D50770

--HG--
extra : moz-landing-system : lando
2019-11-08 06:28:54 +00:00
Coroiu Cristina
27a753cc4a Backed out changeset 96048cce4b80 (bug 1571656) for xpcshell failures at toolkit/components/places/tests/unifiedcomplete/test_autofill_origins.js on a CLOSED TREE 2019-11-06 22:59:45 +02:00
Moritz Birghan
70c7a633fb Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-11-06 18:07:54 +00:00
Thom Chiovoloni
0aee355709 Bug 1582263 - Move devices list to top level of sync ping. r=markh
Move devices list to top level of sync ping

Differential Revision: https://phabricator.services.mozilla.com/D49194

--HG--
extra : moz-landing-system : lando
2019-11-05 17:21:12 +00:00
Thom Chiovoloni
962b41a45b Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment

Differential Revision: https://phabricator.services.mozilla.com/D49166

--HG--
extra : moz-landing-system : lando
2019-10-25 21:38:01 +00:00
lougenia
4a5ba28d8a Bug 1588948 - Check passwords engine handles incoming records with null or missing username fields r=lina
Differential Revision: https://phabricator.services.mozilla.com/D49805

--HG--
extra : source : b300b58faf473a242d4ed3428a97dec17bcd862c
2019-10-23 17:49:51 +00:00
Cosmin Sabou
68edcb2abb Backed out changeset b300b58faf47 (bug 1588948) for browser chrome failures on test_basic_form_autocomplete.html. 2019-10-24 02:06:37 +03:00
lougenia
8fff38140a Bug 1588948 - Check passwords engine handles incoming records with null or missing username fields r=lina
Differential Revision: https://phabricator.services.mozilla.com/D49805

--HG--
extra : moz-landing-system : lando
2019-10-23 17:49:51 +00:00
Oana Pop Rus
5033d599b4 Backed out changeset 3d7b77564cb7 (bug 1238810) for bc perma failures in browser_startup.js on a CLOSED TREE 2019-10-24 00:38:10 +03:00
Thom Chiovoloni
b8fe187695 Bug 1238810 - Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment. r=chutten,markh,loines
Replace {FXA,WEAVE}_CONFIGURED with entries in the telemetry environment

Differential Revision: https://phabricator.services.mozilla.com/D49166

--HG--
extra : moz-landing-system : lando
2019-10-15 22:57:58 +00:00
Drew Willcoxon
c7e19ee271 Bug 1579334 - Properly limit remote tab matches in the quantumbar. r=mak
This is a narrow patch that simply adds a `maxMatches` param to `PlacesRemoteTabsAutocompleteProvider.getMatches`.

Differential Revision: https://phabricator.services.mozilla.com/D50019

--HG--
extra : moz-landing-system : lando
2019-10-22 15:22:48 +00:00
Mark Hammond
12dd37165b Bug 1574051 - make FxA's session/account status checking sane and understandable. r=rfkelly,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D49689

--HG--
extra : moz-landing-system : lando
2019-10-22 00:58:36 +00:00
Mark Hammond
9a28c6748d Bug 1574052 - only return public fields from fxAccounts.getSignedInUser(). r=rfkelly,eoger
Differential Revision: https://phabricator.services.mozilla.com/D49525

--HG--
extra : moz-landing-system : lando
2019-10-22 00:57:27 +00:00
ffxbld
7b3edc3d02 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-10-21 18:00:38 +00:00
Lina Cambridge
a0d2e56628 Bug 1588329 - Centralize array chunking in PlacesUtils.chunkArray. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D49072

--HG--
extra : moz-landing-system : lando
2019-10-15 21:23:07 +00:00
Sam Foster
9b996482ca Bug 1567196 - Ignore invalid password date values. r=markh
Depends on D48941

Differential Revision: https://phabricator.services.mozilla.com/D49218

--HG--
extra : moz-landing-system : lando
2019-10-15 00:23:42 +00:00
Mark Hammond
0481284ac7 Bug 1583897 - Send a telemetry event for new sendtab. r=tcsc,eoger,lina
Differential Revision: https://phabricator.services.mozilla.com/D48153

--HG--
extra : moz-landing-system : lando
2019-10-14 22:17:28 +00:00
Mark Hammond
c7296e7825 Bug 1587769 - update the pref we watch to ensure we sync immediately after device name change. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D49102

--HG--
extra : moz-landing-system : lando
2019-10-14 16:30:27 +00:00
Lina Cambridge
5ac45f3f35 Bug 1588018 - Remove remaining event telemetry from the bookmarks mirror. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D49049

--HG--
extra : moz-landing-system : lando
2019-10-14 00:22:10 +00:00
Edouard Oger
25eb2d60df Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48410

--HG--
extra : moz-landing-system : lando
2019-10-11 17:06:57 +00:00
Andreea Pavel
eb350d4f6b Backed out changeset 4695136f7e82 (bug 1549049) for assertion failures at ErrorResult.h on a CLOSED TREE 2019-10-11 00:53:42 +03:00
Edouard Oger
136a86deed Bug 1549049 - Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D48410

--HG--
extra : moz-landing-system : lando
2019-10-10 21:08:01 +00:00
Edouard Oger
44a0e91fcd Bug 1584249 - Update enabled sync engines before opening CWTS dialog. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D48272

--HG--
extra : moz-landing-system : lando
2019-10-07 15:25:38 +00:00
Lina Cambridge
397d3a1156 Bug 1583413 - Fetch the Send Tab target list from FxA, not Sync. r=markh,eoger
Instead of using the list of FxA devices from the Sync clients engine,
we now fetch the list of Send Tab devices from FxA. This works like
this:

* `FxAccountsDevice#getDeviceList` has been split up into
  `recentDeviceList` and `refreshDeviceList`.
* `recentDeviceList` synchronously returns the last fetched list, so
  that consumers like Send Tab can use it right away.
* `refreshDeviceList` is asynchronous, and refreshes the last fetched
  list. Refreshes are limited to once every minute by default, matching
  the minimum sync interval (Send Tab passes the `ignoreCached` option
  to override the limit if the user clicks the "refresh" button).
  Concurrent calls to `refreshDeviceList` are also serialized, to
  ensure the list is only fetched once.
* The list is flagged as stale when a device is connected or
  disconnected. It's still kept around, but the next call to
  `refreshDeviceList` will fetch a new list from the server.
* The Send Tab UI refreshes FxA devices in the background. Matching FxA
  devices to Sync client records is best effort; we don't do it if Sync
  isn't configured or hasn't run yet. This only impacts the fallback
  case if the target doesn't support FxA commands.

Differential Revision: https://phabricator.services.mozilla.com/D47521

--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:55 +00:00
Mark Hammond
499384cb8e Bug 1585211 - Have TPS enable sync when the test user logs in. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D47714

--HG--
extra : moz-landing-system : lando
2019-10-01 00:32:01 +00:00
Mark Hammond
4b629788b2 Bug 1570567 - update about:preferences#sync to reflect the decoupling of FxA and Sync. r=Gijs,eoger,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D46574

--HG--
extra : moz-landing-system : lando
2019-09-26 10:48:22 +00:00
Mark Hammond
7ec2097ae8 Bug 1582633 - allow an FxA user to be signed in without sync being enabled. r=eoger,lina
Differential Revision: https://phabricator.services.mozilla.com/D46572

--HG--
extra : moz-landing-system : lando
2019-09-25 06:51:18 +00:00
Geoff Brown
dcb380399e Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
Most of these tests have been disabled for a long time; they run well
in the current test environment.

Differential Revision: https://phabricator.services.mozilla.com/D46642

--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
Mark Hammond
7531325c86 Bug 1582023 - Replace "sync disconnect" dialog and local data removal with simple confirmation dialog. r=eoger,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D46253

--HG--
extra : moz-landing-system : lando
2019-09-19 05:59:51 +00:00