We must delay setting the selected index, otherwise we may end dealing with
richlistitems without an applied binding, and the richlistbox may break them
permanently by setting a "selected" expando.
Differential Revision: https://phabricator.services.mozilla.com/D14385
--HG--
extra : moz-landing-system : lando
Also, use a single hidden window to hold <browser> elements
for multiple extensions.
Differential Revision: https://phabricator.services.mozilla.com/D14163
--HG--
rename : browser/components/extensions/test/browser/browser_ext_tabs_cookieStoreId.js => browser/components/extensions/test/browser/browser_ext_tabs_cookieStoreId_private.js
extra : moz-landing-system : lando
This patch move the actual widget construction to a onsetup method, allow UAWidgetsChild to hold the reference of the widget instance even if the actual setup (happens in the onsetup call) throws. With the reference of the widget kept, UAWidgetsChild will finally able to call its destructor later on.
Depends on D13607
Differential Revision: https://phabricator.services.mozilla.com/D13608
--HG--
extra : moz-landing-system : lando
I think this should have been here before but it wasn't.
To make it easier to distinguish recipes generated by
preferenceStudyFactory, give them a unique name with the unused
_preferenceStudyFactoryId.
Depends on D13574
Differential Revision: https://phabricator.services.mozilla.com/D13575
--HG--
extra : moz-landing-system : lando
Reading test logs is a bit baffling because all tests are called
"wrappedTestFunction". Try to imitate a Pythonic decorator and
make the returned function have the same name as the old one.
Function.prototype.name is a readonly property, but MDN says you can
set a function's name using Object.defineProperty, so that's what we
do.
Depends on D13572
Differential Revision: https://phabricator.services.mozilla.com/D13573
--HG--
extra : moz-landing-system : lando
Having _preExecute be called in the constructor makes it hard to test
it, but because it's a lifecycle hook that subclasses are intended to
override, testing it is very natural.
While we're here, move the initialization of AddonStudyAction from
_preExecute to the constructor, since it doesn't really make sense for
AddonStudyAction to be constructed without all members initialized.
Differential Revision: https://phabricator.services.mozilla.com/D13572
--HG--
extra : moz-landing-system : lando
Marionette tests have a hard time properly overwriting the module's
Policies that handle this in xpcshell tests currently.
A preference on the other hand can be easily set from the outside, is
persistent across restarts of the test instance and easily checked.
Differential Revision: https://phabricator.services.mozilla.com/D14458
--HG--
extra : moz-landing-system : lando
Instead of obtaining the recipes from the Normandy server, obtain them from RemoteSettings
Differential Revision: https://phabricator.services.mozilla.com/D11490
--HG--
extra : moz-landing-system : lando
This commit consolidates the `insertNewLocalItems` and
`updateExistingLocalItems` triggers into a single trigger that uses
an upsert, and removes the last vestiges of annotations from the
mirror.
Differential Revision: https://phabricator.services.mozilla.com/D14035
--HG--
extra : moz-landing-system : lando
We have a few places where C++ calls ChromeUtils::Import directly.
I fixed these to pass the target object directly instead of an empty Optional<>.
Differential Revision: https://phabricator.services.mozilla.com/D14180
--HG--
extra : moz-landing-system : lando
The patch updates the expiry version to 70, but I intend to remove it
as soon as bug 1423013 lands (which will hopefully be quite a bit earlier
than 70).
Differential Revision: https://phabricator.services.mozilla.com/D14106
--HG--
extra : moz-landing-system : lando
