Commit Graph

275 Commits

Author SHA1 Message Date
Mark Banner
e04689fad3 Bug 1738678 - Remove unnecessary ESLint warning rules for sjs files. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D130048
2021-11-02 08:55:52 +00:00
Mark Banner
ed96f8961f Bug 1738236 - Clean up remaining production uses of the second argument to ChromeUtils.import and change rule to a warning. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D129824
2021-11-01 14:25:46 +00:00
Miriam Onuoha
d8cc061416 Bug 1738232 - Removed the second argument to ChromeUtils.import in password manager tests. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D129836
2021-10-29 08:44:13 +00:00
Mark Banner
9ec0a602e7 Bug 1738235 - Remove unused precompile_cache.js. r=firefox-build-system-reviewers,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D129805
2021-10-28 14:28:54 +00:00
Mathew Hodson
adfcd3644a Bug 1531368 - Use ChromeUtils.import with one parameter in extensions code. r=robwu
Simplify some instances where modules were lazy loaded.

Differential Revision: https://phabricator.services.mozilla.com/D118569
2021-10-25 14:42:59 +00:00
Evgenia Kotovich
228e38a58c Bug 1576768 [eslint] Turn on JavaScript linting and formatting rules for .sjs files. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D128483
2021-10-25 11:12:41 +00:00
criss
152f71d4d3 Backed out changeset b60f98f26664 (bug 1576768) for causing mochitest failures. CLOSED TREE 2021-10-22 15:55:50 +03:00
Evgenia Kotovich
e29e29aa5a Bug 1576768 [eslint] Turn on JavaScript linting and formatting rules for .sjs files. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D128483
2021-10-22 11:39:46 +00:00
msub2
d7037d2ab2 Bug 1726734 - Replace deprecated octal sequences to satisfy ESLint no-octal-rule. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D128684
2021-10-18 14:37:04 +00:00
Mark Banner
f7ee253451 Bug 1734823 - Enable ESLint rule no-unused-vars globally for xpcshell test*.js files. r=necko-reviewers,Gijs,valentin
This enables it as a warning for all files, and as an error for some files.

Differential Revision: https://phabricator.services.mozilla.com/D127944
2021-10-11 11:07:02 +00:00
Mark Banner
f3ee19dbc7 Bug 1727591 - Enable remaining ESLint rule on remaining docshell/ xhtml files. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D123657
2021-08-25 18:42:19 +00:00
Jasleen
d32a884ef2 Bug 1716642 - Replaced calls to GlobalManager.extensionMap.get() with WebExtensionPolicy.getByID(). r=Standard8,kmag,robwu
Differential Revision: https://phabricator.services.mozilla.com/D118407
2021-06-24 15:06:17 +00:00
Lasse
05a2d4bf17 Bug 1710381 - Stop using this argument in ChromeUtils.import for importing modules in toolkit/components/telemetry/tests/unit/. r=Standard8,chutten
We also expanded the EXPORTED_SYMBOLS lists of some .jsm files, because otherwise we got the error that these symbols were undefined.

Differential Revision: https://phabricator.services.mozilla.com/D116208
2021-06-14 13:03:57 +00:00
Silke Hofmann
3b01fc4248 Bug 1710273 - Stop using ChromeUtils.import(..., null) for importing EnterprisePolicies.jsm. r=nhnt11,extension-reviewers,preferences-reviewers,zombie
Differential Revision: https://phabricator.services.mozilla.com/D115024
2021-05-12 23:16:33 +00:00
Mark Banner
39a3db78d4 Bug 1707711 - Stop using ChromeUtils.import(..., null) in testing/. r=kmag
Also clean up some unused exclusions in .eslintrc.js.

Differential Revision: https://phabricator.services.mozilla.com/D114623
2021-05-10 08:56:05 +00:00
Sandor Molnar
8d9abf3285 Backed out changeset ed582ad8db97 (bug 1707711) for causing dt failures in browser_webconsole_stubs_page_error. CLOSED TREE 2021-05-09 18:46:56 +03:00
Mark Banner
44419c64f1 Bug 1707711 - Stop using ChromeUtils.import(..., null) in testing/. r=kmag
Also clean up some unused exclusions in .eslintrc.js.

Differential Revision: https://phabricator.services.mozilla.com/D114623
2021-05-09 08:06:41 +00:00
Mark Banner
6d7ec21683 Bug 1705127 - Enable more ESLint rules for some more dom/security/test directories. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D112053
2021-04-15 11:11:18 +00:00
Mark Banner
c3d0fbb56a Bug 1702166 - Update ESLint, Babel and associated modules to the latest versions. r=mossop,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D110606
2021-04-04 08:05:39 +00:00
Chris H-C
ea2a18d757 Bug 1697555 - Remove Telemetry portions of Accounts Ecosystem Telemetry r=Dexter
Differential Revision: https://phabricator.services.mozilla.com/D110091
2021-03-29 20:03:38 +00:00
Mark Banner
d2073b123d Bug 1701734 - Re-enable ESLint on top-level dot files. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D110129
2021-03-29 19:49:12 +00:00
Alexandre Poirot
ded026f627 Bug 1700106 - [devtools] Remove now-useless eslint files related to mochitests. r=jdescottes,Standard8
I kept a few having some overrides. But they may be irrelevant.
And I kept some eslint files for all folder that aren't matching the pattern matching "**/test*/**/browser*/".
Ideally we would rename these folder to match.

Last but not least, I identified one case where we were using mochitest file for xpcshell tests!

Differential Revision: https://phabricator.services.mozilla.com/D109481
2021-03-23 15:51:18 +00:00
Niklas Goegge
bf279d8795 Bug 1698768 - Bundle sec-fetch-* tests within dom/security/tests/sec-fetch/ r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D108942
2021-03-18 15:00:37 +00:00
Mark Banner
5319c0f444 Bug 1696873 - Apply automatic fixes to enable more ESLint rules on remaining docshell xhtml files. r=smaug
This automatically fixes issues for these rules: dot-notation, object-shorthand and mozilla/no-useless-parameters
The other enabled rules had no issues associated with them, so are enabled without code changes.

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D107424
2021-03-08 13:41:52 +00:00
Mark Banner
acb019156a Bug 1696873 - Enable ESLint rule no-undef on remaining docshell xhtml files. r=smaug
Depends on D100450

Differential Revision: https://phabricator.services.mozilla.com/D107423
2021-03-08 13:41:52 +00:00
Sonia Singla
c58860a007 Bug 1656293 - Enable ESLint no-unused-vars rules on docshell/test/chrome/*.xhtml files. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D100450
2021-03-08 09:20:53 +00:00
Emma Malysz
e2feec63e1 Bug 1686526, hide sidebar button in proton toolbar r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D105819
2021-02-24 20:00:15 +00:00
Emma Malysz
6369fb568d Bug 1692214, hide library button by default in proton toolbar r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D105076
2021-02-19 22:14:21 +00:00
Csoregi Natalia
3aa417b128 Backed out changeset 6ce7064d4bf6 (bug 1692214) for browser-chrome failures on browser_proton_toolbar_hide_home_and_library_buttons.js. CLOSED TREE 2021-02-19 21:42:56 +02:00
Emma Malysz
1186c0fad7 Bug 1692214, hide library button by default in proton toolbar r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D105076
2021-02-19 19:00:55 +00:00
Mark Banner
67bf517e00 Bug 1608272 - Extend an ESLint rule to disallow 'this' as the second argument to ChromeUtils.import. r=Gijs
Depends on D104684

Differential Revision: https://phabricator.services.mozilla.com/D104685
2021-02-11 22:02:16 +00:00
Mark Banner
263d555274 Bug 1608272 - Remove 'this' as the second argument to 'ChromeUtils.import', use object destructuring instead (test-only changes). r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104683
2021-02-11 22:02:15 +00:00
Mark Banner
e3ee71f734 Bug 1687235 - Enable ESLint rule no-setter-return for mobile/. r=agi
Differential Revision: https://phabricator.services.mozilla.com/D102156
2021-01-26 13:44:11 +00:00
Mark Banner
07d7dc3c7a Bug 1687235 - Enable ESLint rule no-setter-return for dom. r=bryce
Differential Revision: https://phabricator.services.mozilla.com/D102155
2021-01-26 13:44:03 +00:00
Mark Banner
6f70e91a5d Bug 1687235 - Enable ESLint rule no-setter-return for devtools. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D102154
2021-01-26 13:44:01 +00:00
Mark Banner
930543e681 Bug 1687235 - Enable ESLint rule no-setter-return for toolkit and services. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D102153
2021-01-26 13:43:58 +00:00
Mark Banner
c4afa9e9ad Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-26 13:42:38 +00:00
Brindusan Cristian
70ab748bed Backed out 5 changesets (bug 1687235) for mochitest failures at test_menulist_null_value.xhtml. CLOSED TREE
Backed out changeset 638c802ca1d1 (bug 1687235)
Backed out changeset ec830b771bce (bug 1687235)
Backed out changeset a7c933ddecfd (bug 1687235)
Backed out changeset c36493fb0599 (bug 1687235)
Backed out changeset 6eb33ad5d460 (bug 1687235)
2021-01-26 10:58:43 +02:00
Mark Banner
94aaf448b5 Bug 1687235 - Enable ESLint rule no-setter-return for mobile/. r=agi
Depends on D102155

Differential Revision: https://phabricator.services.mozilla.com/D102156
2021-01-19 17:03:57 +00:00
Mark Banner
aae922599a Bug 1687235 - Enable ESLint rule no-setter-return for dom. r=bryce
Depends on D102154

Differential Revision: https://phabricator.services.mozilla.com/D102155
2021-01-19 14:50:44 +00:00
Mark Banner
49127400c8 Bug 1687235 - Enable ESLint rule no-setter-return for devtools. r=jdescottes
Depends on D102153

Differential Revision: https://phabricator.services.mozilla.com/D102154
2021-01-18 10:30:49 +00:00
Mark Banner
9cbc91833a Bug 1687235 - Enable ESLint rule no-setter-return for toolkit and services. r=mossop
Depends on D102152

Differential Revision: https://phabricator.services.mozilla.com/D102153
2021-01-25 22:27:01 +00:00
Mark Banner
c793c1efb7 Bug 1687235 - Enable ESLint rule no-setter-return for browser/. r=mossop,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D102152
2021-01-25 22:27:19 +00:00
joaovanzuita
e740ed7de3 Bug 1656295 - Enable ESLint rule no-unused-vars for all of netwerk/. r=necko-reviewers,dragana
Patch by joaovanzuita, updated by Standard8.

Differential Revision: https://phabricator.services.mozilla.com/D92333
2021-01-12 13:39:11 +00:00
Mark Banner
098cf85cdd Bug 1683340 - Enable ESLint rule no-async-promise-executor for the remaining dom/ files. r=nika
Depends on D100135

Differential Revision: https://phabricator.services.mozilla.com/D100136
2020-12-18 18:31:21 +00:00
Mark Banner
7fcb23f319 Bug 1683340 - Enable ESLint rule no-async-promise-executor for dom/payments. r=baku
Depends on D100134

Differential Revision: https://phabricator.services.mozilla.com/D100135
2021-01-04 15:59:11 +00:00
Mark Banner
c44311b76e Bug 1683340 - Enable ESLint rule no-async-promise-executor for test_http2-proxy.js. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D100134
2020-12-18 16:43:54 +00:00
David Parks
90be6e1a12 Bug 1675349: Update tests under dom/plugins/test for the removal of plugins. r=jmathies
ADDED/UPDATED
-------
dom/plugins/test/mochitest/browser_blockallplugins.js
Make sure that all plugin elements use the fallback for removed plugins.

dom/plugins/test/mochitest/test_mixed_case_mime.html
Bug 206659
Test MIME-type case sensitivity using "application/x-Second-Test"
Change to test "image/png".

dom/plugins/test/mochitest/test_plugin_fallback_focus.html
Test that (denying) object/embed focus and focusability are properly maintained when those elements change type to/from plugins.

REMOVED
-------
dom/plugins/test/unit/test_nice_plugin_name.js
bug 838290
Plugin permission string is "nicely" based on plugin lib name.

dom/plugins/test/unit/test_bug471245.js
bug 471245
Something to do with disabled plugins being enabled under some weird condition.

dom/plugins/test/unit/test_bug813245.js
bug 813245
Plugin registry file doesn't cause crash or incorrectly represent real plugin.

dom/plugins/test/unit/test_bug854467.js
bug 854467
PluginTag correctly controls click-to-play behavior.

dom/plugins/test/unit/test_plugin_default_state.js
bug 866390
Click-to-play abides plugin.default.state setting.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
CTP state is maintained in settings (not pluginreg.dat) and persists regardless of plugin removal

dom/plugins/test/mochitest/test_NPNVdocumentOrigin.html
Bug 622199
Test NPNV connection to DOM properly handles documentOrigin.

dom/plugins/test/mochitest/test_NPPVpluginWantsAllNetworkStreams.html
Test NPPV connection to JS when plugin requests all HTTP stream <body>s (including failed requests)

dom/plugins/test/mochitest/test_bug1028200-*.html
Properly handle fullscreen wrt plugins doing things (like crashing)

dom/plugins/test/unit/test_bug471245.js
Bug 471245
Extensions should not enable inadvertently enable plugins when they consult PluginHost.

dom/plugins/test/unit/test_bug813245.js
Bug 813245
Do not crash when we read a corrupt pluginreg.dat

dom/plugins/test/unit/test_bug854467.js
Bug 854467
Should be able to unset CTP setting in chrome JS.

dom/plugins/test/unit/test_nice_plugin_name.js
Bug 838290
Permission string names for plugins should be pretty and not just based on plugin filename.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
Persist plugin prefs in user prefs, not pluginreg.dat

dom/plugins/test/unit/test_plugin_default_state.js
Bug 866390
Plugins that use default CTP state should follow changes to the default.  Others should not be affected by changes.

dom/plugins/test/mochitest/test_bug1092842.html
bug 1092842
Plugin clipping around specific HTML element attributes.

dom/plugins/test/mochitest/test_bug1165981.html
bug 1165981
Test non-Flash plugins are blocked

dom/plugins/test/mochitest/test_bug1245545.html
bug 1245545
Test unloading plugins based on `dom.ipc.plugins.unloadTimeoutSecs`

dom/plugins/test/mochitest/test_bug1307694.html
bug 1307694
Test scale and salign attributes musst be processed in an order dependent way.  But salign is no longer supported.  The test uses special testplugin behavior.

dom/plugins/test/mochitest/test_bug532208.html
bug 532208
Test that plugins can handle large streams, using special testplugin behavior.

dom/plugins/test/mochitest/test_bug539565-1.html
dom/plugins/test/mochitest/test_bug539565-2.html
bug 539565
Plugins should get proper mouse coords in the face of CSS transformations

dom/plugins/test/mochitest/test_bug771202.html
bug 771202
Use JS-exported plugin functions after plugin is moved to a subdocument.

dom/plugins/test/mochitest/test_bug777098.html
bug 777098
Test that plugin is properly deleted and a JS exception is thrown when an invalid NPObject (from a dead instance) is passed to a plugin.

dom/plugins/test/mochitest/test_bug784131.html
bug 784131
Plugins should properly stop when they lose their frames (via e.g. `display:none`)

dom/plugins/test/mochitest/test_bug813906.html
bug 813906
Make sure plugins can't access chrome-privileged pages

dom/plugins/test/mochitest/test_bug852315.html
bug 852315
Tests a specific case where JS code that added an element in response to an <embed> event handler would alter a hash table in the midst of iteration, causing a crash.

dom/plugins/test/mochitest/test_bug854082.html
bug 854082
Tests that destroying the plugin's frame inside NPP_New does not cause a crash

dom/plugins/test/mochitest/test_bug863792.htm
bug 863792
Do not leak when a plugin removes itself from the document and inactivates the document in its NPP_New

dom/plugins/test/mochitest/test_bug967694.html
bug 967694
CTP dialog should not spawn plugin inside CTP dialog event.

dom/plugins/test/mochitest/test_bug985859.html
bug 985859
navigator.mimetypes should work as case-insensitive hashmap (there don't seem to be any legal mimetypes left now).

dom/plugins/test/mochitest/test_bug986930.html
bug 986930
Properly handle plugin with non-ASCII mime type.

dom/plugins/test/mochitest/test_copyText.html
Plugins should be able to use the clipboard.

dom/plugins/test/mochitest/test_crash_nested_loop.html
Plugins resulting in a call to PluginCrashed while still on the stack causing a browser crash (non-oop plugins).  So this is ancient (11 years).

dom/plugins/test/mochitest/test_crashing.html
Bug 560213
Test that plugin crashes generate exceptions and do not lead to heap corruption when using JS to call methods on the crashed plugin.

dom/plugins/test/mochitest/test_CrashService_crash.html
dom/plugins/test/mochitest/test_CrashService_hang.html
dom/plugins/test/mochitest/test_x11_error_crash.html
Bug 983313 and bug 1331320
Check that CrashService (which is currently only used by plugin tests) properly detects plugin crash, hang and crashes from X11 errors.

dom/plugins/test/mochitest/test_crashing2.html
Reloading should restore crashed plugin.  Test was already completely disabled.

dom/plugins/test/mochitest/test_defaultValue.html
Bug 679509
Make NPObjects ok to use as a primitve [[DefaultValue]], instead of calling valueOf on the NPObject itself.

dom/plugins/test/mochitest/test_bug751809.html
Bug 751809
Plugin CTP broke plugin input (ancient).

dom/plugins/test/mochitest/browser_bug1335475.js
bug 1335475
Test that plugins aren't available in chrome-privilege, null-principal, and file:// content but are available to http:// and about:blank content

dom/plugins/test/mochitest/browser_data_url_plugin.js
Bug 1381755
Test that data URIs inside iframes can't use plugins

dom/plugins/test/mochitest/browser_bug1196539.js
Test that plugin repaints when it should (and not more than that, modulo OS repaints)

dom/plugins/test/mochitest/test_hidden_plugin.html
Test navigator.plugins, including that disabling plugins removes them from navigator.plugins

dom/plugins/test/mochitest/test_enumerate.html
Test PluginHost's ability to expose plugin's JS API (looks for TestPlugin's SetColor)

dom/plugins/test/mochitest/test_clear_site_data.html
Directly test PluginHost's clearSiteData API.

dom/plugins/test/mochitest/test_instance_re-parent.html
Bug 90268
Test that reparenting plugin instance in DOM before spinning event loop does not destroy or restart it.

dom/plugins/test/mochitest/test_instance_unparent1.html
dom/plugins/test/mochitest/test_instance_unparent2.html
dom/plugins/test/mochitest/test_instance_unparent3.html
Bug 90268
Test that removing plugin from DOM destroys it (1) normally, (2) if reparented and removed in the same event cycle and (3) when its parent is the element that gets removed.

dom/plugins/test/mochitest/test_instantiation.html
Create that plugin is loaded when element is programmatically created (using createElement).

dom/plugins/test/mochitest/test_multipleinstanceobjects.html
Test NPObject access from multiple plugin instances

dom/plugins/test/mochitest/test_newstreamondestroy.html
Test calling NPN_GetURL from NPP_Destroy

dom/plugins/test/mochitest/test_npn_timers.html
Test NPN_Timer

dom/plugins/test/mochitest/test_npobject_getters.html
Test `pluginFoundElement` and `pluginFoundWindow` JS properties set on plugin instance by `NPP_New`.

dom/plugins/test/mochitest/test_npruntime_construct.html
Test that NP plugin JS method `constructObject` properly configures prototype chain

dom/plugins/test/mochitest/test_npruntime_identifiers.html
Test various ways the plugin JS reflection method can convert "identifiers" to JS values.

dom/plugins/test/mochitest/test_npruntime_npnevaluate.html
Test NPN_Evaluate (i.e. plugin executing JS code)

dom/plugins/test/mochitest/test_npruntime_npninvoke.html
Test NPN_Invoke (i.e. plugin calling JS method)

dom/plugins/test/mochitest/test_npruntime_npninvokedefault.html
Test NPN_InvokeDefault (i.e. plugin calling default JS method)

dom/plugins/test/mochitest/test_painting.html
Test invalidation and repaint requests for clipped plugins.

dom/plugins/test/mochitest/test_pluginstream_err.html
Bug 517078
Test that plugin streaming error reporting works

dom/plugins/test/mochitest/test_pluginstream_post.html
dom/plugins/test/mochitest/test_pluginstream_poststream.html
Test NPN_PostURL responds (1) by inserting response into given element or (2) by sending response to plugin with NPN_NewStream.

dom/plugins/test/mochitest/test_bug479979.xhtml
Bug 479979
NPN_SetValue should return error for unknown variables.

dom/plugins/test/mochitest/test_crash_notify.xhtml
dom/plugins/test/mochitest/test_crash_notify_no_report.xhtml
Check event data, crash report/minidump (or not using MOZ_CRASHREPORTER_NO_REPORT), etc for `plugin-crash` event.

dom/plugins/test/mochitest/test_crash_submit.xhtml
dom/plugins/test/mochitest/test_hang_submit.xhtml
Test plugin crash/hang report submission using mock server from toolkit.

dom/plugins/test/mochitest/test_pluginstream_referer.html
Bugs 410904 and 724465
Test NPN_PostURLNotify and NPN_GetURLNotify.

dom/plugins/test/mochitest/test_pluginstream_src.html
Test NPP_NewStream and NPP_DestroyStream using embed tag streammode/streamchunksize parameters.

dom/plugins/test/mochitest/test_pluginstream_src_dynamic.html
Bug 90268
Like test_pluginstream_src.html but using dynamic HTML elements.

dom/plugins/test/mochitest/test_pluginstream_src_referer.html
Bug 737433
Make sure plugin stream data includes the correct referrer (taken from its content)

dom/plugins/test/mochitest/test_propertyAndMethod.html
Test NPObject with property and method with the same name

dom/plugins/test/mochitest/test_queryCSSZoomFactor.htm
Bug 1171182
Test CSS zoom with plugins (handled with NPNVcontentsScaleFactor)

dom/plugins/test/mochitest/test_redirect_handling.html
Test NPN_PostURLNotify and NPN_GetURLNotify URL redirect support.

dom/plugins/test/mochitest/test_secondPlugin.html
Bug 749257
Test navigator.plugins and navigator.mimeTypes (via index and iteration) for proper behavior WRT active, CTP and disabled plugins.

dom/plugins/test/mochitest/test_src_url_change.html
Bug 726734
Changing embed src tag should destroy/restart plugin.

dom/plugins/test/mochitest/test_streamNotify.html
Test that plugin streams properly handle all URLs, including proper errors for malformed URLs.

dom/plugins/test/mochitest/test_streamatclose.html
Any open streams should be notified before NPP_Destroy.

dom/plugins/test/mochitest/test_stringHandling.html
Bug 1106552
Properly handle 0 bytes in strings passed to plugins as NPVariants.

dom/plugins/test/mochitest/test_visibility.html
Make sure plugins respect visibility attribute and issue the correct number of paints.

dom/plugins/test/mochitest/test_zero_opacity.html
Windowed plugins should use clip rect to avoid drawing opacity:0 displays.

dom/plugins/test/mochitest/test_cocoa_window_focus.htm
Test that NPCocoaEventWindowFocusChanged is properly sent for plugin's window

dom/plugins/test/mochitest/test_cocoa_focus.htm
Test that NPCocoaEventFocusChanged is properly sent for plugin's element

dom/plugins/test/mochitest/test_windowed_invalidate.html
Test NPN_Invalidate for windowed plugins

dom/plugins/test/mochitest/test_windowless_flash.htm
Make sure Flash always runs in windowless mode

dom/plugins/test/mochitest/test_windowless_ime.html
Test (windowless) plugins with IME

dom/plugins/test/mochitest/test_busy_hang.xhtml
dom/plugins/test/mochitest/test_idle_hang.xhtml
Test plugin busy/idle detection observers and events

dom/plugins/test/mochitest/test_object.html
Bug 783059
Test plugin "instantiation", mostly by stressing behavior when the plugin's element tags are programmatically updated.

dom/plugins/test/mochitest/test_convertpoint.xhtml
Test coordinate space transformations via NPN_ConvertPoint.

dom/plugins/test/mochitest/test_hangui.xhtml
Test the _plugin hung_ UI.

dom/plugins/test/mochitest/test_npruntime.xhtml
Simple test that npruntime (the JS/plugin bridge) works.

dom/plugins/test/mochitest/test_plugin_tag_clicktoplay.html
Make sure nsIPluginTags click-to-play state properly matches enabledState of plugin (in chrome code)

dom/plugins/test/mochitest/test_privatemode_perwindowpb.xhtml
Check that plugins can properly determine when run in private mode with NPNVprivateModeBool.

dom/plugins/test/mochitest/test_wmode.xhtml
Bad test that ends up checking the constant boolean in testplugin returned by pluginSupportsWindowMode() and "confirming" that mac and Linux don't support windowed mode but Windows does.

dom/plugins/test/mochitest/test_xulbrowser_plugin_visibility.xhtml
Tests that plugins properly get visibility and invalidate messages when in the current or not-current tab.

Differential Revision: https://phabricator.services.mozilla.com/D95910
2020-11-18 15:58:15 +00:00
Bogdan Tara
56346a0425 Backed out 19 changesets (bug 1675349) for lint failures on browser_ext_browsingData_pluginData and test_archive CLOSED TREE
Backed out changeset 244e0f2b410c (bug 1675349)
Backed out changeset ba5724069dd4 (bug 1675349)
Backed out changeset 37fca259c7e9 (bug 1675349)
Backed out changeset f2b16caca1fc (bug 1675349)
Backed out changeset 28835d4935be (bug 1675349)
Backed out changeset eb913f58953a (bug 1675349)
Backed out changeset 19e3cb80f469 (bug 1675349)
Backed out changeset d9723f3a3a7e (bug 1675349)
Backed out changeset c888dfcdf70e (bug 1675349)
Backed out changeset 48f153341af6 (bug 1675349)
Backed out changeset 7fc67a9b2932 (bug 1675349)
Backed out changeset 1cee4d97f801 (bug 1675349)
Backed out changeset 59a0cb79c7c1 (bug 1675349)
Backed out changeset 43d349fa37b1 (bug 1675349)
Backed out changeset c84bfb6eae59 (bug 1675349)
Backed out changeset 38e9af69ae57 (bug 1675349)
Backed out changeset 3255c1ab3059 (bug 1675349)
Backed out changeset 2f3eaf9c342c (bug 1675349)
Backed out changeset 769e5c0db4c2 (bug 1675349)
2020-11-18 06:06:36 +02:00
David Parks
22d4a17ff8 Bug 1675349: Update tests under dom/plugins/test for the removal of plugins. r=jmathies
ADDED/UPDATED
-------
dom/plugins/test/mochitest/browser_blockallplugins.js
Make sure that all plugin elements use the fallback for removed plugins.

dom/plugins/test/mochitest/test_mixed_case_mime.html
Bug 206659
Test MIME-type case sensitivity using "application/x-Second-Test"
Change to test "image/png".

dom/plugins/test/mochitest/test_plugin_fallback_focus.html
Test that (denying) object/embed focus and focusability are properly maintained when those elements change type to/from plugins.

REMOVED
-------
dom/plugins/test/unit/test_nice_plugin_name.js
bug 838290
Plugin permission string is "nicely" based on plugin lib name.

dom/plugins/test/unit/test_bug471245.js
bug 471245
Something to do with disabled plugins being enabled under some weird condition.

dom/plugins/test/unit/test_bug813245.js
bug 813245
Plugin registry file doesn't cause crash or incorrectly represent real plugin.

dom/plugins/test/unit/test_bug854467.js
bug 854467
PluginTag correctly controls click-to-play behavior.

dom/plugins/test/unit/test_plugin_default_state.js
bug 866390
Click-to-play abides plugin.default.state setting.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
CTP state is maintained in settings (not pluginreg.dat) and persists regardless of plugin removal

dom/plugins/test/mochitest/test_NPNVdocumentOrigin.html
Bug 622199
Test NPNV connection to DOM properly handles documentOrigin.

dom/plugins/test/mochitest/test_NPPVpluginWantsAllNetworkStreams.html
Test NPPV connection to JS when plugin requests all HTTP stream <body>s (including failed requests)

dom/plugins/test/mochitest/test_bug1028200-*.html
Properly handle fullscreen wrt plugins doing things (like crashing)

dom/plugins/test/unit/test_bug471245.js
Bug 471245
Extensions should not enable inadvertently enable plugins when they consult PluginHost.

dom/plugins/test/unit/test_bug813245.js
Bug 813245
Do not crash when we read a corrupt pluginreg.dat

dom/plugins/test/unit/test_bug854467.js
Bug 854467
Should be able to unset CTP setting in chrome JS.

dom/plugins/test/unit/test_nice_plugin_name.js
Bug 838290
Permission string names for plugins should be pretty and not just based on plugin filename.

dom/plugins/test/unit/test_persist_in_prefs.js
Bug 830267
Persist plugin prefs in user prefs, not pluginreg.dat

dom/plugins/test/unit/test_plugin_default_state.js
Bug 866390
Plugins that use default CTP state should follow changes to the default.  Others should not be affected by changes.

dom/plugins/test/mochitest/test_bug1092842.html
bug 1092842
Plugin clipping around specific HTML element attributes.

dom/plugins/test/mochitest/test_bug1165981.html
bug 1165981
Test non-Flash plugins are blocked

dom/plugins/test/mochitest/test_bug1245545.html
bug 1245545
Test unloading plugins based on `dom.ipc.plugins.unloadTimeoutSecs`

dom/plugins/test/mochitest/test_bug1307694.html
bug 1307694
Test scale and salign attributes musst be processed in an order dependent way.  But salign is no longer supported.  The test uses special testplugin behavior.

dom/plugins/test/mochitest/test_bug532208.html
bug 532208
Test that plugins can handle large streams, using special testplugin behavior.

dom/plugins/test/mochitest/test_bug539565-1.html
dom/plugins/test/mochitest/test_bug539565-2.html
bug 539565
Plugins should get proper mouse coords in the face of CSS transformations

dom/plugins/test/mochitest/test_bug771202.html
bug 771202
Use JS-exported plugin functions after plugin is moved to a subdocument.

dom/plugins/test/mochitest/test_bug777098.html
bug 777098
Test that plugin is properly deleted and a JS exception is thrown when an invalid NPObject (from a dead instance) is passed to a plugin.

dom/plugins/test/mochitest/test_bug784131.html
bug 784131
Plugins should properly stop when they lose their frames (via e.g. `display:none`)

dom/plugins/test/mochitest/test_bug813906.html
bug 813906
Make sure plugins can't access chrome-privileged pages

dom/plugins/test/mochitest/test_bug852315.html
bug 852315
Tests a specific case where JS code that added an element in response to an <embed> event handler would alter a hash table in the midst of iteration, causing a crash.

dom/plugins/test/mochitest/test_bug854082.html
bug 854082
Tests that destroying the plugin's frame inside NPP_New does not cause a crash

dom/plugins/test/mochitest/test_bug863792.htm
bug 863792
Do not leak when a plugin removes itself from the document and inactivates the document in its NPP_New

dom/plugins/test/mochitest/test_bug967694.html
bug 967694
CTP dialog should not spawn plugin inside CTP dialog event.

dom/plugins/test/mochitest/test_bug985859.html
bug 985859
navigator.mimetypes should work as case-insensitive hashmap (there don't seem to be any legal mimetypes left now).

dom/plugins/test/mochitest/test_bug986930.html
bug 986930
Properly handle plugin with non-ASCII mime type.

dom/plugins/test/mochitest/test_copyText.html
Plugins should be able to use the clipboard.

dom/plugins/test/mochitest/test_crash_nested_loop.html
Plugins resulting in a call to PluginCrashed while still on the stack causing a browser crash (non-oop plugins).  So this is ancient (11 years).

dom/plugins/test/mochitest/test_crashing.html
Bug 560213
Test that plugin crashes generate exceptions and do not lead to heap corruption when using JS to call methods on the crashed plugin.

dom/plugins/test/mochitest/test_CrashService_crash.html
dom/plugins/test/mochitest/test_CrashService_hang.html
dom/plugins/test/mochitest/test_x11_error_crash.html
Bug 983313 and bug 1331320
Check that CrashService (which is currently only used by plugin tests) properly detects plugin crash, hang and crashes from X11 errors.

dom/plugins/test/mochitest/test_crashing2.html
Reloading should restore crashed plugin.  Test was already completely disabled.

dom/plugins/test/mochitest/test_defaultValue.html
Bug 679509
Make NPObjects ok to use as a primitve [[DefaultValue]], instead of calling valueOf on the NPObject itself.

dom/plugins/test/mochitest/test_bug751809.html
Bug 751809
Plugin CTP broke plugin input (ancient).

dom/plugins/test/mochitest/browser_bug1335475.js
bug 1335475
Test that plugins aren't available in chrome-privilege, null-principal, and file:// content but are available to http:// and about:blank content

dom/plugins/test/mochitest/browser_data_url_plugin.js
Bug 1381755
Test that data URIs inside iframes can't use plugins

dom/plugins/test/mochitest/browser_bug1196539.js
Test that plugin repaints when it should (and not more than that, modulo OS repaints)

dom/plugins/test/mochitest/test_hidden_plugin.html
Test navigator.plugins, including that disabling plugins removes them from navigator.plugins

dom/plugins/test/mochitest/test_enumerate.html
Test PluginHost's ability to expose plugin's JS API (looks for TestPlugin's SetColor)

dom/plugins/test/mochitest/test_clear_site_data.html
Directly test PluginHost's clearSiteData API.

dom/plugins/test/mochitest/test_instance_re-parent.html
Bug 90268
Test that reparenting plugin instance in DOM before spinning event loop does not destroy or restart it.

dom/plugins/test/mochitest/test_instance_unparent1.html
dom/plugins/test/mochitest/test_instance_unparent2.html
dom/plugins/test/mochitest/test_instance_unparent3.html
Bug 90268
Test that removing plugin from DOM destroys it (1) normally, (2) if reparented and removed in the same event cycle and (3) when its parent is the element that gets removed.

dom/plugins/test/mochitest/test_instantiation.html
Create that plugin is loaded when element is programmatically created (using createElement).

dom/plugins/test/mochitest/test_multipleinstanceobjects.html
Test NPObject access from multiple plugin instances

dom/plugins/test/mochitest/test_newstreamondestroy.html
Test calling NPN_GetURL from NPP_Destroy

dom/plugins/test/mochitest/test_npn_timers.html
Test NPN_Timer

dom/plugins/test/mochitest/test_npobject_getters.html
Test `pluginFoundElement` and `pluginFoundWindow` JS properties set on plugin instance by `NPP_New`.

dom/plugins/test/mochitest/test_npruntime_construct.html
Test that NP plugin JS method `constructObject` properly configures prototype chain

dom/plugins/test/mochitest/test_npruntime_identifiers.html
Test various ways the plugin JS reflection method can convert "identifiers" to JS values.

dom/plugins/test/mochitest/test_npruntime_npnevaluate.html
Test NPN_Evaluate (i.e. plugin executing JS code)

dom/plugins/test/mochitest/test_npruntime_npninvoke.html
Test NPN_Invoke (i.e. plugin calling JS method)

dom/plugins/test/mochitest/test_npruntime_npninvokedefault.html
Test NPN_InvokeDefault (i.e. plugin calling default JS method)

dom/plugins/test/mochitest/test_painting.html
Test invalidation and repaint requests for clipped plugins.

dom/plugins/test/mochitest/test_pluginstream_err.html
Bug 517078
Test that plugin streaming error reporting works

dom/plugins/test/mochitest/test_pluginstream_post.html
dom/plugins/test/mochitest/test_pluginstream_poststream.html
Test NPN_PostURL responds (1) by inserting response into given element or (2) by sending response to plugin with NPN_NewStream.

dom/plugins/test/mochitest/test_bug479979.xhtml
Bug 479979
NPN_SetValue should return error for unknown variables.

dom/plugins/test/mochitest/test_crash_notify.xhtml
dom/plugins/test/mochitest/test_crash_notify_no_report.xhtml
Check event data, crash report/minidump (or not using MOZ_CRASHREPORTER_NO_REPORT), etc for `plugin-crash` event.

dom/plugins/test/mochitest/test_crash_submit.xhtml
dom/plugins/test/mochitest/test_hang_submit.xhtml
Test plugin crash/hang report submission using mock server from toolkit.

dom/plugins/test/mochitest/test_pluginstream_referer.html
Bugs 410904 and 724465
Test NPN_PostURLNotify and NPN_GetURLNotify.

dom/plugins/test/mochitest/test_pluginstream_src.html
Test NPP_NewStream and NPP_DestroyStream using embed tag streammode/streamchunksize parameters.

dom/plugins/test/mochitest/test_pluginstream_src_dynamic.html
Bug 90268
Like test_pluginstream_src.html but using dynamic HTML elements.

dom/plugins/test/mochitest/test_pluginstream_src_referer.html
Bug 737433
Make sure plugin stream data includes the correct referrer (taken from its content)

dom/plugins/test/mochitest/test_propertyAndMethod.html
Test NPObject with property and method with the same name

dom/plugins/test/mochitest/test_queryCSSZoomFactor.htm
Bug 1171182
Test CSS zoom with plugins (handled with NPNVcontentsScaleFactor)

dom/plugins/test/mochitest/test_redirect_handling.html
Test NPN_PostURLNotify and NPN_GetURLNotify URL redirect support.

dom/plugins/test/mochitest/test_secondPlugin.html
Bug 749257
Test navigator.plugins and navigator.mimeTypes (via index and iteration) for proper behavior WRT active, CTP and disabled plugins.

dom/plugins/test/mochitest/test_src_url_change.html
Bug 726734
Changing embed src tag should destroy/restart plugin.

dom/plugins/test/mochitest/test_streamNotify.html
Test that plugin streams properly handle all URLs, including proper errors for malformed URLs.

dom/plugins/test/mochitest/test_streamatclose.html
Any open streams should be notified before NPP_Destroy.

dom/plugins/test/mochitest/test_stringHandling.html
Bug 1106552
Properly handle 0 bytes in strings passed to plugins as NPVariants.

dom/plugins/test/mochitest/test_visibility.html
Make sure plugins respect visibility attribute and issue the correct number of paints.

dom/plugins/test/mochitest/test_zero_opacity.html
Windowed plugins should use clip rect to avoid drawing opacity:0 displays.

dom/plugins/test/mochitest/test_cocoa_window_focus.htm
Test that NPCocoaEventWindowFocusChanged is properly sent for plugin's window

dom/plugins/test/mochitest/test_cocoa_focus.htm
Test that NPCocoaEventFocusChanged is properly sent for plugin's element

dom/plugins/test/mochitest/test_windowed_invalidate.html
Test NPN_Invalidate for windowed plugins

dom/plugins/test/mochitest/test_windowless_flash.htm
Make sure Flash always runs in windowless mode

dom/plugins/test/mochitest/test_windowless_ime.html
Test (windowless) plugins with IME

dom/plugins/test/mochitest/test_busy_hang.xhtml
dom/plugins/test/mochitest/test_idle_hang.xhtml
Test plugin busy/idle detection observers and events

dom/plugins/test/mochitest/test_object.html
Bug 783059
Test plugin "instantiation", mostly by stressing behavior when the plugin's element tags are programmatically updated.

dom/plugins/test/mochitest/test_convertpoint.xhtml
Test coordinate space transformations via NPN_ConvertPoint.

dom/plugins/test/mochitest/test_hangui.xhtml
Test the _plugin hung_ UI.

dom/plugins/test/mochitest/test_npruntime.xhtml
Simple test that npruntime (the JS/plugin bridge) works.

dom/plugins/test/mochitest/test_plugin_tag_clicktoplay.html
Make sure nsIPluginTags click-to-play state properly matches enabledState of plugin (in chrome code)

dom/plugins/test/mochitest/test_privatemode_perwindowpb.xhtml
Check that plugins can properly determine when run in private mode with NPNVprivateModeBool.

dom/plugins/test/mochitest/test_wmode.xhtml
Bad test that ends up checking the constant boolean in testplugin returned by pluginSupportsWindowMode() and "confirming" that mac and Linux don't support windowed mode but Windows does.

dom/plugins/test/mochitest/test_xulbrowser_plugin_visibility.xhtml
Tests that plugins properly get visibility and invalidate messages when in the current or not-current tab.

Differential Revision: https://phabricator.services.mozilla.com/D95910
2020-11-18 02:45:23 +00:00