Commit Graph

62148 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
e06ff3dbe2 Backout changeset b54c60961def (Bug 1409672) for failing one OSX reftest on a CLOSED TREE. r=backout
MozReview-Commit-ID: 6ZHlFBpMOUo
2018-01-17 23:09:38 +01:00
Gerald Squelart
cb368a9c98 Bug 1430494 - Skip new-list loop and its related operations if list is empty - r=mattwoodrow
MozReview-Commit-ID: LkY2lldl7Al

--HG--
extra : rebase_source : 4fe5c71008b470f4c8b15f05e903d50d5c6e9303
2018-01-15 10:15:50 +11:00
Emilio Cobos Álvarez
e191632bd8 Bug 1409672: Hook in the invalidator stuff. r=xidorn
MozReview-Commit-ID: EoSMrYPS7dl
2018-01-17 21:51:53 +01:00
Emilio Cobos Álvarez
141792488a Bug 1430608: Make nsMediaFeatures work with a document, not a pres context. r=heycam
Returning a zero-sized viewport in the case there's no shell / pres context.

For now, no other change yet. After this we can start tweaking the ShadowRoot
Stylist setup, and even try to return computed styles without a document \o/.

MozReview-Commit-ID: 3cT2PKQISri
2018-01-17 21:51:47 +01:00
Tom Tromey
1bb2ea3983 Bug 1255402 - fix getCSSValuesForProperty for object-position and perspective-origin; r=heycam
getCSSValuesForProperty was not including "calc" for object-position
and perspective-origin.  Fixed by updating the variants in
nsCSSPropList.h.

MozReview-Commit-ID: 8STipRhqFwT

--HG--
extra : rebase_source : 70cbb9fc1a9b3a1084bd8846f065f0876daccd75
2018-01-16 10:52:28 -07:00
Emilio Cobos Álvarez
480dcc7f05 Bug 1428491: Remove redundant mBindingManager member in ServoStyleSet. r=heycam
MozReview-Commit-ID: KMiivgik0fr
2018-01-17 19:12:45 +01:00
Emilio Cobos Álvarez
ae38d1cb24 Bug 1428491: Make the style set know about a document, not a pres context. r=heycam
MozReview-Commit-ID: I7T41NiHuJv
2018-01-17 19:12:40 +01:00
Emilio Cobos Álvarez
271544691d Bug 1430844: Add assertions that would've caught this. r=bz
MozReview-Commit-ID: 1UfhIRn2We2
2018-01-17 19:12:34 +01:00
Emilio Cobos Álvarez
cd4b889709 Bug 1430844: Make resize reflow sound re. viewport units. r=bz
In particular, we set the pres context visible area _before_ processing
restyles.

This causes inconsistencies when resolving viewport units. In particular, the
resulting style tree will have some units resolved in terms of the old size, and
some in terms of the new size, depending on whatever is dirty, because we don't
flush the pending media query changes.

Also, some sizes are resolved against the unconstrained size because of the
shrink-to-fit stuff. Fix this by flushing _before_ in this case, instead of
after, since we're going to set the size to an actual value later when reflowing
the root frame.

MozReview-Commit-ID: ExI5yTJCjGp
2018-01-17 19:12:25 +01:00
Tim Huang
98af9c6f96 Bug 1222285 - Part 2: Making the keyboard events of modifier keys been suppressed when 'privacy.resistFingerprinting' is true. r=arthuredelstein,masayuki
This patch makes 'Shift', 'Alt', 'Contorl' and 'AltGraph' been suppressed for content
when fingerprinting resistance is enabled. Chrome can still get these events.

The reason behind this is that websites can still observe key combinations to
tell which keyboard layout is using even we spoof the keyboardEvent.code,
keyboardEvent.keyCode and modifier states. For example, the AZERTY France
keyboard, the digit keys of it requires the user press the Shift key. So, it is
easy to differentiate AZERTY and QWERTY keyboard by observing whether a Shift key
generates its own before the digit keys. There are similar issues for 'Alt' and
'AltGraph' as well.

MozReview-Commit-ID: 3CwCgvey4lK

--HG--
extra : rebase_source : 225a34ab188f6cca288a6c0e9874261df7db629f
2017-08-31 11:14:14 +08:00
Cosmin Sabou
75435dc3b2 Merge mozilla-central to autoland a=merge on a CLOSED TREE 2018-01-17 11:49:21 +02:00
Cosmin Sabou
1f9b4f0f06 Merge inbound to mozilla-central. a=merge 2018-01-17 11:46:53 +02:00
Hiroyuki Ikezoe
9e4a4577fd Bug 1430924 - Create animation event struct directly. r=boris
We don't need to create AnimationEventParams, we can direcly create
AnimationEventInfo array and move it to dispatcher.

MozReview-Commit-ID: BCzKGAV8VTw

--HG--
extra : rebase_source : f668b27bacb0c929de5b997b5428c3c75e5a8474
2018-01-17 08:13:01 +09:00
Hiroyuki Ikezoe
5b7a247462 Bug 1430924 - Queue a bunch of animation events at once. r=boris
MozReview-Commit-ID: BjRjohOFA7V

--HG--
extra : rebase_source : c235d5394f1a724913415f170aab194564443316
2018-01-17 08:13:01 +09:00
Hiroyuki Ikezoe
089161c4d1 Bug 1430924 - AnimationEventInfo and TransitionEventInfo take NonOwningAnimationTarget instead of Element and CSSPseudoElementType pair. r=boris
MozReview-Commit-ID: HYN9AWuyjem

--HG--
extra : rebase_source : 3d63272c2ff62a82ccde641a6765ed2faf4d28f9
2018-01-17 08:13:01 +09:00
Hiroyuki Ikezoe
906b83a978 Bug 1430924 - Move mEventDispatcher in nsAnimationManager and nsTransitionManager into the common template class. r=boris
DispatchEvents() couldn't be moved since the function holds a reference of
nsAnimationManager or nsTransitionManager, but the common template class
is not ref-countable.

MozReview-Commit-ID: FfiJtzSZWn

--HG--
extra : rebase_source : 30d1cdcebf8e06696f28ba5c0968a90797976f06
2018-01-17 08:13:01 +09:00
Matt Woodrow
b654a30f82 Bug 1420737 - Fix merge algorithm to handle more complex z-index changes. r=mstange
--HG--
extra : rebase_source : 2cef89d230348204bc08af071d57109097865417
2018-01-17 12:07:42 +13:00
Matt Woodrow
89bf796c70 Bug 1429078 - Handle the case where the subdoc view doesn't have a frame. r=miko
--HG--
extra : rebase_source : badce58f07f66a7a0146f51792463c08a75506f1
2018-01-17 12:04:51 +13:00
Jonathan Watt
e04dd6678d Bug 1430682 - Use OwningNonNull for nsPagePrintTimer::mDocViewerPrint and remove null checks. r=bobowen
MozReview-Commit-ID: 5CPaYTA2PrC
2018-01-09 22:21:53 +00:00
Jonathan Watt
706256a2cc Bug 1430687 - Move the mDestroyBlockedCount early return in nsDocumentViewer::Destroy to the top. r=bobowen
MozReview-Commit-ID: Exe0hIFHK8z
2018-01-09 12:47:20 +00:00
Jonathan Watt
d75df097a4 Bug 1430686 - Rename the document viewer "DestroyRefCount" member and methods. r=bobowen
MozReview-Commit-ID: KGUJXOKEQjV
2018-01-08 16:59:31 +00:00
Jonathan Watt
7085690980 Bug 1430683 - Remove nsPrintData::mOrigDCScale. r=bobowen
MozReview-Commit-ID: 3iUiCuiVBei
2018-01-08 11:43:16 +00:00
Jonathan Watt
a9cf608630 Bug 1430689 - Make ReturnToGalleyPresentation non-virtual. r=bobowen
MozReview-Commit-ID: J3dZuZfDXFd
2018-01-05 12:47:20 +00:00
Andreea Pavel
d6a9e2303f Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2018-01-16 18:00:21 +02:00
Andrea Marchesini
8fa0f9ab3a Bug 1425440 - Replace RemoveChildAt_Deprecated with RemoveChildNode in nsTextControlFrame, r=catalinb 2018-01-16 14:17:10 +01:00
Andreea Pavel
c98c2f7291 Backed out 2 changesets (bug 1428491) for failing browser chrome mochitest at /builds/worker/workspace/build/src/layout/style/ServoStyleSet.cpp:941 on a CLOSED TREE
Backed out changeset 308e79e6c98f (bug 1428491)
Backed out changeset dbfd798e491b (bug 1428491)
2018-01-16 14:26:41 +02:00
Andreea Pavel
b246f6ad48 Merge mozilla-central to mozilla-inbound. a=merge on a CLOSED TREE 2018-01-16 11:53:37 +02:00
Morris Tseng
68bd6b6c46 Bug 1424177 - Add reftest. r=kats
MozReview-Commit-ID: GfMRLGCia4Y
2018-01-16 17:33:13 +08:00
Emilio Cobos Álvarez
4ce67178eb Bug 1428491: Remove redundant mBindingManager member in ServoStyleSet. r=heycam
MozReview-Commit-ID: KMiivgik0fr

--HG--
extra : rebase_source : 9cb1181c2b3c1fd5274af3d53042fa3a0966ad10
2018-01-05 20:17:26 +01:00
Emilio Cobos Álvarez
bde9657140 Bug 1428491: Make the style set know about a document, not a pres context. r=heycam
MozReview-Commit-ID: I7T41NiHuJv

--HG--
extra : rebase_source : 4642cf6f511f5c4e5ba285e2e865574a44459081
2018-01-05 13:51:08 +01:00
Emilio Cobos Álvarez
124c284658 Bug 1429961: Crashtest. r=me
MozReview-Commit-ID: 79OJm4Ay1lf
2018-01-16 11:03:40 +01:00
Dorel Luca
09deda375a Merge mozilla-central to autoland r=merge 2018-01-16 06:07:49 +02:00
Emilio Cobos Álvarez
8631d601b8 Bug 1429961: Avoid copying PostDestroyData. r=mats
We don't want that to happen.

MozReview-Commit-ID: EQ6igMRyeaV

--HG--
extra : rebase_source : 58c374baf6d5d6af778829f9ca708e8aa3372899
2018-01-15 21:51:58 +01:00
Emilio Cobos Álvarez
b2223e5580 Bug 1429961: Destroy continuations last-to-first. r=mats
MozReview-Commit-ID: Ftc8NJLTaAw

--HG--
extra : rebase_source : bfe1e6be81b460b320145fa345b722775db24f4c
2018-01-15 21:39:03 +01:00
Emilio Cobos Álvarez
03f4a1ab69 Bug 1429961: Make sure to remove all the continuations with the same PostDestroyData. r=mats
If we remove the first continuation of the ::after content before the last,
before this patch unbind the generated content ASAP. Part of the generated
content (the second counter) in the test-case ends up in a continuation of that
frame.

That text node would already be unbound from the tree when destroying its
frame.

MozReview-Commit-ID: 4VtVRSoGxCT

--HG--
extra : rebase_source : e14b9660adf27c906ec7e89f27693b462ab5bde2
2018-01-15 16:40:26 +01:00
Neil Deakin
0538f8c6ce Bug 1427449, don't close the menu in nsMenuBarFrame::FindMenuWithShortcut when just checking if such a menu shortcut key exists from the keydown event handler, also for extra safety this should only happen for menus not panels, r=felipe 2018-01-15 15:16:56 -05:00
KuoE0
25856340db Bug 1428297 - (Part 3) Disable the assertion that don't allow to call ShowDropDown() in the content process when content-select is enabled. r=mats
To prevent the crash when content-select is enabled, I disable this
assertion that don't allow to call ShowDropDown() in the content
process.

MozReview-Commit-ID: F3BelChp1AK

--HG--
extra : rebase_source : 2bbec4dceffb7698804609010127b37442a907a7
2018-01-10 11:52:37 +08:00
KuoE0
4bd2b6bbf0 Bug 1428297 - (Part 2) Ignore the widget/view usage that is used to show the dropdown menu when content-select is enabled. r=mats
MozReview-Commit-ID: 68HYWmniXwt

--HG--
extra : rebase_source : 4163e1ca016c818acc24ff27121c7e54b45e0aa8
2018-01-08 11:43:51 +08:00
KuoE0
ddd7e128f7 Bug 1428297 - (Part 1) Add an nsLayoutUtils function to check whether content-select is enabled r=mats
MozReview-Commit-ID: KVQ25Dhl9xl

--HG--
extra : rebase_source : 3f3186a7c73ff59f46566a5636d66d0684e3f0f4
2018-01-11 10:37:41 +08:00
Makoto Kato
12f318b242 Bug 1415416 - Part 2. Add test. r=masayuki
MozReview-Commit-ID: 5Bbh5ifPSs7

--HG--
extra : rebase_source : 07cabbc6f2ed00018c4b6a3ce8eebe121cb7998f
2018-01-11 18:39:40 +09:00
Makoto Kato
81d105c639 Bug 1415416 - Part 1. Collapse selection on focus when value is empty. r=masayuki
After landing bug 1375910, input.value = "" doesn't remove inter text node.
When value is empty, SelectAllOrCollapseToEndOfText will set selection to
end of text.  But since empty text node is still exist, it select all nodes,
instead of collapsed.  So if text node is empty, we should collapse selection.

MozReview-Commit-ID: Gm0AP6YSJIg

--HG--
extra : rebase_source : fa7ecda9761f1e202b0a4600968c2e1151220fc3
2018-01-11 18:39:12 +09:00
Chris Peterson
37efe4d0e6 Bug 1428535 - Add missing override specifiers to overridden virtual functions. r=froydnj
MozReview-Commit-ID: DCPTnyBooIe

--HG--
extra : rebase_source : cfec2d96faeb11656d86d760a34e0a04cacddb13
extra : intermediate-source : 6176724d63788b0fe8caa3f91607c2d93dbaa7ec
extra : source : eebbb0600447f9b64aae3bcd47b4be66c02a51ea
2017-11-05 19:37:28 -08:00
Daniel Holbert
a6a50738be Bug 1430312: Use StaticRefPtr instead of raw pointer for nsImageFrame::gIconLoad. r=tnikkel
MozReview-Commit-ID: HvkQEaZS1OG

--HG--
extra : rebase_source : 2a0da7c49741224c9c4fb8bcb9da3e17d957b253
2018-01-12 16:49:48 -08:00
Coroiu Cristina
d4fc15adbe Backed out 1 changesets (bug 1429088) for crashes, e.g. in reftest/tests/layout/reftests/bugs/309914-1.xul on a CLOSED TREE
Backed out changeset 7647a5900c99 (bug 1429088)
2018-01-13 12:50:05 +02:00
Coroiu Cristina
c90daa0e30 Merge mozilla-central to autoland r=merge a=merge on a CLOSED TREE 2018-01-13 12:02:52 +02:00
Coroiu Cristina
c6a942e1bf Merge inbound to mozilla-central r=merge a=merge 2018-01-13 11:55:23 +02:00
Daniel Holbert
df50292ee2 Bug 1430297: Use AddRef() instead of NS_ADDREF (when keeping generated content alive in nsCSSFrameConstructor). r=mats
MozReview-Commit-ID: ECz1SCYO4ia

--HG--
extra : rebase_source : 87ce08ef34758d4e8ad2463e94a1b62d94f22fe8
2018-01-12 15:33:01 -08:00
Neerja Pancholi
3a1636e2aa Bug 1389319 - Add fuzzy annotation for 1313772.xhtml for non-Android platforms. r=dholbert
MozReview-Commit-ID: LmdtIi12qJQ

--HG--
extra : rebase_source : bbd744b7b38f7ace162a44656ba83884357619ec
2018-01-12 14:07:01 -08:00
Emilio Cobos Álvarez
7902160491 Bug 1429088: Only style children on non-lazy frame construction after we found an insertion point. r=bz
Servo tries to keep this invariant that stuff under a display: none element
subtree doesn't get styled.

This invariant isn't checked in StyleNewChildRange, but we can fix this by just
doing the work after finding an insertion point, which guarantees that.

Do the same for listboxes, since we also style early for them without knowing
whether they actually have a listbox parent frame.

MozReview-Commit-ID: Glyx24wQ6qY

--HG--
extra : rebase_source : 18535795e5a29080f6f0ecc620ee8601faf4826f
2018-01-09 17:19:00 +01:00
Nika Layzell
a0d1f16079 Bug 1383876 - Part 1: Remove GroupedSHistory and Prerendering logic from C++ code, r=freesamael, r=smaug
MozReview-Commit-ID: 2aHA6NcQPGk
2018-01-12 17:52:52 -05:00