Commit Graph

111 Commits

Author SHA1 Message Date
gasolin
d5ec85700b Bug 1387220 - [onboarding]document how to show notification and snippets;r=mossop
MozReview-Commit-ID: 47UIKw4NAQX

--HG--
extra : rebase_source : eb34d2ee4b146754c9337b6b314f3c9ab17643d8
2017-08-04 10:52:13 +08:00
Yura Zenevich
74beb04fec Bug 1377283 - making Close onboarding dialog button accessible. r=gasolin, mossop
MozReview-Commit-ID: 47rUBS3PoNY
2017-08-04 09:34:38 -04:00
Sebastian Hengst
c9e3da9edf Backed out changeset a4e1205b2d4b (bug 1377283) for linting failure at onboarding.js:984 and failing browser-chrome's browser_onboarding_accessibility.js. r=backout on a CLOSED TREE 2017-08-04 09:32:00 +02:00
Sebastian Hengst
4c40354290 Backed out changeset d0c848b96019 (bug 1377298) 2017-08-04 09:31:09 +02:00
Sebastian Hengst
a27bb5029a Backed out changeset 3eaec2fe0d89 (bug 1377276) 2017-08-04 09:31:04 +02:00
Sebastian Hengst
63c58eea46 Backed out changeset e6ac32ef78d3 (bug 1387057) 2017-08-04 09:30:59 +02:00
Yura Zenevich
62dc5614eb Bug 1387057 - improved accessibliity of onboarding notification bar. r=mossop
MozReview-Commit-ID: Hx60C142g3u
2017-08-04 01:05:57 -04:00
Yura Zenevich
b2ed131cbd Bug 1377276 - add modal dialog semantics and better accessibility for onboarding overlay dialog. r=mossop, gasolin, rexboy
MozReview-Commit-ID: 9xyhn7jLJqD
2017-08-04 01:05:56 -04:00
Yura Zenevich
fa4926ee67 Bug 1377298 - improve semantics and keyboard accessibility of tour tabs UI in onboarding overlay. r=mossop, gasolin
MozReview-Commit-ID: Iay3mL6RJKF
2017-08-04 01:05:56 -04:00
Yura Zenevich
630e84a80d Bug 1377283 - making Close onboarding dialog button accessible. r=gasolin, mossop
MozReview-Commit-ID: 47rUBS3PoNY
2017-08-04 01:05:56 -04:00
Wes Kocher
2196b718d3 Merge inbound to central, a=merge
MozReview-Commit-ID: DlSLhaepjeU
2017-08-03 18:06:53 -07:00
Yura Zenevich
0d362b188c Bug 1377273 - added focus styling for onboarding overlay button. r=mossop, gasolin
MozReview-Commit-ID: BZgx4ODL2at
2017-08-03 15:55:35 -04:00
Tim Nguyen
355a783bae Bug 1385702 - Update and clean up close icon styling for photon. r=dao
MozReview-Commit-ID: IpM0Ampi9fE

--HG--
extra : rebase_source : cd7cda3cb86a86cb66113034ac6cb6f2a07b6882
2017-08-03 17:01:36 +00:00
Rex Lee
b0efeb2304 Bug 1385123 - [Onboarding] Fix word wrapping when focusing on tour items under some languages. r=Fischer,mossop
MozReview-Commit-ID: HgMnsOQefQR

--HG--
extra : rebase_source : f19ac9fe53bbe931223c7598e2a150eec66f46b3
2017-08-01 12:22:03 +08:00
Sebastian Hengst
cbd7e56969 merge mozilla-central to autoland. r=merge a=merge 2017-08-01 11:25:13 +02:00
Wes Kocher
3c2dc39278 Merge m-c to inbound, a=merge
MozReview-Commit-ID: BgPWEtPV0sy
2017-07-31 17:49:47 -07:00
gasolin
a1a6b986fb Bug 1385170 - show button string by checking if the platform support set default browser in background;r=mossop
MozReview-Commit-ID: E71IN3QFsqo

--HG--
extra : rebase_source : c63b65aa884fb3fdfa804d27d64d4f4a535954c2
2017-07-28 13:39:31 +08:00
Marco Castelluccio
d5bbddcc3e Bug 1357517 - Remove Preferences.jsm usage from some browser/extensions/ modules. r=Gijs
--HG--
extra : rebase_source : 88c4cec30759e18d77e7e492747a58364ad82474
2017-07-31 20:18:57 +02:00
Fischer.json
ca0a680558 Bug 1383070 - Intermittent: Uncaught exception Should load onboarding overlay, r=mossop
MozReview-Commit-ID: 6avWDMV3PAg

--HG--
extra : rebase_source : e8a9ed4d88d9fe566b5589b1bfd208ecb59a2fa4
2017-07-22 23:40:01 +08:00
gasolin
68ccdfe639 Bug 1382510 - update Private Browsing overlay and notification description;r=Ehsan,flod,mossop
MozReview-Commit-ID: KHyrFHHPVpo

--HG--
extra : rebase_source : eed2e3862f3502cad3d678ceba49e792345f0a97
2017-07-21 11:27:47 +08:00
Fischer.json
cca97d8d15 Bug 1381366 - The onboarding tour notifications and tour dialog close buttons should have a tooltip, r=mossop
MozReview-Commit-ID: 9sEMs6gUsNu

--HG--
extra : rebase_source : f39467f6d1f192e844a851da43182ddb3ae70a84
2017-07-27 13:52:17 +08:00
Rex Lee
60823446ea Bug 1384045 - Show different contents in sync tour of onboarding for signed-in user.r=flod,mossop
MozReview-Commit-ID: BH2f4ujdHbG

--HG--
extra : rebase_source : 45eee8f6284432275db4c106879fdfc398816c13
2017-07-28 16:54:55 +08:00
Carsten "Tomcat" Book
8a74dfa905 Merge mozilla-central to autoland 2017-07-26 11:18:21 +02:00
Rex Lee
cf92e34d51 Bug 1383660 - Let speech bubble of onboarding icon clickable. r=mossop
MozReview-Commit-ID: Mmq5CZNdre

--HG--
extra : rebase_source : a442270cf5b3067b86e20b144b914a46315f6286
2017-07-24 18:56:17 +08:00
Rex Lee
04ef4d11b8 Bug 1381360 - Make the speech bubbles 3px to the right of the fox icons. r=mossop
MozReview-Commit-ID: 8htzKAz3dRS

--HG--
extra : rebase_source : 49968325182d34cec88af72e52ea554f1b7f5e6c
2017-07-24 12:25:30 +08:00
Yura Zenevich
8e51be4606 Bug 1377285 - better focus styling for onboarding-tour action buttons. r=mossop
MozReview-Commit-ID: DuVWIzaKJkG
2017-07-25 15:44:24 -04:00
gasolin
11235d69b5 Bug 1381765 - Should show the first uncomplete tour by default;r=Fischer,mossop
MozReview-Commit-ID: 4vDvR4lVE16

--HG--
extra : rebase_source : 6ba646d7c02b1a56acdee2c155c6db25ae4e0821
2017-07-18 18:23:47 +08:00
Ricky Chien
554036bb60 Bug 1381356 - The onboarding notification button should not wrap r=mossop
MozReview-Commit-ID: L7mMLopZqdl

--HG--
extra : rebase_source : 232d05713ff957e950aedecb7ba0ae9dcc81156e
2017-07-20 14:29:29 +08:00
Fischer.json
38803e780c Bug 1377439 - Should adapt the oboarding UI to the hight-contrast display mode, r=mossop
This patch makes the mininmum and the important elements and images visible in the high-constrast mode, including
- making button have border (using the given default grey border in the high-constrast mode)
- making the upper-left overlay button's fox image visible
- making the images of the X close buttons on the notification bar and on the overlay visible
- making that the navigation item of the current tour on the overlay's right side would have outline
- making the hovered navigation item on the overlay's right side would have outline
- making sure using <button> element for buttons for a better semantic
- changing #onboarding-overlay-icon to #onboarding-overlay-button for a better semantic

MozReview-Commit-ID: Aj6wndb4to9

--HG--
extra : rebase_source : 927658d278dc2ecec762cf856a10020329a95a50
2017-07-18 14:26:25 +08:00
Rex Lee
4cbb3e83f9 Bug 1357027 - Should mark the Firefox Sync tour as completed if user sign-in a Firefox Account. r=florian,mossop
MozReview-Commit-ID: 3giuXdqjJc3

--HG--
extra : rebase_source : 27ac2427291d05b56abcd0cce03345943aef3846
2017-07-10 14:10:03 +08:00
Rex Lee
e8b290868d Bug 1380963 - Display different welcome messages for update or new users on the overlay tour icon.r=flod,gasolin,mossop
MozReview-Commit-ID: A8DxVkSz9dX

--HG--
extra : rebase_source : b3271c44df2b6f92773ada01f003537e86244705
2017-07-17 15:51:43 +08:00
Rex Lee
f4762d7c5e Bug 1381407 - Add Fast&Mordern tour in onboarding overlay. r=flod,gasolin,mossop
MozReview-Commit-ID: 7P4BT3xDheV

--HG--
extra : rebase_source : 16d3d27129bfc664fe3c2d75486414454fc13b1e
2017-07-17 18:25:39 +08:00
Rex Lee
cfc0003109 Bug 1371531 - Add single search tour and notification to onboarding. r=flod,mossop
MozReview-Commit-ID: CQJPpYAmOZd

--HG--
extra : rebase_source : 2e8b28898880d6fc74fa068a985f402d2ad32e72
2017-07-11 16:04:49 +08:00
gasolin
3752705ad3 Bug 1371540 - Should add the Library tour in the onBoarding overlay;r=flod,mossop,rexboy
MozReview-Commit-ID: xPtSZfrzS4

--HG--
extra : rebase_source : 4aadfa9744e28b2e96d48d6c5f65429c2e99e5fa
2017-07-18 14:35:51 +08:00
Rex Lee
6d266e8d9f Bug 1357017 - Display a welcome message on the overlay tour icon. r=flod,mossop
MozReview-Commit-ID: 6Dm0yN0Zc4u

--HG--
extra : rebase_source : 1d2d0dfa8f4715a7c4105f518e01bc33ca1d5e0d
2017-07-12 15:18:40 +08:00
gasolin
abef9a3395 Bug 1381364 - Update Overlay heading string;r=mossop
MozReview-Commit-ID: 1DreCCN0SYg

--HG--
extra : rebase_source : e9e36c93b40ed122ebbc2258d282dc5116099ee2
2017-07-17 12:00:06 +08:00
Rex Lee
29160d4ab7 Bug 1381355 - Use individual icons for Fx 56 tour notifications. r=mossop
MozReview-Commit-ID: DLlRFAqkKxh

--HG--
extra : rebase_source : 146a83107a0001ff6aec80dfdd261481d7e585c1
2017-07-17 14:58:29 +08:00
gasolin
4e8f593a15 Bug 1377289 - [a11y] All tour images should be accessible;r=mossop,yzen
MozReview-Commit-ID: APBEXnNgxC4

--HG--
extra : rebase_source : 606a75fd9434868097cc99f89502c0fb12329160
2017-07-14 12:03:36 +08:00
Ed Lee
17fb6437cc Bug 1381335 - Increase waitForCondition time for initial onboarding-overlay check. f=Fischer r=dmose
Use the larger default 50 tries (and 100ms) on the initial loading of the overlay.

MozReview-Commit-ID: 3qPt8w8yDNN

--HG--
extra : rebase_source : 9ffca1cba88e1cff57dbe3348aacd43f64afd389
2017-07-16 10:04:30 -07:00
Fischer.json
ba0dfbc28a Bug 1381010 - After resizing the window, open the onboarding overlay but the tours would not appear. r=mossop
MozReview-Commit-ID: 3ZxuqTEJJu3

--HG--
extra : rebase_source : 69fe148f0a446f32c96300f54f77133df7652c3d
2017-07-14 21:41:26 +08:00
gasolin
f324b86e29 Bug 1374717 - show alternative message when firefox already the default browser;r=flod,mossop
the call-to-action button will disabled when user click the button, to prevent open settings panel several times
the call-to-action button will be replaced to alternative text when Firefox is already the default browser

MozReview-Commit-ID: LFeTuDnQEFA

--HG--
extra : rebase_source : 93090d1d5994534e370c31b279e23ec78b43cf8a
2017-07-06 16:14:59 +08:00
Rex Lee
124429537c Bug 1378770 - [Onboarding] Sync tour should proceed with only valid Email. r=mossop
MozReview-Commit-ID: BBHPrZPlZzN

--HG--
extra : rebase_source : 1f554bed559b0ab5c6e39561070b2c57f383f690
2017-07-12 12:24:01 +08:00
Fischer.json
7d13c565c2 Bug 1372067 - Part 2: Add the test cases, r=mossop
This commit
- splits up the browser_onboarding_notification.js test
- adds the test_mute_notification_on_1st_session test case
- adds the test_move_on_to_next_notification_when_reaching_max_prompt_count test case
- adds the test_move_on_to_next_notification_when_reaching_max_life_time test case
- adds the test_move_on_to_next_notification_after_interacting_with_notification test case
- updates the existing test cases for the new notification timing policy
- updates the browser_newtab_focus.js test

MozReview-Commit-ID: Ej2bHJSr35z

--HG--
extra : rebase_source : b96eccecf4a82d575ca8dcb13d2ea83848c537a2
2017-07-12 12:44:34 +08:00
Fischer.json
b370360534 Bug 1372067 - Part 1: Implement the prompt timing policy of the tour notification bar, r=mossop
This commit
- mutes tour notification for the 1st 5 mins on the 1st session
- moves on to next tour notification when
  a. previous tour has been prompted 8 times(8 impressions) or
  b. the last time of changing previous tour is 5 days ago
- removes tour from the notification queue forever after user clicked the close or the action button on notification bar to interact with that tour notification.
- makes each tour only has 2 chances to prompt with notification. Each chance includes 8 impressions and 5-days life time. After these 2 chances, no notification would be prompted for tour.

MozReview-Commit-ID: 8fFxohgEkWm

--HG--
extra : rebase_source : 30da9e102d7ffecb3b731ac95dea7c5281db799c
2017-07-12 12:33:45 +08:00
gasolin
0b11bf9e92 Bug 1377470 - run onboarding scripts after browser UI is ready;r=mossop
MozReview-Commit-ID: BRxWc962EW2

--HG--
extra : rebase_source : f64af8d463b9475d3871b8e031cb9e37349cf0bc
2017-07-06 11:40:26 +08:00
Timothy Guan-tin Chien
c493aa2154 Bug 1358970 - Hide onboarding UI when the window size is smaller than 960px, r=mossop
MozReview-Commit-ID: 9Y5SRt21DDP

--HG--
extra : rebase_source : 53195715c38946ebad7537e9110d93a43ea618bf
2017-07-11 14:25:29 +08:00
gasolin
707e2adcab Bug 1379558 - Button style in onboarding should follow photon button style;r=mossop,rexboy
MozReview-Commit-ID: JNXUvOPJDjO

--HG--
extra : rebase_source : cb83c1534e63b25ce3e5003a7e1ced681d33b272
2017-07-10 15:38:17 +08:00
gasolin
345a2f81da Bug 1375775 - test cases for reusable tourset;r=mossop
MozReview-Commit-ID: IlxgYRuFpCc

--HG--
extra : rebase_source : 5fb443a6181e909e6e7dad276e0e5b60ba983936
2017-07-07 11:52:33 +08:00
gasolin
6a631df7f2 Bug 1375775 - Allow reuse existing tours;r=mossop
MozReview-Commit-ID: 4KwLBH5oPXY

--HG--
extra : rebase_source : 3741ce9cc856264774810bd26b727d5fa6ebc2f8
2017-06-26 14:25:55 -07:00
Timothy Guan-tin Chien
e20d1fd33b Bug 1378168 - Ensure overlay notification icon sizing. r=mossop
MozReview-Commit-ID: BNHxuSK2B5R

--HG--
extra : rebase_source : b3596656cd76e20397099621ee761a599653e658
2017-07-06 13:39:19 +08:00