654 Commits

Author SHA1 Message Date
John Schanck
82eacc7db6 Bug 1878598 - remember selected webauthn service for callbacks. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D200721
2024-02-08 00:10:55 +00:00
John Schanck
db62ec84ae Bug 1819713 - remove PublicKeyCredential::IsExternalCTAP2SecurityKeySupported. r=keeler,webidl,smaug
Telemetry shows no use of this method since it was deprecated in 121.

Differential Revision: https://phabricator.services.mozilla.com/D200738
2024-02-06 20:59:18 +00:00
Norisz Fay
068c9016ea Backed out changeset 3eeec53ca76b (bug 1878598) for causing bc failure on nsCOMPtr.h CLOSED TREE 2024-02-06 20:51:20 +02:00
Norisz Fay
bd0a7be2c8 Backed out changeset 8a4086f45142 (bug 1819713) for causing mochitest failures on test_webauthn_isexternalctap2securitykeysupported.html CLOSED TREE 2024-02-06 20:24:07 +02:00
John Schanck
54008d3c55 Bug 1819713 - remove PublicKeyCredential::IsExternalCTAP2SecurityKeySupported. r=keeler,webidl,smaug
Telemetry shows no use of this method since it was deprecated in 121.

Differential Revision: https://phabricator.services.mozilla.com/D200738
2024-02-06 16:36:04 +00:00
John Schanck
dace46ee1d Bug 1878598 - remember selected webauthn service for callbacks. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D200721
2024-02-06 16:33:25 +00:00
Dana Keeler
5255efd04b Bug 1878404 - webauthn: properly implement excludeCredentials for security keys on macOS r=jschanck
Differential Revision: https://phabricator.services.mozilla.com/D200519
2024-02-05 17:01:04 +00:00
John Schanck
ced65429f4 Bug 1877790 - give new webauthn requests priority over pending requests. r=keeler
Previously, a new webauthn request would only have priority over a pending
request if there had been a visibility change. This was an arbitrary design
decision, and was inconsequential before conditional mediation was implemented.

Differential Revision: https://phabricator.services.mozilla.com/D200349
2024-02-01 23:18:36 +00:00
John Schanck
6ee3913a50 Bug 1860016 - zero out aaguid from webauthn attestation statements on android. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D200216
2024-02-01 18:43:49 +00:00
John Schanck
12bcffb776 Bug 1877332 - consume user activation in webauthn cross-origin iframe create request. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D199945
2024-01-30 20:10:18 +00:00
Gijs Kruitbosch
6f0d4c37bc Bug 1780071 - autofix dom/ and layout/ violations of no-comparison-or-assignment-inside-ok r=media-playback-reviewers,dom-storage-reviewers,layout-reviewers,dom-core,emilio,mccr8,aosmond,tschuster,padenot,asuth
Differential Revision: https://phabricator.services.mozilla.com/D198976
2024-01-25 22:18:55 +00:00
Joel Maher
3ad5072cf1 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
221d7acc5b Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Joel Maher
807575f8e1 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Dana Keeler
d5bf4cdb13 Bug 1865379 - Present WebAuthn autofill entries from iCloud keychain r=jschanck,bradwerth
Differential Revision: https://phabricator.services.mozilla.com/D197979
2024-01-16 22:20:39 +00:00
Mark Banner
63f984510a Bug 1866589 - Enable ESLint rules no-self-assign and no-self-compare on dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D194660
2024-01-16 20:45:40 +00:00
Janne Heß
6f8dfdc71f Bug 1870863 - Implement publickey-credentials-create in Permissions-Policy. r=jschanck
MDN: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Permissions-Policy/publickey-credentials-create
This is from the WebAuthn Level 3 standard and extends D174108 and D186245 with cross-origin credentials.create().

This patch now includes changes by jschack which fix the state management in the test.
The 30 tests in test_webauthn_crossorigin_featurepolicy.html pass locally for me.

Differential Revision: https://phabricator.services.mozilla.com/D196856
2024-01-12 22:31:00 +00:00
M. Sirringhaus
dce5c0c5cf Bug 1854918 - Add bio enrollment management (list, add and delete enrollments) to about:webauthn (r=jschanck,fluent-reviewers,desktop-theme-reviewers,flod,Itiel)
Differential Revision: https://phabricator.services.mozilla.com/D189115
2024-01-04 00:12:46 +00:00
Dana Keeler
a12aa47057 Bug 1871439 - (macos) set authenticatorAttachment to cross-platform when using cross-platform provider (i.e. not passkeys) r=jschanck
Differential Revision: https://phabricator.services.mozilla.com/D197091
2023-12-21 19:24:41 +00:00
John Schanck
2a3955ae30 Bug 1863135 - part 2: reset USB token manager even when there is no pending transaction. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D196466
2023-12-18 18:13:53 +00:00
John Schanck
0cbf259e6c Bug 1853747 - add a link to Windows settings for passkey management. r=keeler,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,bolsson,flod
Differential Revision: https://phabricator.services.mozilla.com/D195613
2023-12-12 20:34:39 +00:00
Cristian Tuns
89bdec9dd5 Backed out changeset 7351cc3d5b11 (bug 1853747) for causing failures in createcredential-abort.https.html CLOSED TREE 2023-12-11 18:17:22 -05:00
John Schanck
535fee1af8 Bug 1853747 - add a link to Windows settings for passkey management. r=keeler,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,bolsson,flod
Differential Revision: https://phabricator.services.mozilla.com/D195613
2023-12-11 20:51:52 +00:00
Paul Zuehlcke
89d916da7e Bug 1869309 - Fix test failure by waiting for PopupNotification security delay to expire before clicking the button. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D196079
2023-12-11 18:39:11 +00:00
John Schanck
fa2ce32099 Bug 1868637 - enable passkey support on macOS in early beta and earlier. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195724
2023-12-07 18:12:45 +00:00
Noemi Erli
997fce423a Backed out changeset 6030e83beb63 (bug 1868637) for causing build bustage in StaticPrefList.yaml CLOSED TREE 2023-12-07 01:55:17 +02:00
John Schanck
2ebf3063c7 Bug 1868637 - enable passkey support on macOS in early beta and earlier. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195724
2023-12-06 22:46:12 +00:00
Dana Keeler
1e1116c2b5 Bug 1867682 - cache pending get requests for conditional mediation on macOS r=jschanck
Differential Revision: https://phabricator.services.mozilla.com/D195499
2023-12-05 21:36:08 +00:00
John Schanck
b0137aa8b3 Bug 1868206 - preserve excludeList transports in WebAuthnManager. r=keeler
Depends on D195283

Differential Revision: https://phabricator.services.mozilla.com/D195470
2023-12-05 18:42:06 +00:00
John Schanck
56a6a94bf8 Bug 1867847 - part 3: use auth-rs for AppID credentials on security keys on macOS. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195283
2023-12-05 18:42:06 +00:00
John Schanck
d993aca055 Bug 1867847 - part 2: add hybrid transport identifier. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195282
2023-12-05 18:42:05 +00:00
John Schanck
755fe26699 Bug 1867847 - part 1: simplify internal service selection in WebAuthnService. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195281
2023-12-05 18:42:05 +00:00
Natalia Csoregi
6db34389ea Backed out 4 changesets (bug 1867847, bug 1868206) for causing bustage on WebAuthnService.cpp. CLOSED TREE
Backed out changeset 0c3d33cf25c0 (bug 1868206)
Backed out changeset a5892463f5d7 (bug 1867847)
Backed out changeset e27d868dadef (bug 1867847)
Backed out changeset 6abaa6e54335 (bug 1867847)
2023-12-05 03:47:10 +02:00
John Schanck
20d795081c Bug 1868206 - preserve excludeList transports in WebAuthnManager. r=keeler
Depends on D195283

Differential Revision: https://phabricator.services.mozilla.com/D195470
2023-12-04 22:42:54 +00:00
John Schanck
808f995509 Bug 1867847 - part 3: use auth-rs for AppID credentials on security keys on macOS. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195283
2023-12-04 22:42:54 +00:00
John Schanck
dcae74c097 Bug 1867847 - part 2: add hybrid transport identifier. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195282
2023-12-04 22:42:53 +00:00
John Schanck
9a4722e837 Bug 1867847 - part 1: simplify internal service selection in WebAuthnService. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195281
2023-12-04 22:42:53 +00:00
John Schanck
49437fb58e Bug 1864544 - autofill WebAuthn credentials from Windows Hello. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D194304
2023-12-01 23:56:48 +00:00
John Schanck
792c83a355 Bug 1838932 - implement WebAuthn conditional mediation. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D192764
2023-12-01 23:56:47 +00:00
Cristian Tuns
320a766374 Backed out 4 changesets (bug 1838932, bug 1864544, bug 1853951, bug 1824215) for causing build bustages in WinWebAuthnService.cpp CLOSED TREE
Backed out changeset 8199d5ce1bfa (bug 1864544)
Backed out changeset 1084e05b2914 (bug 1853951)
Backed out changeset 55320a72238f (bug 1824215)
Backed out changeset 876476ccd759 (bug 1838932)
2023-12-01 17:59:13 -05:00
John Schanck
ff584799e6 Bug 1864544 - autofill WebAuthn credentials from Windows Hello. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D194304
2023-12-01 22:01:10 +00:00
John Schanck
9dc1eb2932 Bug 1838932 - implement WebAuthn conditional mediation. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D192764
2023-12-01 22:01:09 +00:00
John Schanck
3ac5ef3004 Bug 1864504 - test case for missing credential id in CTAP 2.0 get response. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D195039
2023-11-30 17:03:05 +00:00
John Schanck
1c9d804d47 Bug 1867353 - vendor authenticator-rs v0.4.0-alpha.24. r=keeler,supply-chain-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D195024
2023-11-29 22:42:39 +00:00
Dana Keeler
2baffe50b3 Bug 1865625 - force attestation to none in macOS platform passkey support r=jschanck
On macOS, the API for platform passkeys doesn't support attestation, so it must
always be "none". Also, when using a cross-platform device, the API shows no
consent UI for non-none attestation, so this forces that to "none" as well, for
now.

Differential Revision: https://phabricator.services.mozilla.com/D194935
2023-11-28 23:19:11 +00:00
John Schanck
788b080ee4 Bug 1866614 - avoid reloading webauthn.dll if the library is not usable. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D194797
2023-11-27 21:58:59 +00:00
Sandor Molnar
aa5fb2756c Backed out 2 changesets (bug 1838932, bug 1853951) for causing wpt failures on webauthn/conditional-mediation.https.html CLOSED TREE
Backed out changeset a3d03bb38eb4 (bug 1853951)
Backed out changeset 26e34a832901 (bug 1838932)
2023-11-18 01:30:17 +02:00
John Schanck
1c9e1e94b1 Bug 1838932 - implement WebAuthn conditional mediation. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D192764
2023-11-17 22:43:40 +00:00
John Schanck
ca5e63d215 Bug 1865223 - prevent WebAuthnManager from generating transaction ID 0. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D193859
2023-11-17 18:35:58 +00:00
John Schanck
ef24c8f842 Bug 1863135 - reset webauthn service after transaction completion. r=keeler
authenticator-rs keeps its device monitor thread alive after a transaction has
completed. This is a workaround to ensure that the device monitor thread does
not prevent the browser from closing.

Differential Revision: https://phabricator.services.mozilla.com/D193481
2023-11-16 17:33:34 +00:00