Florian Queze
4c6a68d1c9
Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj.
2017-04-14 18:29:12 +02:00
Sebastian Hengst
159215e6f4
Backed out changeset 18d45aa984d6 (bug 1355161)
2017-04-14 23:39:23 +02:00
Florian Queze
a363fb8c8b
Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj.
2017-04-14 18:29:12 +02:00
Jared Wein
a54eda04ca
Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
...
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.
MozReview-Commit-ID: ANyg2qfo3Qx
--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Mark Banner
09889d3184
Bug 1343519 - Change the ESLint rule 'import-browserjs-globals' to be an environment (mozilla/browser-window) to better describe the purpose of it. r=mossop
...
MozReview-Commit-ID: FTDV8BcMGeF
--HG--
rename : tools/lint/eslint/eslint-plugin-mozilla/lib/rules/import-browserjs-globals.js => tools/lint/eslint/eslint-plugin-mozilla/lib/environments/browser-window.js
extra : rebase_source : f0e89f2ce3cfdf343213f66a007f74a80a785c19
2017-03-01 21:29:52 +00:00
Mark Banner
a656cedb11
Bug 1341029 - Turn on the ESLint no-undef rule for all of toolkit/. r=jaws
...
MozReview-Commit-ID: Ed9FfkskDos
--HG--
extra : rebase_source : 6ae47dc76b3ebe77b66725a899d32e728af5d35e
2017-02-20 11:45:58 +00:00
Florian Quèze
85611a7b6d
Bug 1331081
- script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
...
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Mark Banner
7d81bfea9f
Bug 1315951 - Fix no-unused-vars issues in toolkit/components (except places). r=mossop
...
MozReview-Commit-ID: 8svkCKZHxsq
--HG--
extra : rebase_source : 01552e8214f02490aad3cf704757f52a9c3b3959
2016-11-08 12:49:32 +00:00
Boris Zbarsky
fee88c0518
Bug 1167575. Ensure that we don't exit modal state while we're still waiting on a Gecko runnable in the event-loop-spinning code in nsPrompter.js. r=dolske
...
If we synchronously shut down the prompt, that will exit modal state while we're
still processing our mouse or key event, which happens _before_ Gecko runnable
processing. Exiting modal state will generally post a runnable to run timeouts,
so we can end up processing that runnable before we return from processNextEvent
and unwind to whatever code did the alert() call on the web page. The upshot is
that the webpage will see timeouts fire before the alert() call returns.
If we exit modal state off a Gecko runnable instead, that will ensure that we
return to the nsPrompter code immediately after exiting modal state, see that
the prompt is no longer active, and return to the calling web page code _before_
processing any more runnables.
2016-09-01 21:31:22 -04:00
Jared Wein
e6276ea7f5
Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
...
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
fd84c776c7
Bug 1292042
- Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
...
MozReview-Commit-ID: EMjJ3yWt9Wt
--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Jared Wein
12c934b23b
Bug 622939 - Clicking anywhere on a tab-modal prompt should focus it. r=Gijs
...
MozReview-Commit-ID: JziZBlLQZiI
--HG--
extra : rebase_source : 769e84bcaf45442af5a4ed14e249d8454b62198c
2016-07-14 14:24:24 -04:00
Xidorn Quan
8bb94fa4a4
Bug 1141895 part 2 - Use unprefixed unicode-bidi values in internal code. r=jfkthame
...
MozReview-Commit-ID: 1o2NEe8eiSX
--HG--
extra : rebase_source : b09e931fc8e318ceda224fe9c02dd7931c75f8ed
2016-06-30 16:25:31 +10:00
Dragana Damjanovic
1de3e688ca
Bug 1230462 - Change the authentiation dialog message. r=mayhemer,dolske,margaret,tanvi
...
--HG--
rename : toolkit/components/prompts/test/test_bug625187.html => toolkit/components/prompts/test/test_subresources_prompts.html
2016-06-06 01:06:00 +02:00
Carsten "Tomcat" Book
e8d8c705a1
Backed out changeset 490d3460a197 (bug 1230462) for test failures in test_modal_prompts.html
...
--HG--
rename : toolkit/components/prompts/test/test_subresources_prompts.html => toolkit/components/prompts/test/test_bug625187.html
2016-06-05 11:26:57 +02:00
Dragana Damjanovic
8d4a3a8b49
Bug 1230462 - Change the authentiation dialog message. r=mayhemer,dolske,margaret,tanvi
...
--HG--
rename : toolkit/components/prompts/test/test_bug625187.html => toolkit/components/prompts/test/test_subresources_prompts.html
extra : rebase_source : f37ed50a558040dee1958c215ccc5559637d2f84
2016-06-03 09:09:00 +02:00
Justin Dolske
1ad0f7cf0f
Bug 1265194 - use the hidden attribute in commonDialog.xul for consistency with tabPrompts.xml. r=adw
2016-04-24 11:01:01 -07:00
Makoto Kato
25b679c83e
Bug 1250772 - Remove softkb-change observer listener. r=mossop
...
MozReview-Commit-ID: 2PkpjTSVSsM
--HG--
extra : rebase_source : 53688c2352da873d8131109c5a9b2eb60f2e16c8
2016-02-24 12:52:38 +09:00
Dave Townsend
9c612a4946
Bug 1231828: Fix JS parsing errors in toolkit and browser XBL files. r=felipe
...
--HG--
extra : commitid : Ig2Yj9oB8m5
extra : rebase_source : 9a83b71125ccbb482e51b649ca09a6c348a5c111
2015-12-10 16:53:46 -05:00
Gijs Kruitbosch
9bdc4d9b9d
Bug 332195 - part 2: allow the user to control this behaviour with a checkbox, r=mconley
...
--HG--
extra : commitid : 7jvP5BNMLUp
extra : rebase_source : 59b5789802d1a46f46d6bd3c04d35633c8cc7132
2015-10-13 11:06:01 +01:00
Carsten "Tomcat" Book
08997000eb
Backed out 2 changesets (bug 1202902
) to recking bug 1202902
to be able to reopen inbound on a CLOSED TREE
...
Backed out changeset 647025383676 (bug 1202902
)
Backed out changeset d70c7fe532c6 (bug 1202902
)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
e7ef778c9d
Backed out 1 changesets (bug 1202902
) for causing merge conflicts to mozilla-central
...
Backed out changeset cfc1820361f5 (bug 1202902
)
--HG--
extra : rebase_source : 5d3db72337754bc7ab0ed0c30b2896100411ff92
2015-10-07 12:13:45 +02:00
Shu-yu Guo
d06b6030f6
Bug 1202902
- Scripted fix the world.
2015-10-06 14:00:31 -07:00
Shu-yu Guo
64db2267cf
Bug 1202902
- Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff)
2015-09-15 11:19:45 -07:00
Alex Bardas
e95da48b1b
Bug 1068660 - Add confirmation dialog to unblock downloads. r=Paolo r=MattN
2014-10-14 11:19:00 +02:00
Blake Kaplan
3a3257f6a8
Bug 899648 - Initial patch to make tab-modal prompts work. Original patch from Tom Schuster <evilpies@gmail.com>. r=dolske
2014-04-04 14:50:42 -07:00
Masayuki Nakano
a183cc5385
Bug 969247 part.1 Remove or replace DOM_VK_ENTER and NS_VK_ENTER users r=smaug
2014-02-15 09:57:39 +09:00
Gervase Markham
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
Simon Montagu
2bb22a3fe3
Give the text in prompts unicode-bidi: isolate. Bug 652550, r=dolske
2011-12-28 10:33:18 +02:00
Jan Bambach
16da8f10c3
Bug 707677 - Use defaultPrevented instead of the deprecated getPreventDefault() in front-end code. r=dao
2011-12-08 10:21:32 +01:00
Dão Gottwald
0bda59ff75
Bug 686469 - Tab-modal alert can overflow the browser window. r=dolske
2011-10-01 21:40:36 +02:00
Mihai Sucan
b23aa91dad
Bug 625187 - Alert origin is no longer shown for third-party iframes.
...
r+a=dolske
2011-02-22 13:04:56 +01:00
Neil Rashbrook
b95151bca0
Bug 625814 - commonDialog icon and text are now differently misaligned. ui-r=faaborg, r=dolske, a=dolske
2011-02-11 20:24:08 -08:00
Frank Yan
1a3b0cf3c2
Bug 613704 - Improve visual design for tab-modal buttons & dialog. r=dolske, a=dolske
2011-02-11 20:24:06 -08:00
Justin Dolske
e2da84b346
Bug 627896 - tab-modal prompts should handle Cmd-. on OS X; r,a=gavin
2011-02-08 18:03:57 -05:00
Paolo Amadini
2090798157
Bug 620615 - New tab-modal alerts can make Firefox unable to quit (part 2). r=dolske, a=blocker
2011-01-28 17:21:00 -08:00
Frank Yan
374abd6a33
Bug 613749 - Fix tab-modal prompt sizing. [hardblocker] r=dolske a=blocking2.0-final
2011-01-27 00:08:05 -08:00
Kyle Huey
3acefc4dd4
Bug 620615 - Make double-extra-sure that we shutdown the prompt. r=dolske
2011-01-19 19:38:48 -05:00
Justin Dolske
2818ff1023
Bug 608604 - commonDialog icon and text are misaligned. r=gavin, a=gavin
2011-01-12 15:51:33 -08:00
Margaret Leibovic
6a24861f60
Bug 622495 - New contentmodal alerts no longer accessible to screen readers. r=gavin, a=blocking-final
2011-01-12 15:49:21 -08:00
Kyle Huey
c4883e406f
Bug 619644: Stop ESC from propagating through a tab-modal prompt. r=dolske a=b:betaN
2010-12-31 21:57:56 -05:00
Gavin Sharp
053cd13b30
Bug 613742: text in tab-modal prompts should be selectable
...
Bug 613742: text in tab-modal prompts should be selectable. r=dolske, a=blocking
2010-12-05 10:33:12 -05:00
Justin Dolske
96cb3976d7
Bug 613760 - Tab-modal prompt dialog has no default button on os x. r=gavin, a=blocking
2010-11-24 19:30:00 -08:00
Edward Lee
50a5d1faf6
Bug 613767 - Return in tab modal prompts doesn't trigger default action [r=dolske a=dolske]
...
Pass the number instead of the xul:button.
--HG--
extra : rebase_source : 4ef8ddbf765efe40ccb6e4e389112926cef82749
2010-11-21 22:35:26 -08:00
Justin Dolske
f150754486
Bug 598786 - Visual design for tab-modal prompts. r=dao, a=me
2010-11-19 21:23:30 -08:00
Justin Dolske
e131dbf0f7
Bug 59314 - Alerts should be content-modal, not window-modal. r=gavin, a=blocking+
2010-11-19 21:23:25 -08:00
Justin Dolske
838d9325a9
Bug 575485 - Refactor commonDialog code into a sharable JSM (Part 3, JSM). r=gavin, a=beltzner
2010-10-27 14:16:17 -07:00
Justin Dolske
2bc44d4e22
Bug 575485 - Refactor commonDialog code into a sharable JSM (Part 1, cleanup). r=gavin, a=beltzner
2010-10-27 14:16:17 -07:00
Mike Hommey
c9b0258029
Backed out changeset 1769b8307bde (bug 575485). a=backout
2010-10-26 12:55:13 +02:00
Mike Hommey
cd11a1c4b8
Backed out changeset fc2988ab64e5 (bug 575485)
2010-10-26 12:53:16 +02:00