Commit Graph

34 Commits

Author SHA1 Message Date
Nathan Froyd
e1d8b92ec6 Bug 1255425 - part 2 - pack kSTSPreloadList into a more efficient format; r=keeler
Entries in kSTSPreloadList currently look like:

class nsSTSPreload
{
  public:
    const char *mHost;
    const bool mIncludeSubdomains;
};

This is inefficient for a couple of reasons:

* The structure has a bunch of wasted space: it takes 8 bytes on 32-bit
  platforms and 16 bytes on 64-bit platforms, even though it only uses 5
  and 9 bytes, respectively.

* The |const char*| requires additional space in the form of relocations
  (at least on Linux/Android), which doubles the space cost of
  individual entries.  (The space cost of the relocations is mitigated
  somewhat on Linux and Android because of elfhack, but there's still
  extra cost in the on-disk format and during the load of libxul to
  process those relocations.)

* The relocations the structure requires means that the data in it can't
  be shared between processes, which is important for e10s with multiple
  content processes.

We can make it more efficient by structuring it like so:

static const char kSTSPreloadHosts[] = {
  // One giant character array containing the hosts, in order:
  //   "example.com\0example.org\0example.test\0..."
  // Use an array rather than a literal string due to compiler limitations.
};

struct nsSTSPreload
{
  // An index into kSTSPreloadHosts for the hostname.
  uint32_t mHostIndex: 31;
  // We use the same datatype for both members so that MSVC will pack
  // the bitfields into a single uint32_t.
  uint32_t mIncludeSubdomains: 1;
};

nsSTSPreload now has no wasted space and is significantly smaller,
especially on 64-bit platforms (saves ~29K on 32-bit platforms and ~85K
on 64-bit platforms).  This organization does add a couple extra
operations to searching for preload list entries, depending on your
platform, but the space savings make it worth it.
2016-03-24 15:09:28 -04:00
ffxbld
a593c802bf No bug, Automated HSTS preload list update from host bld-linux64-spot-543 - a=hsts-update 2016-03-19 04:43:30 -07:00
ffxbld
0391ff34f5 No bug, Automated HSTS preload list update from host bld-linux64-spot-304 - a=hsts-update 2016-03-12 04:40:12 -08:00
ffxbld
a560947174 No bug, Automated HSTS preload list update from host bld-linux64-spot-223 - a=hsts-update 2016-03-08 19:41:36 -08:00
ffxbld
3da59d3c6d No bug, Automated HSTS preload list update from host bld-linux64-spot-309 - a=hsts-update 2016-01-23 04:36:32 -08:00
ffxbld
a2da16b4a2 No bug, Automated HSTS preload list update from host bld-linux64-spot-439 - a=hsts-update 2016-01-16 04:03:44 -08:00
ffxbld
98b790fabc No bug, Automated HSTS preload list update from host bld-linux64-spot-506 - a=hsts-update 2016-01-09 04:38:48 -08:00
ffxbld
5b3f84c48b No bug, Automated HSTS preload list update from host bld-linux64-spot-389 - a=hsts-update 2016-01-02 04:05:31 -08:00
ffxbld
3af3c75cc9 No bug, Automated HSTS preload list update from host bld-linux64-spot-593 - a=hsts-update 2015-12-26 04:05:27 -08:00
ffxbld
beab6972e5 No bug, Automated HSTS preload list update from host bld-linux64-spot-573 - a=hsts-update 2015-12-19 04:09:24 -08:00
ffxbld
28f9941a1a No bug, Automated HSTS preload list update from host bld-linux64-spot-1077 - a=hsts-update 2015-12-12 04:08:00 -08:00
ffxbld
d2a4d282da No bug, Automated HSTS preload list update from host bld-linux64-spot-049 - a=hsts-update 2015-12-05 04:05:17 -08:00
ffxbld
eb8afa37f2 No bug, Automated HSTS preload list update from host bld-linux64-spot-369 - a=hsts-update 2015-12-02 14:59:14 -08:00
ffxbld
71a59e9585 No bug, Automated HSTS preload list update from host bld-linux64-spot-1073 - a=hsts-update 2015-11-21 03:49:55 -08:00
ffxbld
a3e192d586 No bug, Automated HSTS preload list update from host bld-linux64-spot-383 - a=hsts-update 2015-11-17 00:44:56 -08:00
ffxbld
dfb1f8693f No bug, Automated HSTS preload list update from host bld-linux64-spot-508 - a=hsts-update 2015-10-24 03:47:11 -07:00
ffxbld
7b8e76fcc8 No bug, Automated HSTS preload list update from host bld-linux64-spot-1092 - a=hsts-update 2015-10-17 04:10:51 -07:00
ffxbld
8aa9ed515a No bug, Automated HSTS preload list update from host bld-linux64-spot-138 - a=hsts-update 2015-10-10 03:46:00 -07:00
ffxbld
bde4cad906 No bug, Automated HSTS preload list update from host bld-linux64-spot-410 - a=hsts-update 2015-10-03 03:44:49 -07:00
ffxbld
1b40f22c12 No bug, Automated HSTS preload list update from host bld-linux64-spot-363 - a=hsts-update 2015-09-26 03:40:57 -07:00
ffxbld
c354c7fbb7 No bug, Automated HSTS preload list update from host bld-linux64-spot-560 - a=hsts-update 2015-09-19 03:46:49 -07:00
ffxbld
28a278226f No bug, Automated HSTS preload list update from host bld-linux64-spot-542 - a=hsts-update 2015-09-12 03:39:44 -07:00
ffxbld
3ee4abd6a6 No bug, Automated HSTS preload list update from host bld-linux64-spot-1098 - a=hsts-update 2015-09-05 03:41:52 -07:00
ffxbld
1d00751ccd No bug, Automated HSTS preload list update from host bld-linux64-spot-305 - a=hsts-update 2015-09-03 13:59:50 -07:00
ffxbld
ae7af3ea3c No bug, Automated HSTS preload list update from host bld-linux64-spot-317 - a=hsts-update 2015-08-01 03:34:17 -07:00
ffxbld
eb03434709 No bug, Automated HSTS preload list update from host bld-linux64-spot-010 - a=hsts-update 2015-07-30 13:51:26 -07:00
ffxbld
f12b366895 No bug, Automated HSTS preload list update from host bld-linux64-spot-135 - a=hsts-update 2015-07-18 03:35:49 -07:00
ffxbld
f596fa8330 No bug, Automated HSTS preload list update from host bld-linux64-spot-222 - a=hsts-update 2015-07-11 03:33:36 -07:00
ffxbld
857d30b804 No bug, Automated HSTS preload list update from host bld-linux64-spot-384 - a=hsts-update 2015-07-04 03:30:37 -07:00
ffxbld
7ee431527f No bug, Automated HSTS preload list update from host bld-linux64-spot-098 - a=hsts-update 2015-06-27 03:33:47 -07:00
ffxbld
1a89ffacb7 No bug, Automated HSTS preload list update from host bld-linux64-spot-224 - a=hsts-update 2015-06-20 03:32:58 -07:00
ffxbld
671e873521 No bug, Automated HSTS preload list update from host bld-linux64-spot-1061 - a=hsts-update 2015-06-06 03:26:57 -07:00
ffxbld
e6879816ca No bug, Automated HSTS preload list update from host bld-linux64-spot-534 - a=hsts-update 2015-05-30 03:26:57 -07:00
Birunthan Mohanathas
a028ea5c2d Bug 1164714 - Move and flatten security/manager/boot/{public,src}/ into security/manager/ssl/. r=keeler
--HG--
rename : security/manager/boot/src/CertBlocklist.cpp => security/manager/ssl/CertBlocklist.cpp
rename : security/manager/boot/src/CertBlocklist.h => security/manager/ssl/CertBlocklist.h
rename : security/manager/boot/src/DataStorage.cpp => security/manager/ssl/DataStorage.cpp
rename : security/manager/boot/src/DataStorage.h => security/manager/ssl/DataStorage.h
rename : security/manager/boot/src/PublicKeyPinningService.cpp => security/manager/ssl/PublicKeyPinningService.cpp
rename : security/manager/boot/src/PublicKeyPinningService.h => security/manager/ssl/PublicKeyPinningService.h
rename : security/manager/boot/src/RootCertificateTelemetryUtils.cpp => security/manager/ssl/RootCertificateTelemetryUtils.cpp
rename : security/manager/boot/src/RootCertificateTelemetryUtils.h => security/manager/ssl/RootCertificateTelemetryUtils.h
rename : security/manager/boot/src/RootHashes.inc => security/manager/ssl/RootHashes.inc
rename : security/manager/boot/src/StaticHPKPins.errors => security/manager/ssl/StaticHPKPins.errors
rename : security/manager/boot/src/StaticHPKPins.h => security/manager/ssl/StaticHPKPins.h
rename : security/manager/boot/src/nsEntropyCollector.cpp => security/manager/ssl/nsEntropyCollector.cpp
rename : security/manager/boot/src/nsEntropyCollector.h => security/manager/ssl/nsEntropyCollector.h
rename : security/manager/boot/public/nsIBufEntropyCollector.idl => security/manager/ssl/nsIBufEntropyCollector.idl
rename : security/manager/boot/public/nsICertBlocklist.idl => security/manager/ssl/nsICertBlocklist.idl
rename : security/manager/boot/public/nsISSLStatusProvider.idl => security/manager/ssl/nsISSLStatusProvider.idl
rename : security/manager/boot/public/nsISecurityUITelemetry.idl => security/manager/ssl/nsISecurityUITelemetry.idl
rename : security/manager/boot/src/nsSTSPreloadList.errors => security/manager/ssl/nsSTSPreloadList.errors
rename : security/manager/boot/src/nsSTSPreloadList.inc => security/manager/ssl/nsSTSPreloadList.inc
rename : security/manager/boot/src/nsSecureBrowserUIImpl.cpp => security/manager/ssl/nsSecureBrowserUIImpl.cpp
rename : security/manager/boot/src/nsSecureBrowserUIImpl.h => security/manager/ssl/nsSecureBrowserUIImpl.h
rename : security/manager/boot/src/nsSecurityHeaderParser.cpp => security/manager/ssl/nsSecurityHeaderParser.cpp
rename : security/manager/boot/src/nsSecurityHeaderParser.h => security/manager/ssl/nsSecurityHeaderParser.h
rename : security/manager/boot/src/nsSiteSecurityService.cpp => security/manager/ssl/nsSiteSecurityService.cpp
rename : security/manager/boot/src/nsSiteSecurityService.h => security/manager/ssl/nsSiteSecurityService.h
2015-05-26 10:31:25 -07:00