Commit Graph

4790 Commits

Author SHA1 Message Date
Mozilla Releng Treescript
e242e3084e Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2023-09-25 13:56:52 +00:00
Marco Bonardo
e9ffac0820 Bug 1846781 - Use recalc_frecency for updating origins frecency instead of triggers. r=daisuke
Until now we updated origins frecency using direct SQL triggers.
While that guaranteed good performance, it also had some downsides:
 * replacing the algorithms is complicate, the current system only works
   with a straight sum of page frecencies. We are planning to experiment with
   different algorithms in the future.
 * it requires using multiple temp tables and DELETE triggers, that is error
   prone for consumers, that may forget to DELETE from the temp tables, and thus
   break data coherency.
 * there's not much atomicity, since the origins update must be triggered apart
   and a crash would lose some of the changes

This patch is changing the behavior to be closer to the recalc_frecency one that
is already used for pages.
When a page is added, visited, or removed, recalc_frecency of its origin is set
to 1. Later frecency of invalidated origins will be recalculated in chunks.
While this is surely less efficient than the existing system, it solves the
problems presented above.
A threshold is recalculated at each chunk, and stored in the moz_meta table.
This patch continues using the old STATS in the moz_meta table, to allow for
easier downgrades. Once a new threshold will be introduced we'll be able to
stop updating those.

The after delete temp table is maintained because there's no more efficient way
to remove orphan origins promptly. Thus, after a removal from moz_places,
consumers MUST still DELETE from the temp table to cleanup orphan origins.
This also introduces a delayed removal of orphan origins when their frecency
becomes 0.

Differential Revision: https://phabricator.services.mozilla.com/D186070
2023-09-13 13:58:30 +00:00
Neil Deakin
3331d1bd85 Bug 1852236, treat null string formActionOrigin values as not present in certain cases, also restores some checks of formActionOrigin that got lost, r=credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D187842
2023-09-12 17:48:15 +00:00
Neil Deakin
d260d8969f Bug 1850553, remove most infromation from a login that has been synced when it is deleted, r=credential-management-reviewers,sync-reviewers,sgalich,markh
Differential Revision: https://phabricator.services.mozilla.com/D187053
2023-09-03 10:58:20 +00:00
Mozilla Releng Treescript
ddb4ab256d Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2023-08-28 14:03:43 +00:00
Neil Deakin
5fae98f0e4 Bug 1846036, replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh
One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin

Differential Revision: https://phabricator.services.mozilla.com/D184840
2023-08-15 00:21:05 +00:00
Mark Banner
36b18bec43 Bug 1844784 - Ensure Synced Tabs in the history menu is properly removed when FxAccounts are disabled. r=sync-reviewers,places-reviewers,lina,markh
Differential Revision: https://phabricator.services.mozilla.com/D185719
2023-08-09 15:00:20 +00:00
Sandor Molnar
f0fc62f087 Backed out changeset b463b9cd8aef (bug 1846036) for causing failures in toolkit/components/passwordmgr/test/mochitest/test_prompt.html CLOSED TREE 2023-08-05 02:15:47 +03:00
Neil Deakin
a60cb82de8 Bug 1846036, replace usage of findLogins with searchLoginsAsync, r=credential-management-reviewers,sync-reviewers,joschmidt,markh
One caller in modifyLogin is switched to synchronous searchLogins, we can switch this later to add an asyncronous version of modifyLogin

Differential Revision: https://phabricator.services.mozilla.com/D184840
2023-08-04 18:36:03 +00:00
Mark Banner
674bbb9d67 Bug 1846570 - Convert more jsm style imports to ES modules (services). r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D185070
2023-08-02 13:43:07 +00:00
Gregory Pappas
8a35d5cf5f Bug 1845311 - [Part 2] Use ChromeUtils.defineLazyGetter in more places r=arai,webcompat-reviewers,necko-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sync-reviewers,anti-tracking-reviewers,tabbrowser-reviewers,bytesized,twisniewski,sgalich,mak,kershaw,sclements,pbz,robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D184623
2023-08-01 23:01:02 +00:00
Sammy Khamis
a4efac9ebc Bug 1841866: History engine roundtrips data it doesn't know about r=lina,mak
Differential Revision: https://phabricator.services.mozilla.com/D183224
2023-08-01 18:45:08 +00:00
Narcis Beleuzu
15de925e05 Merge mozilla-central to autoland. CLOSED TREE 2023-07-31 19:37:03 +03:00
Mozilla Releng Treescript
52aa09e803 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2023-07-31 15:25:42 +00:00
Mark Banner
26f043124f Bug 1845252 - Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D184780
2023-07-31 13:05:44 +00:00
Stanca Serban
65e766744a Backed out 2 changesets (bug 1845252) for causing mochitests failures in browser_fxa_web_channel.js. CLOSED TREE
Backed out changeset d58bbd55cb35 (bug 1845252)
Backed out changeset 683a87892126 (bug 1845252)
2023-07-28 21:29:30 +03:00
Mark Banner
b08a8b3acd Bug 1845252 - Update consumers of FxAccountsCommon to import the ES module directly. r=markh,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D184780
2023-07-28 17:30:39 +00:00
Gregory Pappas
3eac12bbd7 Bug 1845311 - Use ChromeUtils.defineLazyGetter in more places r=arai,webdriver-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,anti-tracking-reviewers,sessionstore-reviewers,pbz,joschmidt,robwu,issammani,bytesized,owlish,dao
Differential Revision: https://phabricator.services.mozilla.com/D184481
2023-07-26 16:28:11 +00:00
Mark Banner
6fe765f7ca Bug 1845079 - Update more consumers to import ES modules directly. r=arai,settings-reviewers,credential-management-reviewers,sync-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D184371
2023-07-24 15:32:45 +00:00
Mike Kaply
134b5be624 Bug 1826608 - Implement open tabs from other device in new Firefox View. r=sclements,kcochrane,fluent-reviewers,fxview-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D180836
2023-07-18 19:08:04 +00:00
Neil Deakin
2483a0cbf2 Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-07-16 20:15:31 +00:00
Gregory Pappas
1468978431 Bug 1839520 - Convert tps.jsm to ES module r=Standard8,sync-reviewers,skhamis
Co-authored-by: Mark Banner <standard8@mozilla.com>

Differential Revision: https://phabricator.services.mozilla.com/D181610
2023-07-14 03:31:26 +00:00
Mark Banner
182b6db303 Bug 1792824 - Convert ObjectUtils.jsm to an ES module. r=barret,necko-reviewers,devtools-reviewers,kershaw
Depends on D183308

Differential Revision: https://phabricator.services.mozilla.com/D183309
2023-07-12 08:07:23 +00:00
Sammy Khamis
525249fbdf Bug 1838974 - Bookmarks engine roundtrips data it doesn't know about r=markh,lina,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181593
2023-07-07 19:55:40 +00:00
Stanca Serban
5e0a341a67 Backed out 2 changesets (bug 1807618) for autocomplete related failures. CLOSED TREE
Backed out changeset 548365f1d102 (bug 1807618)
Backed out changeset 149b536f4fed (bug 1807618)
2023-07-06 01:27:55 +03:00
Tarik Eshaq
efc914c08e Bug 1638359: Removes kSync and kXCS from local storage. r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181789
2023-07-05 20:18:40 +00:00
Neil Deakin
4339c71887 Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-07-05 19:24:40 +00:00
Noemi Erli
0a74430d29 Backed out changeset 3d70f2411ec6 (bug 1638359) for causing failures in test_ext_storage_sync_kinto.js CLOSED TREE 2023-07-05 01:06:24 +03:00
Tarik Eshaq
4a40d2148e Bug 1638359: Removes kSync and kXCS from local storage. r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181789
2023-07-04 21:10:16 +00:00
Mozilla Releng Treescript
b5775ab82f Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2023-07-04 08:35:07 +00:00
Marco Bonardo
ba5469f14e Bug 1816901 - Remove the Places GuidHelper. r=daisuke,sync-reviewers,skhamis
Depends on D180411

Differential Revision: https://phabricator.services.mozilla.com/D180412
2023-06-24 07:16:51 +00:00
Johannes J. Schmidt
f396154a5c Bug 1820599 - streamline addLogin storage interface - r=credential-management-reviewers,dimi
* encryption is done in storage layer
* use `LoginManager.addLoginAsync` all over the place
* use `LoginManager.addLoginsAsync`  everywhere
* remove sync `LoginManager.addLogin`

Differential Revision: https://phabricator.services.mozilla.com/D178672
2023-06-22 16:17:44 +00:00
Noemi Erli
2902d8db20 Backed out changeset 35c8b566fd53 (bug 1820599) for causing failures in browser_form_history_fallback.js 2023-06-22 16:33:46 +03:00
Johannes J. Schmidt
b6b6043ff3 Bug 1820599 - streamline addLogin storage interface - r=credential-management-reviewers,dimi
* encryption is done in storage layer
* use `LoginManager.addLoginAsync` all over the place
* use `LoginManager.addLoginsAsync`  everywhere
* remove sync `LoginManager.addLogin`

Differential Revision: https://phabricator.services.mozilla.com/D178672
2023-06-22 11:47:58 +00:00
Tarik Eshaq
902b92e52e Bug 1838708: Removes legacy webext storage keys from account state. r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181153
2023-06-19 20:29:02 +00:00
Barret Rennie
da61a22c25 Bug 1775167 - Remove OS.File error support from ErrorSanitizer r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181174
2023-06-16 18:27:58 +00:00
Stanca Serban
ee3137f15f Backed out changeset ec9815c8c589 (bug 1775167) for causing xpcshell failures in test_telemetry.js. CLOSED TREE 2023-06-16 18:23:33 +03:00
Barret Rennie
8154330f97 Bug 1775167 - Remove OS.File error support from ErrorSanitizer r=markh,sync-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181174
2023-06-16 14:20:21 +00:00
Cosmin Sabou
3aec0f043b Backed out changeset 5be10443a2ea (bug 1807618) for mochitest failures on test_autocomplete_password_generation.html. 2023-06-16 00:48:28 +03:00
Neil Deakin
0ba4422a3b Bug 1807618, replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D178406
2023-06-15 20:39:05 +00:00
Mark Banner
ae619c5049 Bug 1838155 - Clean up some console.error calls that had been migrated from Cu.reportError. r=jdescottes,perftest-reviewers,geckoview-reviewers,credential-management-reviewers,search-reviewers,sgalich,owlish,jteow,sparky
This goes through the previous changes in the dependencies of bug 877389, and does two things:
1) Remove instances of \n
2) Change reporting of exceptions so that they are passed as separate arguments. This should result
   in an improved display of the exception in the browser console, should it occur.

Differential Revision: https://phabricator.services.mozilla.com/D180843
2023-06-15 08:33:57 +00:00
Marco Castelluccio
21a2f56033 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-15 08:10:45 +00:00
Noemi Erli
37e0c3eb20 Backed out changeset 63ccd00a399a (bug 898315) for causing failures in test_no_window_update_restart.py CLOSED TREE 2023-06-15 03:21:27 +03:00
Marco Castelluccio
f66df9a273 Bug 1406475 - Remove Svc.Prefs as it's no longer used. r=sync-reviewers,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D180811
2023-06-14 23:15:37 +00:00
Marco Castelluccio
0c52758410 Bug 1406475 - Convert engines-related sync modules to using Services.prefs. r=sync-reviewers,skhamis
Depends on D180809

Differential Revision: https://phabricator.services.mozilla.com/D180810
2023-06-14 23:15:37 +00:00
Marco Castelluccio
d744ff76dd Bug 1406475 - Convert tps sync module to using Services.prefs. r=sync-reviewers,skhamis
Depends on D180808

Differential Revision: https://phabricator.services.mozilla.com/D180809
2023-06-14 23:15:37 +00:00
Marco Castelluccio
c85e65e2e0 Bug 898315 - Update all callers of FileUtils.getDir to remove usage of the shouldCreate parameter. r=Gijs,extension-reviewers,application-update-reviewers,nalexander,robwu
Differential Revision: https://phabricator.services.mozilla.com/D180603
2023-06-14 20:55:52 +00:00
Marco Castelluccio
5fac802934 Bug 1406475 - Convert some sync modules to using Services.prefs. r=sync-reviewers,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D180803
2023-06-14 10:00:06 +00:00
Marco Castelluccio
3588a7d013 Bug 1406475 - Convert sync tests to use Services.prefs instead of Preferences.sys.mjs. r=sync-reviewers,skhamis
Differential Revision: https://phabricator.services.mozilla.com/D180802
2023-06-14 10:00:06 +00:00
Marco Castelluccio
d054aad92c Bug 1406475 - Add Svc.PrefBranch to util. r=sync-reviewers,skhamis
This makes it easier to convert sync to Services.prefs from Preferences.jsm incrementally.

Differential Revision: https://phabricator.services.mozilla.com/D180801
2023-06-14 10:00:06 +00:00