Commit Graph

7538 Commits

Author SHA1 Message Date
Tom Tung
6db05b23ac Bug 1599496 - Turn javascript.options.shared_memory on by default on early Beta; r=bzbarsky
This patch mainly enables the pref for SharedArrayBuffer on early Beta. (We have
already enabled that on Nightly by default)

This change causes some tests to fail. This patch handles the failures for
a mochitest and web-platform-tests.

Differential Revision: https://phabricator.services.mozilla.com/D60965

--HG--
extra : moz-landing-system : lando
2020-01-28 14:53:08 +00:00
Jon Coppeard
6b1a075865 Bug 1610412 - Fix FinalizationGroup test that assumed the browser wouldn't trigger a GC during the test r=mccr8
Depends on D60866

Differential Revision: https://phabricator.services.mozilla.com/D60867

--HG--
extra : moz-landing-system : lando
2020-01-24 20:53:43 +00:00
Andrew McCreight
359a6cd8c2 Bug 1611173 - Remove support for non-nsISupports XPIDL interfaces. r=nika
It used to be that some XPIDL interfaces were allowed to be non-nsISupports,
and were only used to hold a bunch of constants. It appears that we've now
had enough de-COM work happen that there are no longer any, so we can remove
support for this.

Differential Revision: https://phabricator.services.mozilla.com/D61008

--HG--
extra : moz-landing-system : lando
2020-01-24 23:13:30 +00:00
Boris Zbarsky
7a190b94ba Bug 1181957. Don't set up an AutoEntryScript if we're not planning to call script in nsXPCWrappedJS::DelegatedQueryInterface. r=mccr8
For builtinclass interfaces, or ones not declared in IDL, we don't call out
into scripted QueryInterface anyway, so we can return earlier, before we ever
set up the AutoEntryScript.

Differential Revision: https://phabricator.services.mozilla.com/D61005

--HG--
extra : moz-landing-system : lando
2020-01-25 00:13:56 +00:00
Brindusan Cristian
d5beb3eb6b Backed out changeset 27bd6308aff7 (bug 1611173) for build bustages at runtests.py. CLOSED TREE 2020-01-25 00:19:04 +02:00
Andrew McCreight
f446abff25 Bug 1611173 - Remove support for non-nsISupports XPIDL interfaces. r=nika
It used to be that some XPIDL interfaces were allowed to be non-nsISupports,
and were only used to hold a bunch of constants. It appears that we've now
had enough de-COM work happen that there are no longer any, so we can remove
support for this.

Differential Revision: https://phabricator.services.mozilla.com/D61008

--HG--
extra : moz-landing-system : lando
2020-01-24 21:59:35 +00:00
Brindusan Cristian
d5dee0c16b Backed out changeset 64c8ab5ec067 (bug 1611173) for linting failure at xpidl.py. CLOSED TREE 2020-01-24 23:54:00 +02:00
Andrew McCreight
ba3997abc8 Bug 1611173 - Remove support for non-nsISupports XPIDL interfaces. r=nika
It used to be that some XPIDL interfaces were allowed to be non-nsISupports,
and were only used to hold a bunch of constants. It appears that we've now
had enough de-COM work happen that there are no longer any, so we can remove
support for this.

Differential Revision: https://phabricator.services.mozilla.com/D61008

--HG--
extra : moz-landing-system : lando
2020-01-24 21:34:24 +00:00
Andrea Marchesini
c4cb10712a Bug 1609990 - AgentCluster comparison in MessagePort and BroadcastChannel - part 3 - CloneDataPolicy, r=smaug,sfink,lth
Differential Revision: https://phabricator.services.mozilla.com/D60485

--HG--
extra : moz-landing-system : lando
2020-01-24 16:31:21 +00:00
Noemi Erli
e4b712dcb8 Backed out 4 changesets (bug 1609990) for causing Spidermonkey rust bustage CLOSED TREE
Backed out changeset 81a77bb3772c (bug 1609990)
Backed out changeset d4524885cb97 (bug 1609990)
Backed out changeset c95aac908332 (bug 1609990)
Backed out changeset bae3e50ab64d (bug 1609990)
2020-01-24 18:13:24 +02:00
Andrea Marchesini
ac6024f408 Bug 1609990 - AgentCluster comparison in MessagePort and BroadcastChannel - part 3 - CloneDataPolicy, r=smaug,sfink,lth
Differential Revision: https://phabricator.services.mozilla.com/D60485

--HG--
extra : moz-landing-system : lando
2020-01-24 15:25:24 +00:00
Andrea Marchesini
0077863f8e Bug 1605566 - MessagePort + wasm - part 2 - implement JS::StructuredCloneScope::UnknownDestination, r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D59613

--HG--
extra : moz-landing-system : lando
2020-01-24 07:57:56 +00:00
Andrew McCreight
3b96774e64 Bug 1611197, part 3 - Remove some unused hasinterface methods. r=nika
I found these via the code coverage report for XPCInlines.h.

Differential Revision: https://phabricator.services.mozilla.com/D60864

--HG--
extra : moz-landing-system : lando
2020-01-23 17:48:40 +00:00
Andrew McCreight
aed4575d2d Bug 1611197, part 2 - Remove some dead XPCCallContext methods. r=nika
The fields these methods deal with are not dead: they are just
interacted with via other means.

I found these via the code coverage report for XPCInlines.h.

Differential Revision: https://phabricator.services.mozilla.com/D60863

--HG--
extra : moz-landing-system : lando
2020-01-23 17:33:19 +00:00
Andrew McCreight
1d3263daa5 Bug 1611197, part 1 - Get rid of some unused XPCOM interface ancestor methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D60862

--HG--
extra : moz-landing-system : lando
2020-01-23 17:02:43 +00:00
Eric Rahm
1eef62fbd1 Bug 1610387 - Remove nsAutoPtr usage from js/xpconnect/. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D60638

--HG--
extra : moz-landing-system : lando
2020-01-22 20:27:41 +00:00
Narcis Beleuzu
cb54b0227b Backed out 5 changesets (bug 1605566) for wpt failures on shared.html . CLOSED TREE
Backed out changeset 622939cef438 (bug 1605566)
Backed out changeset ab98304e6c84 (bug 1605566)
Backed out changeset 7eab8fd2b62e (bug 1605566)
Backed out changeset 99f61f25ed86 (bug 1605566)
Backed out changeset 77bdf4f86052 (bug 1605566)
2020-01-22 12:58:13 +02:00
Andrea Marchesini
14b6fd8572 Bug 1605566 - MessagePort + wasm - part 2 - implement JS::StructuredCloneScope::UnknownDestination, r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D59613

--HG--
extra : moz-landing-system : lando
2020-01-22 09:32:48 +00:00
Emilio Cobos Álvarez
8a7906f381 Bug 1610064 - Avoid including StyleSheet.h from Document.h. r=nordzilla,firefox-style-system-reviewers
This in turn requires fixing various other include hell / missing include
issues.

Differential Revision: https://phabricator.services.mozilla.com/D60337

--HG--
extra : moz-landing-system : lando
2020-01-21 20:31:05 +00:00
Matthew Gaudet
2146b82ef4 Bug 1610340 - Remove deferred allocation switch r=tcampbell
Differential Revision: https://phabricator.services.mozilla.com/D60452

--HG--
extra : moz-landing-system : lando
2020-01-21 18:02:17 +00:00
Nazım Can Altınova
f70859c47d Bug 1609674 - Add innerWindowID param to AUTO_PROFILER_TEXT_MARKER_CAUSE and use that macro for setTimeout callback marker. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D60270

--HG--
extra : moz-landing-system : lando
2020-01-20 18:53:09 +00:00
Yoshi Cheng-Hao Huang
133ce9d613 Bug 1609636 - Part 2: Add mochitests for WeakRef in browser. r=smaug,jonco
Differential Revision: https://phabricator.services.mozilla.com/D60155

--HG--
extra : moz-landing-system : lando
2020-01-20 12:35:30 +00:00
Jon Coppeard
8e7bc65d31 Bug 1596756 - Add browser tests for FinalizationGroup r=mccr8
These are mochitests because there's currently no way to trigger a GC from WPT. I tried to do this with xpcshell tests but I couldn't get the pref to enable weak refs to work.

Differential Revision: https://phabricator.services.mozilla.com/D59375

--HG--
extra : moz-landing-system : lando
2020-01-15 14:19:28 +00:00
Jon Coppeard
9372af6635 Bug 1593698 - Add a pref to enable support for weak references in nightly builds, off by default r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53023

--HG--
extra : moz-landing-system : lando
2020-01-15 14:22:29 +00:00
Mihai Alexandru Michis
4345a38d0d Backed out 9 changesets (bug 1607791, bug 1605566) for causing multiple wpt failures.
CLOSED TREE

Backed out changeset 39f34852842e (bug 1605566)
Backed out changeset 3427a92445c8 (bug 1605566)
Backed out changeset 36631ec96f1f (bug 1605566)
Backed out changeset 554b2bdce66c (bug 1605566)
Backed out changeset 37026beadbd8 (bug 1605566)
Backed out changeset f15835338319 (bug 1607791)
Backed out changeset 4c92f506cf62 (bug 1607791)
Backed out changeset 80707bcc8427 (bug 1607791)
Backed out changeset 75bc7533c899 (bug 1607791)
2020-01-15 13:45:33 +02:00
Andrea Marchesini
c5b0781d9f Bug 1605566 - MessagePort + wasm - part 2 - implement JS::StructuredCloneScope::UnknownDestination, r=sfink
Differential Revision: https://phabricator.services.mozilla.com/D59613

--HG--
extra : moz-landing-system : lando
2020-01-15 10:00:59 +00:00
Eric Rahm
78ee6675cf Bug 1606187 - Part 2b: Update users of nsClassHashtable to handle UniquePtr differences r=KrisWright,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D59042

--HG--
extra : moz-landing-system : lando
2020-01-13 19:18:56 +00:00
Tooru Fujisawa
66979085f1 Bug 1259822 - Part 1: Add pref to enable fix for accessing property of null or undefined. r=jorendorff
Differential Revision: https://phabricator.services.mozilla.com/D58103

--HG--
extra : moz-landing-system : lando
2020-01-11 05:08:33 +00:00
Daniel Varga
0dad0cf998 Backed out 4 changesets (bug 1596756, bug 1593698, bug 1608069) for causing mochitest leakchecks.
CLOSED TREE

Backed out changeset 37d24b36ce31 (bug 1596756)
Backed out changeset dbd7b3de1ce6 (bug 1596756)
Backed out changeset 2079d95da4a2 (bug 1593698)
Backed out changeset 49da2705c358 (bug 1608069)
2020-01-10 21:21:19 +02:00
Jon Coppeard
0f4b542755 Bug 1596756 - Add browser tests for FinalizationGroup r=mccr8
These are mochitests because there's currently no way to trigger a GC from WPT. I tried to do this with xpcshell tests but I couldn't get the pref to enable weak refs to work.

Differential Revision: https://phabricator.services.mozilla.com/D59375

--HG--
extra : moz-landing-system : lando
2020-01-10 17:20:59 +00:00
Jon Coppeard
12a7da33ac Bug 1593698 - Add a pref to enable support for weak references in nightly builds, off by default r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53023

--HG--
extra : moz-landing-system : lando
2020-01-10 17:22:25 +00:00
Tom Schuster
163e9d47af Bug 1565170 - Disable toSource/uneval in non-chrome code. r=jwalden,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D37689

--HG--
extra : moz-landing-system : lando
2020-01-09 11:48:58 +00:00
Olli Pettay
03c717bd41 Bug 1608093 - Remove support for multiple CycleCollectedJSContexts per CycleCollectedJSRuntime, r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D59338

--HG--
extra : moz-landing-system : lando
2020-01-09 17:27:10 +00:00
Masatoshi Kimura
ef626b5951 Bug 1448967 - Remove enablePrivilege. r=mccr8,marionette-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D57243

--HG--
rename : testing/firefox-ui/resources/security/enable_privilege.html => js/xpconnect/tests/mochitest/test_enable_privilege.html
extra : moz-landing-system : lando
2020-01-08 23:14:48 +00:00
Emilio Cobos Álvarez
e363a41bd4 Bug 1607595 - Remove uses of mozilla::IsBaseOf. r=froydnj
Automatically generated by:

$ rg 'IsBaseOf<' | cut -d : -f 1 | xargs sed -i 's/mozilla::IsBaseOf</std::is_base_of</g'
$ rg 'IsBaseOf<' | cut -d : -f 1 | xargs sed -i 's/IsBaseOf</std::is_base_of</g

Differential Revision: https://phabricator.services.mozilla.com/D59013

--HG--
extra : moz-landing-system : lando
2020-01-08 14:52:10 +00:00
Emma Malysz
dcd4934531 Bug 1596478, remove references to kNameSpaceID_XBL except for instance in nsNameSpaceManager.cpp r=bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D58872

--HG--
extra : moz-landing-system : lando
2020-01-07 21:51:27 +00:00
Tom Schuster
c73016a38b Bug 1605854 - Fix remaining tests using uneval/toSource r=mccr8,bzbarsky
Differential Revision: https://phabricator.services.mozilla.com/D58685

--HG--
extra : moz-landing-system : lando
2020-01-07 13:19:30 +00:00
Jon Coppeard
8a5439976d Bug 1605282 - Fix typo in comment r=mccr8 DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D58833

--HG--
extra : moz-landing-system : lando
2020-01-06 18:48:59 +00:00
Jon Coppeard
408e4bbafe Bug 1605282 - Ensure mGCIsRunning flag is set inside WeakPointerZonesCallback, which is always called from inside the GC r=mccr8
The previous patch was incorrect since by my logic mGCIsRunning should already have been true in AssertInvalidWrappedJSNotInTable. This ends up being false in two situations 1) during shutdown when the finalization callback that sets it has been removed and 2) when called during compacting GC.

This patch fixes the situation by setting it explicitly while we're inside WeakPointerZonesCallback and restoring the original value when we leave.

Differential Revision: https://phabricator.services.mozilla.com/D58818

--HG--
extra : moz-landing-system : lando
2020-01-06 18:37:04 +00:00
Tom Schuster
08310b0e31 Bug 1605854 - Fix xrayToJS test to work with conditional toSource. r=bzbarsky
Because toSource is available to chrome code, we need to adjust some parts where toSource is missing because of content contexts.
We can remove most of these changes when we remove toSource everywhere.

Differential Revision: https://phabricator.services.mozilla.com/D58660

--HG--
extra : moz-landing-system : lando
2020-01-05 11:44:08 +00:00
Andrew McCreight
3512d966e5 Bug 1606735 - XPCNativeSet::mMemberCount is never used. r=bzbarsky
Also, fix a typo in a comment.

Differential Revision: https://phabricator.services.mozilla.com/D58567

--HG--
extra : moz-landing-system : lando
2020-01-03 16:50:45 +00:00
Andrew McCreight
0bb222137a Bug 1606736 - Remove redundant IsValid() check in SystemIsBeingShutDown(). r=bzbarsky
XPCWrappedNative::SystemIsBeingShutDown() returns immediately if the
XPCWN isn't valid, so this check is not needed.

Differential Revision: https://phabricator.services.mozilla.com/D58566

--HG--
extra : moz-landing-system : lando
2020-01-03 16:47:52 +00:00
Jon Coppeard
6604449715 Bug 1605282 - Don't call JS_IterateCompartments while inside GC finalization r=mccr8
This function doesn't expected to be called while running inside of the GC and asserts. At the moment this happens inside XPCJSRuntime::AssertInvalidWrappedJSNotInTable which is called while destroying a nsXPCWrappedJS. We should probably just skip the assertions in this case.

Differential Revision: https://phabricator.services.mozilla.com/D58525

--HG--
extra : moz-landing-system : lando
2020-01-02 15:55:04 +00:00
Ted Campbell
fb57be5918 Bug 1510682 - Add field comments for uses of js::ClassExtension. r=jandem
Depends on D58494

Differential Revision: https://phabricator.services.mozilla.com/D58495

--HG--
extra : moz-landing-system : lando
2020-01-02 08:24:48 +00:00
Ted Campbell
9858a1887e Bug 1510682 - Add field comments for uses of JSClassOps. r=jandem
Depends on D58493

Differential Revision: https://phabricator.services.mozilla.com/D58494

--HG--
extra : moz-landing-system : lando
2020-01-02 14:43:01 +00:00
Jan de Mooij
f0fb749a6e Bug 1603055 - Handle BigInt values in XPCVariant code. r=bzbarsky
Ideally this code would use JS::ValueType with a switch-statement and rely on
compiler exhaustiveness checking, but this is the safer patch.

Differential Revision: https://phabricator.services.mozilla.com/D56727

--HG--
extra : moz-landing-system : lando
2019-12-30 00:36:59 +00:00
Chris Peterson
406763af7f Bug 1570499 - Part 1: Replace MOZ_FALLTHROUGH macro with C++17's [[fallthrough]] attribute. r=froydnj
This changeset is a simple find and replace of `MOZ_FALLTHROUGH` and `[[fallthrough]]`.

Unfortunately, the MOZ_FALLTHROUGH_ASSERT macro (to assert on case fallthrough in debug builds) is still necessary after switching from [[clang::fallthrough]] to [[fallthrough]] because:

* MOZ_ASSERT(false) followed by [[fallthrough]] triggers a -Wunreachable-code warning in DEBUG builds
* but MOZ_ASSERT(false) without [[fallthrough]] triggers a -Wimplicit-fallthrough warning in NDEBUG builds.

Differential Revision: https://phabricator.services.mozilla.com/D56440

--HG--
extra : moz-landing-system : lando
2019-12-20 07:16:43 +00:00
Jan de Mooij
5a7f80a341 Bug 1604429 - Check for the uninitialized-lexical MagicValue in the component loader. r=kmag
Bug 1603373 tightened up JS engine assertions around this, but that broke
Thunderbird tests.

Differential Revision: https://phabricator.services.mozilla.com/D57443

--HG--
extra : moz-landing-system : lando
2019-12-18 19:02:01 +00:00
Paul Bone
02e88682dd Bug 1604676 - Fix formatting in XPCJSContext.cpp r=jandem
Differential Revision: https://phabricator.services.mozilla.com/D57591

--HG--
extra : moz-landing-system : lando
2019-12-18 06:53:21 +00:00
Paul Bone
8b4c7c407f Bug 1584892 - Remove CycleCollectedJSContext::Initialize's nursery size param r=karlt
Differential Revision: https://phabricator.services.mozilla.com/D47873

--HG--
extra : moz-landing-system : lando
2019-12-16 04:14:55 +00:00