Commit Graph

20 Commits

Author SHA1 Message Date
Ting-Yu Lin
fc63f147e7 Bug 1065244 - Part 1 - Add GetRectRelativeToFrame to nsLayoutUtils. f=mtseng, r=roc 2014-09-15 17:07:00 +02:00
Ting-Yu Lin
3277fc6dc5 Bug 1057256 - Part 2 - Add null pointer check for touch and selection carets. r=roc
TouchCaret::IsDisplayable() contains more null pointer check. It covers
what's original there in TouchCaret::HandleEvent().
2014-08-25 02:50:00 +02:00
Robert O'Callahan
150ec76871 Bug 1048752. Part 24: Rename and deCOM Set/GetCaretVisible. r=tn
--HG--
extra : rebase_source : 04249e9b22a62b8f2952515fa48f4ba3227e235e
2014-08-06 17:19:29 +12:00
Robert O'Callahan
0a6d04586e Bug 1048752. Part 17: Rename Get/SetCaretDOMSelection to Get/SetSelection. r=tn
The forward declaration of Selection in nsCaret.h will be used in later patches.

--HG--
extra : rebase_source : d1b749adac983c04d3365bb6bfb76a50101beeb5
2014-08-06 17:19:27 +12:00
Robert O'Callahan
2489dc1f01 Bug 1048752. Part 16: Move nsFrameSelection::HINT to CaretAssociationHint.h. r=tn
This patch started an attempt to remove nsFrameSelection.h from nsCaret.h
and metastasized into a rather large refactoring patch that removed it
from some other header files as well, and changed nsFrameSelection::HINT
into a global-scope enum with better names. I also converted bools
into CaretAssociationHint in a few places where that was appropriate,
but there are still some more places (GetChildFrameContainingOffset)
where bools need to be converted. I figured this patch was big enough already.

--HG--
extra : rebase_source : cc618ef60e707e1360644340a2648de389383da0
2014-08-06 17:19:27 +12:00
Robert O'Callahan
b4ed20d441 Bug 1048752. Part 14: Split GetGeometry into a static and a non-static version. r=tn
GetGeometry is used in two different ways. Sometimes it's used to get
information about a particular caret. Sometimes it's used to get
information about a particular selection that's not associated with
a caret. Splitting GetGeometry into a non-static version for the former
and a static version for the latter makes this more clear. Also it saves
code since for the latter version we don't have to get an nsCaret first.

--HG--
extra : rebase_source : b7730dac56b308a82b79b175749234c9a92b6f59
2014-08-06 17:19:26 +12:00
Robert O'Callahan
b8bd1730f3 Bug 1048752. Part 9: Remove nsCaret.h from nsDisplayList.h. r=tn
I got tired of slow build turnarounds every time I modified nsCaret.h.

--HG--
extra : rebase_source : 0c4598c4881ab8de0a636b08c70fb801bb912247
2014-08-06 17:19:25 +12:00
Ting-Yu Lin
db39eafdda Bug 1046732 - Part 1: Fix incorrect event message used in TouchCaret.cpp. r=ehsan
NS_WHEEL_EVENT_START isn't a specific event message for compairing in
the switch case. Since we would like to hide touch caret whenever
receving wheel events, all the wheel event types are added.
2014-08-07 01:26:00 -04:00
Ting-Yu Lin
4099ebe260 Bug 1016184 - Part 3b: Revise touch caret visibility logic. f=pchang, r=ehsan
* Refactor UpdateTouchCaret() into smaller functions.
* Update touch caret in PresShell::DidDoReflow() and
  PresShell::UnsuppressAndInvalidate() if needed.
2014-07-27 00:15:00 +02:00
Ting-Yu Lin
ac20b2f613 Bug 1016184 - Part 3a: Fix typos and minor style changes. r=ehsan
Also group the private section together, and remove the protect section
since TouchCaret is a MOZ_FINAL class.
2014-07-27 00:13:00 +02:00
Morris Tseng
e2277374e8 Bug 1023041 - Part 2: Generate correct event when dragging touch caret. r=roc 2014-08-04 00:24:00 -04:00
Ryan VanderMeulen
908eceaa30 Backed out 9 changesets (bug 1016184) for frequent OSX Gip timeouts.
Backed out changeset 0893f2ef4b9a (bug 1016184)
Backed out changeset 93587ce1162b (bug 1016184)
Backed out changeset a52c9d674927 (bug 1016184)
Backed out changeset ca2fd0f41a12 (bug 1016184)
Backed out changeset 84dacf014e39 (bug 1016184)
Backed out changeset 16854e321f23 (bug 1016184)
Backed out changeset 8acd5e707c83 (bug 1016184)
Backed out changeset d0513eae0c97 (bug 1016184)
Backed out changeset 0d03cd217c64 (bug 1016184)
2014-07-31 13:29:30 -04:00
Ting-Yu Lin
ebba7aea48 Bug 1016184 part 3b - Revise touch caret visibility logic. f=pchang, r=ehsan
* Refactor UpdateTouchCaret() into smaller functions.
* Update touch caret in PresShell::DidDoReflow() and
  PresShell::UnsuppressAndInvalidate() if needed.
2014-07-27 00:15:00 +02:00
Ting-Yu Lin
c882c29267 Bug 1016184 part 3a - Fix typos and minor style changes. r=ehsan
Also group the private section together, and remove the protect section
since TouchCaret is a MOZ_FINAL class.
2014-07-27 00:13:00 +02:00
Ting-Yu Lin
1c2a705229 Bug 1016184 - part 2 - Add debug logs to touch caret. r=ehsan 2014-07-13 21:29:00 +02:00
Kartikaya Gupta
30f43e9c10 Bug 1036444 - Kill touchenter and touchleave events. r=smaug 2014-07-09 10:27:00 -04:00
Ting-Yu Lin
a1ed7482f0 Bug 1020261 - Part 1: Fix touch event handling for touch caret. r=roc
For touch events generated by marionette, the touch id is not started
from 0. Therefore, instead of getting the event position of touch id 0
directly in HandleTouchDownEvent(), we should loop over all the touch
ids to get their positions.
2014-06-12 22:58:00 -04:00
Morris Tseng
e0ddfe5e18 Bug 987718 - Part 5: Add SelectionCarets; r=roc 2014-06-04 22:57:00 +02:00
Phoebe Chang
4286f5c0d3 Bug 924692 - Part 4: Hooks up event handling to TouchCaret; r=roc, bugs 2014-06-03 15:08:54 +08:00
Phoebe Chang
2bcba7c1cc Bug 924692 - Part 3: Add TouchCaret; r=roc, bugs 2014-06-03 15:08:45 +08:00