Noemi Erli
e40be0aa72
Backed out 6 changesets (bug 1638358) for causing failures in test_Chrome_cookies.js CLOSED TREE
...
Backed out changeset 4e8fbe01aa38 (bug 1638358)
Backed out changeset 532731e94bb2 (bug 1638358)
Backed out changeset fad2ba760157 (bug 1638358)
Backed out changeset 932a3fdbd07c (bug 1638358)
Backed out changeset 05a62901a3f5 (bug 1638358)
Backed out changeset cddeada5c4a6 (bug 1638358)
2020-06-01 19:45:46 +03:00
Noemi Erli
f08b043cf6
Backed out 5 changesets (bug 1639833
) for causing sessionstorage related failures CLOSED TREE
...
Backed out changeset b36af8d9db34 (bug 1639833
)
Backed out changeset 712c11904dbe (bug 1639833
)
Backed out changeset 14f1e4783582 (bug 1639833
)
Backed out changeset b7f14c4cfe5d (bug 1639833
)
Backed out changeset b4b25034dd83 (bug 1639833
)
2020-06-01 19:31:50 +03:00
Andrea Marchesini
a997c1d626
Bug 1639833
- IntrisincStoragePrincipal should always be partitioned - part 4 - Renaming storage access permission methods, r=dimi
...
Differential Revision: https://phabricator.services.mozilla.com/D76917
2020-06-01 11:59:46 +00:00
Andrea Marchesini
bfdca98faf
Bug 1638358 - Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75800
2020-06-01 15:17:31 +00:00
Andrea Marchesini
bcda89c3fb
Bug 1638358 - Cookie Schemeful Same-Site - part 5 - schemeful comparison, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75629
2020-06-01 11:43:28 +00:00
Andrea Marchesini
ce264fd0b1
Bug 1638358 - Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75628
2020-06-01 11:43:30 +00:00
Andrea Marchesini
165022b2c4
Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-01 11:43:19 +00:00
Andrea Marchesini
d3f891933d
Bug 1638358 - Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75626
2020-06-01 11:43:21 +00:00
Andrea Marchesini
0cc026faf1
Bug 1638358 - Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75624
2020-06-01 11:43:23 +00:00
Dorel Luca
9574e25c80
Backed out 6 changesets (bug 1638358) for XPCShell failures in netwerk/cookie/test/unit/test_schemeMap.js. CLOSED TREE
...
Backed out changeset 745eab35e851 (bug 1638358)
Backed out changeset a45df1876e37 (bug 1638358)
Backed out changeset 1a85cc92d2fb (bug 1638358)
Backed out changeset 2156294cb158 (bug 1638358)
Backed out changeset 31101054c52c (bug 1638358)
Backed out changeset d284b50551ab (bug 1638358)
2020-06-01 14:38:22 +03:00
Andrea Marchesini
814f65058b
Bug 1638358 - Cookie Schemeful Same-Site - part 6 - console messages, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75800
2020-06-01 10:29:48 +00:00
Andrea Marchesini
e2b687e0ce
Bug 1638358 - Cookie Schemeful Same-Site - part 5 - schemeful comparison, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75629
2020-06-01 10:29:34 +00:00
Andrea Marchesini
f9e824f6c7
Bug 1638358 - Cookie Schemeful Same-Site - part 4 - tests for cookie scheme merging, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75628
2020-06-01 10:29:06 +00:00
Andrea Marchesini
d1c11476f6
Bug 1638358 - Cookie Schemeful Same-Site - part 3 - update add/addNative methods, r=mayhemer,remote-protocol-reviewers,marionette-reviewers,maja_zf,MattN,whimboo
...
Differential Revision: https://phabricator.services.mozilla.com/D75627
2020-06-01 10:28:51 +00:00
Andrea Marchesini
8d0f3f353b
Bug 1638358 - Cookie Schemeful Same-Site - part 2 - schemeMap in the cookie DB, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75626
2020-06-01 10:28:18 +00:00
Andrea Marchesini
4afe05e324
Bug 1638358 - Cookie Schemeful Same-Site - part 1 - scheme map in nsICookie, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D75624
2020-06-01 10:27:51 +00:00
Andrea Marchesini
a0049a050f
Bug 1641459 - Consider 3rd parties cookie requested by documents with a window, r=smaug
...
This is required for how Cookies gtests are written
Differential Revision: https://phabricator.services.mozilla.com/D77301
2020-05-29 15:57:29 +00:00
Andrea Marchesini
58c2fe71b1
Bug 1641459 - Do not allow the setting of sameSite=lax/strict cookies from cross-site iframe documents - part 1 - implementation, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D77244
2020-05-29 15:54:24 +00:00
Andrea Marchesini
e9c61f5c0b
Bug 1641459 - Do not expose sameSite=lax/strict cookies to cross-site documents - part 1 - implementation, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D77208
2020-05-29 15:53:42 +00:00
Sebastian Hengst
d9ac58cbcd
Backed out 5 changesets (bug 1641459) for causing bug 1641635 (as requested by baku).
...
Backed out changeset 8f30acc0c69f (bug 1641459)
Backed out changeset 9bb7f1d7f4e8 (bug 1641459)
Backed out changeset a29a3d445871 (bug 1641459)
Backed out changeset d708ea7a1d98 (bug 1641459)
Backed out changeset 21fe51299547 (bug 1641459)
2020-05-29 10:21:52 +02:00
Andrea Marchesini
d0913541e4
Bug 1641459 - Consider 3rd parties cookie requested by documents with a window, r=smaug CLOSED TREE
...
This is required for how Cookies gtests are written
Differential Revision: https://phabricator.services.mozilla.com/D77301
2020-05-28 16:21:33 +00:00
Andrea Marchesini
9706a3ab32
Bug 1641459 - Do not allow the setting of sameSite=lax/strict cookies from cross-site iframe documents - part 1 - implementation, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D77244
2020-05-28 13:25:49 +00:00
Andrea Marchesini
385945afb9
Bug 1641459 - Do not expose sameSite=lax/strict cookies to cross-site documents - part 1 - implementation, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D77208
2020-05-28 11:04:23 +00:00
Andrea Marchesini
8605dd5b17
Bug 1639570 - Implement nsICookieService::getCookieStringFromDocument - part 2 - tests, r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D76143
2020-05-27 10:15:41 +00:00
Andrea Marchesini
ab373eca61
Bug 1639570 - Implement nsICookieService::getCookieStringFromDocument - part 1 - implementation, r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D76142
2020-05-27 10:15:21 +00:00
Dimi Lee
1bd66e58e7
Bug 1637634 - Update IsOnContentBlockingAllowList in nsHttpChannel::AsyncOpen r=timhuang,necko-reviewers
...
This patch removes the assertion that ensures the channel is
top-level via BrowsingContext.
This is because more than one testcases creates a TYPE_DOCUMENT channel
to test.
Differential Revision: https://phabricator.services.mozilla.com/D76152
2020-05-26 06:52:39 +00:00
Csoregi Natalia
60c1f31133
Backed out changeset b42b355fc457 (bug 1637634) for crashes on UpdateIsOnContentBlockingAllowList. CLOSED TREE
2020-05-25 23:54:18 +03:00
Dimi Lee
ed4c44789a
Bug 1637634 - Update IsOnContentBlockingAllowList in nsHttpChannel::AsyncOpen r=timhuang,necko-reviewers
...
This patch removes TYPE_DOCUMENT test in test_shouldclassify because the
testcase creates a non-top level channel with TYPE_DOCUMENT flag (this is wong!),
which triggers the assertion in UpdateIsOnContentBlockingAllowList.
File a follow-up bug 1640715 to add TYPE_DOCUMENT test back.
Differential Revision: https://phabricator.services.mozilla.com/D76152
2020-05-25 18:30:43 +00:00
Liang-Heng Chen
466189ebb4
Bug 1631676 - Part 2: remember FPI state in CookieJarSettings; r=baku,timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D74050
2020-05-19 14:47:57 +00:00
Liang-Heng Chen
0c371a2e76
Bug 1631676 - Part 1: add cookie behavior pref getter; r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D74049
2020-05-19 14:51:10 +00:00
Dimi Lee
27c0acc692
Bug 1637194 - P4. Inherit the first-party domain from the parent document when creating CookieJarSetting in document r=timhuang,baku
...
This fixes a issue that about:blank page can't get correct first-party
domain when fission is enabled.
Differential Revision: https://phabricator.services.mozilla.com/D75784
2020-05-19 09:47:42 +00:00
Dimi Lee
7cf904bbc5
Bug 1637194 - P1. Add firstPartyDomain to CookieJarSetting r=timhuang,baku
...
Differential Revision: https://phabricator.services.mozilla.com/D75276
2020-05-19 09:47:12 +00:00
Magnus Melin
96a75d8f03
Bug 1638288 - don't use nsIPrincipal->GetURI for Thunderbird. r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D75535
2020-05-18 09:23:25 +00:00
ssengupta
cf852bbfb9
Bug 1635399 - Function PrincipalInfoToPrincipal now returns Result<nsCOMPtr<nsIPrincipal>, nsresult> r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D73868
2020-05-12 19:02:05 +00:00
Andrea Marchesini
8317bb8abb
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 5 - extra cleanup, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71978
2020-05-09 20:26:06 +00:00
Andrea Marchesini
b5a4c16dc8
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 4 - remove nsICookieService::setCookieString, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71977
2020-05-09 20:26:09 +00:00
Andrea Marchesini
3321630999
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 3 - remove nsICookieService::setCookieString from tests, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71976
2020-05-09 22:28:53 +00:00
Andrea Marchesini
871dd4ea6a
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 2 - implementation, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71974
2020-05-09 20:26:13 +00:00
Andrea Marchesini
14236dd004
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 1 - CookieService::CanSetCookie without nsIChannel, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71973
2020-05-09 20:26:04 +00:00
Coroiu Cristina
b2935aef35
Backed out 5 changesets (bug 1632187) for xpcshell failures at netwerk/test/unit/test_proxyconnect.js
...
Backed out changeset c0e6dad41b74 (bug 1632187)
Backed out changeset 328ee0899987 (bug 1632187)
Backed out changeset cb775f75ff1f (bug 1632187)
Backed out changeset de6907618ac9 (bug 1632187)
Backed out changeset 1070e843071c (bug 1632187)
2020-05-09 23:22:06 +03:00
Andrea Marchesini
1857609938
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 5 - extra cleanup, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71978
2020-05-09 19:03:47 +00:00
Andrea Marchesini
ac2dfdc4a4
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 4 - remove nsICookieService::setCookieString, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71977
2020-05-09 19:03:30 +00:00
Andrea Marchesini
275ef67da0
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 3 - remove nsICookieService::setCookieString from tests, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71976
2020-05-09 19:03:12 +00:00
Andrea Marchesini
5dbb73b13c
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 2 - implementation, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71974
2020-05-09 19:02:44 +00:00
Andrea Marchesini
c80e092dc1
Bug 1632187 - Introduce nsICookieService::setCookieStringFromDocument - part 1 - CookieService::CanSetCookie without nsIChannel, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D71973
2020-05-09 19:02:30 +00:00
Andrea Marchesini
fcc5266a9e
Bug 1635193 - StoragePrincipalHelper::GetOriginAttributes instead of NS_GetOriginAttributes, r=timhuang
...
Differential Revision: https://phabricator.services.mozilla.com/D73727
2020-05-05 20:56:04 +00:00
Andrea Marchesini
20e7f42224
Bug 1632853 - Remove the support for cookie.txt import, r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D72392
2020-04-28 15:40:37 +00:00
Alex Catarineu
0b7a953f77
Bug 1633015 - Allow 'secure' cookies when set by .onion site r=baku
...
Allow secure cookies when set by a .onion site if
the pref dom.securecontext.whitelist_onions is set to true.
Most of the needed parts were introduced in bug 1618113, due
to the fact that the `IsPotentiallyTrustworthyOrigin()` check
also takes into account onion hostnames.
This adds one missing check, allowing a trustworthy origin
(e.g. onion site) to replace a secure cookie by an insecure
one, as well as adding some tests for the .onion case.
Differential Revision: https://phabricator.services.mozilla.com/D72486
2020-04-27 09:20:50 +00:00
MahakBansal
4650254df8
Bug 1622620 - Replace URIParams with nsIURI in PCookieService.ipdl.r=valentin
...
Differential Revision: https://phabricator.services.mozilla.com/D67268
2020-04-25 19:10:00 +00:00
Andrea Marchesini
37a13f7df5
Bug 1632188 - Cleanup Cookie CTOR, r=dimi
...
Differential Revision: https://phabricator.services.mozilla.com/D71972
2020-04-22 21:01:37 +00:00