Commit Graph

521 Commits

Author SHA1 Message Date
Gabriel Luong
410a2bf7c6 Bug 1175661 - Adding a new rule should use classList instead of splitting the className r=pbrosset 2015-06-18 09:06:56 -07:00
Patrick Brosset
e76d21130d Bug 1174407 - Collapse pseudo-elements section in rule-view by default; r=miker
This changes the default value for the devtools.inspector.show_pseudo_elements pref
to false so that the pseudo-elements section in the rule-view is collapsed by
default.
This section may now contain a lot more rules, especially when showing browser styles
and so it's better to have it collapsed by default.

This required to fix 2 tests that assumed the section was expanded by default.
browser_ruleview_pseudo-element_01.js was also cleaned up a bit to be more compliant
with our eslint rules.

--HG--
extra : rebase_source : 7b096a33d5f485760b2a6138cee0618f81e55e84
extra : histedit_source : e581601164303609176a7519192eb8ec925a9f5d
2015-06-18 10:10:53 +02:00
Gabriel Luong
df467ff0d5 Bug 1173005 - Fixed margin with the pseduoclass panel and left align the pseduoclass options. r=bgrins 2015-06-14 02:16:00 -04:00
Gabriel Luong
978033514e Bug 1172788 - Add tooltip for pseudo class toggle button in the rule view r=bgrins
--HG--
extra : commitid : 6uuIB5Xonry
2015-06-13 13:00:53 -07:00
Jarda Snajdr
f06270e506 Bug 1159922 - In rule view, update the computed values of a property after editing. r=pbro 2015-06-11 12:18:53 +02:00
Tim Nguyen
43c042a6e5 Bug 1173298 - Disable add rule button for non-element nodes and anonymous elements. r=bgrins
--HG--
extra : rebase_source : f623f72d4258fd41339241072ab70ce76f3a1abd
2015-06-10 11:42:00 +02:00
Gabriel Luong ext:(%2C%20Vikneshwar%20%3Clviknesh%40gmail.com%3E)
dbd3261916 Bug 1024693 - [rule view] Copy CSS declarations r=pbrosset 2015-06-10 15:08:27 -07:00
Tom Tromey
83666142fb Bug 1158288 - Show color swatch in drop-shadow function. r=pbrosset 2015-06-08 12:26:00 -04:00
Tom Tromey
f863d43adc Bug 1158288 - Minimal changes for eslint. r=pbrosset 2015-06-08 12:26:00 -04:00
Tim Nguyen
a0c7abbf78 Bug 1165032 - Make 'Add new rule' button add a new rule for currently emulated pseudo class locks. r=bgrins 2015-06-08 12:25:00 -04:00
Jennifer Fong
f1c41ff68f Bug 1163183 - Show HTML5 Forms pseudo elements in the rule view. r=bgrins 2015-06-05 14:48:00 -04:00
Gabriel Luong
574bcb9751 Bug 987365 - Add pseudo-class lock options to rule view r=bgrins 2015-04-23 21:35:00 -07:00
Kyle Zentner
95a87c9836 Bug 1170173 - Parse CSS 'contain' property. r=dholbert
--HG--
extra : rebase_source : 73e15a3049f7e69fdecd7b45157df25fca949b0c
2015-06-04 16:38:00 +02:00
Gabriel Luong
b6cdabf0fd Bug 1040199 - Adding a new rule for a node should handle invalid characters in the element's selector. r=pbrosset 2015-06-01 11:38:00 -04:00
Carsten "Tomcat" Book
0bc9390f36 Backed out changeset 08eaa27485c1 (bug 1166774) for linux e10s dt failures 2015-06-02 15:52:31 +02:00
Alexandre Poirot
785c0a55a5 Bug 1166774 - Wait for rule-view modifications before proceeding to next tests. r=pbrosset 2015-06-01 18:21:46 +02:00
Patrick Brosset
8c2aaa42cf Bug 1166189 - ESLint configuration files for devtools; r=tromey
Adds a global .eslintrc file for all source files in /browser/devtools.
This file defines a set of global variables that are commonly used in
/browser/devtools code.
The files that import modules with Cu.import will need to define their
own globals as /* globals ... */ comments.
This file also defines the configuration for all the rules we want to
use.

This also adds a set of .eslintrc files, one per test directory in
/browser/devtools. Each of these files extend from one of 2 parent config
files: .eslintrc.xpcshell or .eslintrc.mochitest.
The parent config define the set of globals these types of tests have
access to (test runner functions, assertion functions, etc.).

Finally, this also adds .eslintrc files in /toolkit/devtools for code and
tests, which just extend from their counterparts in /browser/devtools.

--HG--
extra : rebase_source : d7b6f639634b64dc084d0835a5fb36c9720a87e7
2015-05-28 09:30:03 +02:00
Gabriel Luong
ab02bbc252 Bug 1139058 - Part 2: Unit test for adding unmatched rules to the rule view r=pbrosset 2015-05-27 17:36:20 -07:00
Gabriel Luong
fda3f71cf7 Bug 1139058 - Part 1: Allow unmatched rules to be added to the rule view r=pbrosset 2015-05-27 17:36:17 -07:00
Alexandre Poirot
4b3d1e9adf Bug 1167181 - Fix pending getOriginalLocation requests while running browser_computedview_matched-selectors_01.js. r=pbrosset 2015-05-25 22:51:45 +02:00
Phil Ringnalda
fba56c45f3 Back out b85bc83d5a15 (bug 1166774) for frequent failures in browser_ruleview_colorpicker-edit-gradient.js 2015-05-26 21:04:21 -07:00
Alexandre Poirot
8f996c93d5 Bug 1166774 - Wait for rule-view modifications before proceeding to next tests. r=pbrosset 2015-05-25 20:14:01 +02:00
Alexandre Poirot
d92d593f6d Bug 1167174 - Assert that custom highlighter do show the highlighter before proceeding. r=pbrosset 2015-05-25 18:54:08 +02:00
Julian Descottes
8db81fb95a Bug 965199 - "Copy Image Data-URL" in computed & rule views. r=pbrosset
This feature is about the inspector's rule view & computed view.
The context menu for an image URL (e.g. value of background-image property)
will contain a new entry : "Copy Image Data-URL". Clicking on it will fill the
clipboard with the image encoded as a data url.

The mechanism to hide/show the entry is inspired from the "Copy Color" menu
entry. When the context menu is displayed, check if the target is contained in
a node of type "image", using the getNodeInfo method available on both views.

If the image data cannot be retrieved for a given URL, the clipboard is filled
with an error message.

Modified rule-view getNodeInfo method in order to exclude from image nodes the
'source' links (such as 'style.css', displayed on the right of the rule-view).

Added a new mochitest that tests the feature on an element using a base64
background image.
2015-05-24 01:41:09 +02:00
Alexandre Poirot
b5cd5dd34f Bug 1167181 - Wait for computed view to be fully loaded in tests before proceeding to next one. r=pbrosset 2015-05-25 01:09:47 +02:00
J. Ryan Stinnett
a4136bcb21 Bug 1067325 - DevTools test fixes for view source in tab. r=pbrosset 2015-05-23 18:17:50 -05:00
Phil Ringnalda
d98af6849d Merge f-t to m-c, a=merge
--HG--
rename : browser/devtools/performance/modules/io.js => browser/devtools/performance/modules/logic/io.js
2015-05-23 14:28:07 -07:00
Patrick Brosset
6b0f771384 Bug 1167617 - Remove SpiderMonkey specific JS syntax from inspector; r=jryans
--HG--
extra : rebase_source : 95a9daf992adf418831ed362c07ac3402e0c5f5f
extra : histedit_source : 4e2d9d6fadc0da7bb7b29bad6dffd7576df6f16a
2015-05-22 20:50:01 +02:00
Gabriel Luong
fc8eec3ca8 Bug 1166344 - [rule view] Store and get the parsed property value displayed in the computed list when filtering styles in the computed list. r=bgrins 2015-05-21 14:47:00 -04:00
J. Ryan Stinnett
cf6686ca14 Backed out changeset a5e245f216b7 on CLOSED TREE (bug 1067325)
--HG--
extra : histedit_source : 96b040b151c109c4843ba62e352509a0ab76714a
2015-05-22 07:01:59 -05:00
J. Ryan Stinnett
cf719c969d Bug 1067325 - DevTools test fixes for view source in tab. r=pbrosset 2015-05-22 05:16:24 -05:00
Gabriel Luong
e39ce9480f Bug 1043835 - Add Rule on an element with multiple classes should include all the classes. r=pbrosset 2015-05-20 14:36:00 +02:00
John Pavlicek
9fb76a86b8 Bug 1164906 - Use EventUtils.sendString instead of looping and calling EventUtils.sendChar in DevTools tests. r=mratcliffe 2015-05-19 14:32:00 -04:00
Gabriel Luong
62545c1e78 Bug 1165380 - [rule view] Filter rules should also highlight stylesheet names. r=bgrins 2015-05-19 13:33:00 -04:00
Tom Tromey
d9710fe9c5 Bug 1154809 - rename and clarify last CSS regexp in rule-view.js; r=pbrosset 2015-05-19 08:55:59 -07:00
Tom Tromey
c82c12171e Bug 1154809 - remove dead css-parsing code; r=pbrosset 2015-05-19 08:55:57 -07:00
Alexandre Poirot
bcdcfd3253 Bug 1161072 - Prevent "no such actor" exception from style inspector during toolbox shutdown. r=pbrosset 2015-05-18 20:15:35 +02:00
Ryan VanderMeulen
33aa7cc49f Backed out 7 changesets (bug 1154809) for xpcshell failures.
Backed out changeset 056f69eee8db (bug 1154809)
Backed out changeset 13f93d585e42 (bug 1154809)
Backed out changeset 1e967727087e (bug 1154809)
Backed out changeset 1f3809022d39 (bug 1154809)
Backed out changeset 7e730e9cb6b3 (bug 1154809)
Backed out changeset 139959618516 (bug 1154809)
Backed out changeset ea59187953f6 (bug 1154809)
2015-05-17 19:54:49 -04:00
Tim Nguyen
64f650e19f Bug 1136101 - Add an "Add rule" button in the rules view toolbar. r=bgrins, ui-r=shorlander 2015-05-16 02:10:00 -04:00
Tom Tromey
412abec581 Bug 1154809 - Rename and clarify last CSS regexp in rule-view.js. r=pbrosset
--HG--
extra : rebase_source : fc11cc70ad7efd590732302791d380ea8748c51c
extra : histedit_source : 9892fd09dd39fcc5a82d76f286e3fb8c808a3aef
2015-05-14 05:35:00 -04:00
Tom Tromey
7fec4dca21 Bug 1154809 - Remove dead css-parsing code. r=pbrosset
--HG--
extra : rebase_source : 5de56b0d53f5e76d4bba51369b0f5d35d280d89e
extra : histedit_source : 447dd118274dd40388369c762f820bfbd5222484
2015-05-14 05:35:00 -04:00
Birunthan Mohanathas
3ffa8d565d Bug 1166840 - Remove unused document argument in uses of nsIClipboardHelper.copyString. r=ehsan 2015-05-21 21:49:30 +01:00
Tom Tromey
58078b80e7 Bug 1153305 - change css-tokenizer.js to use CSSLexer r=pbrosset
--HG--
extra : amend_source : 076c3f65cbbd635d39000f05e1ed6c34fc5ccd52
2015-05-13 11:37:51 -07:00
Tom Tromey
beb546cc3e Bug 930680 - allow inserting ";" in values in style inspector; r=pbrosset 2015-05-13 11:37:18 -07:00
Will Bamberg
02c0af8d5c Bug 1159109 - The MDN tooltip should be controlled by a pref. r=pbrosset
--HG--
extra : rebase_source : 2a13baf09fd96856b87343b3e8c616e70a8979f7
2015-05-06 20:59:00 +02:00
Gabriel Luong
44f5f63247 Bug 1157293 - Part 3: Use filter-open and user-open attributes instead of classes. r=bgrins 2015-05-02 23:40:00 +02:00
Gabriel Luong
397d888f1d Bug 1157293 - Part 2: Renamed styleinspector-open class to user-open. r=bgrins 2015-05-02 23:40:00 +02:00
Gabriel Luong
77d03427b4 Bug 1157293 - Part 1: Filter styles highlight computed styles. r=bgrins 2015-05-06 16:23:00 +02:00
Sami Jaktholm
f094f51b2c Bug 1160720 - Stop dragging the color selector around if no buttons are pressed down on mousemove. r=bgrins
The color picker stops following the mouse when it receives a mouseup event.
However, in some cases when the mouse button is released outside the color
picker frame, the picker won't know about it and will continue to move the
selection when mouse comes back over the picker frame.

As the MouseEvent.buttons property specifies which buttons are pressed when
the event occurs the picker can use said property to detect if it should stop
following the mouse. When .buttons === 0 on a mousemove event no buttons are
pressed down and it should stop following the mouse.

--HG--
extra : rebase_source : c8a852ba34bcf0e6faf63fd69ea5042e572f8d03
2015-05-06 16:58:20 -07:00
Carsten "Tomcat" Book
4feb19d888 Backed out changeset 47a1d2e67785 (bug 1157293) for dt and dt3 test failures 2015-05-06 11:23:50 +02:00
Carsten "Tomcat" Book
56a0c91f42 Backed out changeset 1ec520b96ede (bug 1157293) 2015-05-06 11:22:43 +02:00
Carsten "Tomcat" Book
8621f3385b Backed out changeset 80fc4351eba3 (bug 1157293) 2015-05-06 11:22:22 +02:00
Gabriel Luong
1b3da2781e Bug 1157293 - Part 3: Use filter-open and user-open attributes instead of classes. r=bgrins 2015-05-02 23:40:00 +02:00
Gabriel Luong
17a2bb8701 Bug 1157293 - Part 2: Renamed styleinspector-open class to user-open. r=bgrins 2015-05-02 23:40:00 +02:00
Gabriel Luong
c1f59a3a0c Bug 1157293 - Part 1: Filter styles highlight computed styles. r=bgrins 2015-05-02 23:39:00 +02:00
Gabriel Luong
6b46f2c695 Bug 1158506 - [rule view] Filter styles should handle escape keycode correctly r=bgrins 2015-05-04 14:11:07 -07:00
Tooru Fujisawa
0edbeb71c8 Bug 1102219 - Part 5: Replace more String.prototype.contains with String.prototype.includes in chrome code. r=till 2015-04-30 00:32:05 +09:00
ziyunfei
e1db0f779e Bug 1102219 - Part 4: Replace String.prototype.contains with String.prototype.includes in chrome code. r=till 2015-04-30 00:32:05 +09:00
Brian Grinstead
d4cf2e0950 Bug 1150780 - Refactor ruleview tests and add 'empty value' inplace editor test;r=pbrosset 2015-04-27 07:03:41 -07:00
Alexandre Poirot
11b2ddad6e Bug 1157201 - Prevent exception while hovering the rule-view. r=pbrosset 2015-04-22 07:34:00 +02:00
Jordan Santell
2513d09a8a Bug 1134778 - Consolidate usages of view sourcing in tools with a source-utils module. r=vp,jryans 2015-04-24 14:16:34 -07:00
Will Bamberg
3bf45dfbd2 Bug 980006 - Add MDN tooltips for CSS properties. r=pbrosset
--HG--
extra : rebase_source : 6383633d26384543286e4311a91cb26d4ce4bfd6
2015-04-21 16:28:00 -04:00
Mahdi Dibaiee
def5ece8a6 Bug 1155113 - add ruleview-swatch class to expanded properties; r=pbrosset 2015-04-23 15:03:36 -07:00
Jennifer Fong
be62ea33bc Bug 1032984 - Fix Shift+Home/End/PageUp/PageDown to highlight value. r=bgrins
--HG--
extra : rebase_source : ce1c811725e43245729b2bf2b02cdf77257151ae
2015-04-21 09:28:00 -04:00
Brian Grinstead
7a4f3e1cd2 Bug 1155971 - rename userStylesSearch to filterStylesPlaceholder;r=pbrosset 2015-04-21 11:18:02 -07:00
Michael Ratcliffe
b66e2c69f8 Bug 1136257 - Shift-click to switch between color unit format in place. r=bgrins 2015-04-17 11:53:06 +01:00
Wes Kocher
0d38675c84 Backed out changeset d321fbee8cd8 (bug 1136257) for being the probably cause of e10s-dt orange 2015-04-20 13:42:48 -07:00
Michael Ratcliffe
40cecd0bac Bug 1136257 - Shift-click to switch between color unit format in place r=bgrins 2015-04-17 11:53:06 +01:00
Patrick Brosset
292adfbff7 Bug 1121528 - Avoid the inspector going blank when quickly navigating; r=bgrins
This prevents the WalkerActor from failing at handling various requests when
those requests are about DeaedNodes. Indeed, the async nature of the devtools
protocol means that the client could be asking for information about a node that
doesn't exist anymore because it was part of a page that was navigated away from.
The WalkerActor should know how to deal with such cases, so the patch adds a
number of early returns and a new test for them.
This helps avoiding the inspector-panel from going blank in some edge cases.

--HG--
extra : rebase_source : 26ef72eee71334f6fe467d46a486768296035b8a
extra : histedit_source : 697ddbd179ec2992706f20ca7baccbd4f90f9175%2C6e1130e38ed538809f3ee16fd9a5291fe60a85c1
2015-04-17 12:09:58 +02:00
Gabriel Luong
4e698df748 Bug 1120616 - Part 5: Refactor style inspector tests to use synthesizeKeys r=bgrins 2015-04-16 14:15:35 -04:00
Gabriel Luong
5627d34bdd Bug 1120616 - Part 4: Add textbox context menu for rule and computed view r=bgrins 2015-04-16 14:15:28 -04:00
Gabriel Luong
f9f4f8c891 Bug 1120616 - Part 3: Adjust the styles in the computed view's filter style search r=bgrins 2015-04-16 14:15:24 -04:00
Gabriel Luong
4ab56e56e8 Bug 1120616 - Part 2: Add unit tests for filter styles in rule view r=bgrins 2015-04-16 14:15:20 -04:00
Gabriel Luong
1faf344267 Bug 1120616 - Part 1: Implement filter styles in rule view r=bgrins 2015-04-16 14:15:09 -04:00
Patrick Brosset
e6e0278825 Bug 966787 - 2 - Skip inspector breadcrumb updates when the output doesn't change; r=bgrins
Whenever something changed on the selected element (pseudo, attribute), the
breadcrumbs widget used to loop over all breadcrumbs buttons and re-create the
markup for each.
Now, we cache a string version of the text displayed in a button and compare
the new value to that in the loop, to skip DOM updates.

Additionally, the breadcrumbs widget used to update itself after all markup mutations
in the DOM tree displayed in the inspector. The update method now looks at the mutations
array and early return if none of them actually impact the displayed breadcrumbs.

--HG--
extra : rebase_source : 4945c42d03e5be856c92919aa271811e66f3d188
2015-04-13 10:22:05 +02:00
Mahdi Dibaiee
8a2b7753f8 Bug 1055181 - Mochitests for the CSS Filter tooltip; r=pbrosset
--HG--
extra : rebase_source : d455b727e82bc8eb5817d470a20e5464b7358068
extra : histedit_source : 82eac2b90816fdedd8b4fb7c910db3ac01d78ff6
2015-04-10 12:01:40 +04:30
Mahdi Dibaiee
43193dfe3b Bug 1055181 - CSS Filter Tooltip; r=pbrosset
Adds a new devtools tooltip type in the inspector used to edit
css filters. The widget displayed in the tooltip allows to add,
edit, remove, and re-order filters.
Changes made inside the tooltip are applied to the filter
property in the rule-view.

--HG--
extra : rebase_source : a38ce7108bfa4e035892c3c3d89098dc1b2b0052
extra : histedit_source : ff309c03f920359df61e139731f8f57cf55a1545
2015-04-09 13:30:42 +04:30
Sami Jaktholm
6d3dcf46e2 Bug 1148323 - Make checked checkboxes visibile in rule and computed view context menus on Windows. r=pbrosset 2015-04-04 09:19:47 +03:00
Panos Astithas
e4b9084401 Add a devtools tag to all devtools tests (bug 1149907). r=pbrosset 2015-04-01 14:09:33 +03:00
Sami Jaktholm
499b1fa2b9 Bug 1147765 - Fix console and style inspector tests that interact with style editor. r=ejpbruel
CLOSED TREE
2015-03-21 19:03:35 +02:00
Patrick Brosset
31fcbce2ca Bug 1106272 - Part 3: Test for the selector highlighter feature in the rule-view. r=miker
--HG--
extra : rebase_source : 4b65324399a8ecb8eba60377b16446e4fc0ecf55
2015-03-24 15:57:33 +01:00
Patrick Brosset
d44f1cbad1 Bug 1106272 - Part 2: Change all rule-view events from custom dom events to eventemitter events. r=miker
--HG--
extra : rebase_source : f84711e8e874c92d3f34850573bf375b00930f7d
2015-03-24 15:06:39 +01:00
Patrick Brosset
7a37471593 Bug 1106272 - Part 1: Remove the selector highlight on hover and add a selector icon instead. r=miker
--HG--
extra : rebase_source : 57dcc58a96c35d42111f5b3671de2d4e8da78e35
2015-03-24 14:42:27 +01:00
Alessio Placitelli
d19436f3f5 Bug 1134279 - Change Telemetry data producers to use the correct recording flags. r=vladan 2015-03-23 04:39:00 +01:00
Michael Ratcliffe
cbdede1635 Bug 1120570 - Fix media query in rule view link text. r=bgrins 2015-03-23 17:33:02 +00:00
Tom Tromey
e5bc6a16d3 Bug 1142194 - fix quoteString to correctly quote. r=pbrosset 2015-03-18 08:12:00 +01:00
Tom Tromey
958fa8aaf3 Bug 1142207 - add "^" to REGEX_CSS_VAR to fix variables in the rule view. r=pbrosset
--HG--
extra : amend_source : f904a5d6ae584822606c5c12a3f4027a4d3f7dae
2015-03-16 07:55:00 -07:00
Ryan VanderMeulen
ef7adc09c2 Bug 1137765 - Request a longer timeout for browser_styleinspector_context-menu-copy-color_01.js.
CLOSED TREE

--HG--
extra : rebase_source : 06a5b00a8d4d6747290c1111b80f3e5bb6b7d85b
2015-02-27 12:53:15 -05:00
Tim Nguyen
8e21ed3081 Bug 1133205 - Fix SVG style edition in rules view. r=pbrosset 2015-02-23 12:40:00 -05:00
Brian Grinstead
dc83310391 Bug 1123948 - Wait for _applyingModifications to finish before checking computed style in livepreview test. r=pbrosset 2015-02-18 09:43:00 -05:00
Carsten "Tomcat" Book
5d6b2bde45 Backed out changeset 0799176cb906 (bug 1120570) for m-oth test regressions on a CLOSED TREE 2015-02-18 16:57:48 +01:00
Michael Ratcliffe
2e43ba9759 Bug 1120570 - Fix media query in rule view link text r=bgrins 2015-02-18 12:54:11 +00:00
Matteo Ferretti
b5fd939f60 Bug 1127238 - Remove the hard-coded list of highlighters; r=pbrosset CLOSED TREE
--HG--
extra : amend_source : cd57594cb3fae346e0d454920bc62475a0a3a9ec
2015-02-03 13:03:33 +01:00
L. David Baron
d11f0e55fb Bug 743392 - Serialize background-color at the beginning of the last item of the background shorthand. r=heycam
This matches what Chrome and WebKit do for a single-item background
shorthand, per discussion on today's CSS teleconference.  (At least
Chrome has bugs for multiple-items.)

The added test fails without the patch and passes with the patch.
2015-01-22 16:53:56 -08:00
Patrick Brosset
c993303a3d Bug 1110110 - 1 - Remove various inspector-related exception logs during dt test runs; r=bgrins 2015-01-22 10:42:45 +01:00
Eddy Bruël
4d5052fce3 Bug 1096490 - Remove the deprecated-sync-thenables from protocol.js;r=bgrins 2015-01-19 13:58:45 +01:00
Cameron McCormack
bb019d8d4c Bug 1038134 - Part 6.1: Change browser_ruleview_completion-existing-property_01.js from using border-* to font-*. r=pbrosset 2015-01-17 15:22:52 +11:00
Eddy Bruël
3004465c29 Bug 1118806 - Handle uncaught promise rejections in the storage inspector;r=pbrosset 2015-01-13 10:05:20 +01:00
Heather Arthur
5e9f69c5a4 Bug 990741 - Add telemetry to eyedropper. r=mratcliffe 2014-12-17 11:04:00 -05:00
Michael Ratcliffe
93673abdb9 Bug 1111601 - Avoid using hiddenwindow in DevTools code r=pbrosset 2014-12-17 13:43:30 +00:00