Commit Graph

6711 Commits

Author SHA1 Message Date
Sylvestre Ledru
0aa6f03cf3 Bug 1519636 - Reformat recent changes to the Google coding style r=jgilbert
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D67574

--HG--
extra : moz-landing-system : lando
2020-04-05 13:34:58 +00:00
Narcis Beleuzu
00218b8a49 Backed out 6 changesets (bug 1626404) for assertion failures on BrowsingContext.cpp . CLOSED TREE
Backed out changeset aed006ab4c20 (bug 1626404)
Backed out changeset ad87dcb98637 (bug 1626404)
Backed out changeset c065bd4594b4 (bug 1626404)
Backed out changeset a248fc78ab0c (bug 1626404)
Backed out changeset 52892d053ff1 (bug 1626404)
Backed out changeset 440b9193338a (bug 1626404)
2020-04-04 05:29:30 +03:00
Kris Maglione
c106c09af2 Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69421

--HG--
extra : moz-landing-system : lando
2020-04-04 00:36:30 +00:00
Kris Maglione
5918cf1cca Bug 1626404: Part 3 - Do sandbox flag checks at both ends of cross-process loads. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69420

--HG--
extra : moz-landing-system : lando
2020-04-04 00:12:57 +00:00
Kris Maglione
9f2a2ae567 Bug 1626404: Part 2b - Serialize source BC with LoadState. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69419

--HG--
extra : moz-landing-system : lando
2020-04-04 00:12:59 +00:00
Kris Maglione
4024d7dc97 Bug 1626404: Part 2a - Store source BrowsingContext rather than DocShell in LoadState. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69418

--HG--
extra : moz-landing-system : lando
2020-04-04 00:13:01 +00:00
Kris Maglione
eab4010949 Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69417

--HG--
extra : moz-landing-system : lando
2020-04-04 00:13:04 +00:00
Narcis Beleuzu
ef38cbbda1 Backed out 6 changesets (bug 1626404) for bustages on LocationBase.cpp . CLOSED TREE
Backed out changeset a399dfff2725 (bug 1626404)
Backed out changeset ad3272abd830 (bug 1626404)
Backed out changeset 322c170e8301 (bug 1626404)
Backed out changeset df37f57cfa1d (bug 1626404)
Backed out changeset e255e4c9e665 (bug 1626404)
Backed out changeset 51120d617459 (bug 1626404)
2020-04-04 02:42:18 +03:00
Kris Maglione
e041eac79c Bug 1626404: Part 4 - Remove now-redundant accessor args from BrowsingContext load methods. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69421

--HG--
extra : moz-landing-system : lando
2020-04-03 22:42:25 +00:00
Kris Maglione
8d76c4b32e Bug 1626404: Part 3 - Do sandbox flag checks at both ends of cross-process loads. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69420

--HG--
extra : moz-landing-system : lando
2020-04-03 22:42:17 +00:00
Kris Maglione
b63f3327b7 Bug 1626404: Part 2b - Serialize source BC with LoadState. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69419

--HG--
extra : moz-landing-system : lando
2020-04-03 22:41:27 +00:00
Kris Maglione
70a8120363 Bug 1626404: Part 2a - Store source BrowsingContext rather than DocShell in LoadState. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69418

--HG--
extra : moz-landing-system : lando
2020-04-03 22:41:29 +00:00
Kris Maglione
9a209ac965 Bug 1626404: Part 1 - Move IsSandboxedFrom to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69417

--HG--
extra : moz-landing-system : lando
2020-04-03 22:41:26 +00:00
Eric Rahm
12ca859e67 Bug 1626456 - Remove stray nsAutoPtr.h includes. r=KrisWright
Differential Revision: https://phabricator.services.mozilla.com/D69127

--HG--
extra : moz-landing-system : lando
2020-04-03 21:05:46 +00:00
Olli Pettay
bfc20e2014 Bug 1620818 - Release nsDocShell::mContentViewer properly. r=nika,peterv a=dveditz
Differential Revision: https://phabricator.services.mozilla.com/D69383

--HG--
extra : amend_source : b41f1fc187e21ab8682749034fb1556f59c2c685
2020-04-02 14:43:50 +00:00
Matt Woodrow
7f9f26d6de Bug 1626417 - Try enabling DocumentChannel for about:privatebrowsing. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D69096

--HG--
extra : moz-landing-system : lando
2020-04-02 00:47:43 +00:00
Neil Deakin
61184721de Bug 1610141, findbar should only apply to the main browsers and tests, r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D68782

--HG--
extra : moz-landing-system : lando
2020-03-30 15:10:52 +00:00
nika
3ac24d06a9 Bug 1557118, add support for filtering actor creation based on the messagemanagergroup attribute set on browser elements, r=farre
Differential Revision: https://phabricator.services.mozilla.com/D68780

--HG--
extra : moz-landing-system : lando
2020-04-01 12:59:19 +00:00
Peter Van der Beken
d3031742f5 Bug 1622420 - Cleanup docshell/test/browser/browser_bug422543.js. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D68573

--HG--
extra : moz-landing-system : lando
2020-04-01 10:28:44 +00:00
Peter Van der Beken
88d677afa5 Bug 1622420 - Set the current WindowContext for BrowsingContexts newly created over IPC. r=farre
Differential Revision: https://phabricator.services.mozilla.com/D68572

--HG--
extra : moz-landing-system : lando
2020-04-01 12:54:28 +00:00
Paul Bone
0a2d65eb13 Bug 1597154 - pt 4. Rename SchemeUsesDocChannel r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D59823

--HG--
extra : moz-landing-system : lando
2020-04-01 00:33:31 +00:00
Paul Bone
3a6d9ec5d6 Bug 1597154 - pt 3. Flip documentchannel whitelist to blacklist r=mattwoodrow
This fixes 1597154 because the lists of URIs here and in nsDocShell now
match.

Note that they don't exactly match, there's an exception for about:newtab
which we'll fix in a follow-up bug.

Differential Revision: https://phabricator.services.mozilla.com/D69136

--HG--
extra : moz-landing-system : lando
2020-04-01 01:17:13 +00:00
Paul Bone
ebec315fcf Bug 1597154 - pt 1. Add a comment about checking GetPendingRedirectedChannel r=mattwoodrow,kmag
Differential Revision: https://phabricator.services.mozilla.com/D57597

--HG--
extra : moz-landing-system : lando
2020-04-01 00:32:17 +00:00
sonakshi
a6f08454e0 Bug 1622619 - Replace URIParams with nsIURI in PContent.ipdl r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D67729

--HG--
extra : moz-landing-system : lando
2020-03-31 18:47:30 +00:00
Razvan Maries
40412d7928 Backed out changeset 2515c5b5a0d2 (bug 1622619) for build bustages. CLOSED TREE 2020-03-31 17:18:38 +03:00
sonakshi
fc4a38cd03 Bug 1622619 - Replace URIParams with nsIURI in PContent.ipdl r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D67729

--HG--
extra : moz-landing-system : lando
2020-03-31 13:38:55 +00:00
Kris Maglione
1a8c27fa02 Bug 1576262: Handle ownership races during cross-process navigations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D68454

--HG--
extra : moz-landing-system : lando
2020-03-27 13:55:07 +00:00
Nika Layzell
ba41903373 Bug 1618992 - Improve diagnostics for 'Invalid Transaction from Child', r=farre
Differential Revision: https://phabricator.services.mozilla.com/D67942

--HG--
extra : moz-landing-system : lando
2020-03-26 15:12:09 +00:00
Tim Huang
7e5e34c94e Bug 1616788 - Part 5: Add a field HasStoragePermission in the WindowContext. r=dimi,baku,farre
Differential Revision: https://phabricator.services.mozilla.com/D67470

--HG--
extra : moz-landing-system : lando
2020-03-30 14:12:08 +00:00
Emilio Cobos Álvarez
02c5c21c33 Bug 1625792 - Remove nsIURIContentListener.onStartURIOpen. r=mattwoodrow
It's only used to check whether the docshell is gone already, and we need to
deal with that in other places anyway. No other useful implementation.

In comm-central there are a couple, but they're useless too.

Differential Revision: https://phabricator.services.mozilla.com/D68731

--HG--
extra : moz-landing-system : lando
2020-03-29 22:10:09 +00:00
Emilio Cobos Álvarez
266c1d0b6c Bug 1528305 - Don't show an error page for unknown protocols for page-triggered navigations that replace a document. r=mattwoodrow
Pages apparently do this to try to open to native apps, and that on Firefox
causes an error page to be shown if the app is not installed, which is pretty
bad.

Differential Revision: https://phabricator.services.mozilla.com/D68471

--HG--
extra : moz-landing-system : lando
2020-03-27 17:20:14 +00:00
Csoregi Natalia
8526066f54 Backed out changeset 8aeb06899b10 (bug 1528305) for failures on test_location_href_unknown_protocol.html. CLOSED TREE 2020-03-27 08:07:32 +02:00
Emilio Cobos Álvarez
453c627cea Bug 1528305 - Don't show an error page for unknown protocols for page-triggered navigations that replace a document. r=mattwoodrow
Pages apparently do this to try to open to native apps, and that on Firefox
causes an error page to be shown if the app is not installed, which is pretty
bad.

Differential Revision: https://phabricator.services.mozilla.com/D68471

--HG--
extra : moz-landing-system : lando
2020-03-27 00:06:25 +00:00
Emilio Cobos Álvarez
a251b713ef Bug 1625304 - Remove INTERNAL_LOAD_FLAGS_IS_USER_TRIGGERED. r=mattwoodrow
It's unused (modulo assertions that mask it off), and I want to add something
similar for bug 1528305, so this avoids some confusion.

Differential Revision: https://phabricator.services.mozilla.com/D68456

--HG--
extra : moz-landing-system : lando
2020-03-26 22:39:16 +00:00
James Willcox
1f15cc4c1e Bug 1620657 - Add CanonicalBrowsingContext::GetParentProcessWidgetContaining() r=nika,tnikkel
Differential Revision: https://phabricator.services.mozilla.com/D67683

--HG--
extra : moz-landing-system : lando
2020-03-25 23:47:40 +00:00
Nika Layzell
a1910253b1 Bug 1616991 - Rename WindowGlobalChild::WindowGlobal getter to reflect nullability, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D64660

--HG--
extra : moz-landing-system : lando
2020-03-23 23:03:50 +00:00
Kristen Wright
5094f72a18 Bug 1622111 - Convert security.data_uri.unique_opaque_origin to static pref and remove ClientPrefs. r=njn
Converts security.data_uri.unique_opaque_origin to a static pref. This pref was initialized by the ClientManager in ClientPrefs, so this commit also removes those files. Somehow this pref was getting added in VarCache twice, so it also removes the places where the pref was added in Networking.

Differential Revision: https://phabricator.services.mozilla.com/D67185

--HG--
extra : moz-landing-system : lando
2020-03-23 16:08:52 +00:00
Nika Layzell
bd152e0d88 Bug 1614259 - Ensure BrowisngContexts are detached when nsDocShell is destroyed, r=farre
After bug 1582832, DocShell destruction and BrowsingContext detaching happen
in separate operations, leaving a gap where a DocShell has been destroyed, but
its BrowsingContext is still considered attached. During this gap, the usual
invariant that an in-process, attached BrowsingContext always has an
associated DOM window doesn't hold, nor do the usual invariants for outer
window forwarding security checks.

This patch fixes the detach timing so that a child BrowsingContext for a frame
which has been removed is always marked detached at the same time its DocShell
is destroyed.

Co-authored-by: Kris Maglione <maglione.k@gmail.com>

Differential Revision: https://phabricator.services.mozilla.com/D62791

--HG--
extra : moz-landing-system : lando
2020-03-23 13:28:09 +00:00
Dan Glastonbury
04870fc980 Bug 1623562 - Refactor allowPlugins to use BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D67428

--HG--
extra : moz-landing-system : lando
2020-03-20 04:53:43 +00:00
Narcis Beleuzu
66477aeb36 Backed out changeset 20f1bb2d5bd2 (bug 1623562) for bc failures. CLOSED TREE 2020-03-20 05:42:41 +02:00
Dan Glastonbury
d15761b621 Bug 1623562 - Refactor allowPlugins to use BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D67428

--HG--
extra : moz-landing-system : lando
2020-03-20 02:16:12 +00:00
Matt Woodrow
72a7d5a69b Bug 1613002 - Fix process switch channel connection race. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D67090

--HG--
extra : moz-landing-system : lando
2020-03-19 22:30:07 +00:00
Andrea Marchesini
1e01916653 Bug 1531289 - target=_blank with a download should close the download tab, r=nika,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D66454

--HG--
extra : moz-landing-system : lando
2020-03-19 13:03:14 +00:00
Masatoshi Kimura
3df19bc1d4 Bug 1623222 - Remove the charset parameter from nsITextToSubURI::UnEscapeURIForUI. r=hsivonen
Only 3 callers are using a non-UTF-8 charset as the first parameter.
* MediaDocument.cpp: This does not make sense because the "filename" part of
  URLs will always be encoded with UTF-8.
* nsContextMenu.js: This is wrong because "mailto:" URLs don't care about the
  document charset.
* Finder.jsm: This caused bug 1623222.

Differential Revision: https://phabricator.services.mozilla.com/D67386

--HG--
extra : moz-landing-system : lando
2020-03-19 10:45:28 +00:00
Dan Glastonbury
85893ca83c Bug 1621192 - P4: Remove documentOpenFlags from DocumentChannelCreationArgs. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D66170

--HG--
extra : moz-landing-system : lando
2020-03-19 01:49:24 +00:00
Dan Glastonbury
2e0a825b23 Bug 1621192 - P3: Remove mPluginsAllowed from DocumentChannel. r=mattwoodrow
Differential Revision: https://phabricator.services.mozilla.com/D66169

--HG--
extra : moz-landing-system : lando
2020-03-19 01:49:11 +00:00
Dan Glastonbury
3bbde12e78 Bug 1621192 - P2: Move allowContentRetargeting to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D66168

--HG--
extra : moz-landing-system : lando
2020-03-19 01:49:04 +00:00
Dan Glastonbury
2bb6d70d00 Bug 1621192 - P1: Move allowPlugins to BrowsingContext. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D66167

--HG--
extra : moz-landing-system : lando
2020-03-19 01:48:56 +00:00
Stefan Hindli
5f419e4b50 Backed out 9 changesets (bug 1622111) for causing mochitest failures in dom/animation/test/mozilla/test_restyles.html CLOSED TREE
Backed out changeset c244160797f8 (bug 1622111)
Backed out changeset dd9209f6bd8b (bug 1622111)
Backed out changeset d694c9e7061f (bug 1622111)
Backed out changeset 486aae809f6d (bug 1622111)
Backed out changeset 709266168c41 (bug 1622111)
Backed out changeset ca0d47bb86a8 (bug 1622111)
Backed out changeset caa735c8bb91 (bug 1622111)
Backed out changeset 12397711ab25 (bug 1622111)
Backed out changeset b66002fd1480 (bug 1622111)
2020-03-19 02:47:51 +02:00
Kristen Wright
54ef9a89c8 Bug 1622111 - Convert security.data_uri.unique_opaque_origin to static pref and remove ClientPrefs. r=njn
Converts security.data_uri.unique_opaque_origin to a static pref. This pref was initialized by the ClientManager in ClientPrefs, so this commit also removes those files. Somehow this pref was getting added in VarCache twice, so it also removes the places where the pref was added in Networking.

Differential Revision: https://phabricator.services.mozilla.com/D67185

--HG--
extra : moz-landing-system : lando
2020-03-18 22:12:20 +00:00