Magic-Mirror/gecko-dev
1
0
Fork 0
mirror of https://github.com/mozilla/gecko-dev.git synced 2024-10-25 11:15:34 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity
674,347 Commits 615 Branches 98 Tags 5.9 GiB
e539d2cdc1
Commit Graph

227 Commits

Author SHA1 Message Date
Tyler
b354857779 Bug 1576908 - uses fission model for sending purge history messages r=mconley,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D45959

--HG--
extra : moz-landing-system : lando
 2019-10-03 14:03:34 +00:00
Mike Conley
7429e303ed Bug 1582502 - Don't interpret a click at 0,0 of a fullscreen video as a click on the Picture-in-Picture toggle. r=JSON_voorhees 
We weren't handling the case where the toggle has no dimensions, so its X and Y
coordinate would be at 0,0, which would match a click in the top-left corner of
the screen for a video that was fullscreened.

This adds a check that ensures that the toggle has both width and height before
checking whether or not a mouse event occurred within it.

Differential Revision: https://phabricator.services.mozilla.com/D47789

--HG--
extra : moz-landing-system : lando
 2019-10-01 18:07:14 +00:00
Mike Conley
5794ef1442 Bug 1549442 - Make sure to hide the Picture-in-Picture toggle when the mouse cursor leaves the window. r=JSON_voorhees 
Originally, we were using the :hover pseudoclass to show the Picture-in-Picture toggle,
and using the DevTools InspectorUtils module to manually apply that :hover pseudoclass
in PictureInPictureToggleChild in the event that the <video> element wasn't able to get
the :hover element "naturally".

Removing this pseudoclass when the mouse leaves the browser window (without first
leaving the toggle) doesn't work, since the mouseout event (which we use to detect
the mouse leaving the window) fires _after_ :hover states would normally be cleared,
so it's too late to "unlock" it.

The solution ended up being replacing the :hover pseudoclass with a .hovering class
that PictureInPictureToggleChild continues to manage on its own.

Differential Revision: https://phabricator.services.mozilla.com/D47677

--HG--
extra : moz-landing-system : lando
 2019-10-01 18:09:43 +00:00
Mike Conley
cf8d0284a0 Bug 1583882 - Close Picture-in-Picture player window if the originating <video> is removed from the DOM. r=JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D47613

--HG--
extra : moz-landing-system : lando
 2019-10-01 16:20:51 +00:00
Neil Deakin
4348582007 Bug 1582833, update findbar state correctly when findbar is closed to allow keyboard to work properly, r=mikedeboer 
Differential Revision: https://phabricator.services.mozilla.com/D46906

--HG--
extra : moz-landing-system : lando
 2019-09-30 15:12:28 +00:00
Coroiu Cristina
c094fff9aa Backed out changeset ea2c69779571 (bug 1577381) for a11y failures at accessible/tests/mochitest/attributes/test_obj_group.xul on a CLOSED TREE 2019-09-27 08:00:39 +03:00
James Teh
1adf6ac726 Bug 1577381: Correct accessibility exposure for optgroups in content select dropdowns. r=eeejay,NeilDeakin 
For remote content documents, select dropdowns (for <select size="1">) are rendered in the parent process using a XUL menupopup.
This means that the accessibility code for HTML selects doesn't apply.

In the menupopup, the optgroup is a sibling of its contained options.
For accessibility, we want to preserve the hierarchy such that the options are inside the optgroup.
We do this using aria-owns on the optgroup item.

This required some tweaks to XULMenuitemAccessible, as it couldn't previously handle grouping Accessibles between the menupopup and its items.

Differential Revision: https://phabricator.services.mozilla.com/D43901

--HG--
extra : moz-landing-system : lando
 2019-09-27 02:50:59 +00:00
Alexander Surkov
b56e085e0c Bug 1584218 - form autofill and HTML:select don't respect ui.popup.disable_autohide preference r=emilio,MattN 
Differential Revision: https://phabricator.services.mozilla.com/D47322

--HG--
extra : moz-landing-system : lando
 2019-09-26 22:07:07 +00:00
Tim Nguyen
b0d1ddb586 Bug 1581956 - Make search-textbox not use the <textbox> tag. r=surkov,MarcoZ 
Differential Revision: https://phabricator.services.mozilla.com/D46219

--HG--
extra : moz-landing-system : lando
 2019-09-25 19:12:48 +00:00
Neil Deakin
b6a3fc1ce5 Bug 1553384, remove old find/findAgain methods in typeaheadfind in favour of a single find method, r=mikedeboer 
Differential Revision: https://phabricator.services.mozilla.com/D41232

--HG--
extra : moz-landing-system : lando
 2019-09-18 09:31:43 +00:00
Neil Deakin
4ca768c7f6 Bug 1553384, update find extension api to support out-of-process iframes. r=mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D41229

--HG--
extra : moz-landing-system : lando
 2019-09-17 23:31:34 +00:00
Neil Deakin
1ab71ae6f9 Bug 1553384, update findbar actors to inherit from JSWindowActor so that type ahead find works in out of process iframes, r=mikedeboer 
Differential Revision: https://phabricator.services.mozilla.com/D41226

--HG--
extra : moz-landing-system : lando
 2019-09-17 23:29:46 +00:00
Neil Deakin
9a9e65a7e5 Bug 1553384, find should iterate over each frame within a document in the parent process to allow out-of-process frames to be searched through, r=mikedeboer 
Differential Revision: https://phabricator.services.mozilla.com/D41224

--HG--
extra : moz-landing-system : lando
 2019-09-17 23:28:41 +00:00
Mike Conley
376b551e6b Bug 1543810 - Regression test to ensure that the Picture-in-Picture works with videos that have pointer-events: none. r=JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D45232

--HG--
extra : moz-landing-system : lando
 2019-09-14 14:27:37 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
 2019-09-14 09:39:26 +00:00
Frederik Braun
a4a5944876 Bug 1530709 - Restrict styles to known selectors and single rules per message r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D43945

--HG--
extra : moz-landing-system : lando
 2019-09-13 14:30:58 +00:00
Mike Conley
ef4806bc17 Bug 1543810 - Make sure Picture-in-Picture toggle works on videos that have pointer-events: none. r=JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D45231

--HG--
extra : moz-landing-system : lando
 2019-09-11 18:38:30 +00:00
Noemi Erli
f74e07d847 Backed out 2 changesets (bug 1543810) for failing in browser_togglePointerEventsNone.js CLOSED TREE 
Backed out changeset a0c079f40c78 (bug 1543810)
Backed out changeset 5aec6172783d (bug 1543810)
 2019-09-11 19:04:59 +03:00
Mike Conley
b87f19be5a Bug 1543810 - Make sure Picture-in-Picture toggle works on videos that have pointer-events: none. r=JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D45231

--HG--
extra : moz-landing-system : lando
 2019-09-11 00:11:22 +00:00
Neil Deakin
e4e7986acb Bug 1577388, use the top browser when receiving zoom messages, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D45178

--HG--
extra : moz-landing-system : lando
 2019-09-09 15:42:43 +00:00
Mike Conley
3d0ca8182e Bug 1566183 - Add a keyboard shortcut to enter Picture-in-Picture for first video of focused window. r=NeilDeakin,JSON_voorhees,flod 
Differential Revision: https://phabricator.services.mozilla.com/D40082

--HG--
extra : moz-landing-system : lando
 2019-09-05 17:40:02 +00:00
Razvan Maries
1ad3f5b235 Backed out changeset bb08767934a8 (bug 1566183) for causing perma fails on browser_duplicateIDs.js. CLOSED TREE 2019-09-05 20:30:40 +03:00
Mike Conley
61209ad7a6 Bug 1566183 - Add a keyboard shortcut to enter Picture-in-Picture for first video of focused window. r=NeilDeakin,JSON_voorhees,flod 
Differential Revision: https://phabricator.services.mozilla.com/D40082

--HG--
extra : moz-landing-system : lando
 2019-09-05 14:09:25 +00:00
Mike Conley
db96277530 Bug 1548296 - Attach Picture-in-Picture toggle on UAWidgetSetupOrChange event rather than canplay. r=JSON_voorhees 
Videos can fire their "canplay" events even when they're not part of the DOM. This
means that videos that have already fired that event won't get the
PictureInPictureToggleChild properly attached after being inserted.

The UAWidgetSetupOrChange event, however, is fired for video events once they've
been bound to the DOM, so we can use that instead.

Differential Revision: https://phabricator.services.mozilla.com/D44541

--HG--
extra : moz-landing-system : lando
 2019-09-04 21:06:26 +00:00
arthur.iakab
ffeeb56270 Backed out changeset 1b54dc70e042 (bug 1530709) for causing browser-chrome failures on browser_selectpopup_colors.js CLOSED TREE 2019-09-03 20:58:45 +03:00
Frederik Braun
776d03bd30 Bug 1530709 - Restrict styles to known selectors and single rules per message r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D43945

--HG--
extra : moz-landing-system : lando
 2019-09-03 15:21:49 +00:00
Emilio Cobos Álvarez
dcb8e23c93 Bug 1561882 - Make sure to dispatch input and change consistently even if the first causes us to get uninited. r=mconley,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D43061

--HG--
extra : moz-landing-system : lando
 2019-08-23 10:14:39 +00:00
Mike Conley
50fbe8f5cb Bug 1571214 - Make sure to strip any element styles on the cloned <video> before inserting into the Picture-in-Picture player window. r=JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D42006

--HG--
extra : moz-landing-system : lando
 2019-08-21 16:48:49 +00:00
Abdoulaye O. Ly
55e51c578b Bug 1562990 - Remove 'audioMuted' and 'audioVolume' properties from nsIDOMWindowUtils. r=NeilDeakin,alwu,farre 
While working on porting the (audio-playback indicators) bug 1562990 to fission, we saw the potential to delete some methods in nsIDOMWindowUtils because they were not used anymore in our codebase except in a couple of tests files. So now, we should only mute/unmute or change the volume in the parent process. As such, interfaces are added in SpecialPowers to change media muted or volume state from content processes.

Differential Revision: https://phabricator.services.mozilla.com/D41782

--HG--
extra : moz-landing-system : lando
 2019-08-19 21:17:21 +00:00
Abdoulaye O. Ly
5ce82c5c12 Bug 1562990 - [Fission] Make AudioPlayback work with JSWindowActor. r=NeilDeakin,farre 
Differential Revision: https://phabricator.services.mozilla.com/D36648

--HG--
extra : moz-landing-system : lando
 2019-08-19 21:17:21 +00:00
Mike Conley
d64c589ac1 Bug 1568320 - Add a context menu to the Picture-in-Picture toggle to allow for easy hiding. r=NeilDeakin,JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D40305

--HG--
extra : moz-landing-system : lando
 2019-08-13 18:29:29 +00:00
Mike Conley
1d62a12e08 Bug 1568320 - Make Picture-in-Picture toggle preference live-updating. r=NeilDeakin,JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D40303

--HG--
extra : moz-landing-system : lando
 2019-08-13 13:19:06 +00:00
Michael Ratcliffe
9488f545ea Bug 1569570 - Select elements fail to display dropdown in RDM r=bradwerth,layely 
The `xul:menulist` appears a little offset but this is the same as it was prior to the fission patch that completely broke it.

If you have an alternate approach or a way to get the correct position for the `xul:menulist` I am all ears.

Differential Revision: https://phabricator.services.mozilla.com/D40805

--HG--
extra : moz-landing-system : lando
 2019-08-09 15:23:33 +00:00
Mike Conley
5c745b9ffa Bug 1557994 - Picture-in-Picture player video element should not try decoding its own version of the originating video. r=JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D39697

--HG--
extra : moz-landing-system : lando
 2019-08-02 18:09:24 +00:00
Mike Conley
681b8ccd2e Bug 1570406 - Ensure that we properly detach window root event listeners in PictureInPictureToggleChild. r=JSON_voorhees 
We were using the pagehide event before incorrectly: the pagehide event target
was being inspected to see if it was the top-level frame, and only then, would
we remove the mouse event handlers on the window root.

The problem is that event.target.top on a pagehide event is undefined, since the
event target is a Document.

Further, we probably want to remove any window root event listeners that were
registered for subframes as well. I'm not sure why I decided to try to filter
out subframes, but that definitely can keep windows alive.

So instead, I'm using the "cleanup" method that ActorManagerChild calls if
defined on an ActorChild, which runs when the associated frame unloads. This
way, if a subframe happened to have registered a window root event listener,
it'll get unregistered.

Differential Revision: https://phabricator.services.mozilla.com/D40090

--HG--
extra : moz-landing-system : lando
 2019-08-01 16:53:02 +00:00
Mike Conley
b0452cabd0 Bug 1555711 - Port RemotePrompt to a JS Window Actor to be Fission-compatible. r=NeilDeakin,layely 
Differential Revision: https://phabricator.services.mozilla.com/D38189

--HG--
rename : browser/modules/RemotePrompt.jsm => browser/actors/PromptParent.jsm
extra : moz-landing-system : lando
 2019-07-31 15:32:15 +00:00
Abdoulaye O. Ly
b2fe6b48ce Bug 1505907 - [Fission] Make UAWidget elements work with JSWindowActor. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D39094

--HG--
extra : moz-landing-system : lando
 2019-07-31 15:09:59 +00:00
Cosmin Sabou
20d813093c Bug 1563597 - Fix lint errors. r=jdai 
--HG--
extra : amend_source : 9ded5b32117f5d390d50b90d71e22d215d121f32
 2019-07-23 19:50:19 +03:00
John Dai
5bed95bf3d Bug 1563597 - Support nsGlobalWindowOuter as observer notification's subject; r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D39029

--HG--
extra : moz-landing-system : lando
 2019-07-23 16:09:27 +00:00
Mike Conley
9a7584fcf6 Bug 1566152 - Hide the Picture-in-Picture toggle after a period of no mousemove activity. r=JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D38378

--HG--
extra : moz-landing-system : lando
 2019-07-18 00:50:08 +00:00
Mike Conley
4cad3b16a2 Bug 1566906 - Make Picture-in-Picture toggle only listen for clicks from the primary mouse button. r=JSON_voorhees 
Differential Revision: https://phabricator.services.mozilla.com/D38376

--HG--
extra : moz-landing-system : lando
 2019-07-18 00:47:53 +00:00
Jonathan Kingston
31441f82ea Bug 1560455 - rename CodebasePrincipal to ContentPrincipal. r=ckerschb 
Differential Revision: https://phabricator.services.mozilla.com/D35504

--HG--
extra : moz-landing-system : lando
 2019-07-08 16:37:45 +00:00
Victor Porof
d3a1b5aeaa Bug 1561435 - Format toolkit/actors, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36050

--HG--
extra : source : 2540803fff7587f65dd5d6253b6fb544647e5e20
 2019-07-05 11:04:56 +02:00
Abdoulaye O. Ly
536807149d Bug 1497280 - [Fission] Make DateTimePicker works with JSWindowActor. r=NeilDeakin,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D33965

--HG--
rename : toolkit/modules/DateTimePickerParent.jsm => toolkit/actors/DateTimePickerParent.jsm
extra : moz-landing-system : lando
 2019-07-04 10:14:41 +00:00
Mike Conley
d38b3552f2 Bug 1560590 - Add Telemetry for Picture-in-Picture opening and closing mechanisms. data-review=chutten,r=JSON_voorhees 
Depends on D36358

Differential Revision: https://phabricator.services.mozilla.com/D36359

--HG--
extra : moz-landing-system : lando
 2019-07-02 18:08:16 +00:00
Abdoulaye Oumar Ly
3d4a698edb Bug 1560171 - Merge SelectParent.jsm and SelectParentHelper.jsm files. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D36272

--HG--
extra : moz-landing-system : lando
 2019-07-02 13:25:41 +00:00
Mihai Alexandru Michis
3583565bf1 Backed out changeset dc987632b5bb (bug 1497280) for causing geckoview failures in MediaElementTest. CLOSED TREE 
--HG--
rename : toolkit/actors/DateTimePickerParent.jsm => toolkit/modules/DateTimePickerParent.jsm
extra : rebase_source : d1b8689074b0efb1cd80d1f6b93b8edaaa772112
 2019-06-27 00:58:03 +03:00
Abdoulaye O. Ly
a27a868591 Bug 1497280 - [Fission] Make DateTimePicker works with JSWindowActor. r=NeilDeakin,mconley 
Differential Revision: https://phabricator.services.mozilla.com/D33965

--HG--
rename : toolkit/modules/DateTimePickerParent.jsm => toolkit/actors/DateTimePickerParent.jsm
extra : moz-landing-system : lando
 2019-06-26 17:55:48 +00:00
Neil Deakin
31c2f503ab Bug 1558919, switch page zoom to use JSWindowActor so that zooming works in OOP frames, r=mconley 
Differential Revision: https://phabricator.services.mozilla.com/D35019

--HG--
extra : moz-landing-system : lando
 2019-06-26 18:16:42 +00:00
Abdoulaye O. Ly
90236200b9 Bug 1560229 - [Fission] Make Autoplay work with JSWindowActor. r=NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D35395

--HG--
extra : moz-landing-system : lando
 2019-06-25 20:29:19 +00:00