Commit Graph

147 Commits

Author SHA1 Message Date
Cosmin Sabou
00f3836a87 Merge mozilla-inbound to mozilla-central. a=merge 2019-02-28 12:57:50 +02:00
Julian Descottes
235dde6c92 Bug 1528276 - Do not destroy the DebuggerServer in non-e10s when last frame connection is closed r=ochameau
When reviewing https://bugzilla.mozilla.org/show_bug.cgi?id=1521052 I did not think about Firefox for Android which is not using e10s.
This means the main DebuggerServer will be killed when there are no connections left. Happy to discuss more about the preferred solution.
This is a regression in 66 and I hope to uplift a fix for this.

Differential Revision: https://phabricator.services.mozilla.com/D20830

--HG--
extra : moz-landing-system : lando
2019-02-27 19:17:37 +00:00
Brian Hackett
a342374c62 Bug 1527203 Part 2 - Prevent worker debuggee execution until the thread actor has attached, r=ochameau.
--HG--
extra : rebase_source : 00d301909314379c3667af456579f9dbf0b47016
2019-02-12 13:05:34 -10:00
Alexandre Poirot
34cccbbf19 Bug 1521052 - Add DebuggerServer.hasConnection to track if it still has active connections. r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D16961

--HG--
extra : moz-landing-system : lando
2019-01-23 14:46:10 +00:00
Julian Descottes
0baa80215b Bug 1497264 - Remove references to AddonTargetActor setAddonOptions;r=ochameau,yulia
Depends on D15383

Differential Revision: https://phabricator.services.mozilla.com/D15384

--HG--
extra : moz-landing-system : lando
2019-01-08 18:42:44 +00:00
Daisuke Akatsuka
1610592c49 Bug 1497448: Rename closeAllListener to closeAllSocketListeners. r=ochameau,jdescottes
Depends on D10868

Differential Revision: https://phabricator.services.mozilla.com/D11150

--HG--
extra : moz-landing-system : lando
2018-11-07 17:46:05 +00:00
Daisuke Akatsuka
5e8c304c73 Bug 1497448: Rename _addListener/_removeListener of DebuggerServer to addSocketListener/removeSocketListener. r=ochameau,jdescottes
Depends on D10867

Differential Revision: https://phabricator.services.mozilla.com/D10868

--HG--
extra : moz-landing-system : lando
2018-11-07 16:56:34 +00:00
Daisuke Akatsuka
56d22dec55 Bug 1497448: Use SocketListener directly. r=ochameau,jdescottes
Depends on D10865

Differential Revision: https://phabricator.services.mozilla.com/D10867

--HG--
extra : moz-landing-system : lando
2018-11-08 00:41:18 +00:00
Daisuke Akatsuka
711e30b3ec Bug 1497448: Close connections that were accepted in ServerSocketListener. r=ochameau,jdescottes
Yet another approach. In the previous D9889 approach, both DebuggerSerever and
SocketServerListener retain the connections duplicately, it will be possible to
be difficult for the management. In this approach, only DebuggerSerever retains
the connections, then when ServerSocketListener was removed, removes the
connections as well that were linked the ServerSocketListener.

Differential Revision: https://phabricator.services.mozilla.com/D10864

--HG--
extra : moz-landing-system : lando
2018-11-07 02:18:02 +00:00
Mark Banner
ceaeb93550 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389

--HG--
extra : moz-landing-system : lando
2018-10-19 12:55:39 +00:00
Alexandre Poirot
ee61342d3a Bug 1497226 - Rename WebExtensionActor/WebExtensionTargetActor/AddonTargetActor.id to addonId. r=jdescottes
MozReview-Commit-ID: 1frhYk1M9sC

Differential Revision: https://phabricator.services.mozilla.com/D8001

--HG--
extra : moz-landing-system : lando
2018-10-08 20:34:45 +00:00
yulia
72f9e83eb1 Bug 1473513 - move ActorRegistry module to server/actors/utils; r=ochameau
Summary: Depends on D6477

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6479

--HG--
rename : devtools/server/actor-registry.js => devtools/server/actors/utils/actor-registry.js
extra : rebase_source : ae52db7b028b4d866d8a363eae9ae7c124714458
2018-09-26 10:09:15 +02:00
yulia
dd29e366ea Bug 1473513 - refactor main.js to use protocol.js pools; r=ochameau
Summary:
MozReview-Commit-ID: FNMK4f553yI

Depends on D6474

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6475

--HG--
extra : rebase_source : c61d394da0a20991def49968f01ee563fea9afde
2018-09-26 10:07:27 +02:00
yulia
9c120b705d Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
Summary:
MozReview-Commit-ID: 3GsXRxcIKfx

Depends on D6473

Reviewers: ochameau

Reviewed By: ochameau

Subscribers: reviewbot

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6474

--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : rebase_source : 3ea4edd91ca8b09ad5e25ae01df885c587bee7b1
2018-09-26 10:06:43 +02:00
yulia
4a8f74eb3e Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
Summary:
create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor;

Depends on D6468

Reviewers: ochameau

Reviewed By: ochameau

Bug #: 1473513

Differential Revision: https://phabricator.services.mozilla.com/D6470

--HG--
rename : devtools/server/actors/common.js => devtools/shared/protocol/lazy-pool.js
extra : rebase_source : 09a1c8eac3cbb5856a5e3e61a1c0540efe32e5bd
2018-09-26 10:03:33 +02:00
yulia
825e041cf6 Bug 1485378 - Replace CallWatcher actor with helper; r=jdescottes
creates a CallWatcherActor only for tests and migrates other functionality to the helper

Differential Revision: https://phabricator.services.mozilla.com/D5534

--HG--
rename : devtools/server/actors/call-watcher.js => devtools/client/canvasdebugger/test/call-watcher-actor.js
rename : devtools/shared/fronts/call-watcher.js => devtools/client/canvasdebugger/test/call-watcher-front.js
rename : devtools/shared/specs/call-watcher.js => devtools/client/canvasdebugger/test/call-watcher-spec.js
rename : devtools/server/actors/call-watcher.js => devtools/server/actors/utils/call-watcher.js
rename : devtools/server/actors/call-watcher.js => devtools/server/actors/utils/function-call.js
rename : devtools/shared/fronts/call-watcher.js => devtools/shared/fronts/function-call.js
rename : devtools/shared/specs/call-watcher.js => devtools/shared/specs/function-call.js
extra : moz-landing-system : lando
2018-09-20 13:41:26 +00:00
Julian Descottes
e82936d001 Bug 1487284 - Update message manager in actors spawned in parent after browserSwap;r=yulia
Differential Revision: https://phabricator.services.mozilla.com/D5028

--HG--
extra : moz-landing-system : lando
2018-09-06 16:06:34 +00:00
yulia
9611217838 Bug 1429421 - remove gcli code; r=jdescottes,julienw,ochameau
Remove remaining GCLI code

Differential Revision: https://phabricator.services.mozilla.com/D3618

--HG--
extra : moz-landing-system : lando
2018-09-06 11:42:57 +00:00
arthur.iakab
4862d62ddf Backed out changeset 5e21be5fdf9d (bug 1429421)for build busteges CLOSED TREE 2018-09-06 12:12:40 +03:00
yulia
139e4e0b9a Bug 1429421 - remove gcli code; r=jdescottes,julienw,ochameau
Remove remaining GCLI code

Differential Revision: https://phabricator.services.mozilla.com/D3618

--HG--
extra : moz-landing-system : lando
2018-09-06 08:55:50 +00:00
yulia
e259742bdf Bug 1483173 - introduce screenshot actor; r=ochameau
This patch introduces a screenshot actor, which allows the screenshot functionality to be
shared across tools, and also implements it for the toolbox itself

Differential Revision: https://phabricator.services.mozilla.com/D3341

--HG--
rename : devtools/server/actors/webconsole/screenshot.js => devtools/shared/screenshot/capture.js
rename : devtools/shared/webconsole/screenshot-helper.js => devtools/shared/screenshot/save.js
extra : moz-landing-system : lando
2018-08-27 15:14:10 +00:00
arthur.iakab
457fa2b8ab Backed out 7 changesets (bug 1473513) for failing devtools e.g. leakcheck | default process: 1618727 bytes leaked
Backed out changeset deb8812556ef (bug 1473513)
Backed out changeset 5bf38cfa04f9 (bug 1473513)
Backed out changeset 6e157bea362a (bug 1473513)
Backed out changeset 12eb1139a802 (bug 1473513)
Backed out changeset ce86ea60a31c (bug 1473513)
Backed out changeset 7acc52a7f81f (bug 1473513)
Backed out changeset 4e1e283b347e (bug 1473513)

--HG--
extra : rebase_source : a79787b05e0cf6c837e08c9541d559e4509b0deb
2018-08-22 18:23:46 +03:00
yulia
3a96831e0a Bug 1473513 - refactor main.js to use protocol.js pools; r=ochameau
MozReview-Commit-ID: FNMK4f553yI

--HG--
extra : rebase_source : 5c4005041d8b65cd4e7f08e4edd8b2c57e7642c8
2018-08-09 11:45:00 +02:00
yulia
8cde2abb7a Bug 1473513 - separate registerModule behavior from DebuggerServer; r=ochameau
MozReview-Commit-ID: 3GsXRxcIKfx

--HG--
rename : devtools/server/main.js => devtools/server/actor-registry.js
extra : rebase_source : 5988ed48f4d4cfc077c7bc768a546698f3e5d541
2018-07-13 18:03:28 +02:00
yulia
e69880da61 Bug 1473513 - create LazyActorClass based off ObservedActorFactory and RegisterdFactory classes for use in RootActor and BrowsingContextActor; r=ochameau
MozReview-Commit-ID: LRuhNzBLrZh

--HG--
rename : devtools/server/actors/common.js => devtools/shared/protocol/lazy-pool.js
extra : rebase_source : c47f8dd558a308905637bee2e8681f51db448487
2018-07-11 18:34:22 +02:00
Ciure Andrei
a52997851e Backed out changeset 4f7d58a640b8 (bug 1483173) for browser_jsterm_screenshot_command_clipboard.js failures CLOSED TREE
--HG--
rename : devtools/shared/screenshot/capture.js => devtools/server/actors/webconsole/screenshot.js
2018-08-21 22:03:10 +03:00
yulia
9cbf625f78 Bug 1483173 - introduce screenshot actor; r=ochameau
This patch introduces a screenshot actor, which allows the screenshot functionality to be
shared across tools, and also implements it for the toolbox itself

Differential Revision: https://phabricator.services.mozilla.com/D3341

--HG--
rename : devtools/server/actors/webconsole/screenshot.js => devtools/shared/screenshot/capture.js
extra : moz-landing-system : lando
2018-08-21 13:10:52 +00:00
Kris Maglione
7ce09e1fd8 Bug 1481025: Fix devtools code which calls message manager methods with a null target. r=ochameau
MozReview-Commit-ID: KJeQjwhfJbw

--HG--
extra : rebase_source : 682a0007b1fa802643e5ec43e0ff40db8efded03
2018-08-04 15:51:56 -07:00
Alexandre Poirot
835840ac99 Bug 1477988 - Implements DebuggerServer.spawnActorInParentProcess. r=jryans
This new API allows to instanciate an actor in the parent process from actors running in the parent process.
The created actors are returned to the client from the actors running in content,
but after that, the client communicates directly with the created actors running in the parent process.

MozReview-Commit-ID: 5B3wRQ94UEx

--HG--
extra : rebase_source : 808ea31fe8a467d0185fc27056c6524873cddbce
2018-07-16 09:53:28 -07:00
Alexandre Poirot
452829e172 Bug 1474980 - Stop exporting ActorPool/OriginalLocation from server/main.js. r=jryans
MozReview-Commit-ID: Gsef6U1g46r

--HG--
extra : rebase_source : 88211a36264a8f0191b0c8d2a22f3abf4df92183
2018-07-11 10:49:45 -07:00
Alexandre Poirot
09d08ff845 Bug 1474980 - Remove deprecated DebuggerServer.addActors(). r=jryans
MozReview-Commit-ID: 8J1wucp1G0p

--HG--
extra : rebase_source : 4a40b578808667ac45519172686e4237bb61423a
2018-07-11 10:41:27 -07:00
Alexandre Poirot
98f72acbf8 Bug 1000814 - Move WorkerDebuggerTransport to its own module. r=jryans
MozReview-Commit-ID: I1eFQCDLaDh

--HG--
extra : rebase_source : e3daaa5fa8e452b514a482addcedded86998ab9b
2018-07-11 08:44:55 -07:00
Alexandre Poirot
9e8c15b15c Bug 1000814 - Move ChildDebuggerTransport to its own module. r=jryans
MozReview-Commit-ID: FgTVee7NLyC

--HG--
rename : devtools/shared/transport/transport.js => devtools/shared/transport/child-transport.js
extra : rebase_source : a077c10f7a9ed0c8688db2f06bf10ab538f37c8a
2018-07-11 08:38:53 -07:00
Alexandre Poirot
8e96c01239 Bug 1000814 - Move LocalDebuggerTransport to its own module. r=jryans
MozReview-Commit-ID: 3rV5TGPPKq6

--HG--
rename : devtools/shared/transport/transport.js => devtools/shared/transport/local-transport.js
extra : rebase_source : 6474e754831785ffec0cc1e568744d86f148ab83
2018-07-11 08:35:44 -07:00
Alexandre Poirot
773955e709 Bug 1000814 - Use loader helpers to import symbols lazily. r=jryans
MozReview-Commit-ID: v20oLp5Azm

--HG--
extra : rebase_source : c0909285eadb9dcedd335721d79f7a2366fbf62a
2018-07-11 08:21:13 -07:00
Alexandre Poirot
aece1534ef Bug 1473578 - Remove deprecated synchronous DebuggerServer.registerModule feature. r=jryans
MozReview-Commit-ID: DTAEJyfICNz

--HG--
extra : rebase_source : 043241ac68dd00f24236e9583dc262bce4d208b7
2018-07-05 07:13:52 -07:00
J. Ryan Stinnett
ca90a5ef7b Bug 1465637 - Rename tab-scoped actors to target-scoped actors. r=ochameau
The term "tab actor" was used ambiguously to mean either the "target actor
representing a tab" or "a child actor of the tab target actor" (such as the
console actor).  Here we rename the second case to "target-scoped actor".

Differential Revision: https://phabricator.services.mozilla.com/D1760

--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_tabactor-01.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_tabactor-02.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-02.js
2018-06-26 13:27:57 +00:00
arthur.iakab
ff23802cfd Backed out changeset 88960670cf9f (bug 1465637) for failing talos damp tests on server/protocol.js: Error: Can't manage front without an actor ID on a CLOSED TREE
--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-01.js => devtools/client/debugger/test/mochitest/browser_dbg_tabactor-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-02.js => devtools/client/debugger/test/mochitest/browser_dbg_tabactor-02.js
2018-06-25 21:56:27 +03:00
J. Ryan Stinnett
8433b7ff9f Bug 1465637 - Rename tab-scoped actors to target-scoped actors. r=ochameau
The term "tab actor" was used ambiguously to mean either the "target actor
representing a tab" or "a child actor of the tab target actor" (such as the
console actor).  Here we rename the second case to "target-scoped actor".

Differential Revision: https://phabricator.services.mozilla.com/D1760

--HG--
rename : devtools/client/debugger/test/mochitest/browser_dbg_tabactor-01.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-01.js
rename : devtools/client/debugger/test/mochitest/browser_dbg_tabactor-02.js => devtools/client/debugger/test/mochitest/browser_dbg_target-scoped-actor-02.js
2018-06-25 17:53:40 +00:00
J. Ryan Stinnett
be021da252 Bug 1172897 - Rename BrowserAddonActor to AddonTargetActor. r=ochameau
MozReview-Commit-ID: 4iI6BQaleJS

--HG--
rename : devtools/server/actors/addon.js => devtools/server/actors/targets/addon.js
extra : rebase_source : f48676bdda8b68226a00cb29c164180526389c4a
2018-06-04 18:37:02 -05:00
J. Ryan Stinnett
3133003d18 Bug 1172897 - Move DevTools addon modules to subdir. r=ochameau
MozReview-Commit-ID: D61WJnoYQe3

--HG--
rename : devtools/server/actors/addons.js => devtools/server/actors/addon/addons.js
rename : devtools/server/actors/addon-console.js => devtools/server/actors/addon/console.js
rename : devtools/server/actors/webextension-inspected-window.js => devtools/server/actors/addon/webextension-inspected-window.js
rename : devtools/server/actors/webextension-parent.js => devtools/server/actors/addon/webextension-parent.js
rename : devtools/server/actors/webextension.js => devtools/server/actors/addon/webextension.js
rename : devtools/shared/fronts/addons.js => devtools/shared/fronts/addon/addons.js
rename : devtools/shared/fronts/webextension-inspected-window.js => devtools/shared/fronts/addon/webextension-inspected-window.js
rename : devtools/shared/specs/addons.js => devtools/shared/specs/addon/addons.js
rename : devtools/shared/specs/webextension-inspected-window.js => devtools/shared/specs/addon/webextension-inspected-window.js
rename : devtools/shared/specs/webextension-parent.js => devtools/shared/specs/addon/webextension-parent.js
extra : rebase_source : 7a9038e96f51695f92c3a676aeeaab02fd8ca10a
2018-06-04 18:12:11 -05:00
J. Ryan Stinnett
ff819eb8ce Bug 1172897 - Remove deprecated eager actor construction path. r=ochameau
MozReview-Commit-ID: ALnbhoh0Nzj

--HG--
rename : devtools/server/tests/unit/registertestactors-03.js => devtools/server/tests/unit/registertestactors-lazy.js
extra : rebase_source : 9d998569e3ffb5ccdd74c3b01a8981c3f68ea656
2018-05-30 19:19:11 -05:00
J. Ryan Stinnett
fd4961af52 Bug 1172897 - Rename ContentActor to FrameTargetActor. r=ochameau
MozReview-Commit-ID: 3Rgvftpea8g

--HG--
rename : devtools/server/actors/content.js => devtools/server/actors/targets/frame.js
extra : rebase_source : 80f0aa2ad4a9ab183e08142aa043341a630faf1e
2018-05-30 14:09:45 -05:00
J. Ryan Stinnett
eaa4969e77 Bug 1172897 - Rename TabActor to BrowsingContextTargetActor. r=ochameau
MozReview-Commit-ID: LPTEx2h4F1o

--HG--
rename : devtools/server/actors/tab.js => devtools/server/actors/targets/browsing-context.js
rename : devtools/shared/specs/tab.js => devtools/shared/specs/targets/browsing-context.js
extra : rebase_source : e62720693ad492cdfb68ab21af1f54d78e85123a
2018-05-25 18:20:28 -05:00
Julian Descottes
7fdc2c153f Bug 1454696 - Fix leftover issues for prefer-const;r=yulia
MozReview-Commit-ID: JwOXoqw2mks

--HG--
extra : rebase_source : a3f07665a42c2779a85b7901a07206266a9d1616
extra : source : ae946f375e0d0f4f0f0fc859c54040fef42cbc2c
2018-06-01 12:19:35 +02:00
Julian Descottes
640fe52298 Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4

--HG--
extra : rebase_source : 65de1b0aba412d9044b5196115f74276caa058f2
2018-06-01 12:36:09 +02:00
Boris Zbarsky
76ead58490 Bug 1455674 part 19. Get rid of JS uses of nsIDOMElement. r=qdot
In nsBlocklistService.js we know we're dealing with actual nodes, so .nodeType
checks should be fine.
2018-04-26 23:37:34 -04:00
Kris Maglione
a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Alexandre Poirot
9b2fdcf8bb Bug 1453712 - Use a preference to set the testing flag. r=jryans
MozReview-Commit-ID: 1cjSQnXtc4h

--HG--
extra : rebase_source : 55c0c9fa81a8dc17b92cba721dcc5912b07d0fab
2018-04-12 09:22:42 -07:00
J. Ryan Stinnett
7fef001d2a Bug 1449610 - Remove event loop lag in DevTools. r=ochameau
Bug 962511 added event loop lag info in DevTools for use via a "jank watcher"
tool on Firefox OS devices.

With the removal of Firefox OS, this is now dead code that can be removed.

MozReview-Commit-ID: IHRozqCviuQ

--HG--
extra : rebase_source : 0429ae3655c30ccf79950cd33153ee0a9223c69c
2018-03-28 11:19:22 -05:00