Commit Graph

2195 Commits

Author SHA1 Message Date
Michael Kelly
e79e6e14a3 Bug 1448185: Use appBuildId as release for browser error reports. r=Gijs
Release is already included in the context as browser info and doesn't need to
be kept as a tag like appBuildId was.

Differential Revision: https://phabricator.services.mozilla.com/D807

MozReview-Commit-ID: IGzT3C3HSG

--HG--
extra : rebase_source : eda48fdf022f19bc681002635f893b2a726836f8
extra : amend_source : 55f7d9fe77af586863576ee9b3ed6bc4fae6d639
2018-03-27 13:03:49 -07:00
Tim Nguyen
f92cfc19f5 Bug 1417883 - Refactor theme code to have processing code in the variable map. r=dao 2018-03-27 13:40:06 +02:00
Dylan Stokes
a538a161a1 Bug 1417883 - Allow theming autocomplete popups. r=ntim, jaws 2018-02-11 12:32:33 -05:00
Bogdan Tara
39d9b048b9 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-03-27 12:16:26 +03:00
Bogdan Tara
302a55b534 Merge inbound to mozilla-central. a=merge 2018-03-27 12:12:57 +03:00
Zhengyi Lian
7b7b462b5d Bug 1423757 - Allow theming toolbar fields focused state r=jaws,ntim
MozReview-Commit-ID: 9XrN64FTMA4

--HG--
extra : rebase_source : 8c585eb710c913adcaea5b29360292db8893b670
2018-03-07 02:59:00 -05:00
Kris Maglione
d47023da3b Bug 1446686: Follow-up: Fix pending permission prompts when prompt is dismissed. r=bustage
MozReview-Commit-ID: 35tW39omECd

--HG--
extra : rebase_source : e0b2a229f1f4a2e4bd452c233469e3fd92f9b3ce
2018-03-26 19:06:00 -07:00
Kris Maglione
1f5d2b4db6 Bug 1446686: Part 3 - Fix discovery pane and drag-and-drop tests which rely on legacy extensions. r=aswan
This removes some discovery pane tests which are obsolete. The discovery pane
page that it tests uses InstallTrigger, rather than mozAddonManager as we use
in production, and fails when used with WebExtensions.

The other tests have been updated to use WebExtensions, and some relevant
PopupNotifications bugs have been fixed so that they actually pass.

MozReview-Commit-ID: 1g0n73vhncp

--HG--
rename : toolkit/mozapps/extensions/test/browser/addons/browser_dragdrop1/install.rdf => toolkit/mozapps/extensions/test/browser/addons/browser_dragdrop1/manifest.json
rename : toolkit/mozapps/extensions/test/browser/addons/browser_dragdrop2/install.rdf => toolkit/mozapps/extensions/test/browser/addons/browser_dragdrop2/manifest.json
rename : toolkit/mozapps/extensions/test/browser/addons/browser_dragdrop_incompat/install.rdf => toolkit/mozapps/extensions/test/browser/addons/browser_dragdrop_incompat/manifest.json
extra : rebase_source : 0334268d0476227d084fb81bc8455deb186e6bd1
2018-03-17 17:42:51 -07:00
Kirk Steuber
4f68045c04 Bug 1428948 - Add policies to modify the available search engines r=Felipe,florian
This adds a policy with the capability of adding search engines, choosing the default search engine, and blocking the installation of new search engines.

Additionally, fixes the messages for errors reported by MainProcessSingleton.addSearchEngine so that the offending URL is printed rather than "[xpconnect wrapped nsIURI]".

MozReview-Commit-ID: HuLT15Rnq0r

--HG--
rename : browser/components/search/test/testEngine.xml => browser/components/enterprisepolicies/tests/browser/opensearchEngine.xml
extra : rebase_source : 7815f5d03395decc39ee2657ba05c071dd332abb
2018-03-02 12:11:16 -08:00
Brindusan Cristian
2c121fc11d Merge inbound to mozilla-central. a=merge 2018-03-26 00:44:42 +03:00
Kiran
78451d10e0 Bug 1447956 - Use this.tabbrowser.tabContainer instead of this.tabbrowser.tabbox.tabs. r=dao 2018-03-25 19:49:00 +02:00
Tim Nguyen
e002c63fa4 Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht

--HG--
extra : rebase_source : 881e10f2987606e84e55c267260661c0f7b3b746
2018-03-16 23:21:46 +00:00
Tim Nguyen
5e399b2f06 Bug 1444760 - Support only one form of loadURIWithFlags calls. r=dao
MozReview-Commit-ID: A5rMjQ6xnRw

--HG--
extra : rebase_source : 31166bca511e5bc16ffff2acab2e3295d9f6079c
2018-03-25 14:35:17 +02:00
Margareta Eliza Balazs
27703664b0 Backed out 2 changesets (bug 1444760) for ES lint failure in /builds/worker/checkouts/gecko/browser/base/content/browser.js on a CLOSED TREE
Backed out changeset 71f61091a716 (bug 1444760)
Backed out changeset 4956db1e9bdd (bug 1444760)
2018-03-25 15:29:54 +03:00
Tim Nguyen
e2ed0b5dfb Bug 1444760 - Combine loadURIWithFlags and loadURI methods. r=dao
MozReview-Commit-ID: 5dsyKwvjYht

--HG--
extra : rebase_source : 8e9f24d20829021db2239435c7d8d0db08e28bf9
2018-03-16 23:21:46 +00:00
Tim Nguyen
78b296ff06 Bug 1444760 - Support only one form of loadURIWithFlags calls. r=dao
MozReview-Commit-ID: A5rMjQ6xnRw

--HG--
extra : rebase_source : e44817bd271a3477fdd54f405beb1b5096a032d0
2018-03-25 13:59:50 +02:00
Prathiksha
eb3768c868 Bug 1443781 - Eliminate innerHTML usage in contentSearchUI.js. r=johannh
MozReview-Commit-ID: 3JmZF6dR0jZ

--HG--
extra : rebase_source : fb6474f138db7087f24283eb661eaefece3a273f
2018-03-18 00:13:14 +05:30
Daniel Almeida
673edf8ee3 Bug 1447950 - use a switch statement in place of chained if-else in AsyncTabSwitcher.handleEvent. r=dao 2018-03-23 19:00:01 +01:00
Dão Gottwald
1b366a1008 Bug 1448102 - Move tabWarmingEnabled, tabWarmingMax, tabWarmingUnloadDelay properties from gBrowser to AsyncTabSwitcher.jsm. r=mconley
MozReview-Commit-ID: 2pI1aDUxWFw

--HG--
extra : rebase_source : ed6f75031f47456e91ed419c939b2e29ecc58526
2018-03-22 19:36:00 +01:00
Andreea Pavel
4dc16ea693 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-03-22 11:34:04 +02:00
Boris Zbarsky
bf1ef0641d Bug 1444143 part 10. Remove unnecessary QIs to Ci.nsIFrameLoader in JS. r=mystor
nsFrameLoader is on WebIDL bindings, so those QIs are no-ops anyway, unless the given object is no a frameloader to start with.

MozReview-Commit-ID: IPiW70H5NPc
2018-03-21 22:43:17 -04:00
arthur.iakab
24af737f4c Merge inbound to mozilla-central. a=merge 2018-03-22 01:46:39 +02:00
Marco Bonardo
36e5d86043 Bug 1446951 - 3 - Make AsyncExecuteLegacyQueries singular. r=standard8
MozReview-Commit-ID: KyYw92tzyN6

--HG--
extra : rebase_source : 0c31233d251c7b0062047ab12b52d25fbc9510f5
2018-03-16 18:10:09 +01:00
Michael Kelly
2893d7699c Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Differential Revision: https://phabricator.services.mozilla.com/D725

MozReview-Commit-ID: KY90uSslMmb

--HG--
extra : rebase_source : f4294437829b4fa0e86bdc222eb747165dc7b0f7
extra : intermediate-source : 882d329ad652edabf01be8bdf16e38915bbaba55
extra : source : a760e111f2f157fbb18e66117f026ca298d4343e
2018-03-16 13:24:39 -07:00
Peter Van der Beken
f5754d679a Bug 888600 - Move ContentFrameMessageManager to WebIDL. Part 6: Mark some IDL interfaces as non-scriptable. r=bz.
--HG--
extra : rebase_source : 5911f91bd7a63cd3603494e087e3858bd0527500
2018-03-01 20:19:56 +01:00
Mike Conley
8f3cddc6cf Bug 1447326 - Fix tab warming state probe. r=dthayer
Since bug 1432509, the warmingTabs WeakSet has had warmed tabs
cleared from it once they have entered STATE_LOADED. This allowed
us to make decisions on tab switch operations based on whether or
not a tab was still being warmed.

This broke our Telemetry, which assumed that warming tabs would
still be in the warmingTabs WeakSet until either requested or
evicted. Now, instead, we look to see whether or not tab warming
is enabled, and whether tabs _could_ have been warmed in order to
add entries to the right buckets.

MozReview-Commit-ID: 94oiKYzf4au

--HG--
extra : rebase_source : 0b6be98ff93d9753fcdacbec15a2a7b08232bb3a
2018-03-21 14:01:18 -04:00
Kris Maglione
46748f4fae Backed out changeset 68e32f5b50e7 (bug 1444554) for failing its own test. r=backout
MozReview-Commit-ID: C6TooaguKcm
2018-03-20 20:31:57 -07:00
Michael Kelly
3e4a160302 Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Differential Revision: https://phabricator.services.mozilla.com/D725

MozReview-Commit-ID: KY90uSslMmb

--HG--
extra : source : a760e111f2f157fbb18e66117f026ca298d4343e
2018-03-16 13:24:39 -07:00
Michael Kelly
527a07efae Bug 1445009: Tag errors from extensions with isExtensionError. r=Gijs
MozReview-Commit-ID: AQrlvTfJUUS

--HG--
extra : rebase_source : 0f88d1072dbb66334a6790bc9c62e8ce4a57f097
extra : histedit_source : 6210b991eeb12f19d4eb0e38d105e3200c372f7d
2018-03-19 13:40:53 -07:00
Michael Kelly
693bb90432 Bug 1445009: Refactor BrowserErrorReporter.jsm and tests. r=Gijs
The transforms for turning an nsIScriptError into a payload that Sentry
understands were getting a bit complex for a single function, so they're
refactored into a list of transform functions that are applied in sequence to
produce the payload. This will make it easier to manage adding new transforms to
the list.

Refactoring this revaled a problem with the test code: it assumed that listeners
for console messages were notified in order of registration (since it used a
temporary listener to determine when the rest of the listeners had been notified
of a message). Changing the async evaluation of the code broke the tests, so
they had to be refactored as well.

Without a way to know when all console listeners have been notified, we can't
assert that a message will not be received by BrowserErrorReporter. We do two
things to get around this:

- Where possible, call `observe` directly on the reporter instance.
- Add constructor params for registering and unregistering listeners so we can
  test that logic without relying on messages being received or not.

MozReview-Commit-ID: EEH6IROOuHD

--HG--
extra : rebase_source : a5af344c86e9756d4dbef761e4a6060515c87a61
extra : histedit_source : 5491c7359d2989a2735ec6d39de372154706c475
2018-03-19 12:41:30 -07:00
Cosmin Sabou
2f02b690ff Merge central to inbound. a=merge on a CLOSED TREE 2018-03-21 04:06:42 +02:00
Cosmin Sabou
abbd20f9e5 Backed out changeset a760e111f2f1 (bug 1444554) for merge conflicts on browser_BrowserErrorReporter.js and failures after merging to autoland. a=backout 2018-03-21 02:51:03 +02:00
Michael Kelly
193cfecedb Bug 1444554: Add Telemetry scalars for BrowserErrorReporter.jsm. r=Gijs,chutten
Differential Revision: https://phabricator.services.mozilla.com/D725

MozReview-Commit-ID: KY90uSslMmb

--HG--
extra : rebase_source : 4d079be8eb56ace73b385f276e741b672385bda6
2018-03-16 13:24:39 -07:00
Kris Maglione
eb1a0bb258 Bug 1446250: Part 1 - Optimize Photon PageAction update performance. r=Gijs
The amount of computational complexity and garbage array/string/object
generation for each update to a pageAction property went up astronomically
with the migration of WebExtension page actions to the Photon API. This
resulted in non-trivial talos regression when Screenshots attempted to switch
back to the built-in pageAction API.

These changes fix most of the garbage generation, and reduce a lot of the
duplicated work for each update.

MozReview-Commit-ID: 4uPLnAesdU2

--HG--
extra : rebase_source : 3f723f3f35abf032cf12e02ce38552e21ea4827f
2018-03-15 21:34:01 -07:00
Boris Zbarsky
837dc7eaaa Bug 1446711 part 8. Get rid of nsIDOMMouseEvent. r=qdot
MozReview-Commit-ID: 2FK1MA4LGZj
2018-03-20 00:16:07 -04:00
Michael Kelly
bfe6a7b625 Bug 1445012: Add user agent data to error report context. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D745

MozReview-Commit-ID: LKD0YwaYGUf

--HG--
extra : rebase_source : f2fc35b853cb4ec69cc02d89b2318a11b097670c
extra : amend_source : 346f4710d019498e499a13405efcfeaa1ebdfd54
2018-03-19 13:59:10 -07:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Bogdan Tara
4785e99532 Merge inbound to mozilla-central. a=merge 2018-03-17 12:29:57 +02:00
Kris Maglione
313b707b2e Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc

--HG--
extra : rebase_source : 765ddd5c62c9449c07ed050e44d86a3bd5c0ae64
extra : amend_source : 627a7694ac07182200f876901ded7a34721cd228
2018-03-07 19:31:28 -08:00
Vivek Dhingra
7b323d8758 Bug 1446060 - Rename mPanelContainer to tabpanels r=dao
MozReview-Commit-ID: 85PNkl3OeBE

--HG--
extra : rebase_source : d7bfb49a8736b8319f6d1ca45f39fe001d4214d8
2018-03-16 10:23:00 -04:00
Tiberius Oros
a4a2be52e8 Merge inbound to mozilla-central. a=merge 2018-03-16 11:53:43 +02:00
Michael Kelly
b6cb9ad0f5 Bug 1441366 Use internal add-on IDs in browser error stacktrace reports. r=kmag
MozReview-Commit-ID: 7OC4utHLgXC

--HG--
extra : source : 935e19ff56b7850622beb0bc6c85e07c2e1ff297
extra : intermediate-source : f9fac304d7e48f70f129e43508ec80673ccd82a8
2018-02-26 16:12:08 -08:00
Kris Maglione
ae3e671c55 Bug 1445551: Part 1c - Fix browser tests that attempt to use importGlobalProperties. r=mconley
When compartment-per-addon is disabled, browser mochitests will no longer
automatically run in an implicit Sandbox scope, which means that things like
Cu.importGlobalProperties will stop working.

MozReview-Commit-ID: AWloQ7gasEf

--HG--
extra : rebase_source : dacd0f8676dd3af60eeb372985e26d7850470e69
2018-03-13 18:18:27 -07:00
Michael Kelly
cf25d3e972 Bug 1445011: Include sourceName in error report payload. r=Gijs
The module attribute for an exception is surfaced in Sentry as the "transaction"
tag, and is useful for errors that don't include stack traces.

Differential Revision: https://phabricator.services.mozilla.com/D727

MozReview-Commit-ID: JKwgmE2jBXB

--HG--
extra : rebase_source : af817b5709e5b596885cc1674bcaaf7f96a0a48f
extra : amend_source : 8b7820ca53c29429ea9d788b1cf84012c99fdf81
2018-03-14 09:45:35 -07:00
Emilio Cobos Álvarez
b17e217c07 Bug 1424963: Replace remaining consumers of getPropertyCSSValue for getCSSImageURLs. r=florian,bz
The context-menu change is technically not idempotent, since something like:

  background-image: url(foo), linear-gradient(..);

Would throw before. But that didn't seem like a great deal to me.

MozReview-Commit-ID: 70pD1EyXDB
2018-03-14 11:07:43 +01:00
Gijs Kruitbosch
d2ebbb38df Bug 1358815 - remove sync reflow from find bar initialization, r=jaws
This removes the sync reflow from almost all cases. The only case where we keep it is when a keypress
caught in content triggers a sync message to the parent process. We should clean this up in bug 1371523.

I've tried to fix the tests, but a lot of them seem to be disabled anyway...

MozReview-Commit-ID: 9k36p7q8MKy

--HG--
extra : rebase_source : 311ee41ba9456a5c5d58b81a0cfa999bcef0027e
2018-03-12 14:01:44 +00:00
Brindusan Cristian
4f5a76dc76 Backed out 2 changesets (bug 1358815) for bc failures on browser_pdfjs_main.js CLOSED TREE
Backed out changeset 880736d97de3 (bug 1358815)
Backed out changeset a2a0a0990e1a (bug 1358815)
2018-03-15 21:23:12 +02:00
Gijs Kruitbosch
59e21359c8 Bug 1358815 - remove sync reflow from find bar initialization, r=jaws
This removes the sync reflow from almost all cases. The only case where we keep it is when a keypress
caught in content triggers a sync message to the parent process. We should clean this up in bug 1371523.

I've tried to fix the tests, but a lot of them seem to be disabled anyway...

MozReview-Commit-ID: 9k36p7q8MKy

--HG--
extra : rebase_source : 311ee41ba9456a5c5d58b81a0cfa999bcef0027e
2018-03-12 14:01:44 +00:00
Mike Conley
1bb8e62185 Bug 1423220 - Don't delay activating the DocShell for tabs that we're rendering by switching and not warming. r=dthayer
MozReview-Commit-ID: 3UmocajaSWJ

--HG--
extra : rebase_source : f79b07bd5620312b959503aeee5410c2e205a471
2018-03-16 11:39:22 -04:00
Andrea Marchesini
f02b4b3641 Bug 1433037 - WindowsPreviewPerTab should use decodeImageAsync, r=aosmond 2018-03-26 17:59:11 +02:00