Commit Graph

2 Commits

Author SHA1 Message Date
Gregory Szorc
8e85824bcb Bug 1411462 - Abort when I/O error seen; r=glandium
Before, I/O errors writing to stdout/stderr (e.g. due to broken pipe)
would result in handleError() being called and execution would
keep running. This would potentially result in an error message for
every log/line failure being printed to stderr.

We change the behavior so I/O failures are fatal and abort
execution.

We test the new behavior by changing a test to pipe to `head`
directly. Since `head` exits once it has seen sufficient output,
this results in an EPIPE which now results in immediate program
termination.

MozReview-Commit-ID: 1UecZJ56h4r

--HG--
extra : rebase_source : b35d9c096621d9698260d29a7d0132c4989200a7
2017-11-09 20:44:10 -08:00
Gregory Szorc
407d687142 Bug 1411462 - Add test for configure --help; r=glandium
We add a simple cram test that `configure --help` works.

I added the test to build/tests because I'm not sure where else it should go.

This test uncovers a few interesting things:

1) piping `./configure --help` to `head` directly causes a Python
   traceback (presumably due to the pipe disappearing once N lines
   have been read)
2) "checking for vcs source checkout" is printed for --help
3) It is printed twice (!!)

These will be addressed later. Establishing test coverage is
more important.

MozReview-Commit-ID: 9zQ5X8ulTkc

--HG--
extra : rebase_source : aaf660152cdfe37580f559976bca13ea9bf14c49
2017-10-24 17:10:55 -07:00