Reading this code I found I did not know what the position the start was being
set to. The patch renames this to make it clear that it's being set to the
current position.
Differential Revision: https://phabricator.services.mozilla.com/D190191
These members specify the start of the nursery (usually they are zero, but can
be different in generational zeal mode). They are constant between collections.
Calling them 'current' implies that they change often and this could lead to
confusion with currentChunk, which does change between collections. It's
simpler to remove the 'current'.
Differential Revision: https://phabricator.services.mozilla.com/D190189
Instead of using get_free_port(), pass in 0 as the port number and
allow geckodriver to select a free port. Then read the port from the
geckodriver output at startup. This should prevent rare race
conditions where we happen to select a port that later turns out to be
used.
Differential Revision: https://phabricator.services.mozilla.com/D189927
Instead of passing in a port selected in the fixture, pass in 0 as the
port, allowing geckodriver to select the port, and then read the port
number from the utput in stdout.
This should prevent us trying to reuse an already bound port in
a race-free way.
Differential Revision: https://phabricator.services.mozilla.com/D189926
Previously this bound to a free port, but we weren't allowing
connections because we checked the Host header against the specified
port (i.e. 0) rather than the bound port.
Differential Revision: https://phabricator.services.mozilla.com/D189925
The preference "test.events.async.enabled" controls the usage of
widget events in general, but Marionette doesn't support all of
them yet. To get widget events enabled for web-platform tests
those unsupported event types need to still synthesize the event.
Differential Revision: https://phabricator.services.mozilla.com/D188296
This converts addon suggestions from dynamic to standard results and removes
support for review stars. Other things worth noting:
* I removed `suggestion.is_top_pick` support because addons should always be top
picks. This lets us simplify the code and tests.
* This changes the overall icon box size for addons from 60px to 52px, since it
combines the icon rules for Pocket and addons. I checked with Josh, and he
says that's fine ([Slack](https://mozilla.slack.com/archives/C03LYL79G82/p1696471328852089?thread_ts=1696446640.986769&cid=C03LYL79G82))
* Currently the default `-webkit-line-clamp` is 3 and MDN and Pocket rows
override it by setting it to 2. I think the opposite makes more sense, i.e.
the default should be 2, since there are no row types that need it to be 3.
This lets me avoid adding a rule for addon rows. (`-webkit-line-clamp` was
added in D185247)
Depends on D190138
Differential Revision: https://phabricator.services.mozilla.com/D190145
Counted ref of TextureHostWrapperD3D11 is added to GpuProcessD3D11TextureMap::UpdatingTextureHolder. Then TextureHostWrapperD3D11 remains alive during updating Texture.
TextureCheck is added to TextureHostWrapperD3D11::~TextureHostWrapperD3D11(). It is for preventing the crash by null pointer deref.
NotifyNotUsed() call to wrapped TextureHost is removed, since TextureHostWrapperD3D11 holds compositable ref of wrapped TextureHost and the NotifyNotUsed() is called when compositable ref becomes 0. Then NotifyNotUsed() call to wrapped TextureHost is not necessary.
Differential Revision: https://phabricator.services.mozilla.com/D190243
This sets `has-url` on dynamic-result-type rows when their view template
contains a `.urlbarView-url` element. This fixes the missing separator in both
addon and weather rows.
This does not address one remaining problem: When `wrap` is set, the separator
is still missing in addon rows because they don't handle wrapping. Prior to
bug 1855639, they just always showed their title separator, and since they don't
wrap their URL, that was fine. I'd like to handle that separately by converting
addon rows from dynamic to standard. I filed bug 1857137 for that.
Differential Revision: https://phabricator.services.mozilla.com/D190144
As we will need to re-initialize the wmf decoder module, which takes
longer time sometime resulting IPC timeout. Therefore, make it async in
order to not interfere IPC response.
Differential Revision: https://phabricator.services.mozilla.com/D190224
This is a pure refactoring that just moves the inline string logic out into NewDependentString so that all *String::new_ creation functions are low-level and return a string of the class they are called on.
Differential Revision: https://phabricator.services.mozilla.com/D190127
The test requests reflow to a child document which the listener listens to
when expected event gets received as a message. However, the message listener
is set twice for listening same events on `<html>` and `<div>`. Therefore,
the request occurs twice, and that assumes that the reflow happens before
the next task of a `setTimeout` call.
This patch makes the order stabler.
* Request reflow only when the the last expected event is received
* Remove the message listeners when the reflow request is performed in the child
Differential Revision: https://phabricator.services.mozilla.com/D189817
With extended attribute attribution using exactly the same attribution strings as Windows (eg: no URLs), this turns out to be quite straightforward. Once we've pulled in the attribution string from the extended attribute, the existing parsing, validation, etc. just works.
The only wrinkle is that the extended attributes may have nul bytes or tabs that we need to strip away. (Tabs may be present because we use them to pad the attribution area when we prepare the DMG for attribution. Nul bytes may be present because we overwrite the entire attribution before updating the attribution data.)
Differential Revision: https://phabricator.services.mozilla.com/D189258
- Ensure that we hold a strong reference to the APZ event state before
calling ProcessSingleTap, as ProcessSingleTap fires events.
- Mark ProcessSingleTap as MOZ_CAN_RUN_SCRIPT since it can fire events.
Differential Revision: https://phabricator.services.mozilla.com/D190228
This patch lands an initial GeckoView session API for using toolkit
translations. This patch adds an initial session translate delegate,
functions to translate, detect languages, and restore to an original
page. The runtime API will follow in bug 1852313 and additional session
API changes are planned.
Differential Revision: https://phabricator.services.mozilla.com/D189228
This patch detects inband change for the HEVC playback so that we can
recreate decoder if the new config is different from the previous one.
Differential Revision: https://phabricator.services.mozilla.com/D187805
`READ_IN_RANGE_OR_RETURN` causes incorrectly reading bits multiple
times,so we remove it and modify the other macros to ensure that reading
bits should only be triggered once.
Differential Revision: https://phabricator.services.mozilla.com/D189871
When we call `nextEventMatchingMask` we send a "did launch app" notification to the OS workspace. If we do that before we call `[NSApp run]` accessibility isn't hooked up yet internally in AppKit and we fail to respond to a11y API queries.
Pumping Apple events is currently used for getting url requests in order to launch Firefox with the URLs loading correctly in a browser window. We can achieve the same result by using `application:openURLs:` in the delegate and calling `run` on the NSApp earlier and then stopping the loop in order to build the command line and finish initializing Firefox.
Also pumping the apple event queue should be deferred in `ProcessNextNativeEvent` until `[NSApp run]` is called.
Differential Revision: https://phabricator.services.mozilla.com/D184524
