Commit Graph

6680 Commits

Author SHA1 Message Date
Gerald Squelart
eadc54dcc3 Bug 1492121 - Use BaseProfiler in XRE_Init{Parent,Child}Process() - r=njn
Differential Revision: https://phabricator.services.mozilla.com/D31934

--HG--
extra : moz-landing-system : lando
2019-06-04 06:55:48 +00:00
Gerald Squelart
78897828c9 Bug 1492121 - Gecko Profiler integrates BaseProfiler startup profiled threads - r=njn
If MOZ_BASE_PROFILER_STARTUP and MOZ_PROFILER_STARTUP are set, this will integrate
a pre-XPCOM startup profile into the main profile.
It is stored as separate threads (in a single JSON string that is moved around),
which will appear as a new track under the main process.

Only adding threads from BaseProfiler means a better integration with Gecko
Profiler profiles, and is more efficient: Less code, and a smaller memory
footprint.

Differential Revision: https://phabricator.services.mozilla.com/D31932

--HG--
extra : moz-landing-system : lando
2019-06-04 06:55:37 +00:00
Gerald Squelart
d0e93db004 Bug 1492121 - Run BaseProfiler's InitializeWin64ProfilerHooks once from either profiler - r=njn
Running identical (but separate) InitializeWin64ProfilerHooks in both profilers
confuses the DLL interceptor and the 2nd one crashes because of unexpected
opcodes introduced by the 1st one.
If MOZ_BASE_PROFILER is defined, Gecko Profiler will use that implementation of
InitializeWin64ProfilerHooks instead of its own; and that code also has a guard
so that it effectively only run once even if called from both profilers.

Differential Revision: https://phabricator.services.mozilla.com/D31931

--HG--
extra : moz-landing-system : lando
2019-06-04 06:55:30 +00:00
Gerald Squelart
ebef0090cf Bug 1492121 - Rename env-vars MOZ_PROFILER_* to MOZ_BASE_PROFILER_* - r=njn
Notice the extra 'BASE' in the env-var names.
This is to control BaseProfiler separately from the Gecko Profiler.

Differential Revision: https://phabricator.services.mozilla.com/D31928

--HG--
extra : moz-landing-system : lando
2019-06-04 06:53:56 +00:00
Gijs Kruitbosch
65eeddec9b Bug 1548515 - Make quitter wait until we've run idle tasks, r=kmag
Differential Revision: https://phabricator.services.mozilla.com/D32470

--HG--
extra : rebase_source : b101c99e7ba2bc9a169a7313eed3ed501f74fd6e
extra : amend_source : fda5ee8c008540b205bab43b498a2e685c610b58
2019-05-24 12:58:43 +01:00
Daniel Varga
f35d98dcc4 Merge mozilla-central to mozilla-inbound 2019-06-01 12:45:58 +03:00
Nick Alexander
9366390a2b Bug 1555158 - Part 4: Default to -b firefox --skipHar in mach browsertime. r=dpalmeiro
Differential Revision: https://phabricator.services.mozilla.com/D33326

--HG--
extra : moz-landing-system : lando
2019-06-01 02:23:46 +00:00
Nick Alexander
2c85bd96b3 Bug 1555158 - Part 3: Make mach visualmetrics calculate contentfulSpeedIndex. r=dpalmeiro
Differential Revision: https://phabricator.services.mozilla.com/D33325

--HG--
extra : moz-landing-system : lando
2019-06-01 02:23:37 +00:00
Nick Alexander
7666bb7d95 Bug 1555158 - Part 2: Accept system ImageMagick on Linux. r=dpalmeiro
Differential Revision: https://phabricator.services.mozilla.com/D32923

--HG--
extra : moz-landing-system : lando
2019-06-01 02:23:22 +00:00
Nick Alexander
ae0bdfac53 Bug 1555158 - Part 1: Point mach browsertime --setup at mozilla/browsertime github repository. r=dpalmeiro
Key features in this commit:

- support for `contentfulSpeedIndex` visual metric
- support for the Gecko Window Recorder (Desktop only)
- support for the Gecko Profiler (Desktop only)
- partial support for GeckoView on Android

Differential Revision: https://phabricator.services.mozilla.com/D32907

--HG--
extra : moz-landing-system : lando
2019-06-01 02:23:09 +00:00
Nick Alexander
3df6d400a1 Bug 1549781 - Ensure browsertime state path is created before use. r=dpalmeiro
Differential Revision: https://phabricator.services.mozilla.com/D32906

--HG--
extra : moz-landing-system : lando
2019-06-01 02:22:55 +00:00
arthur.iakab
36d75a7e56 Merge mozilla-central to mozilla-inbound 2019-06-01 01:30:47 +03:00
Brian Grinstead
1a65cc7e89 Bug 1555421 - Include 'other' and 'g5' test suites in perf-chrome preset;r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D33049

--HG--
extra : moz-landing-system : lando
2019-05-31 15:53:48 +00:00
Brian Grinstead
8917b90c82 Bug 1553188 - Part 3 - Support eslint for browser.xhtml;r=Standard8
Since it's not a xul document anymore we can't rely on the xul.js lint preprocessor.
This means we need to remove preprocessor attributes from inline scripts, and tell
lint about the browser window environment.

Differential Revision: https://phabricator.services.mozilla.com/D33207
2019-05-30 09:30:21 -07:00
Mike Hommey
4c0ecc6982 Bug 1554063 - Move decimal to mozglue. r=jwalden
Differential Revision: https://phabricator.services.mozilla.com/D32435

--HG--
rename : mfbt/decimal/Decimal.cpp => mozglue/misc/decimal/Decimal.cpp
rename : mfbt/decimal/Decimal.h => mozglue/misc/decimal/Decimal.h
rename : mfbt/decimal/UPSTREAM-GIT-SHA => mozglue/misc/decimal/UPSTREAM-GIT-SHA
rename : mfbt/decimal/comparison-with-nan.patch => mozglue/misc/decimal/comparison-with-nan.patch
rename : mfbt/decimal/fix-wshadow-warnings.patch => mozglue/misc/decimal/fix-wshadow-warnings.patch
rename : mfbt/decimal/mfbt-abi-markers.patch => mozglue/misc/decimal/mfbt-abi-markers.patch
rename : mfbt/decimal/moz-decimal-utils.h => mozglue/misc/decimal/moz-decimal-utils.h
rename : mfbt/decimal/to-moz-dependencies.patch => mozglue/misc/decimal/to-moz-dependencies.patch
rename : mfbt/decimal/update.sh => mozglue/misc/decimal/update.sh
rename : mfbt/decimal/zero-serialization.patch => mozglue/misc/decimal/zero-serialization.patch
extra : moz-landing-system : lando
2019-05-29 06:57:28 +00:00
Ehsan Akhgari
4cb428d268 Bug 1555205 - Move db/sqlite3 to third_party/; r=mak
Differential Revision: https://phabricator.services.mozilla.com/D32939

--HG--
rename : db/sqlite3/README => third_party/sqlite3/README
rename : db/sqlite3/README.MOZILLA => third_party/sqlite3/README.MOZILLA
rename : db/sqlite3/src/moz.build => third_party/sqlite3/src/moz.build
rename : db/sqlite3/src/sqlite.symbols => third_party/sqlite3/src/sqlite.symbols
rename : db/sqlite3/src/sqlite3.c => third_party/sqlite3/src/sqlite3.c
rename : db/sqlite3/src/sqlite3.h => third_party/sqlite3/src/sqlite3.h
extra : moz-landing-system : lando
2019-05-29 10:16:29 +00:00
Mihai Alexandru Michis
372773e7f5 Backed out changeset 3edc5be703be (bug 1554063) for mass test failures. CLOSED TREE
--HG--
rename : mozglue/misc/decimal/Decimal.cpp => mfbt/decimal/Decimal.cpp
rename : mozglue/misc/decimal/Decimal.h => mfbt/decimal/Decimal.h
rename : mozglue/misc/decimal/UPSTREAM-GIT-SHA => mfbt/decimal/UPSTREAM-GIT-SHA
rename : mozglue/misc/decimal/comparison-with-nan.patch => mfbt/decimal/comparison-with-nan.patch
rename : mozglue/misc/decimal/fix-wshadow-warnings.patch => mfbt/decimal/fix-wshadow-warnings.patch
rename : mozglue/misc/decimal/mfbt-abi-markers.patch => mfbt/decimal/mfbt-abi-markers.patch
rename : mozglue/misc/decimal/moz-decimal-utils.h => mfbt/decimal/moz-decimal-utils.h
rename : mozglue/misc/decimal/to-moz-dependencies.patch => mfbt/decimal/to-moz-dependencies.patch
rename : mozglue/misc/decimal/update.sh => mfbt/decimal/update.sh
rename : mozglue/misc/decimal/zero-serialization.patch => mfbt/decimal/zero-serialization.patch
2019-05-29 09:54:37 +03:00
Mike Hommey
66cb95a768 Bug 1554063 - Move decimal to mozglue. r=jwalden
Differential Revision: https://phabricator.services.mozilla.com/D32435

--HG--
rename : mfbt/decimal/Decimal.cpp => mozglue/misc/decimal/Decimal.cpp
rename : mfbt/decimal/Decimal.h => mozglue/misc/decimal/Decimal.h
rename : mfbt/decimal/UPSTREAM-GIT-SHA => mozglue/misc/decimal/UPSTREAM-GIT-SHA
rename : mfbt/decimal/comparison-with-nan.patch => mozglue/misc/decimal/comparison-with-nan.patch
rename : mfbt/decimal/fix-wshadow-warnings.patch => mozglue/misc/decimal/fix-wshadow-warnings.patch
rename : mfbt/decimal/mfbt-abi-markers.patch => mozglue/misc/decimal/mfbt-abi-markers.patch
rename : mfbt/decimal/moz-decimal-utils.h => mozglue/misc/decimal/moz-decimal-utils.h
rename : mfbt/decimal/to-moz-dependencies.patch => mozglue/misc/decimal/to-moz-dependencies.patch
rename : mfbt/decimal/update.sh => mozglue/misc/decimal/update.sh
rename : mfbt/decimal/zero-serialization.patch => mozglue/misc/decimal/zero-serialization.patch
extra : moz-landing-system : lando
2019-05-29 00:59:20 +00:00
Sylvestre Ledru
ddeb921733 Bug 1554406 - rustfmt: Remove servo from the list (not green yet) r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D32681

--HG--
extra : moz-landing-system : lando
2019-05-27 15:25:47 +00:00
Sylvestre Ledru
c016ea09a2 Bug 1554111 - Add js/src/wasm/cranelift/src/ to the rustfmt list r=bbouvier
Differential Revision: https://phabricator.services.mozilla.com/D32437

--HG--
extra : moz-landing-system : lando
2019-05-27 07:22:04 +00:00
Sylvestre Ledru
d4a0ba5010 Bug 1554115 - mozlint rustfmt should fail if using the old rustfmt version r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D32439

--HG--
extra : moz-landing-system : lando
2019-05-24 21:53:58 +00:00
Tom Prince
dd553f4200 No bug: [release] Fix path to update-verify diff-summary log; r=bhearsum
when update-verify migrated from using build-tools to in-tree, the path
to `diff-summary.log` was not updated.

Differential Revision: https://phabricator.services.mozilla.com/D32403

--HG--
extra : moz-landing-system : lando
2019-05-24 00:22:50 +00:00
Sylvestre Ledru
d1fc7c3609 Bug 1551078 - Add rustfmt as part of mozlint r=ahal
Two use cases:

1) Show the errors
$ ./mach lint -l rustfmt js/rust/src/rust.rs

Also works on a directory:
$ ./mach lint -l rustfmt js/rust/src/

2) Update the code
$ ./mach lint -l rustfmt js/rust/src/rust.rs --fix

To install it:
$ rustup component add rustfmt
$ export PATH=$PATH:~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/bin/

Differential Revision: https://phabricator.services.mozilla.com/D30813

--HG--
extra : moz-landing-system : lando
2019-05-23 17:26:05 +00:00
Andi-Bogdan Postelnicu
ca4a195007 Bug 1551842 - Add new clang-tidy checkers from clang 8.0.0. r=sylvestre,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D31229

--HG--
extra : moz-landing-system : lando
2019-05-22 14:55:45 +00:00
Sylvestre Ledru
f793b0ae36 Bug 1553060 - Enable codespell on ftl files r=ahal
Depends on D31967

Differential Revision: https://phabricator.services.mozilla.com/D31968

--HG--
extra : moz-landing-system : lando
2019-05-22 12:08:46 +00:00
Sylvestre Ledru
09be72c708 Bug 1553060 - Enable codespell on more directories r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D31967

--HG--
extra : moz-landing-system : lando
2019-05-22 12:08:46 +00:00
Nika Layzell
95e8f0306b Bug 1540731 - Part 2: Move toplevel actors to override ActorDestroy, r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D28573

--HG--
extra : moz-landing-system : lando
2019-05-21 17:04:21 +00:00
Denis Palmeiro
49502b1ffa Bug 1545091 - Spew tracelogger statistics with IONFLAGS=tracelogger r=iain,mstange
Add Jitspewing control for tracelogger data.  This can be enabled from the profiler or from the JS shell.  Usage is as follows:

From browser (ION_SPEW_FILENAME is recommended here so stdout doesn't get clobbered by each process):
  1.  JS_TRACE_LOGGING=1 IONFLAGS=tracelogger ION_SPEW_FILENAME=tracelogger ./mach run
  2.  Enable JSTracer feature in profiler addon
  3.  Start profiling and ctrl+shift+2 to view profile, and the data will be automatically spewed during profile collection.

From shell:
  1.  JS_TRACE_LOGGING=1 IONFLAGS=tracelogger dist/bin/js test.js
  2.  Data is automatically spewed to stdout when the shell exits, or use ION_SPEW_FILENAME.

There is an optional environment variable JS_TRACELOGGER_SPEW that can be used to emit specific events, for example JS_TRACELOGGER_SPEW="Interpreter,Baseline,GC" will emit only those specific events along with the script and self time of each script.

The structured spewer is also supported with SPEW=tracelogger, and this will emit the tracelogger data for every recorded event.

Differential Revision: https://phabricator.services.mozilla.com/D30033

--HG--
extra : moz-landing-system : lando
2019-05-21 15:25:32 +00:00
Boris Zbarsky
e03bc405fa Bug 1551106 part 2. Stop using [array] in profiler's GetFeatures/GetAllFeatures. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D30968

--HG--
extra : moz-landing-system : lando
2019-05-21 14:43:10 +00:00
Boris Zbarsky
dbdb74ad56 Bug 1551106 part 1. Stop using [array] in StartProfiler. r=gerald
Differential Revision: https://phabricator.services.mozilla.com/D30967

--HG--
extra : moz-landing-system : lando
2019-05-21 14:42:57 +00:00
Sylvestre Ledru
bbb9e0c803 Bug 1552560 - Update to codespell 1.15 and update the exclude list r=ahal
Depends on D31667

Differential Revision: https://phabricator.services.mozilla.com/D31668

--HG--
extra : moz-landing-system : lando
2019-05-21 13:32:00 +00:00
Sylvestre Ledru
ada39585cd Bug 1552560 - Fix a typo found by codespell 1.15 r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D31667

--HG--
extra : moz-landing-system : lando
2019-05-21 13:31:27 +00:00
Andreas Farre
c6af33c82e Bug 1552775 git clang-format hook: Ignore deleted files. r=sylvestre
Differential Revision: https://phabricator.services.mozilla.com/D31758

--HG--
extra : moz-landing-system : lando
2019-05-20 11:43:04 +00:00
Joel Maher
2ba42a9f7d Bug 1550130 - make tools/profiler/tests/xpcshell/test_enterjit_osr.js more robust. r=gregtatum
make tools/profiler/tests/xpcshell/test_enterjit_osr.js more robust.

Differential Revision: https://phabricator.services.mozilla.com/D31796

--HG--
extra : moz-landing-system : lando
2019-05-20 18:15:24 +00:00
Sylvestre Ledru
fb63889274 Bug 1552430 - Fix some typos using codespell trunk r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D31589

--HG--
extra : moz-landing-system : lando
2019-05-17 15:56:50 +00:00
Victor Porof
35ecad1c2c Bug 1551218 - Part 1: Enable running top-level eslint for the devtools debugger, r=Standard8,jlast
Differential Revision: https://phabricator.services.mozilla.com/D30926

--HG--
extra : moz-landing-system : lando
2019-05-17 15:50:29 +00:00
Mihai Alexandru Michis
766636073f Backed out changeset 8952fe75cb7a (bug 1551218) for causing linting failures. CLOSED TREE 2019-05-17 16:37:40 +03:00
Victor Porof
e4c63108e7 Bug 1551218 - Part 1: Enable running top-level eslint for the devtools debugger, r=Standard8,jlast
Differential Revision: https://phabricator.services.mozilla.com/D30926

--HG--
extra : moz-landing-system : lando
2019-05-17 12:47:41 +00:00
Ethan Glasser-Camp
69baf93870 Bug 1547034: Migrate PreferenceExperiments to allow for multiple prefs r=mythmon,leplatrem
This is part 1 of the required changes. This just addresses the
storage mechanism and any place that uses experiments in their raw
form. This updates most callers to support studies with multiple
preferences.

We update about-studies to assume only one preference. This seems
counterproductive, but studies with multiple preferences will include
a description field that obviates the need for this.

Differential Revision: https://phabricator.services.mozilla.com/D29293

--HG--
extra : moz-landing-system : lando
2019-05-16 15:04:12 +00:00
Csoregi Natalia
8ef3142853 Merge inbound to mozilla-central. a=merge 2019-05-17 00:55:45 +03:00
Gerald Squelart
c369aec152 Bug 1551625 - Lower profiler max startup entries - r=florian
Now starting with a maximum of `1u << 22`, i.e. 4,194,304 entries, or 36MB per
process. (Using powers of two, because that's what we round up to anyway.)

Also giving more information in MOZ_PROFILER_HELP:
- Reminding this is a number of entries *per process*.
- Bytes per entry, and resulting total buffer sizes per process.

Differential Revision: https://phabricator.services.mozilla.com/D31389

--HG--
extra : moz-landing-system : lando
2019-05-16 07:40:54 +00:00
Tom Prince
428ae7cea5 Bug 1551738: [try-staging] Add release-to-esr migration for staging release; r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D31185

--HG--
extra : moz-landing-system : lando
2019-05-15 18:04:45 +00:00
Tom Prince
7f9169c00a Bug 1551743 Generate better treeherder errors when update-verify fails; r=bhearsum
Treeherder will display a summary of errors from the log, if they are match
certain patterns. Make update-verify more useful by outputing errors that
match.

Differential Revision: https://phabricator.services.mozilla.com/D31165

--HG--
extra : moz-landing-system : lando
2019-05-15 14:13:34 +00:00
Mark Banner
0142a7611e Bug 1551551 - Update eslint-plugin-mozilla mocha version (dev dependency). r=ahal
Depends on D31076

Differential Revision: https://phabricator.services.mozilla.com/D31077

--HG--
extra : moz-landing-system : lando
2019-05-15 14:35:36 +00:00
Mark Banner
863328242a Bug 1551551 - Fix dependency checking for when to update developer's npm installs. r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D31075

--HG--
extra : moz-landing-system : lando
2019-05-15 14:34:09 +00:00
Matthew Gaudet
69feb249f9 Bug 1539814 - An initial pair of try presets for SpiderMonkey r=jandem,ahal
- sm-shell: Selects shell only test cases that shouldn't require a full browser build.
- sm-all: Selects test cases that may require a full browser build.

Differential Revision: https://phabricator.services.mozilla.com/D28994

--HG--
extra : moz-landing-system : lando
2019-05-07 13:40:06 +00:00
Andi-Bogdan Postelnicu
7be18f3d26 Bug 1503453 - re-enable static-analysis autotest on win64 platform after migrating to clang-tidy 8. r=sylvestre
Also for checker `modernize-avoid-bind` export the respective reliability index from config.yaml

Differential Revision: https://phabricator.services.mozilla.com/D30904

--HG--
extra : moz-landing-system : lando
2019-05-14 13:00:13 +00:00
Sylvestre Ledru
41004a2d1a Bug 1551083 - Fix a bugprone-move-forwarding-reference defect in ProfileBufferEntry r=erahm
Depends on D30816

Differential Revision: https://phabricator.services.mozilla.com/D30817

--HG--
extra : moz-landing-system : lando
2019-05-14 07:12:19 +00:00
Sylvestre Ledru
88e7b97c2a Bug 1551083 - Enable bugprone-move-forwarding-reference r=andi
Differential Revision: https://phabricator.services.mozilla.com/D30816

--HG--
extra : moz-landing-system : lando
2019-05-14 07:12:37 +00:00
Andrew McCreight
2841945140 Bug 1550860 - Mark implicit builtinclass interfaces explicitly. r=nika
If an XPIDL interface has a method or attribute that is [notxpcom],
then it is implicitly treated as [builtinclass], even if it is not
marked as such. For clarity, this patch goes through and marks every
place that relies on this behavior (aside from some test code).

Differential Revision: https://phabricator.services.mozilla.com/D30714

--HG--
extra : moz-landing-system : lando
2019-05-13 19:51:49 +00:00