Commit Graph

6683 Commits

Author SHA1 Message Date
Jorg K
a83efbdfb5 Bug 1426062 - Follow-up for bug 1422465: check parent before dereferencing it. r=surkov 2017-12-20 00:00:00 -05:00
Eric Rahm
b1c032672b Bug 1424120 - Part 5: Enforce support for only radix of 10 and 16. r=njn
In theory other radixes can be passed in but we don't actually handle them.
This asserts that the radix is supported and just switches over to using 10 and
16 directly.

--HG--
extra : rebase_source : 71891302d499bfd108a5bb41626d921b3be193ce
2017-12-07 18:54:13 -08:00
Alexander Surkov
180fc6c813 Bug 1424768 - telemetry accessible tree update times, r=jamie, francois 2017-12-18 09:50:45 -05:00
Samuel Thibault
0b770bd497 Bug 1260598 Make document events wait for chrome content insertion events r=surkov
When switching from a tab to another, accessibility layers needs to get
events about the tab switch before events about the newly-focused
element of the document.

This changeset does it so by first making IsUpdatePending() not only
watch for the document's pending updates, but also its parent's pending
updates, so that the document doesn't process focus events immediately,
but queue them.

Then, WillRefresh for the document should not process events until its
parent chrome has finished processing its content insertion events
(corresponding to the tab switch).

Eventually, ScheduleContentInsertion can not afford leaving an empty
array of notifications and not a schedule processing any more.
(was introduced by c2aeece5eb10 'Bug 1242989 - keep content insertions
in a hash')
2017-12-14 11:07:00 +02:00
Mark Banner
d44db2f404 Bug 1425244 - Enable ESLint rule no-redeclare for accessible/tests/mochitest/. r=surkov
MozReview-Commit-ID: CPetBgR8ZAm

--HG--
extra : rebase_source : 79d6829bcce9a775e9b44b4659d7f0992a4ff2a1
2017-12-11 15:32:36 +00:00
Mark Banner
4330ae79f1 Bug 1425244 - Enable ESLint rule no-shadow for accessible/tests/mochitest/. r=surkov
MozReview-Commit-ID: 1lkHq7csLkq

--HG--
extra : rebase_source : 4b6965532e3a18a74c62ed9fa6f7312e3baf783f
2017-12-11 14:04:42 +00:00
Mark Banner
bf483821a7 Bug 1425244 - Enable ESLint rule space-unary-ops for accessible/tests/mochitest/. r=surkov
MozReview-Commit-ID: BPufvA8kUkv

--HG--
extra : rebase_source : 041a756d850f000fc5b806b23d628f2da542d271
2017-12-11 13:49:22 +00:00
Mark Banner
217fc0f5a2 Bug 1425244 - Enable ESLint rule no-new-object for accessible/tests/mochitest/. r=surkov
MozReview-Commit-ID: AU5AlyOdgoy

--HG--
extra : rebase_source : a9bb04d3dc5d6823160baa83b710ac68cefeb814
2017-12-11 13:45:41 +00:00
Mark Banner
6ad02b364e Bug 1425244 - Enable ESLint rule no-lonely-if for accessible/tests/mochitest/. r=surkov
MozReview-Commit-ID: DILOcLjsaoF

--HG--
extra : rebase_source : ac66819b55cf689b5264d6ea1ef16d96712cd179
2017-12-11 13:42:17 +00:00
Mark Banner
c39a3faacd Bug 1425244 - Enable ESLint rule no-cond-assign for accessible/tests/mochitest/. r=surkov
MozReview-Commit-ID: 59yovY1BQ0p

--HG--
extra : rebase_source : c4923734a9403c316f2d6f21ebef777d70e147a9
2017-12-11 13:36:16 +00:00
Mark Banner
c375803246 Bug 1425244 - Enable ESLint rule comma-spacing for accessible/tests/mochitest/. r=surkov
MozReview-Commit-ID: BIgkIWmCcaM

--HG--
extra : rebase_source : 9abe9235db376babf464e4e246026499a69245b7
2017-12-11 13:32:51 +00:00
Mark Banner
7f569f1c3b Bug 1425244 - Enable ESLint rule object-shorthand for accessible/. r=surkov
MozReview-Commit-ID: 9LCLDppVj1t

--HG--
extra : rebase_source : 5e93113ce588f9c50fff55099b27489806158b6c
2017-12-11 13:08:14 +00:00
James Teh
0ba48a4da2 Bug 1425030: ia2Accessible::get_accessibleWithCaret: Gracefully handle null returned from SelectionManager::AccessibleWithCaret. r=surkov
We weren't checking for null previously, thus causing a crash when there was no caret.
MozReview-Commit-ID: 6NNRafcVPhb

--HG--
extra : rebase_source : 7d6bfc8c776c1be1429da8c2c94f4bda232c6314
2017-12-12 13:38:34 +10:00
James Teh
47040c9214 Bug 1424657: Make IAccessible::accChild handle remote ids for popup windows. r=eeejay
Bug 1422201 changed GetIAccessibleFor so it only handles remote ids when called on the root accessible.
However, this breaks webextension popup documents.
These popups have their own HWND, so the root accessible of that HWND needs to handle accChild for ids in remote documents within that HWND.
Therefore, expand the restriction to cover the root accessible of any HWND, not just the main HWND.

MozReview-Commit-ID: 69v4XSeQLcS

--HG--
extra : rebase_source : bf5c5e0a475424b2276800d1a10ab1a46c136bd6
2017-12-11 14:35:00 +10:00
Aaron Klotz
f438b13735 Bug 1423989: Add telemetry probe to measure the time spent finding the UIA client; r=Jamie, r=francois
MozReview-Commit-ID: 7Z9Ay3TiHjH

--HG--
extra : amend_source : 3e17c89bb53ea8605021c4c1771db6d4fea3bcbb
2017-12-04 17:56:45 -07:00
Gurzau Raul
91d3bc0100 Merge inbound to mozilla-central r=merge a=merge 2017-12-09 00:36:15 +02:00
Eitan Isaacson
2fccef2647 Bug 1396478 - Don't process text changes from nodes that were removed from doc. r=surkov 2017-12-07 10:45:00 +02:00
Bill McCloskey
9f4d083047 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-07 12:55:24 -08:00
Sylvestre Ledru
a9961096c0 Bug 1394734 - Simplify various corner cases r=glandium
MozReview-Commit-ID: 4s4JdXZPvmv

--HG--
extra : rebase_source : c8f663c99442d41db5f81ac5fe1aa1f47fd5ed82
2017-12-07 22:10:19 +01:00
Sylvestre Ledru
4591d82b23 Bug 1394734 - Replace CONFIG['CLANG*'] by CONFIG['CC_TYPE'] r=glandium
MozReview-Commit-ID: HbF5oT5HW6f

--HG--
extra : rebase_source : eca479b6ae4bff7f600d1cdb39e11ac2057e4e79
2017-12-07 22:09:38 +01:00
Sylvestre Ledru
9bfe27d903 Bug 1394734 - Replace CONFIG['GNU_C*'] by CONFIG['CC_TYPE'] r=glandium
MozReview-Commit-ID: 7duJk2gSd4m

--HG--
extra : rebase_source : 7312fe276e561e8c034a5f6749774ae812727f9c
2017-12-07 22:09:15 +01:00
Brindusan Cristian
5b9ee89503 Merge mozilla-central to autoland a=merge r=merge on a CLOSED TREE 2017-12-08 12:06:24 +02:00
Brian Grinstead
9c9c6b777b Bug 1422465 - Remove the nsIDOMXULPopupElement interface and [implements] attribute on the "popup-base" and "panel" bindings;r=bz,surkov
MozReview-Commit-ID: EvzuohEgFSh

--HG--
extra : rebase_source : 838cd68dda56778e6815c7c75a6ca158902c8f29
2017-12-07 13:37:06 -08:00
Brian Grinstead
a443d0e5d4 Bug 1422465 - Add regression test to ensure that the awesomebar richlistbox gets the COMBOBOX_LIST role;r=surkov
In the next changeset we will remove the nsIDOMXULPopupElement interface, which
was only used to make sure that this role is set. There wasn't a test covering
this case yet, so this changeset adds one.

Note that we are using a mochitest-browser test as opposed to directly testing
markup like `<panel><richlistbox /></panel>` in a mochitest-chrome test so that
we'll actually be able to catch a regression if the markup for the awesomebar changes.

MozReview-Commit-ID: KGaxQZTDq69

--HG--
extra : rebase_source : 671b718fd010b5f6a2036a695d2c4c03c8b64654
2017-12-07 13:05:07 -08:00
Andreea Pavel
89531e8dc3 Backed out 9 changesets (bug 1412456) for crashing talos g2 and unexpected network connections in browser-chrome's browser_searchEngine_behaviors.js r=backout a=backout on a CLOSED TREE
Backed out changeset 0c01a98f4fd5 (bug 1412456)
Backed out changeset 27077db47231 (bug 1412456)
Backed out changeset f35ec2a884f8 (bug 1412456)
Backed out changeset 602b30ac3c69 (bug 1412456)
Backed out changeset b1ff1050c589 (bug 1412456)
Backed out changeset f100d953f9eb (bug 1412456)
Backed out changeset d85af60fe259 (bug 1412456)
Backed out changeset 736f38486832 (bug 1412456)
Backed out changeset 13a637602dc2 (bug 1412456)
2017-12-07 12:20:21 +02:00
Aaron Klotz
80a4e21834 Bug 1419886: Part 2 - Add UIA detection to a11y and centralize a11y instantiator telemetry under a11y::SetInstantiator function; r=Jamie
MozReview-Commit-ID: 11QN7amImK9
2017-12-04 17:56:31 -07:00
Bill McCloskey
bef7c122df Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 21:17:05 -08:00
Dorel Luca
eb65c24c7b Backed out 8 changesets (bug 1412456) for ESlint failure on browser_urlbarKeepStateAcrossTabSwitches.js:13:49 r=backout on a CLOSED TREE
Backed out changeset 0e88de036c55 (bug 1412456)
Backed out changeset 49b93f807db0 (bug 1412456)
Backed out changeset 039e980b7dc6 (bug 1412456)
Backed out changeset c7698410ddbd (bug 1412456)
Backed out changeset e56a1ba26b7c (bug 1412456)
Backed out changeset 0c4506e124ac (bug 1412456)
Backed out changeset a7aec2ce903b (bug 1412456)
Backed out changeset 3e9fb71f1e8e (bug 1412456)
2017-12-07 07:09:33 +02:00
Bill McCloskey
be77cf4a01 Bug 1412456 - Test changes to no longer use interposition (r=felipe,bgrins,mrbkap)
MozReview-Commit-ID: 2nQPOSGTr1s
2017-12-06 20:46:58 -08:00
Emilio Cobos Álvarez
74b31155f7 Bug 1423167: Move most attribute-related methods from nsIContent to Element. r=bz
MozReview-Commit-ID: 6WXqNiODttD
2017-12-06 16:05:59 +01:00
Gurzau Raul
f5f1c3f294 Merge inbound to mozilla-central r=merge a=merge 2017-12-06 11:53:55 +02:00
James Teh
63f0dbc751 Bug 1422674: Fix IAccessible::accChild on parent process accessibles with positive indices. r=MarcoZ
Previously, in the parent process, we were treating positive child ids as remote unique ids.
This of course failed when searching remote documents and returned early.
Make sure we only treat ids as remote if they are less than 0.
Ids above 0 are child indices and are handled later in the code for both local and remote children.

MozReview-Commit-ID: 2KmFj6rTXTV

--HG--
extra : rebase_source : 273496a3f6420d184f71795095937638e1e3e2ca
2017-12-06 10:11:17 +10:00
Noemi Erli
449829ebb2 Merge mozilla-central to mozilla-autoland. r=merge a=merge 2017-12-05 16:31:06 +02:00
Eitan Isaacson
2cc9a52ceb Bug 1421018 - Create accessible client blocklist and add TBNNotifier.exe. r=jimm 2017-12-04 13:20:00 -05:00
Narcis Beleuzu
1f7fdd5826 Merge mozilla-central to inbound. r=merge a=merge on a CLOSED TREE 2017-12-06 01:49:19 +02:00
Marco Castelluccio
8a57eeb106 Bug 1423218 - Disable a11y test_tabbrowser.xul in Windows coverage builds. r=jmaher
--HG--
extra : rebase_source : 9d0215e31081c77fa1dd993f4dc32b0876e70ab3
2017-12-05 16:10:29 +01:00
James Teh
caac6a3325 Bug 1422201: Only handle remote ids passed to IAccessible::accChild on the root accessible. r=MarcoZ
Previously, we could return remote accessibles which weren't actually descendants of the accessible on which accChild was called.
For example, calling accChild on a local document with the id of a remote document would happily return the remote accessible.
This confused clients such as NVDA which use accChild to check whether something is a descendant of a document.

MozReview-Commit-ID: 8mJ4m6RC3r2

--HG--
extra : rebase_source : c56040d84e09c2b9ede94985cdd94606c27160a3
2017-12-04 15:32:56 +10:00
Eitan Isaacson
a55e238edf Bug 1409731 - Expose input[type=date/time] correctly in a11y. r=surkov, r=jjong 2017-12-02 18:12:14 -05:00
James Teh
31c03e927b Bug 1421873: Fix infinite loop in HandlerProvider::GetAllTextInfoMainThread when invalid attribute offsets are returned. r=MarcoZ
When querying text attributes, Gecko can return an end offset less than the requested offset in some rare cases, which isn't valid.
This is perhaps because the text mutated during the attribute fetching loop for some reason, making the requested offset invalid.
We now check the end offset and break out of the loop in this case.
This fixes a freeze after sending a message in OX Mail with NVDA.

MozReview-Commit-ID: 1lVSLAdOcS7

--HG--
extra : rebase_source : 048fbed8ddc591f62c17d559483bfe2f1542431c
2017-11-30 16:44:02 +10:00
Bogdan Tara
d8635b15e4 Merge inbound to mozilla-central r=merge a=merge on a CLOSED TREE 2017-11-30 00:41:09 +02:00
Dorel Luca
f622b80073 Merge mozilla-central to mozilla-inbound r=merge 2017-11-29 12:34:02 +02:00
Dorel Luca
be78e6ea9b Merge inbound to mozilla-central r=merge a=merge 2017-11-29 12:26:15 +02:00
Yura Zenevich
77e0097f7a Bug 1419131 - adding a11y force disabled pref observer when accessibility service is being created. r=surkov
MozReview-Commit-ID: G2pG3PcUMrE
2017-11-29 00:01:18 -05:00
James Teh
e9098869dd Bug 1421478: Clarify comment in handlerDataCleanup.h. r=aklotz
MozReview-Commit-ID: EVzuqVMl7Ck

--HG--
extra : rebase_source : ebcad7cbc5ed49417ece2d9b220d52488ee28732
2017-11-29 10:18:01 +10:00
James Teh
2cb46a14be Bug 1418448 part 3: Accessible Handler/Provider: Unify release of interfaces in StaticIA2Data. r=aklotz
Both Provider and Handler need to release the interfaces in StaticIA2Data.
Therefore, move this into a common function to avoid duplication pain in future.

MozReview-Commit-ID: 7J4iuvDa8m2

--HG--
extra : rebase_source : 98c97b51c27c318ba987787518cfd70bda8967d4
2017-11-24 15:10:41 +10:00
James Teh
f7fcce5742 Bug 1418448 part 2: AccessibleHandler: Clean up DynamicIA2Data. r=aklotz
We need to clean up the VARIANT and BSTRs in DynamicIA2Data in the handler as well.
We do this in two places:
1. Before reading a new payload (because we need to clean up the existing payload); and
2. When we're being destroyed.

MozReview-Commit-ID: GvO7csuxtwZ

--HG--
extra : rebase_source : 92cc9a64deddee07bbbc77e53117c15351816778
2017-11-24 15:14:04 +10:00
James Teh
f81d8d0130 Bug 1418448 part 1: Accessible HandlerProvider: Clean up DynamicIA2Data correctly. r=aklotz
DynamicIA2Data contains several BSTRs that need to be freed with SysFreeString.
Previously, we just did a ZeroMemory without actually freeing them.
This cleanup code is placed in a header file so it can be used by AccessibleHandler as well.

MozReview-Commit-ID: 4SWuK9oMRYZ

--HG--
extra : rebase_source : e7358752e7eee1bae000e4005832bfc48c9342af
2017-11-24 15:12:37 +10:00
Tiberius Oros
18ea9ecad9 Merge mozilla-central to mozilla-inbound. r=merge a=merge CLOSED TREE
--HG--
rename : devtools/client/webconsole/new-console-output/test/mochitest/test-bug-618078-network-exceptions.html => devtools/client/webconsole/new-console-output/test/mochitest/test-network-exceptions.html
rename : devtools/client/webconsole/new-console-output/test/mochitest/test_bug1092055_shouldwarn.html => devtools/client/webconsole/new-console-output/test/mochitest/test-subresource-security-error.html
rename : devtools/client/webconsole/new-console-output/test/mochitest/test_bug1092055_shouldwarn.js => devtools/client/webconsole/new-console-output/test/mochitest/test-subresource-security-error.js
rename : devtools/client/webconsole/new-console-output/test/mochitest/test_bug1092055_shouldwarn.js^headers^ => devtools/client/webconsole/new-console-output/test/mochitest/test-subresource-security-error.js^headers^
extra : rebase_source : e126b0ab427161de0acd67cdfb9a1434415412dc
2017-11-29 02:25:59 +02:00
Brian Grinstead
30a99a2b95 Bug 1419170 - Remove the statusbar and statusbarpanel bindings;r=Paolo
MozReview-Commit-ID: DbwMUBpHcri

--HG--
extra : rebase_source : 0fb627a10860302ca5f31013ed7d8370eb655230
2017-11-27 09:17:04 -08:00
Dorel Luca
79499f4044 Merge mozilla-central to autoland r=merge on a CLOSED TREE 2017-11-29 12:31:25 +02:00