Xidorn Quan
a4a78e1951
Bug 1267515 part 2 - Place ruby annotations outside annotations from ruby descendants. r=dholbert
...
MozReview-Commit-ID: Gbo43pC5jqr
--HG--
extra : rebase_source : 893fe9d419be59679febe2de07bbd495ce23e609
2016-10-26 17:40:58 +11:00
Xidorn Quan
b725f733a2
Bug 1267515 part 1 - Refactor ruby leadings into a helper RubyBlockLeadings struct. r=dholbert
...
MozReview-Commit-ID: IJAA9fHbCZd
--HG--
extra : rebase_source : 4166ebe1be89595f96da12e1e247cf1f0d536ddd
2016-11-10 11:10:42 +11:00
Xidorn Quan
4e5bd79656
Bug 1260031 - Not force break before a block when calculating intrinsic width if the current line is empty and the block cannot intersect floats. r=dbaron
...
MozReview-Commit-ID: 9rNUDK5t5jg
--HG--
extra : rebase_source : 2a852efe3f9801884e558f22ae7d9550fae87836
2016-08-23 09:29:45 +10:00
Nicholas Nethercote
b71747b2ac
Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
...
The new name makes the sense of the condition much clearer. E.g. compare:
NS_WARN_IF_FALSE(!rv.Failed());
with:
NS_WARNING_ASSERTION(!rv.Failed());
The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Ravi Shankar
149cb6c819
Bug 1297982 - Replace NS_STYLE_BOX_DECORATION_BREAK_* with enum class; r=xidorn
...
MozReview-Commit-ID: 9Cli68UpKdz
--HG--
extra : rebase_source : aa43e54c5e5501cbfee29437c5fcfc0216823bd8
2016-08-26 12:44:32 +05:30
Ting-Yu Lin
40fcd21b9a
Bug 1277129 Part 7b - Rename various ReflowState variables to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -r "s/$1/$2/g" "{}" \;
}
rename "([[:alpha:]]*)([rR])eflowState(s?)" "\1\2eflowInput\3"
MozReview-Commit-ID: ITFO7uMTkSb
--HG--
extra : rebase_source : c91a2e174a0baec60c1b0111ac7636295004ab35
2016-07-21 18:36:39 +08:00
Ting-Yu Lin
4053c4c028
Bug 1277129 Part 5c - Rename nsHTMLReflowMetrics to ReflowOutput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename "nsHTMLReflowMetrics" "ReflowOutput"
MozReview-Commit-ID: 2HBb7DkooH5
--HG--
extra : rebase_source : acfa442a6483772fcb5748dc6f5e7072e599032a
2016-07-21 18:36:38 +08:00
Ting-Yu Lin
820f88de49
Bug 1277129 Part 1c - Rename nsHTMLReflowState to ReflowInput. r=dbaron
...
This patch is generated by the following script:
function rename() {
find .\
-type f\
! -path "./obj*"\
! -path "./.git"\
! -path "./.hg"\
\( -name "*.cpp" -or\
-name "*.h" \)\
-exec sed -i -e "s/$1/$2/g" "{}" \;
}
rename nsHTMLReflowState ReflowInput
MozReview-Commit-ID: 9r9vdVv1pXc
--HG--
extra : rebase_source : 623ec822996ba0ea0058dd137acf5a658cdea04a
2016-07-21 18:36:35 +08:00
Ting-Yu Lin
29eadce873
Bug 1264837 Part 11 - Remove nsRubyFrameSuper. r=dholbert
...
MozReview-Commit-ID: ISa4OpM0x8i
--HG--
extra : rebase_source : 6d5f5f92ab636cdb9a857dca955816d7b7dfccdb
2016-04-18 14:11:08 +08:00
Xidorn Quan
dd663b590f
Bug 1229437 part 2 - Reparent floats inside pulled ruby segment. r=dbaron
...
--HG--
extra : source : c30d0f07b5597005de4d18838479e621b6d2f44e
2016-01-27 16:58:53 +11:00
Xidorn Quan
1ed71b2fe7
Backed out 8 changesets (bug 1225018, bug 1229278, bug 1224013
) for reftest failures on CLOSED TREE
...
--HG--
extra : amend_source : ee1d38ab6715e193cb1462614b3395c96ca06a0c
extra : histedit_source : 65b6dcb58b89c3cbcfe9a47834baf3181a2990c8%2Cc19e313c6800de1a1906c0db2f2bd4680fe67b78
2015-12-04 13:08:17 +11:00
Xidorn Quan
45ebb9aa0e
Bug 1224013
part 2 - Move leading fix to ruby base container. r=dholbert
...
Per spec, the additional leading is added on side of ruby base container, not
ruby container. This could lead to some trivial behavior changes on edge cases.
--HG--
extra : source : 495e466ebdb628fecd9a546b539001ac316fc133
2015-12-04 12:02:41 +11:00
Jonathan Kew
4e6c40d7ea
Bug 1131451 part 1 - Replace containerWidth with containerSize in logical-coordinate classes and APIs, frame classes, etc. r=dholbert
2015-07-16 10:07:57 +01:00
Xidorn Quan
59d1864c8a
Bug 1141931 part 7 - Move [Auto]RubyTextContainerArray to RubyUtils and merge RubyTextContainerIterator into AutoRubyTextContainerArray. r=dholbert
...
--HG--
extra : source : 89ae2f9a195fe10f4db19d0a51fd3ec7bafb0ecc
2015-04-08 11:22:34 +12:00
Xidorn Quan
966ef97045
Bug 1141931 part 6 - Move Ruby{Segment,Column}Enumerator to RubyUtils. r=dholbert
...
--HG--
extra : source : 2327584c7a0740617388bc544d2bb8433d034fe7
2015-04-08 11:22:34 +12:00
Xidorn Quan
9576de22a9
Bug 1141931 part 2 - Eliminate writing-mode mismatch in ruby reflow. r=dholbert
...
--HG--
extra : source : f74929af31891aa223da8a7d0ff01d9ccd19cacd
2015-04-08 11:22:34 +12:00
Wes Kocher
74f58c915e
Backed out 10 changesets (bug 1141931) for mochitest-5 failures CLOSED TREE
...
Backed out changeset c90940067de6 (bug 1141931)
Backed out changeset 96b48288abab (bug 1141931)
Backed out changeset 87281c7ded34 (bug 1141931)
Backed out changeset 6a914ba0b8ec (bug 1141931)
Backed out changeset 9cfea55b5e95 (bug 1141931)
Backed out changeset f432612b6475 (bug 1141931)
Backed out changeset 48cf9568a4b1 (bug 1141931)
Backed out changeset f1ab848b3fa6 (bug 1141931)
Backed out changeset 8a3c71a3b525 (bug 1141931)
Backed out changeset 119d3c0fd0f6 (bug 1141931)
2015-04-07 14:23:57 -07:00
Xidorn Quan
53a7f5a9f8
Bug 1141931 part 7 - Move [Auto]RubyTextContainerArray to RubyUtils and merge RubyTextContainerIterator into AutoRubyTextContainerArray. r=dholbert
...
--HG--
extra : source : 89ae2f9a195fe10f4db19d0a51fd3ec7bafb0ecc
2015-04-08 08:40:31 +12:00
Xidorn Quan
1bbf61d898
Bug 1141931 part 6 - Move Ruby{Segment,Column}Enumerator to RubyUtils. r=dholbert
...
--HG--
extra : source : 2327584c7a0740617388bc544d2bb8433d034fe7
2015-04-08 08:40:31 +12:00
Xidorn Quan
3d1eed1f20
Bug 1141931 part 2 - Eliminate writing-mode mismatch in ruby reflow. r=dholbert
...
--HG--
extra : source : f74929af31891aa223da8a7d0ff01d9ccd19cacd
2015-04-08 08:40:31 +12:00
Xidorn Quan
d6b37bd85a
Bug 1146114 - Make assertion checking additional leading in ruby frame non-crash. r=dholbert
...
--HG--
extra : source : 3540e92c7f860c6b314abe7169adaab0f2f5c009
2015-03-31 16:30:29 +11:00
Mats Palmgren
ed9ed2d61a
Bug 1148833 part 3 - Remove nsIFrame::WillReflow and add a non-virtual MarkInReflow method instead that sets NS_FRAME_IN_REFLOW. Call it at the start of Reflow(). r=roc
2015-03-29 22:38:40 +00:00
Cameron McCormack
04722fa8f9
Bug 1120300 - Export WritingModes.h as mozilla/WritingModes.h. r=jfkthame
2015-03-26 18:29:31 +11:00
Xidorn Quan
b5c74cb24b
Bug 1141928 part 1 - Correct the position of ruby text containers in RTL text. r=jfkthame
...
This patch uses the logical version of FinishReflowChild instead, so that we are able to keep the consistent logical rect, and then fix the rect with correct container width after the whole line is reflowed.
--HG--
extra : source : e944e283799cd04b87c1ed52a3fca68174bf4439
2015-03-14 16:46:33 +11:00
Xidorn Quan
b806fae66c
Bug 1141928 part 0 - Change line relative dir mapping code to return LogicalSide instead of physical side. r=jfkthame
...
This also fixes the line relative dir mapping code for inline axis direction.
--HG--
extra : source : 49a69e2193006dd6571765af0f6e464af9fec5b4
2015-03-14 16:46:33 +11:00
Xidorn Quan
e69dae05cd
Bug 1134432 part 2 - Fix basic inline min/pref isize calculation of ruby frames. r=dbaron
...
--HG--
extra : source : 8a18d6dbbac5c01907664eb114338f3afc7353f5
2015-02-22 00:39:33 +13:00
Xidorn Quan
a9545c0e64
Bug 1123917 part 2 - Make ruby-position only accept [over|under] instead of compound values. r=dholbert
...
--HG--
extra : rebase_source : fe13f96fe7bc771dfd899bd7ac391f565899d26d
extra : source : 480c409240940afd5e4e6ce4cf995e5e1a26e640
2015-01-22 14:04:55 +11:00
Xidorn Quan
b6f10f748e
Bug 1055667 part 6 - Fix border/padding of ruby frame. r=dbaron
...
--HG--
extra : source : 42391b99e060a7b3c4e281ce2a4fda77cb3e4efc
2015-01-15 20:02:11 +11:00
Xidorn Quan
e2198398db
Bug 1055667 part 5 - Make nsRubyFrame inherit nsInlineFrame. r=dbaron
...
--HG--
extra : source : 2ebca66c36f692cf29cbeb1eb64c6760bb75847c
2015-01-15 20:02:11 +11:00
Xidorn Quan
1bf1df7b1e
Bug 1055667 part 2 - Remove unnecessary param of SetBSizeFromFontMetrics. r=dbaron
...
--HG--
extra : source : aa79c8cebf3e2ab0fd4335eaa3c630a43dbe81f2
2015-01-15 20:02:11 +11:00
Xidorn Quan
7969797ad3
Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron
...
--HG--
extra : source : 27e60ddbd077439dadd09641ab54fc7eef09c69f
2015-01-13 20:04:41 +11:00
Nigel Babu
053a7d3408
Backed out 4 changesets (bug 1055658) for M5 bustage on a CLOSED TREE
...
Backed out changeset 3cbd9323c896 (bug 1055658)
Backed out changeset 99e071295c42 (bug 1055658)
Backed out changeset 55119d19e4c5 (bug 1055658)
Backed out changeset e82f640cb53f (bug 1055658)
2015-01-12 10:43:11 +05:30
Xidorn Quan
6ba35e648b
Bug 1055658 part 4 - Revert RubyReflowState. r=dbaron
...
--HG--
extra : source : 27e60ddbd077439dadd09641ab54fc7eef09c69f
2015-01-12 14:31:55 +11:00
Xidorn Quan
bfb0d2cc6e
Bug 1069519 part 2 - Make line height calculation be aware of ruby annotations. r=dholbert
...
--HG--
extra : source : e8c8f94afde330276b5d907520d93da10e8f998c
2015-01-08 16:02:41 +11:00
Xidorn Quan
fed49743f0
Bug 1116688 - Always try to push children after reflowing an incomplete ruby segment. r=dbaron
...
--HG--
extra : rebase_source : eddbedeaf484513da0789ec73d82801d55234d69
extra : source : afabc75550c1c5b3e8ce4b375cd0b5bb6a30fb21
2015-01-07 12:47:09 +11:00
Xidorn Quan
58fd48c4de
Bug 1116631 - Fix isize reservation of ruby base container. r=roc
...
--HG--
extra : rebase_source : efc67e14e7e6bbc2b6ba736b09780a9e507b122e
extra : source : 86371e41d07bab00c6cd04b236d194fa312b99c4
2015-01-07 12:47:09 +11:00
Xidorn Quan
b71f548568
Bug 1116037 part 12 - Move mLineSize to RubyReflowState. r=dbaron
...
--HG--
extra : source : 17ad55f13af3e96df7649f968c838bc48b323c68
2014-12-30 11:20:10 +11:00
Xidorn Quan
3013e06e68
Bug 1116037 part 11 - Add RubyReflowState for sharing states between ruby level boxes. r=dbaron
...
--HG--
extra : source : c4f342ece9c1548053348dbc317d9857cbe790b6
2014-12-30 11:16:30 +11:00
Xidorn Quan
eb1ae2b722
Bug 1116037 part 9 - Move ruby text container arrays to stack. r=dbaron
...
--HG--
extra : source : 6c5d7212c3f8c355b4667aa46024dfef0710ca8e
2014-12-30 09:56:34 +11:00
Xidorn Quan
7368bd2654
Bug 1116037 part 1 - Move TextContainerIterator to RubyUtils. r=dbaron
...
--HG--
extra : source : 2953b34d3cc05a3f34edb3d775821e81c798b77b
2014-12-29 11:14:53 +11:00
Chris Peterson
c26e697150
Bug 1115264 - Fix -Wsometimes-uninitialized clang warning in nsRubyFrame.cpp. r=dholbert
2014-12-23 21:29:32 -08:00
Xidorn Quan
0dea205772
Bug 1055665 part 4 - Position text containers according to ruby-position. r=dholbert
...
--HG--
extra : source : 434cf70e300dcf9985e013a0a76703972804b02a
2014-12-17 19:42:32 +11:00
Ehsan Akhgari
b35004b3cd
Bug 1109705 - Fix more bad implicit constructors in layout; r=roc
2014-12-10 17:47:09 -05:00
Xidorn Quan
d5c26883a2
Bug 1093998 - Make nsContainerFrame::CreateNextInFlow return the new frame instead of using an our param. r=dbaron
2014-12-01 22:03:57 -08:00
Xidorn Quan
e464df4013
Bug 1052924 - Implement basic line breaking for ruby. r=dbaron
...
Known problem:
It would cause infinite loop if there is any line break happens inside
ruby base or annotation, or the width of container is not enough for
the widest pair/span. This might be fixed in bug 1098272.
2014-11-26 15:52:50 +11:00
Xidorn Quan
5f4cd8dd0b
Bug 1052924 - Separate reflow code. r=dbaron
2014-11-26 15:52:50 +11:00
Xidorn Quan
43f5510c25
Bug 1052924 - Give rbc & rtc correct position. r=dbaron
...
Important changes:
* Use line layout to reflow ruby base container
2014-11-26 15:52:49 +11:00
Xidorn Quan
d25178b0db
Bug 1052924 - Resolve some warnings. r=dbaron
...
Important changes:
* Change base class of nsRuby{Base,Text}Frame to nsInlineFrame
* Make ComputeSize of nsRubyFrame and nsRubyBaseContainerFrame behavior like inline frames
2014-11-26 15:52:49 +11:00
Xidorn Quan
458a202ef8
Bug 1052924 - Use unified enumerators to simplify code. r=dbaron
2014-11-26 15:52:48 +11:00
Xidorn Quan
9b0f833e9c
Bug 1052924 - Rewrite pref isize and min isize computation. r=dbaron
...
Known regression:
This patch changes AppendTextContainer, and put aside text containers
which contain spanning annotations. This changes makes those text
containers not be reflowed by the current code. It will be fixed in
some later patch.
2014-11-26 15:52:48 +11:00