Commit Graph

5685 Commits

Author SHA1 Message Date
Lina Cambridge
397d3a1156 Bug 1583413 - Fetch the Send Tab target list from FxA, not Sync. r=markh,eoger
Instead of using the list of FxA devices from the Sync clients engine,
we now fetch the list of Send Tab devices from FxA. This works like
this:

* `FxAccountsDevice#getDeviceList` has been split up into
  `recentDeviceList` and `refreshDeviceList`.
* `recentDeviceList` synchronously returns the last fetched list, so
  that consumers like Send Tab can use it right away.
* `refreshDeviceList` is asynchronous, and refreshes the last fetched
  list. Refreshes are limited to once every minute by default, matching
  the minimum sync interval (Send Tab passes the `ignoreCached` option
  to override the limit if the user clicks the "refresh" button).
  Concurrent calls to `refreshDeviceList` are also serialized, to
  ensure the list is only fetched once.
* The list is flagged as stale when a device is connected or
  disconnected. It's still kept around, but the next call to
  `refreshDeviceList` will fetch a new list from the server.
* The Send Tab UI refreshes FxA devices in the background. Matching FxA
  devices to Sync client records is best effort; we don't do it if Sync
  isn't configured or hasn't run yet. This only impacts the fallback
  case if the target doesn't support FxA commands.

Differential Revision: https://phabricator.services.mozilla.com/D47521

--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:55 +00:00
Lina Cambridge
51e03623ee Bug 1583413 - Move device-related methods into FxAccountsDevice.jsm. r=eoger
This commit contains no functional changes, just moving code around to
make the next patch in this series easier to write.

Differential Revision: https://phabricator.services.mozilla.com/D47520

--HG--
extra : moz-landing-system : lando
2019-10-03 22:40:41 +00:00
ffxbld
9238ced3bb No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D48055

--HG--
extra : moz-landing-system : lando
2019-10-03 13:40:24 +00:00
Mark Hammond
47380e1a34 Bug 1581980 - change the text of many Sync notifications so they aren't Sync specific. r=flod,eoger
Differential Revision: https://phabricator.services.mozilla.com/D47853

--HG--
extra : moz-landing-system : lando
2019-10-03 05:52:58 +00:00
Mark Hammond
51a55ec4ba Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D47861

--HG--
extra : moz-landing-system : lando
2019-10-03 01:18:09 +00:00
Bogdan Tara
11b09d510c Backed out changeset 961eac228e3e (bug 1585299) for ES Lint failures on FxAccounts.jsm && test_accounts.js CLOSED TREE 2019-10-02 09:41:37 +03:00
Mark Hammond
c0a71bf7f1 Bug 1585299 - ensure only 1 fxaccounts:onverified notification when a new account verifies. r=lina
Differential Revision: https://phabricator.services.mozilla.com/D47861

--HG--
extra : moz-landing-system : lando
2019-10-02 06:03:39 +00:00
Mark Hammond
499384cb8e Bug 1585211 - Have TPS enable sync when the test user logs in. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D47714

--HG--
extra : moz-landing-system : lando
2019-10-01 00:32:01 +00:00
ffxbld
8a664f77d8 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D47597

--HG--
extra : moz-landing-system : lando
2019-09-30 13:11:37 +00:00
ffxbld
c9b081d8c9 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D47244

--HG--
extra : moz-landing-system : lando
2019-09-26 14:33:06 +00:00
Mark Hammond
4b629788b2 Bug 1570567 - update about:preferences#sync to reflect the decoupling of FxA and Sync. r=Gijs,eoger,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D46574

--HG--
extra : moz-landing-system : lando
2019-09-26 10:48:22 +00:00
Mark Hammond
7ec2097ae8 Bug 1582633 - allow an FxA user to be signed in without sync being enabled. r=eoger,lina
Differential Revision: https://phabricator.services.mozilla.com/D46572

--HG--
extra : moz-landing-system : lando
2019-09-25 06:51:18 +00:00
Geoff Brown
dcb380399e Bug 1582785 - Enable some xpcshell tests on Android; r=geckoview-reviewers,agi
Most of these tests have been disabled for a long time; they run well
in the current test environment.

Differential Revision: https://phabricator.services.mozilla.com/D46642

--HG--
extra : moz-landing-system : lando
2019-09-23 22:43:55 +00:00
Edouard Oger
5431bbfab3 Bug 1547120 - Add a method to list attached clients. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D46838

--HG--
extra : moz-landing-system : lando
2019-09-23 20:43:56 +00:00
ffxbld
bdeece726d No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D46777

--HG--
extra : moz-landing-system : lando
2019-09-23 13:09:04 +00:00
Edouard Oger
7f39ae82a2 Bug 1582542 - Use getUserAccountData in FxA commands invoke. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46511

--HG--
extra : moz-landing-system : lando
2019-09-19 19:51:41 +00:00
ffxbld
959ff7f82f No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D46469

--HG--
extra : moz-landing-system : lando
2019-09-19 14:37:28 +00:00
Edouard Oger
3017be71f8 Bug 1582537 - Call getScopedKeys on keys field. r=vladikoff
Differential Revision: https://phabricator.services.mozilla.com/D46509

--HG--
extra : moz-landing-system : lando
2019-09-19 19:28:48 +00:00
Mark Hammond
7531325c86 Bug 1582023 - Replace "sync disconnect" dialog and local data removal with simple confirmation dialog. r=eoger,flod,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D46253

--HG--
extra : moz-landing-system : lando
2019-09-19 05:59:51 +00:00
Mark Hammond
140dc3f765 Bug 1578217 - remove the sync 'yellow state' telemetry. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D45765

--HG--
extra : moz-landing-system : lando
2019-09-19 00:34:04 +00:00
Ehsan Akhgari
1ba181f8bf Bug 1581160 - Prepackage url-classifier-skip-urls into the binaries; r=leplatrem,glasserc
Differential Revision: https://phabricator.services.mozilla.com/D45871

--HG--
extra : moz-landing-system : lando
2019-09-13 16:26:57 +00:00
Edouard Oger
a6c404619f Bug 1570569 p2 - Add Sync Disabled state to Synced Tabs sidebar. r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D44485

--HG--
extra : moz-landing-system : lando
2019-09-10 18:23:31 +00:00
Edouard Oger
926c5d067c Bug 1570569 p1 - Add Sync Disabled state to Synced Tabs menu. r=vbudhram,fluent-reviewers,flod,markh
Differential Revision: https://phabricator.services.mozilla.com/D44484

--HG--
extra : moz-landing-system : lando
2019-09-11 01:17:46 +00:00
ffxbld
5af1f73d04 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D45662

--HG--
extra : moz-landing-system : lando
2019-09-12 13:37:51 +00:00
Mark Hammond
0203cd1dd5 Bug 1574048 - Remove FxAccounts internal/external/Object.freeze()/ weirdness. r=lina,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D44083

--HG--
extra : moz-landing-system : lando
2019-09-12 02:08:50 +00:00
Mark Hammond
e074186422 Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D43897

--HG--
extra : moz-landing-system : lando
2019-09-11 01:37:50 +00:00
Bogdan Tara
0f5e9e5206 Backed out changeset 93d2d4bbe263 (bug 1575921) for xpcshell failures on test_device.js CLOSED TREE 2019-09-10 04:42:15 +03:00
Mark Hammond
15535c9309 Bug 1575921 - store the FxA device ID in an FxA-specific pref branch. r=eoger
Differential Revision: https://phabricator.services.mozilla.com/D43897

--HG--
extra : moz-landing-system : lando
2019-09-10 00:09:52 +00:00
ffxbld
426de7d9bd Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2019-09-02 09:00:31 +00:00
ffxbld
3b375c8b7b No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D43967

--HG--
extra : moz-landing-system : lando
2019-08-29 13:14:59 +00:00
Mathieu Leplatre
43084d5e54 Bug 1577218 - Upgrade kinto-offline-client to 12.7.0 r=glasserc
Differential Revision: https://phabricator.services.mozilla.com/D43773

--HG--
extra : moz-landing-system : lando
2019-08-28 16:08:29 +00:00
Sylvestre Ledru
d264b841c9 Bug 1576502 - Fix some wording issues r=mhoye
Differential Revision: https://phabricator.services.mozilla.com/D43363

--HG--
extra : moz-landing-system : lando
2019-08-27 15:38:58 +00:00
Luca Greco
b2c8b8875b Bug 1572711 - Record extensions.blocklist.useXML and services.blocklist.*.checked prefs into new telemetry scalars. r=janerik,leplatrem,Gijs
Depends on D41734

Differential Revision: https://phabricator.services.mozilla.com/D41735

--HG--
extra : moz-landing-system : lando
2019-08-22 16:32:19 +00:00
ffxbld
409e5b7a75 No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D43052

--HG--
extra : moz-landing-system : lando
2019-08-22 13:43:50 +00:00
Mark Hammond
c2a3916396 Bug 1574382 - use yaml to parse TPS tests. r=tcsc
Differential Revision: https://phabricator.services.mozilla.com/D42263

--HG--
extra : moz-landing-system : lando
2019-08-19 20:55:05 +00:00
Ciure Andrei
9a123fb597 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan
240771fa29 Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614

--HG--
extra : moz-landing-system : lando
2019-08-19 07:17:12 +00:00
Mark Banner
b1970e6a2f Bug 1571466 - Cleanup unnecessary ESLint global definitions. r=mossop
These are raised as redeclares or unused variables by ESLint 6.

Differential Revision: https://phabricator.services.mozilla.com/D37268

--HG--
extra : moz-landing-system : lando
2019-08-19 07:11:56 +00:00
Lina Cambridge
a17323e9d8 Bug 1573709 - Return an aborted watchdog for testing interrupted bookmark merges. a=testonly
Differential Revision: https://phabricator.services.mozilla.com/D41876

--HG--
extra : moz-landing-system : lando
2019-08-14 00:28:52 +00:00
Lina Cambridge
65dfa84ccd Bug 1573305 - Remove the check for unmerged synced bookmark changes. r=markh
When a local or remote item changed, we'd potentially scan three tables
(with an expensive `LEFT JOIN`!) to check if anything changed...then
scan the same tables again to build the local and remote trees. This
check was originally meant to avoid unnecessary merges. However, the
bottleneck isn't merging now; it's reading from the database.

Since the merger has been rewritten in Rust, is synchronous, doesn't
keep a transaction open for the entire merge (see the
`total_sync_changes` check), and only emits ops for items that actually
changed, it's more efficient to build and merge optimistically, and
bail before applying if nothing changed.

This commit also moves `validateLocalRoots` into Rust.

Differential Revision: https://phabricator.services.mozilla.com/D41690

--HG--
extra : moz-landing-system : lando
2019-08-13 22:58:16 +00:00
Lina Cambridge
19557885f6 Bug 1572615 - Abort bookmark merges that take longer than 5 minutes. r=markh
This commit introduces a new `Watchdog` class that signals an abort,
either after a delay or at shutdown, and wires up the buffered engine
to use it.

Differential Revision: https://phabricator.services.mozilla.com/D41311

--HG--
extra : moz-landing-system : lando
2019-08-13 18:48:25 +00:00
ffxbld
21d02cb6fe No Bug, mozilla-central repo-update HSTS HPKP blocklist remote-settings tld-suffixes - a=repo-update r=RyanVM
Differential Revision: https://phabricator.services.mozilla.com/D41541

--HG--
extra : moz-landing-system : lando
2019-08-12 13:08:23 +00:00
Nicholas Nethercote
41a012cce7 Bug 1572621 - Merge services-sync.js into all.js. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D41323

--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:41 +00:00
Nicholas Nethercote
73d5a12400 Bug 1572621 - Merge services-common.js into all.js. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D41322

--HG--
extra : moz-landing-system : lando
2019-08-09 09:18:27 +00:00
Lina Cambridge
0d63b1e98f Bug 1498073 - Use centisecond precision for modified times in Sync tests. a=testonly
Differential Revision: https://phabricator.services.mozilla.com/D41266

--HG--
extra : moz-landing-system : lando
2019-08-08 19:19:47 +00:00
Jared Wein
22ae3511f6 Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D40878

--HG--
extra : moz-landing-system : lando
2019-08-08 15:18:36 +00:00
Bogdan Tara
844afcfb06 Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Jared Wein
9cf685253f Bug 1571567 - Fix no-fallthrough errors in /services. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D40878

--HG--
extra : moz-landing-system : lando
2019-08-08 01:38:51 +00:00
Mark Hammond
05df0254b8 Bug 1568353 - set the default rest.js timeout to be 5 minutes. r=rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D40927

--HG--
extra : moz-landing-system : lando
2019-08-07 05:25:49 +00:00
Mark Hammond
40d28c338b Bug 1561762 - better handle concurrent requests for FxA oauth tokens. r=eoger,rfkelly
Differential Revision: https://phabricator.services.mozilla.com/D38036

--HG--
extra : moz-landing-system : lando
2019-08-06 15:25:05 +00:00