Commit Graph

18 Commits

Author SHA1 Message Date
Alex Chronopoulos
9cce351cdc Bug 1596528 - Get the statistics under the same mutex to avoid inconsistency. r=padenot
Get all the statistics in one call, under the same mutex, and extract from them the decoded and total frames. The individual getters were previously used, created uncertainty since they lock the mutex separately.

Differential Revision: https://phabricator.services.mozilla.com/D75096
2020-05-14 16:36:19 +00:00
Simon Giesecke
88ead5d627 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/media. r=padenot
Differential Revision: https://phabricator.services.mozilla.com/D65178

--HG--
extra : moz-landing-system : lando
2020-03-04 15:39:20 +00:00
Tarek Ziadé
7f4b636f4f Bug 1543032 - Extend metrics for dropped frames - r=padenot
This patch adds the number of dropped frames for each step of the process
(read/sink/compositor) and gives us more insight about where frames are
dropped, as opposed to the getVideoPlaybackQuality() API which gives the grand
total.

Differential Revision: https://phabricator.services.mozilla.com/D27488

--HG--
extra : moz-landing-system : lando
2019-04-16 11:50:38 +00:00
Sylvestre Ledru
804b8b8883 Bug 1204606 - Reformat of dom/media r=jya
# skip-blame

Differential Revision: https://phabricator.services.mozilla.com/D12251

--HG--
extra : moz-landing-system : lando
2018-11-19 13:25:37 +00:00
Jean-Yves Avenard
df2e2243b9 Bug 1485536 - Don't account frames dropped by the compositor as presented. r=bryce
We rename a method in FrameStatistics to better match what it's actually doing.

Differential Revision: https://phabricator.services.mozilla.com/D4213

--HG--
extra : moz-landing-system : lando
2018-08-27 10:27:19 +00:00
Csoregi Natalia
15876458af Backed out changeset 8c8ff2c7bfa1 (bug 1485536) for crashes at VideoSink. CLOSED TREE 2018-08-26 00:15:16 +03:00
Jean-Yves Avenard
5ab3282a07 Bug 1485536 - Don't account frames dropped by the compositor as presented. r=bryce
We rename a method in FrameStatistics to better match what it's actually doing.

Differential Revision: https://phabricator.services.mozilla.com/D4213

--HG--
extra : moz-landing-system : lando
2018-08-25 12:39:29 +00:00
Andreea Pavel
73467d18e1 Backed out changeset 1dc785e713d9 (bug 1485536) for assertion failure at z:/build/build/src/dom/media/mediasink/VideoSink.cpp on a CLOSED TREE 2018-08-24 21:10:59 +03:00
Jean-Yves Avenard
3b4c682a62 Bug 1485536 - Don't account frames dropped by the compositor as presented. r=bryce
We rename a method in FrameStatistics to better match what it's actually doing.

Differential Revision: https://phabricator.services.mozilla.com/D4213

--HG--
extra : moz-landing-system : lando
2018-08-24 14:26:14 +00:00
JW Wang
709010e3e9 Bug 1378295. P2 - move AutoNotifyDecoded from AbstractMediaDecoder to FrameStatistics. r=jya
MozReview-Commit-ID: EdS2U2sfPdk

--HG--
extra : rebase_source : 786439f7fc7b9ed0904faf383a8e1ff0ccf35311
extra : intermediate-source : 3587a73488e07e13ccd0bc540cd814b5ee3210d9
extra : source : dcd94df0c7577e8c28d913d7061384650955d69f
2017-07-13 15:17:25 +08:00
Gerald Squelart
2a787d2521 Bug 1289668 - Record inter-keyframe statistics - r=kamidphish
FrameStatisticsData can now store inter-keyframe information, which is
provided by the MediaFormatReader (based on live decoding).

MozReview-Commit-ID: HhBy6pgT6ZX

--HG--
extra : rebase_source : 6a072623e8a5b0f23b81307e8ea4b19a3e21b252
2016-07-26 09:36:55 +10:00
Gerald Squelart
7bea2e1262 Bug 1289668 - Refactor FrameStatistics writers to use Data struct - r=kamidphish
Decoders now use FrameStatisticsData to gather data for their frame-related
notifications. This will ease introducing new members later on.

MozReview-Commit-ID: DWdOSPX3JM

--HG--
extra : rebase_source : a3e05f34353a397d1c82b3f4d935c0864f90556e
2016-07-18 10:41:40 +10:00
Gerald Squelart
16ceda9794 Bug 1289668 - Use 64 bits to store FrameStatistics values - r=kamidphish
Decoders uses 64-bit values to count frames, so we should use the same type
in FrameStatistics.

Because VideoPlaybackQuality can only use 32 bits (as defined in W3C specs),
we need to ensure that imported FrameStatistics numbers can fit in 32 bits,
while keeping their ratios the same.

MozReview-Commit-ID: 3pUTGK0ekGv

--HG--
extra : rebase_source : 627fada111b51b8830fd38bf6d60a79b899ce603
2016-07-18 10:51:30 +10:00
Gerald Squelart
9448bd8536 Bug 1289668 - Refactor FrameStatistics - r=kamidphish
Move FrameStatistics' data into separate struct, so that it can more easily be
changed and passed around, outside of the lock-controlled FrameStatistics
object.

MozReview-Commit-ID: TfsMRJhVfQ

--HG--
extra : rebase_source : 8c4c6a23c8c2d6ff4272f9f918c9510326691148
2016-07-18 09:51:25 +10:00
Gerald Squelart
56c9933215 Bug 1289668 - FrameStatistics style - r=kamidphish
MozReview-Commit-ID: B9yEd7tqfAN

--HG--
extra : rebase_source : 3b1bfd11c604f9e57321c842f4893192ca9b77b5
2016-07-15 16:48:56 +10:00
Matt Woodrow
fd534aefc7 Bug 1257013 - Part 3: Stop checking for corrupt frames in MediaDecoderStateMachine since we no longer produce them. r=ajones
--HG--
extra : rebase_source : a68da2757970cd28da5719d77e3036f9051041e5
2016-03-21 18:50:41 +13:00
JW Wang
a62c25461b Bug 1230004. Part 1 - cache data in MDSM so it won't need to ask MediaDecoder. r=cpearce. 2015-12-03 15:59:30 +08:00
Kilik Kuo
90420c357e Bug 1204882 - Move MediaDecoder::FrameStatistics out of MediaDecoder for easier use in other classes. r=jwwang
--HG--
extra : transplant_source : 3%E1%C1%3B%B5%8B%82%20%DF%AE%1A%21%E0f%FF%7C%3C%0EF%10
2015-09-15 22:57:20 +08:00