576 Commits

Author SHA1 Message Date
Mark Banner
cd561394de Bug 1875244 - Enable more rules on dom/xml, dom/xslt and dom/xul. r=peterv
Differential Revision: https://phabricator.services.mozilla.com/D198935
2024-01-29 18:23:52 +00:00
Mark Banner
30b1ef027d Bug 1876988 - Enable remaining ESLint rules on dom/file/ipc. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D199813
2024-01-29 11:23:59 +00:00
Mark Banner
2cdfd413a4 Bug 1876988 - Enable ESLint rules no-undef and no-unused-vars. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D199812
2024-01-29 11:23:59 +00:00
Mike Conley
c6a25b888c Bug 1874276 - Convert PlacesFeed into an ESM. r=thecount,places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D199360
2024-01-26 00:29:59 +00:00
Daisuke Akatsuka
c051aa567d Bug 1849866: Rename moz-anno:favicon protocol to cached-favicon r=necko-reviewers,places-reviewers,valentin,mak
Differential Revision: https://phabricator.services.mozilla.com/D198130
2024-01-24 22:05:42 +00:00
Mark Banner
80ddb3d9c2 Bug 1875027 - Remove deprecated ESLint rule no-return-await. r=mossop
Eslint has now deprecated the rule.

Depends on D198777

Differential Revision: https://phabricator.services.mozilla.com/D198778
2024-01-17 09:51:30 +00:00
Mark Banner
a8abfad9b0 Bug 1875026 - Enable ESLint rules on more dom/ directories where the rules are already passing. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D198777
2024-01-17 09:51:29 +00:00
Mark Banner
e7a36c96d7 Bug 1866589 - Enable ESLint rule consistent-return on all of dom/*. r=dom-core,jgilbert,dom-worker-reviewers,mccr8,smaug
Differential Revision: https://phabricator.services.mozilla.com/D194664
2024-01-16 20:45:42 +00:00
Mark Banner
81d120bb5a Bug 1866589 - Enable ESLint rule no-useless-call on all of dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D194663
2024-01-16 20:45:41 +00:00
Mark Banner
d60c2ab7a2 Bug 1866589 - Enable ESLint rule no-unreachable for dom/*. r=dom-core,dom-worker-reviewers,mccr8,smaug
Differential Revision: https://phabricator.services.mozilla.com/D194662
2024-01-16 20:45:41 +00:00
Mark Banner
7ee25543fe Bug 1866589 - Enable ESLint rule no-cond-assign on all of dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D194661
2024-01-16 20:45:41 +00:00
Mark Banner
63f984510a Bug 1866589 - Enable ESLint rules no-self-assign and no-self-compare on dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D194660
2024-01-16 20:45:40 +00:00
Mark Banner
b73606ba0e Bug 1866589 - Enable ESLint rule no-sequences on all of dom/. r=dom-core,webrtc-reviewers,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D194659
2024-01-16 20:45:40 +00:00
Mark Banner
c7947b6868 Bug 1872674 - Add an ESLint rule to reject new uses of Console.sys.mjs/Log.sys.mjs. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D197504
2024-01-16 13:37:07 +00:00
Oliver Medhurst
465206f92c Bug 1793560 - Remove navigate-to CSP directive r=tschuster
It has never shipped after being implemented years ago,
and was removed from spec in September 2022:
https://github.com/w3c/webappsec-csp/pull/564

Now skipping navigate-to WPT tests. Filed issue upstream for their future removal:
https://github.com/w3c/webappsec-csp/issues/608
Consensus seems to agree to remove, will do in follow up bug once landed.

Also removed our own tests.

Added a hack in StartDocumentLoad as just removing the navigate-to check call
breaks some inhertiance, see comment for more info.

Differential Revision: https://phabricator.services.mozilla.com/D181630
2024-01-03 16:43:12 +00:00
Mike Conley
9415a9f13d Bug 1866802 - Move ASRouterAdmin tool to about:asrouter and its own component folder. r=pdahiya,Gijs,desktop-theme-reviewers,dao
This tries to maintain stylistic continuity, while also trying to decouple from
newtab as much as possible. This is a first foray, and future patches will
further this decoupling.

This also modifies about:asrouter to show an error message if the ASRouter devtools
pref is not set to true.

Differential Revision: https://phabricator.services.mozilla.com/D194811
2023-12-14 18:46:55 +00:00
Butkovits Atila
8582db0ea5 Backed out 5 changesets (bug 1866802) for causing failures at test_TopSitesFeed.js. CLOSED TREE
Backed out changeset af9fbbc9ae50 (bug 1866802)
Backed out changeset 81d5b7de7178 (bug 1866802)
Backed out changeset e4d0863ed222 (bug 1866802)
Backed out changeset c0deb681b193 (bug 1866802)
Backed out changeset dda3e5e39f8c (bug 1866802)
2023-12-14 03:22:48 +02:00
Mike Conley
4b9f3545e2 Bug 1866802 - Move ASRouterAdmin tool to about:asrouter and its own component folder. r=pdahiya,Gijs,desktop-theme-reviewers,dao
This tries to maintain stylistic continuity, while also trying to decouple from
newtab as much as possible. This is a first foray, and future patches will
further this decoupling.

This also modifies about:asrouter to show an error message if the ASRouter devtools
pref is not set to true.

Differential Revision: https://phabricator.services.mozilla.com/D194811
2023-12-13 23:29:48 +00:00
Mike Conley
059b8a1cb7 Bug 1868488 - Add aboutwelcome to the same ESLint directory overrides as newtab. r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D196056
2023-12-11 18:02:41 +00:00
Mike Conley
37abcde317 Bug 1863400 - Part 8: Update stylelint, eslint, prettierignore, hgignore, gitignore and Generated.txt rules for aboutwelcome to match newtab. r=pdahiya
This also re-runs npm install on browser/components/aboutwelcome to make sure everything in
package-lock.json is up-to-date.

Depends on D193122

Differential Revision: https://phabricator.services.mozilla.com/D193228
2023-11-28 01:37:38 +00:00
Jonas Jenwald
c3e7ecd99f Bug 1863716 - Remove the remnants of the unused PDF Viewer notification bar. r=pdfjs-reviewers,calixte
The PDF Viewer notification bar became unused in bug 1705327, which is well over two years ago, hence it seems reasonable to stop shipping this code when it's not being used.

Differential Revision: https://phabricator.services.mozilla.com/D193056
2023-11-08 19:34:52 +00:00
Mark Banner
6c63275a39 Bug 1861865 - Fix ESLint valid-jsdoc issues in various browser code and enable on directories where it is already passing. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192163
2023-11-01 17:20:41 +00:00
Mark Banner
de2cac32f4 Bug 1861865 - Fix ESLint valid-jsdoc issues in pictureinpicture code. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D192162
2023-11-01 17:20:41 +00:00
Mark Banner
1d0eba9d9f Bug 1861865 - Fix ESLint valid-jsdoc issues in UITour code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192161
2023-11-01 17:20:41 +00:00
Mark Banner
f846e0c0c6 Bug 1861865 - Fix ESLint valid-jsdoc issues in textrecognition.mjs. r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D192160
2023-11-01 17:20:40 +00:00
Mark Banner
772ab6e788 Bug 1861865 - Fix ESLint valid-jsdoc issues in syncedtabs code. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D192159
2023-11-01 17:20:40 +00:00
Mark Banner
af66712370 Bug 1861865 - Fix ESLint valid-jsdoc issues in protections code. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D192158
2023-11-01 17:20:39 +00:00
Mark Banner
c271e63264 Bug 1861865 - Fix ESLint valid-jsdoc issues in ion.js. r=rhelmer,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192157
2023-11-01 17:20:39 +00:00
Mark Banner
a82253732a Bug 1861865 - Fix ESLint valid-jsdoc issues in enterprise policy code. r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D192156
2023-11-01 17:20:39 +00:00
Mark Banner
a505a80fe2 Bug 1861865 - Fix ESLint valid-jsdoc issues in Firefox view code. r=sclements,fxview-reviewers,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D192155
2023-11-01 17:20:38 +00:00
Mark Banner
0088c604ff Bug 1844125 - Remove more bits of old translations code. r=gregtatum
Differential Revision: https://phabricator.services.mozilla.com/D192154
2023-10-30 16:20:55 +00:00
Gijs Kruitbosch
ffeedb34d2 Bug 1790354 - warn about using browser/ code from toolkit, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D191976
2023-10-30 15:29:47 +00:00
Cristian Tuns
7d2d3c884f Backed out changeset c66fc23f71d5 (bug 1790354) for causing doc-generate failures. CLOSED TREE 2023-10-27 13:06:04 -04:00
Gijs Kruitbosch
0825ad24e1 Bug 1790354 - warn about using browser/ code from toolkit, r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D191976
2023-10-27 15:02:09 +00:00
Mark Banner
833fc90714 Bug 1860988 - Enable all ESLint rules on the rest of dom/**/*.xhtml files that were renamed from xul. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D191850
2023-10-27 12:43:04 +00:00
Mark Banner
21e52b9399 Bug 1860988 - Enable ESLint rule object-shorthand on remaining parts of dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D191849
2023-10-27 12:43:04 +00:00
Mark Banner
6119729476 Bug 1860988 - Enable ESLint rule no-useless-return on all of dom/*. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D191848
2023-10-27 12:43:03 +00:00
Mark Banner
79b35cfc1b Bug 1858673 - Disable no-unsanitized/method and no-unsanitized/property on test files. r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D190984
2023-10-24 08:48:40 +00:00
Mark Banner
6cb634d207 Bug 1860428 - Enable ESLint rules no-undef and no-unused-vars on dom/media/webaudio/. r=karlt
Depends on D191582

Differential Revision: https://phabricator.services.mozilla.com/D191583
2023-10-24 08:10:11 +00:00
Mark Banner
00a991880a Bug 1860427 - Enable ESLint rules no-undef and no-unused-vars on dom/encoding/test/. r=dom-core,hsivonen
Depends on D191581

Differential Revision: https://phabricator.services.mozilla.com/D191582
2023-10-23 15:37:18 +00:00
Marco Bonardo
07741fd9ee Bug 1666092 - Change waitForLoadOrTimeout test helper to only check for load start. r=adw
Waiting for the full load sometimes will take more than the timeout, and we
don't really need to do it for the purpose of this helper.

Differential Revision: https://phabricator.services.mozilla.com/D190756
2023-10-13 09:18:20 +00:00
Mark Banner
1c781625ed Bug 1857866 - Enable ESlint rule mozilla/no-useless-removeEventListener on all of dom/. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D190439
2023-10-13 08:56:13 +00:00
Mark Banner
932bc23fe7 Bug 1857866 - Enable ESLint rule complexity on all of dom/. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D190438
2023-10-13 08:56:12 +00:00
Mark Banner
1ff32a5712 Bug 1857866 - Remove some unnecessary ESLint exclusions for dom files. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D190437
2023-10-13 08:56:12 +00:00
Mark Banner
fdc83bbfff Bug 1857866 - Enable ESLint rule mozilla/no-useless-parameters on all of dom/. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D190436
2023-10-13 08:56:12 +00:00
Mark Banner
e43869f6d6 Bug 1857866 - Enable ESLint rule mozilla/reject-importGlobalProperties on all of dom/. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D190434
2023-10-13 08:56:11 +00:00
Mark Banner
b75ce2775d Bug 1857866 - Enable mozilla/no-arbitrary-setTimeout on all of dom/. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D190433
2023-10-13 08:56:11 +00:00
Noemi Erli
e5c9fdc125 Backed out 6 changesets (bug 1857866) for causing mochitest failures in test_bug403852.html CLOSED TREE
Backed out changeset d3a20047a9d3 (bug 1857866)
Backed out changeset ac8e95c253a9 (bug 1857866)
Backed out changeset c2d4c9575248 (bug 1857866)
Backed out changeset 521a5e8cb17e (bug 1857866)
Backed out changeset 8d812ea48f5c (bug 1857866)
Backed out changeset de9146469632 (bug 1857866)
2023-10-13 00:27:57 +03:00
Mark Banner
d9dc6c946f Bug 1857866 - Enable ESlint rule mozilla/no-useless-removeEventListener on all of dom/. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D190439
2023-10-12 16:49:49 +00:00
Mark Banner
3357a854df Bug 1857866 - Enable ESLint rule complexity on all of dom/. r=dom-core,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D190438
2023-10-12 16:49:48 +00:00