Commit Graph

7 Commits

Author SHA1 Message Date
Andrew Halberstadt
2255a9eed7 Bug 1395126 - Support cascading configuration for flake8, r=bc
This allows .flake8 files to override one another, and fixes a pretty bad known
bug with our flake8 implementation. For example, say we have a .flake8 file at:
/foo/.flake8

Before this patch, if we ran |mach lint foo/bar|, the configuration defined in
that .flake8 file wouldn't get picked up. It would only work if running the
specific directory that contains it, e.g |mach lint foo|.

This change additionally allows multiple .flake8 files to be used. So if
there's one defined at both:
/.flake8
/foo/.flake8

Then running |mach lint foo/bar| will first apply the root .flake8, then the
one under /foo (overriding earlier configuration).

This bug still doesn't make flake8 configuration perfect though. Any directory
containing a .flake8 file still needs to be explicitly listed in the "include"
section of /tools/lint/flake8.yml. Otherwise in the example above, if running
|mach lint /|, it wouldn't be able to find /foo/.flake8. This is a hard problem
and is likely best solved by fixing flake8's upstream configuration handling.

Unfortunately this means we still can't switch from a whitelist to a blacklist.

MozReview-Commit-ID: 3DZAi1QHYYo

--HG--
extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1
2017-08-29 17:32:31 -04:00
Andrew Halberstadt
115f346cd8 Bug 1392795 - [yamllint] Group paths to lint by their closest config and run each config group separately, r=dustin
This makes configuration files for yamllint work a bit better. It's still not perfect, but it's an improvement
on the current situation.

MozReview-Commit-ID: IKxgQm1a7bP

--HG--
extra : rebase_source : 051fafe21337f0557ee39ec71c90e74fd61d3da7
2017-08-23 11:28:28 -04:00
Justin Wood
b09ed76339 Bug 1387862 - Add initial support for ./mach lint -l yaml r=ahal,dustin
We should have CI Lint YAML files in the tree.

MozReview-Commit-ID: HYVWXzNnnzG

--HG--
rename : tools/lint/flake8_/__init__.py => tools/lint/yamllint_/__init__.py
extra : rebase_source : f4919be1341f6081b99d8b122004f9c2978cc677
2017-08-06 13:23:48 -04:00
Sebastian Hengst
19fae7e07d Backed out changeset 98c08b9cc52e (bug 1387862) for linting failure at .cron.yml:51 (too few spaces). r=backout 2017-08-10 14:30:46 +02:00
Justin Wood
143c24a47a Bug 1387862 - Add initial support for ./mach lint -l yaml r=ahal,dustin
We should have CI Lint YAML files in the tree.

MozReview-Commit-ID: HYVWXzNnnzG

--HG--
rename : tools/lint/flake8_/__init__.py => tools/lint/yamllint_/__init__.py
extra : rebase_source : 54460179e51f6263099a6837e1111dcce05a9331
2017-08-06 13:23:48 -04:00
Ryan VanderMeulen
24396489e3 Backed out 7 changesets (bug 1387862) for yaml linting failures.
Backed out changeset 63f87f6db7d6 (bug 1387862)
Backed out changeset a85b7e7d9f24 (bug 1387862)
Backed out changeset 3713ea9672e8 (bug 1387862)
Backed out changeset 22c1094e387f (bug 1387862)
Backed out changeset e0bfb35b0eec (bug 1387862)
Backed out changeset 5bb5dc7655ec (bug 1387862)
Backed out changeset cc4c01794114 (bug 1387862)
2017-08-09 21:31:30 -04:00
Justin Wood
51838f82e6 Bug 1387862 - Add initial support for ./mach lint -l yaml r=ahal,dustin
We should have CI Lint YAML files in the tree.

MozReview-Commit-ID: HYVWXzNnnzG

--HG--
rename : tools/lint/flake8_/__init__.py => tools/lint/yamllint_/__init__.py
extra : rebase_source : 635ef617eeba1cd1299366beb0c83232d42f0258
2017-08-06 13:23:48 -04:00